lyx_mirror/src/frontends/qt4
Juergen Spitzmueller 0c447db0ca Adjust FIXME
2014-03-05 12:16:57 +01:00
..
ui Allow statusbar to be set on or off in full screen mode as a 2014-02-25 20:48:56 -05:00
.gitignore Setup .gitignore for generated files 2012-03-22 02:16:12 +01:00
Action.cpp Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
Action.h Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
BulletsModule.cpp
BulletsModule.h
ButtonController.cpp
ButtonController.h
ButtonPolicy.cpp
ButtonPolicy.h
CategorizedCombo.cpp Consider filtering when selecting from categorized combo (#8452) 2012-12-10 12:52:23 +01:00
CategorizedCombo.h Rescue monolithic build after 32fde61c8f. 2012-11-24 17:48:47 +01:00
CMakeLists.txt Adjust CMake for Qt5 2013-04-23 21:45:49 +02:00
ColorCache.cpp
ColorCache.h
CustomizedWidgets.cpp Correct \file statement 2013-12-21 12:58:23 +01:00
CustomizedWidgets.h
Dialog.cpp Another assertion that got changed wrongly. 2013-04-27 18:12:27 -04:00
Dialog.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
DialogView.h
DockView.h close floating dock widgets (not currently docked) with escape keypress event 2011-09-29 18:52:36 +00:00
EmptyTable.cpp
EmptyTable.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
FancyLineEdit.cpp Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FancyLineEdit.h Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FileDialog.cpp Some fixes to the SaveAs dialog 2013-11-15 09:20:07 +01:00
FileDialog.h Take Vincent's advice: using a pointer for selectedFilter 2011-10-15 13:32:14 +00:00
FindAndReplace.cpp Added restrict-search-to-maths-only checkbox to advanced pane of Advanced F&R. 2013-10-13 00:59:46 +01:00
FindAndReplace.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
FloatPlacement.cpp
FloatPlacement.h
GuiAbout.cpp GuiAbout: Add missing include 2013-05-15 07:47:02 +02:00
GuiAbout.h
GuiAlert.cpp Avoid that, if an error dialog pops up during a long operation, it freezes LyX. 2012-08-18 22:45:21 +01:00
GuiApplication.cpp Fix #8657 on Linux. 2014-02-23 13:33:04 +01:00
GuiApplication.h Avoid that, if an error dialog pops up during a long operation, it freezes LyX. 2012-08-18 22:45:21 +01:00
GuiBibitem.cpp
GuiBibitem.h
GuiBibtex.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiBibtex.h
GuiBox.cpp GuiBox.cpp, InsetBox.cpp: fix some wrong logic 2013-05-25 15:07:17 +02:00
GuiBox.h support for \mbox and \fbox 2013-03-22 01:33:58 +01:00
GuiBranch.cpp
GuiBranch.h
GuiBranches.cpp Fix monolithic build (bug #8079) 2012-03-24 15:25:30 +01:00
GuiBranches.h Fix handling of the add branch textfield in GuiBranches 2012-03-03 14:39:32 +00:00
GuiChanges.cpp Fix bug #4213: Change tracking support for tex2lyx. 2011-11-06 17:03:59 +00:00
GuiChanges.h
GuiCharacter.cpp Fix toggling of 'misc' font options (bug #8764) 2013-07-17 08:30:42 +02:00
GuiCharacter.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
GuiCitation.cpp Constify some catches and others 2012-09-17 04:05:34 -04:00
GuiCitation.h Move the citation engine machinery to layouts. 2012-03-01 00:41:30 +00:00
GuiClipboard.cpp Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiClipboard.h Implement paste from LaTeX and HTML (bug #3096) 2013-04-14 19:45:36 +02:00
GuiCommandBuffer.cpp Constify some catches and others 2012-09-17 04:05:34 -04:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompare.cpp
GuiCompare.h
GuiCompareHistory.cpp Add very simple revision comparison for git. 2013-02-09 19:35:22 -08:00
GuiCompareHistory.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiCompleter.cpp Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiCompleter.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiDelimiter.cpp Full delimiter support for llbracket and rrbracket 2012-12-16 15:49:42 +01:00
GuiDelimiter.h
GuiDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiDialog.h
GuiDocument.cpp Fix bug #8998: changed document setting is recoded twice as undo 2014-03-03 18:28:23 +01:00
GuiDocument.h A first batch of potential bugs spotted by llvm/clang 2013-05-02 16:38:25 +02:00
GuiErrorList.cpp
GuiErrorList.h
GuiERT.cpp
GuiERT.h
GuiExternal.cpp Move readBB_from_PSFile() out of support (no code change), 2012-02-15 20:50:52 +00:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp A first batch of potential bugs spotted by llvm/clang 2013-05-02 16:38:25 +02:00
GuiFontLoader.h
GuiFontMetrics.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiFontMetrics.h Avoid narrowing in array initializator 2012-01-07 18:29:07 +00:00
GuiGraphics.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
GuiGraphics.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiGraphicsUi.h
GuiHSpace.cpp Focus on custom line edit when custom is selected 2013-11-15 01:03:14 -05:00
GuiHSpace.h
GuiHyperlink.cpp If the selection is some sort of URL, then make it the target, not 2014-02-23 11:36:54 -05:00
GuiHyperlink.h If the selection is some sort of URL, then make it the target, not 2014-02-23 11:36:54 -05:00
GuiIdListModel.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiIdListModel.h
GuiImage.cpp
GuiImage.h
GuiInclude.cpp
GuiInclude.h
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp Don't allow newline characters in document settings. 2011-09-24 16:39:23 +00:00
GuiIndices.h Rename QLineEdit widgets to have a LE suffix (consistent within GuiDocument). 2011-09-24 16:39:20 +00:00
GuiInfo.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiInfo.h
GuiKeySymbol.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiKeySymbol.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiLabel.cpp
GuiLabel.h
GuiLine.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiLine.h
GuiListings.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiListings.h
GuiLog.cpp Add FIXME 2013-05-27 18:48:46 +02:00
GuiLog.h
GuiMathMatrix.cpp GuiMathMatrix.cpp: remove an unused header 2013-05-14 02:26:22 +02:00
GuiMathMatrix.h
GuiNomenclature.cpp
GuiNomenclature.h
GuiNote.cpp
GuiNote.h
GuiPainter.cpp Adjust FIXME 2014-03-05 12:16:57 +01:00
GuiPainter.h Factor out painting of text decorations 2012-05-02 18:02:17 +02:00
GuiParagraph.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiParagraph.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Allow statusbar to be set on or off in full screen mode as a 2014-02-25 20:48:56 -05:00
GuiPrefs.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPrint.cpp
GuiPrint.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPrintindex.cpp
GuiPrintindex.h
GuiPrintNomencl.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiPrintNomencl.h
GuiProgress.cpp Fix bug #8032 (timeout when using the Sweave module) 2012-02-18 14:16:25 +00:00
GuiProgress.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiProgressView.cpp Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiProgressView.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiRef.cpp GuiRef: only enable "Group" CB if non-empty refs 2013-04-22 15:39:16 -04:00
GuiRef.h Fix issues with xref dialog in read-only documents (#8177) 2012-09-29 16:12:31 +02:00
GuiSearch.cpp Style 2014-02-04 10:37:29 +01:00
GuiSearch.h Adding wrap-around pop-up question to simple find and replace dialog (fixing enhancement request #1262). 2013-07-21 17:51:53 +01:00
GuiSelection.cpp
GuiSelection.h
GuiSelectionManager.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiSelectionManager.h Remove ; from end of function definitions 2013-05-12 13:04:18 +02:00
GuiSendto.cpp Do not sort formats in BufferParams::exportableFormats 2013-03-24 18:06:32 +01:00
GuiSendto.h
GuiSetBorder.cpp qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiSetBorder.h qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiShowFile.cpp
GuiShowFile.h
GuiSpellchecker.cpp Fix bug #8238: correct the forward argument of replace2string() in on_replacePB_clicked(). 2012-07-27 00:34:17 +02:00
GuiSpellchecker.h
GuiSymbols.cpp fix Symbols dialog box grid size in case of broken QFontMetrics::maxWidth() 2014-01-04 20:14:06 +01:00
GuiSymbols.h
GuiTabular.cpp GuiTabular: disabling is now done on textChanged() 2013-03-19 14:48:20 -04:00
GuiTabular.h
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp Also display the info about BibTeX databases in the TeX info panel. 2011-12-03 22:24:58 +00:00
GuiTexinfo.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiThesaurus.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiThesaurus.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToc.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiToc.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToolbar.cpp Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToolbar.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiView.cpp Bug #9005: various things that do not work as intended in passthru paragraphs 2014-03-04 11:56:03 +01:00
GuiView.h Some fixes to the SaveAs dialog 2013-11-15 09:20:07 +01:00
GuiViewSource.cpp Another try at making the source view dock arrange itself. 2013-05-07 11:30:46 +02:00
GuiViewSource.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiVSpace.cpp Add missing widget update 2013-11-15 19:29:15 +01:00
GuiVSpace.h
GuiWorkArea_Private.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiWorkArea.cpp Trivial fix: escape ampersands in file names before pushing to tab header (#8757) 2013-07-19 15:55:56 +02:00
GuiWorkArea.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp
IconPalette.h
InGuiThread.cpp
InGuiThread.h LyX 2.1 will support only Qt>=4.5. 2012-11-04 01:22:32 +01:00
InsertTableWidget.cpp More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsertTableWidget.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsetParamsDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
InsetParamsDialog.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
InsetParamsWidget.cpp Fix bug 8880: do not try to validate custom value if it is disabled 2013-11-12 15:48:34 +01:00
InsetParamsWidget.h
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LayoutBox.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
LayoutBox.h Cleanup private part of Layout Box on destructor (probably not really an 2011-10-15 13:34:14 +00:00
LengthCombo.cpp Move LengthCombo into namespace lyx::frontend 2012-12-17 21:38:57 +01:00
LengthCombo.h Move LengthCombo into namespace lyx::frontend 2012-12-17 21:38:57 +01:00
LyXFileDialog.cpp Fix file dialogs with Qt 5.2.0 and later. 2013-12-24 17:21:56 +01:00
LyXFileDialog.h
Makefile.am Revert "Fix make distcheck for monolithic build" 2013-10-12 02:41:36 +02:00
Menus.cpp Fix crash 2014-02-06 13:07:00 +01:00
Menus.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
PanelStack.cpp Fix assert: Do not use translated names as keys 2013-05-13 10:00:57 +02:00
PanelStack.h
pch.h
qt_helpers.cpp Fix the fix to the decimal separator problem with Qt5 2013-07-27 11:18:16 +02:00
qt_helpers.h Fix empty width support for Box inset 2013-05-24 15:44:59 +02:00
qt_i18n.h
README
TocModel.cpp Header cleanup cont. 2013-05-22 19:58:58 -07:00
TocModel.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
TocWidget.cpp Rename some LFUN names to match their text name 2014-02-13 13:50:33 +01:00
TocWidget.h
Toolbars.cpp An IPA toolbar 2012-08-21 14:56:34 +02:00
Toolbars.h An IPA toolbar 2012-08-21 14:56:34 +02:00
Validator.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
Validator.h "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.