lyx_mirror/src/frontends/qt4
Abdelrazak Younes c1fdb12118 n-th bug fixing patch from Vincent:
Almost all methods in the GuiPainter class have something like
 
if (!isDrawingEnabled())
  return;
 
except GuiPainter::fillRectangle(...) !!
 
Adding this will solve
 
gmane.editors.lyx.devel/109857
gmane.editors.lyx.devel/109859
http://bugzilla.lyx.org/show_bug.cgi?id=4937
http://bugzilla.lyx.org/show_bug.cgi?id=5027
http://bugzilla.lyx.org/show_bug.cgi?id=5235
 
Maybe also:
http://bugzilla.lyx.org/show_bug.cgi?id=5230


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26351 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-09 21:01:18 +00:00
..
ui various listings fixes by Vincent, see http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg143302.html 2008-09-08 21:51:38 +00:00
Action.cpp
Action.h
BulletsModule.cpp
BulletsModule.h
ButtonController.cpp pimpl ButtonController 2008-04-19 09:12:34 +00:00
ButtonController.h pimpl ButtonController 2008-04-19 09:12:34 +00:00
ButtonPolicy.cpp pimply buttonpolicy data 2008-04-19 08:42:56 +00:00
ButtonPolicy.h pimply buttonpolicy data 2008-04-19 08:42:56 +00:00
ColorCache.cpp fix my color cache "improvements" 2008-05-31 22:39:52 +00:00
ColorCache.h fix my color cache "improvements" 2008-05-31 22:39:52 +00:00
CustomizedWidgets.cpp More work on the Shortcuts UI: 2008-07-22 09:49:38 +00:00
CustomizedWidgets.h remove superflous lyx:: qualification 2008-08-24 20:29:20 +00:00
Dialog.cpp Outline focus fix for mac: Make sure the GuiView is raised and activated before setting the focus. 2008-06-09 15:33:42 +00:00
Dialog.h Remove invalid comment. 2008-08-12 21:56:07 +00:00
DialogView.h Fix citation bug: In certain circumstances, attempts to insert a new citation 2008-08-13 14:32:30 +00:00
DockView.h set the object name for all DockView based dialog (fix http://bugzilla.lyx.org/show_bug.cgi?id=4922) 2008-06-09 14:09:27 +00:00
EmptyTable.cpp
EmptyTable.h
FileDialog.cpp Another patch from Vincent. This one fixing the very annoying bug 5138. 2008-08-08 15:41:32 +00:00
FileDialog.h move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
FloatPlacement.cpp
FloatPlacement.h
GuiAbout.cpp Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=4943 . 2008-07-07 23:41:19 +00:00
GuiAbout.h
GuiAlert.cpp
GuiApplication.cpp GuiApplication::resetGui(): clear out Mac nenubar before deletion, just in case. 2008-09-05 12:42:47 +00:00
GuiApplication.h Some locale related cleanup. JMarc, please when you come back, review this. It is working fine in all my testings though. 2008-07-28 11:26:46 +00:00
GuiBibitem.cpp move GuiCommand into hedar of its own. InsetCommandParams.h is expensive 2008-04-20 08:19:26 +00:00
GuiBibitem.h move GuiCommand into hedar of its own. InsetCommandParams.h is expensive 2008-04-20 08:19:26 +00:00
GuiBibtex.cpp * GuiBibtex.cpp: 2008-04-28 12:57:41 +00:00
GuiBibtex.h merge GuiCommand into its users. 2008-04-20 09:24:14 +00:00
GuiBox.cpp GuiBox.cpp: 2008-07-20 16:57:37 +00:00
GuiBox.h
GuiBranch.cpp
GuiBranch.h
GuiBranches.cpp Cosmetics. 2008-05-27 19:00:42 +00:00
GuiBranches.h
GuiChanges.cpp
GuiChanges.h
GuiCharacter.cpp fix http://bugzilla.lyx.org/show_bug.cgi?id=4870 2008-05-22 15:20:43 +00:00
GuiCharacter.h LFUN_FONT_FREE_* -> LFUN_TEXSTYLE_* 2008-06-11 08:35:15 +00:00
GuiCitation.cpp Fix citation bug: In certain circumstances, attempts to insert a new citation 2008-08-13 14:32:30 +00:00
GuiCitation.h Fix citation bug: In certain circumstances, attempts to insert a new citation 2008-08-13 14:32:30 +00:00
GuiClipboard.cpp cleanup export of mime type strings 2008-05-25 07:49:16 +00:00
GuiClipboard.h cleanup export of mime type strings 2008-05-25 07:49:16 +00:00
GuiCommandBuffer.cpp
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompleter.cpp this entire method can now be removed (thanks for pointing this out, Bernhard!) 2008-06-04 21:05:27 +00:00
GuiCompleter.h Fix item delegate for qt 4.2: 2008-06-03 22:00:47 +00:00
GuiDelimiter.cpp Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiDelimiter.h Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiDialog.cpp bug 4652: better fix. 2008-05-15 08:06:32 +00:00
GuiDialog.h move GuiCommand into hedar of its own. InsetCommandParams.h is expensive 2008-04-20 08:19:26 +00:00
GuiDocument.cpp Coding style 2008-09-08 01:18:33 +00:00
GuiDocument.h proper fix for bug 4936. 2008-06-09 15:20:38 +00:00
GuiErrorList.cpp * GuiErrorList.cpp: 2008-07-20 17:05:58 +00:00
GuiErrorList.h fix crash. 2008-07-06 10:55:47 +00:00
GuiERT.cpp
GuiERT.h
GuiExternal.cpp - Simplify prefs, graphics and external display options which are now true or false. 2008-06-13 07:34:55 +00:00
GuiExternal.h basic context menu for InsetExternal. 2008-04-28 05:12:28 +00:00
GuiFloat.cpp
GuiFloat.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp cosmetics 2008-05-02 22:07:51 +00:00
GuiFontLoader.h Pimpl stuff in GuiApplication. 2008-05-23 08:43:07 +00:00
GuiFontMetrics.cpp Coding style 2008-09-08 01:18:33 +00:00
GuiFontMetrics.h
GuiGraphics.cpp - Simplify prefs, graphics and external display options which are now true or false. 2008-06-13 07:34:55 +00:00
GuiGraphics.h Fix 4603 for GuiGraphics. I guess most GuiDialog based dialog need fixing... 2008-05-06 15:18:50 +00:00
GuiGraphicsUi.h
GuiHSpace.cpp support for rightarrowfill, leftarrowfill, upbracefill, downbracefill, by Helge Hafting. 2008-04-30 20:11:57 +00:00
GuiHSpace.h
GuiHyperlink.cpp Patch from Vincent van Ravesteijn. 2008-08-08 15:29:26 +00:00
GuiHyperlink.h cosmetics 2008-09-03 18:30:05 +00:00
GuiIdListModel.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
GuiIdListModel.h Fix a bug noticed by Stefan: that the module UI was broken. The problem was introduced at r23981. The data() and setData() methods must be kept in sync. 2008-04-17 02:43:57 +00:00
GuiImage.cpp oups! 2008-07-16 09:46:07 +00:00
GuiImage.h fix http://bugzilla.lyx.org/show_bug.cgi?id=5002 2008-07-16 09:43:46 +00:00
GuiInclude.cpp Patch from Vincent van Ravesteijn. 2008-08-08 15:29:26 +00:00
GuiInclude.h cosmetics 2008-09-03 18:30:05 +00:00
GuiInfo.cpp Fix a bug where spaces can not be appended tonameLE in the info dialoag 2008-08-03 22:26:01 +00:00
GuiInfo.h InsetInfo: Some fixes... 2008-06-06 08:45:58 +00:00
GuiKeySymbol.cpp Fix for accepting Tab key in shortcut dialog. 2008-09-08 01:00:58 +00:00
GuiKeySymbol.h
GuiLabel.cpp merge GuiCommand into its users. 2008-04-20 09:24:14 +00:00
GuiLabel.h merge GuiCommand into its users. 2008-04-20 09:24:14 +00:00
GuiListings.cpp various listings fixes by Vincent, see http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg143302.html 2008-09-08 21:51:38 +00:00
GuiListings.h
GuiLog.cpp Revision control log is not visible after launching, moreover the title didn't 2008-07-20 22:48:48 +00:00
GuiLog.h
GuiMathMatrix.cpp Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiMathMatrix.h Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiNomencl.cpp Fix http://bugzilla.lyx.org/show_bug.cgi?id=5191 2008-09-03 12:59:36 +00:00
GuiNomencl.h cosmetics 2008-09-03 18:30:05 +00:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp n-th bug fixing patch from Vincent: 2008-09-09 21:01:18 +00:00
GuiPainter.h
GuiParagraph.cpp Add session to paragraph dialog. 2008-05-14 14:08:58 +00:00
GuiParagraph.h Add session to paragraph dialog. 2008-05-14 14:08:58 +00:00
GuiPrefs.cpp * separate nomencl processing command from index processing command, since nomencl 2008-08-23 09:44:00 +00:00
GuiPrefs.h More work on the Shortcuts UI: 2008-07-22 09:35:46 +00:00
GuiPrint.cpp compile fix 2008-04-21 06:53:00 +00:00
GuiPrint.h
GuiRef.cpp * GuiRef.cpp: 2008-09-09 13:18:36 +00:00
GuiRef.h Quick fix for a problem noted by Stefan. The better fix is to migrate this 2008-08-25 17:38:57 +00:00
GuiSearch.cpp * GuiSearch.cpp: 2008-09-09 13:20:44 +00:00
GuiSearch.h
GuiSelection.cpp Silence warning 2008-08-27 20:24:18 +00:00
GuiSelection.h GuiSelection: make sure the initial check is done 2008-07-29 10:25:35 +00:00
GuiSelectionManager.cpp Coding style 2008-09-08 01:18:33 +00:00
GuiSelectionManager.h
GuiSendto.cpp Some GuiSendto polishing by Vincent and me. 2008-09-04 09:36:44 +00:00
GuiSendto.h Some GuiSendto polishing by Vincent and me. 2008-09-04 09:36:44 +00:00
GuiSetBorder.cpp
GuiSetBorder.h
GuiShowFile.cpp
GuiShowFile.h
GuiSpellchecker.cpp
GuiSpellchecker.h
GuiSymbols.cpp Pimpl stuff in GuiApplication. 2008-05-23 08:43:07 +00:00
GuiSymbols.h use cheaper includes in ui files 2008-04-20 16:32:40 +00:00
GuiTabular.cpp fix: http://bugzilla.lyx.org/show_bug.cgi?id=4688 2008-05-04 07:51:50 +00:00
GuiTabular.h fix: http://bugzilla.lyx.org/show_bug.cgi?id=4688 2008-05-04 07:51:50 +00:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp
GuiTexinfo.h
GuiThesaurus.cpp
GuiThesaurus.h
GuiToc.cpp Navigator: 2008-06-17 15:44:14 +00:00
GuiToc.h Fix initial focus problem with outline and view-source panes. 2008-06-09 14:52:38 +00:00
GuiToolbar.cpp Fix crash when the Gui Name of a toolbar is not plain ascii. This 2008-08-15 18:43:46 +00:00
GuiToolbar.h Clean up the unknown layout stuff some more. Please test to make sure this works with translated layout names, especially when one of them is "unknown". The use of "unknown" with RTL is also wrong, probably, as it will appear on the wrong side. But I'm not sure how to fix that. 2008-07-16 15:52:10 +00:00
GuiView.cpp Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5234 . 2008-09-08 15:46:23 +00:00
GuiView.h Patch from Vincent. This resets the window title appropriately, after 2008-08-11 12:57:02 +00:00
GuiViewSource.cpp Fix manual update of the viewsource dialog, set default states of the view source checkboxes 2008-06-01 20:03:36 +00:00
GuiViewSource.h Fix initial focus problem with outline and view-source panes. 2008-06-09 14:52:38 +00:00
GuiVSpace.cpp
GuiVSpace.h
GuiWorkArea.cpp Coding style 2008-09-08 01:18:33 +00:00
GuiWorkArea.h * Some more clever elide mode for the LyX buffer tabs. In trunk 2008-04-29 15:44:07 +00:00
GuiWrap.cpp Fix http://bugzilla.lyx.org/show_bug.cgi?id=4603 2008-05-06 14:53:54 +00:00
GuiWrap.h Fix http://bugzilla.lyx.org/show_bug.cgi?id=4603 2008-05-06 14:53:54 +00:00
IconPalette.cpp
IconPalette.h
InsertTableWidget.cpp
InsertTableWidget.h
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LengthCombo.cpp
LengthCombo.h
LyXFileDialog.cpp move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
LyXFileDialog.h move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
Makefile.am Preliminar InsetInfo dialog. This was done as an exercise to show Bo (an others) how easy it is to create a new dialog. This dialog needs to be filled in, right now, there is just an OK button. 2008-06-05 15:08:46 +00:00
Menus.cpp Fix crash when the Gui Name of a toolbar is not plain ascii. This 2008-08-15 18:43:46 +00:00
Menus.h GuiApplication::resetGui(): reset as many things as possible, including menus and toolbars (not sure about Mac global menubar yet). This means that except for already opened dialog, all ui rc settings are taken into account without the need to restart. 2008-06-25 18:03:38 +00:00
PanelStack.cpp Fix for preferences crash by Vincent van Ravesteijn. 2008-08-04 15:50:56 +00:00
PanelStack.h
pch.h
qt_helpers.cpp move LyXerr QString specialisation to support/qstring_helpers 2008-07-23 09:21:22 +00:00
qt_helpers.h move LyXerr QString specialisation to support/qstring_helpers 2008-07-23 09:21:22 +00:00
qt_i18n.h move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
README
TocModel.cpp Local aware sorting of the toc type. 2008-06-18 11:35:24 +00:00
TocModel.h Local aware sorting of the toc type. 2008-06-18 11:35:24 +00:00
TocWidget.cpp Coding style 2008-09-08 01:18:33 +00:00
TocWidget.h Navigator: 2008-06-17 15:44:14 +00:00
Toolbars.cpp Fix crash when the Gui Name of a toolbar is not plain ascii. This 2008-08-15 18:43:46 +00:00
Toolbars.h Fix crash when the Gui Name of a toolbar is not plain ascii. This 2008-08-15 18:43:46 +00:00
Validator.cpp
Validator.h

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.