lyx_mirror/src/frontends/qt4
André Pönitz 54e314c826 cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23293 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-27 22:23:12 +00:00
..
ui * completion infrastructure 2008-02-21 19:42:34 +00:00
Action.cpp header cleanup 2008-02-18 07:14:42 +00:00
Action.h
BulletsModule.cpp getting rid of superfluous std:: statements. 2007-12-12 19:28:07 +00:00
BulletsModule.h
ButtonController.cpp header cleanup 2008-02-18 07:14:42 +00:00
ButtonController.h Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
ButtonPolicy.cpp header cleanup 2008-02-18 07:14:42 +00:00
ButtonPolicy.h
ColorCache.cpp
ColorCache.h
CustomizedWidgets.cpp more compile fixes 2008-02-18 09:55:14 +00:00
CustomizedWidgets.h
Dialog.cpp More cleanup from Andre. 2008-02-24 15:44:11 +00:00
Dialog.h compilation fix 2008-02-05 15:16:49 +00:00
DialogView.cpp header cleanup 2008-02-17 20:47:04 +00:00
DialogView.h Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
DockView.h Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
EmptyTable.cpp
EmptyTable.h
FileDialog.cpp Transfer FileDialog.h to qt4/ 2008-02-07 00:05:18 +00:00
FileDialog.h Transfer FileDialog.h to qt4/ 2008-02-07 00:05:18 +00:00
FloatPlacement.cpp *** Support for generic sideways floats *** 2008-01-11 18:56:53 +00:00
FloatPlacement.h *** Support for generic sideways floats *** 2008-01-11 18:56:53 +00:00
GuiAbout.cpp Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
GuiAbout.h
GuiAlert.cpp disable annoying debug messages 2008-02-22 10:30:46 +00:00
GuiApplication.cpp typo 2008-02-27 11:45:43 +00:00
GuiApplication.h Transfer some GUI oriented code from core to frontend. 2008-02-06 23:02:57 +00:00
GuiBibitem.cpp Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBibitem.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBibtex.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiBibtex.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBox.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiBox.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBranch.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiBranch.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBranches.cpp
GuiBranches.h
GuiChanges.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiChanges.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiCharacter.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiCharacter.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiCitation.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiCitation.h Support for nocite, provided by Bernhard Reiter. 2007-12-20 15:46:14 +00:00
GuiClipboard.cpp cosmetics 2008-02-27 22:23:12 +00:00
GuiClipboard.h * Support for graphics pasting (with most code in the frontend's GuiClipboard) 2008-02-03 10:43:03 +00:00
GuiCommandBuffer.cpp * completion infrastructure 2008-02-21 19:42:34 +00:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompleter.cpp * set the column with in the popup before showing it. Then it even works. 2008-02-26 19:20:23 +00:00
GuiCompleter.h * escape hides the completion 2008-02-26 19:19:34 +00:00
GuiDelimiter.cpp remove unused macro 2008-02-07 14:22:41 +00:00
GuiDelimiter.h
GuiDialog.cpp Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiDialog.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiDocument.cpp Try to make the distinction between base classes and text classes clearer in the code. 2008-02-24 16:59:49 +00:00
GuiDocument.h Restore Andre's TextClassIndex, but now in the form of BaseClassIndex. It seems worth distinguishing more clearly than we do at the moment between TextClass's and BaseClass's. The latter correspond to *.layout files; the former are based upon *.layout files but may be modified by modules. 2008-02-24 16:29:40 +00:00
GuiErrorList.cpp more compile fixes 2008-02-18 09:55:14 +00:00
GuiErrorList.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiERT.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiERT.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiExternal.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiExternal.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiFloat.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiFloat.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiFontLoader.h fix memory leaks 2007-12-02 18:39:05 +00:00
GuiFontMetrics.cpp factorize code between GuiFontMetrics::rectText() and buttonText(). 2008-02-14 09:44:12 +00:00
GuiFontMetrics.h
GuiGraphics.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiGraphics.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiGraphicsUi.h
GuiHyperlink.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiHyperlink.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiIdListModel.cpp cosmetics 2008-01-19 12:33:01 +00:00
GuiIdListModel.h Doxy bit. 2008-02-24 22:40:34 +00:00
GuiImage.cpp getting rid of superfluous lyx::support:: statements. 2007-12-12 19:57:42 +00:00
GuiImage.h
GuiInclude.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiInclude.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiKeySymbol.cpp 'using namespace std' instead of 'using std::xxx' 2007-12-12 10:16:00 +00:00
GuiKeySymbol.h
GuiLabel.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiLabel.h header cleanup 2008-02-17 20:47:04 +00:00
GuiListings.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiListings.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiLog.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiLog.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiMath.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiMath.h Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
GuiMathMatrix.cpp Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
GuiMathMatrix.h
GuiNomencl.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiNomencl.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiNote.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiNote.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiPainter.cpp * once is enough 2008-02-22 14:05:06 +00:00
GuiPainter.h
GuiParagraph.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiParagraph.h header cleanup 2008-02-18 07:14:42 +00:00
GuiPopupMenu.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiPopupMenu.h * MenuBackend.cpp (binding): remove forgui argument 2008-01-07 10:53:04 +00:00
GuiPrefs.cpp * "show popup without delay"-checkbox was missing a connect 2008-02-26 13:09:44 +00:00
GuiPrefs.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiPrint.cpp Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
GuiPrint.h
GuiRef.cpp Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiRef.h
GuiSearch.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiSearch.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSelection.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiSelection.h
GuiSelectionManager.cpp remove duplicated code, (fix cmake merge) 2008-01-14 19:52:16 +00:00
GuiSelectionManager.h This commit changes the way individual LyXModule's are represented, both internally and in the .lyx files. The earlier version represented them by their `descriptive name', e.g., "Endnote" or "Theorems (AMS)", these being the same names used in the UI. This was a mistake, as becomes readily apparent when one starts to think about translating these strings. The modules ought to be represented by their filename, without the extension, just as TextClass's are. 2008-01-12 04:28:12 +00:00
GuiSendto.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiSendto.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSetBorder.cpp
GuiSetBorder.h
GuiShowFile.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiShowFile.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSpellchecker.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiSpellchecker.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSymbols.cpp simplification. 2008-02-08 17:55:43 +00:00
GuiSymbols.h * GuiSymbols.{cpp,h}: 2008-02-08 16:43:02 +00:00
GuiTabular.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiTabular.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiTabularCreate.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiTabularCreate.h
GuiTexinfo.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiTexinfo.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiThesaurus.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiThesaurus.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiToc.cpp Add list of labels. If I have the time and energy the next step is to cleanup the cross-reference lookup so that we can integrate the cross references in the tree, hence the name "Labels and References". 2008-02-27 15:23:22 +00:00
GuiToc.h simplify GuiToc / TocWidget interaction. Much can still be simplified... 2008-02-12 07:47:16 +00:00
GuiToolbar.cpp Improve comment. 2008-02-24 22:42:27 +00:00
GuiToolbar.h Fix bug 4037 and related problems. The patch has been cleaned up a bit 2008-02-12 17:31:07 +00:00
GuiToolbars.cpp Revert 23154. 2008-02-24 14:59:23 +00:00
GuiToolbars.h More cleanup from Andre. 2008-02-24 15:44:11 +00:00
GuiView.cpp Get rid of 'quitting' global variable. It is not needed anymore because all windows are closed in order now and the frontend/core is properly separated. 2008-02-27 12:30:41 +00:00
GuiView.h Cleanup app quitting and window closing now that there is a clean separation between the frontend and the core. 2008-02-27 10:35:28 +00:00
GuiViewSource.cpp Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
GuiViewSource.h use structure with named members instead of pair<int, int>... 2007-11-29 22:12:19 +00:00
GuiVSpace.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiVSpace.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiWorkArea.cpp Fullscreen mode fixes: 2008-02-27 21:04:33 +00:00
GuiWorkArea.h Fullscreen mode fixes: 2008-02-27 21:04:33 +00:00
GuiWrap.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiWrap.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
IconPalette.cpp don't update parent and make sure the icon sizes on the palette are correct 2008-01-16 20:51:00 +00:00
IconPalette.h don't update parent and make sure the icon sizes on the palette are correct 2008-01-16 20:51:00 +00:00
InsertTableWidget.cpp
InsertTableWidget.h
LaTeXHighlighter.cpp Use a less verbose form for warnings in the view source window 2007-12-30 21:28:38 +00:00
LaTeXHighlighter.h * src/Buffer.cpp: 2007-12-24 13:55:01 +00:00
LengthCombo.cpp
LengthCombo.h
LyXFileDialog.cpp * src/frontends/qt4/LyXFileDialog.cpp: 2008-02-10 11:50:10 +00:00
LyXFileDialog.h Transfer FileDialog.h to qt4/ 2008-02-07 00:05:18 +00:00
Makefile.am * completion infrastructure 2008-02-21 19:42:34 +00:00
Menus.cpp Fix mac menubar only modifying the Prefs. 2008-01-16 16:50:10 +00:00
Menus.h * compile fix 2007-12-26 13:29:45 +00:00
PanelStack.cpp 'using namespace std' instead of 'using std::xxx' 2007-12-12 10:16:00 +00:00
PanelStack.h
pch.h
qlkey.h
qt_helpers.cpp header cleanup 2008-02-18 07:14:42 +00:00
qt_helpers.h
README
TocModel.cpp Patch to please gcc 4.3. Less bloat in the include headers means that 2008-02-07 17:04:06 +00:00
TocModel.h
TocWidget.cpp Try to restore current selected type in case of a toc reset. 2008-02-12 15:33:01 +00:00
TocWidget.h simplify GuiToc / TocWidget interaction. Much can still be simplified... 2008-02-12 07:47:16 +00:00
Validator.cpp 'using namespace std' instead of 'using std::xxx' 2007-12-12 10:16:00 +00:00
Validator.h

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.