lyx_mirror/src/frontends/qt4
Jean-Marc Lasgouttes 143c136a7f Do not read array before checking the bounds
Fixes coverity issue 23377
2015-02-20 16:51:20 +01:00
..
ui Correct the spelling of "occured" to "occurred" 2015-02-09 18:44:02 -05:00
.gitignore Setup .gitignore for generated files 2012-03-22 02:16:12 +01:00
Action.cpp Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
Action.h Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
BulletsModule.cpp Update status when bullet size is changed. 2011-06-04 12:50:39 +00:00
BulletsModule.h
ButtonController.cpp
ButtonController.h
ButtonPolicy.cpp Revert r35760, as suggested by Vincent. 2010-10-21 19:33:29 +00:00
ButtonPolicy.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
CategorizedCombo.cpp Squash warnings reported by gcc 4.9 2015-01-14 11:52:14 +01:00
CategorizedCombo.h Rescue monolithic build after 32fde61c8f. 2012-11-24 17:48:47 +01:00
CMakeLists.txt Fix bug #9217: [Qt5] QWindowsMime class not available 2014-12-26 16:53:31 +01:00
ColorCache.cpp Set url color from system theme. 2010-09-09 13:04:02 +00:00
ColorCache.h Finish implementation of "use system colors" checkbox. 2010-08-09 12:15:02 +00:00
CustomizedWidgets.cpp Correct \file statement 2013-12-21 12:58:23 +01:00
CustomizedWidgets.h
Dialog.cpp Another assertion that got changed wrongly. 2013-04-27 18:12:27 -04:00
Dialog.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
DialogView.h DialogView: make GuiView the parent widget to partly solve bug #6710. 2010-10-21 13:40:49 +00:00
DockView.h close floating dock widgets (not currently docked) with escape keypress event 2011-09-29 18:52:36 +00:00
EmptyTable.cpp
EmptyTable.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
FancyLineEdit.cpp Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FancyLineEdit.h Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FileDialog.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
FileDialog.h Fix various warnings issued by clang++. 2014-04-22 00:04:04 +02:00
FindAndReplace.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
FindAndReplace.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
FloatPlacement.cpp More include frenzy. 2010-10-31 01:04:03 +00:00
FloatPlacement.h
GuiAbout.cpp Add new variables lyx_build_date/time 2014-11-25 18:58:35 +01:00
GuiAbout.h
GuiAlert.cpp On Linux show in crash message box the backtrace 2014-06-14 11:25:25 +02:00
GuiApplication.cpp Fix missing symbols in math completer 2015-02-14 20:32:25 +01:00
GuiApplication.h Adjust preprocessor guards for Qt5/X11. 2015-01-11 19:44:35 +01:00
GuiBibitem.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiBibitem.h
GuiBibtex.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiBibtex.h
GuiBox.cpp GuiBox.cpp, InsetBox.cpp: fix some wrong logic 2013-05-25 15:07:17 +02:00
GuiBox.h support for \mbox and \fbox 2013-03-22 01:33:58 +01:00
GuiBranch.cpp
GuiBranch.h
GuiBranches.cpp Fix monolithic build (bug #8079) 2012-03-24 15:25:30 +01:00
GuiBranches.h Fix handling of the add branch textfield in GuiBranches 2012-03-03 14:39:32 +00:00
GuiChanges.cpp Fix bug #4213: Change tracking support for tex2lyx. 2011-11-06 17:03:59 +00:00
GuiChanges.h
GuiCharacter.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
GuiCharacter.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
GuiCitation.cpp Fix the last clang warnings about overloaded virtual methods 2014-12-22 11:02:45 +01:00
GuiCitation.h Fix the last clang warnings about overloaded virtual methods 2014-12-22 11:02:45 +01:00
GuiClipboard.cpp Adjust preprocessor guards for Qt5/X11. 2015-01-11 19:44:35 +01:00
GuiClipboard.h GuiLog: Use GuiClipboard to put the log on the clipboard 2014-04-29 15:38:35 +02:00
GuiCommandBuffer.cpp Constify some catches and others 2012-09-17 04:05:34 -04:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompare.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiCompare.h Some cosmetics (from my local cosmetics branch). 2010-10-18 14:20:03 +00:00
GuiCompareHistory.cpp Add very simple revision comparison for git. 2013-02-09 19:35:22 -08:00
GuiCompareHistory.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiCompleter.cpp Fix missing symbols in math completer 2015-02-14 20:32:25 +01:00
GuiCompleter.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiDelimiter.cpp This is the result of an audit of all static variables, looking 2014-04-21 11:51:57 -04:00
GuiDelimiter.h
GuiDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiDialog.h Typos in the comment. 2011-02-13 09:59:14 +00:00
GuiDocument.cpp Do not warn about changed modules when changing modules. 2014-12-21 19:10:13 +01:00
GuiDocument.h Do not warn about changed modules when changing modules. 2014-12-21 19:10:13 +01:00
GuiErrorList.cpp Fix a bunch of small performance issues spotted by cppcheck 2014-07-05 19:13:10 +02:00
GuiErrorList.h
GuiERT.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiERT.h
GuiExternal.cpp Move readBB_from_PSFile() out of support (no code change), 2012-02-15 20:50:52 +00:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp Solve the "soft-hyphen" (0x00ad) symbol problem. 2015-01-21 14:12:42 +01:00
GuiFontLoader.h
GuiFontMetrics.cpp Squash warnings reported by gcc 4.9 2015-01-14 11:52:14 +01:00
GuiFontMetrics.h Fix positionning of cursor 2014-07-08 21:30:05 +02:00
GuiGraphics.cpp Fix aspectratio UI 2015-01-04 10:05:42 +01:00
GuiGraphics.h Fix aspectratio UI 2015-01-04 10:05:42 +01:00
GuiGraphicsUi.h
GuiHSpace.cpp Focus on custom line edit when custom is selected 2013-11-15 01:03:14 -05:00
GuiHSpace.h InsetSpace support for 2011-08-29 14:07:30 +00:00
GuiHyperlink.cpp If the selection is some sort of URL, then make it the target, not 2014-02-23 11:36:54 -05:00
GuiHyperlink.h If the selection is some sort of URL, then make it the target, not 2014-02-23 11:36:54 -05:00
GuiIdListModel.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiIdListModel.h
GuiImage.cpp #9130 Text in main work area isn't rendered with high resolution 2014-10-18 15:46:17 +02:00
GuiImage.h
GuiInclude.cpp This is the result of an audit of all static variables, looking 2014-04-21 11:51:57 -04:00
GuiInclude.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp Don't allow newline characters in document settings. 2011-09-24 16:39:23 +00:00
GuiIndices.h Rename QLineEdit widgets to have a LE suffix (consistent within GuiDocument). 2011-09-24 16:39:20 +00:00
GuiInfo.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiInfo.h
GuiKeySymbol.cpp Fix key code 2014-10-08 10:57:58 +02:00
GuiKeySymbol.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiLabel.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiLabel.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiLine.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiLine.h GuiLine: honor Abdel as author 2010-09-17 01:32:23 +00:00
GuiListings.cpp This is the result of an audit of all static variables, looking 2014-04-21 11:51:57 -04:00
GuiListings.h
GuiLog.cpp Get rid of ugly font metrics workarounds. 2014-06-25 17:55:16 +02:00
GuiLog.h
GuiMathMatrix.cpp Fix bug #9153 (Using mathpanel to insert matrix creates extra space on top) 2014-06-06 16:14:24 +02:00
GuiMathMatrix.h GuiMathMatrix: 2010-09-24 03:44:34 +00:00
GuiNomenclature.cpp Implement GuiNomenclature::initialiseParams(), thus restoring the 2011-09-11 14:14:04 +00:00
GuiNomenclature.h Implement GuiNomenclature::initialiseParams(), thus restoring the 2011-09-11 14:14:04 +00:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp Solve the "soft-hyphen" (0x00ad) symbol problem. 2015-01-21 14:12:42 +01:00
GuiPainter.h Tweak the shape of the parbreak separator. 2014-10-25 23:38:52 +02:00
GuiParagraph.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
GuiParagraph.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Add pref option to disable middle-mouse-button paste 2015-02-08 17:41:28 +01:00
GuiPrefs.h Fix the last clang warnings about overloaded virtual methods 2014-12-22 11:02:45 +01:00
GuiPrint.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiPrint.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPrintindex.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiPrintindex.h
GuiPrintNomencl.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiPrintNomencl.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiProgress.cpp On Linux show in crash message box the backtrace 2014-06-14 11:25:25 +02:00
GuiProgress.h On Linux show in crash message box the backtrace 2014-06-14 11:25:25 +02:00
GuiProgressView.cpp Sort debug options in the message pane by string. This makes it 2014-10-26 12:49:04 -04:00
GuiProgressView.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiRef.cpp Make BufferList::fileNames() threadsafe 2014-07-05 12:51:40 +02:00
GuiRef.h Fix issues with xref dialog in read-only documents (#8177) 2012-09-29 16:12:31 +02:00
GuiSearch.cpp Style 2014-02-04 10:37:29 +01:00
GuiSearch.h Adding wrap-around pop-up question to simple find and replace dialog (fixing enhancement request #1262). 2013-07-21 17:51:53 +01:00
GuiSelection.cpp Use the cached value GuiSelection::selection_supported_ 2014-04-29 15:17:15 +02:00
GuiSelection.h
GuiSelectionManager.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiSelectionManager.h Remove ; from end of function definitions 2013-05-12 13:04:18 +02:00
GuiSendto.cpp Do not sort formats in BufferParams::exportableFormats 2013-03-24 18:06:32 +01:00
GuiSendto.h
GuiSetBorder.cpp qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiSetBorder.h qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiShowFile.cpp
GuiShowFile.h
GuiSpellchecker.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
GuiSpellchecker.h Fixes the following issues: 2011-04-08 13:26:45 +00:00
GuiSymbols.cpp Do not read array before checking the bounds 2015-02-20 16:51:20 +01:00
GuiSymbols.h
GuiTabular.cpp GuiTabular: disabling is now done on textChanged() 2013-03-19 14:48:20 -04:00
GuiTabular.h Fix #7021: the problem was that activating the border combo was triggering dialogToParams() and thus disallowed because of the empty value. 2010-12-04 10:55:03 +00:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp Also display the info about BibTeX databases in the TeX info panel. 2011-12-03 22:24:58 +00:00
GuiTexinfo.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiThesaurus.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiThesaurus.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToc.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
GuiToc.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToolbar.cpp #9130 Text in main work area isn't rendered with high resolution 2014-10-18 15:50:22 +02:00
GuiToolbar.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiView.cpp Correct the spelling of "occured" to "occurred" 2015-02-09 18:44:02 -05:00
GuiView.h #9130 Text in main work area isn't rendered with high resolution 2014-10-18 11:53:16 +02:00
GuiViewSource.cpp Merge remote-tracking branch 'features/str-metrics' 2014-07-25 20:10:55 +02:00
GuiViewSource.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiVSpace.cpp Add missing widget update 2013-11-15 19:29:15 +01:00
GuiVSpace.h
GuiWorkArea_Private.h Squash warnings reported by gcc 4.9 2015-01-14 11:52:14 +01:00
GuiWorkArea.cpp Adjust preprocessor guards for Qt5/X11. 2015-01-11 19:44:35 +01:00
GuiWorkArea.h #9130 Text in main work area isn't rendered with high resolution 2014-10-18 11:53:16 +02:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp correct icon size in math panels 2010-09-24 12:59:43 +00:00
IconPalette.h
InGuiThread.cpp check also if there is a QApplication instance 2010-11-01 21:32:59 +00:00
InGuiThread.h LyX 2.1 will support only Qt>=4.5. 2012-11-04 01:22:32 +01:00
InsertTableWidget.cpp More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsertTableWidget.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsetParamsDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
InsetParamsDialog.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
InsetParamsWidget.cpp Fix bug 8880: do not try to validate custom value if it is disabled 2013-11-12 15:48:34 +01:00
InsetParamsWidget.h set eol-style 2010-11-18 19:50:29 +00:00
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LayoutBox.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
LayoutBox.h Cleanup private part of Layout Box on destructor (probably not really an 2011-10-15 13:34:14 +00:00
LengthCombo.cpp Move LengthCombo into namespace lyx::frontend 2012-12-17 21:38:57 +01:00
LengthCombo.h Move LengthCombo into namespace lyx::frontend 2012-12-17 21:38:57 +01:00
LyXFileDialog.cpp Fix file dialogs with Qt 5.2.0 and later. 2013-12-24 17:21:56 +01:00
LyXFileDialog.h
Makefile.am Add cmake files to autoconf's dist 2014-08-31 15:21:20 +02:00
Menus.cpp Use appropriate (cheaper) conversion. 2014-12-07 13:06:29 +01:00
Menus.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
PanelStack.cpp Fix assert: Do not use translated names as keys 2013-05-13 10:00:57 +02:00
PanelStack.h Add a search box to the Document Settings and Preferences dialog. 2011-06-05 17:54:27 +00:00
pch.h
qt_helpers.cpp #9130 Text in main work area isn't rendered with high resolution 2014-10-18 15:19:47 +02:00
qt_helpers.h #9130 Text in main work area isn't rendered with high resolution 2014-10-18 15:19:47 +02:00
qt_i18n.h
README
TocModel.cpp Header cleanup cont. 2013-05-22 19:58:58 -07:00
TocModel.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
TocWidget.cpp Focus on buffer after section select in Outliner 2014-04-21 11:51:57 -04:00
TocWidget.h Attempt to workaround movement and editation slowness. 2010-12-19 22:27:21 +00:00
Toolbars.cpp An IPA toolbar 2012-08-21 14:56:34 +02:00
Toolbars.h An IPA toolbar 2012-08-21 14:56:34 +02:00
Validator.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
Validator.h "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.