lyx_mirror/src/frontends/qt4
Jean-Marc Lasgouttes f04c7711b0 Fix empty width support for Box inset
* InsetBox and GuiBox: Use proper empty length instead of the broken -9.99col% trick
* some slight changes to the logic of GuiBox to make sure that values are set as needed.
* lengthToWidget(): handle properly the empty length case. All the other related Qt helpers did it already, it was probably an oversight. Also set the default_unit parameter as optional (not needed in this patch actually, but I got carried away :)
* allow generating LaTeX code for an empty length, since some broken code does that.
2013-05-24 15:44:59 +02:00
..
ui Make the use of system's theme icons configurable 2013-05-14 17:26:06 +02:00
.gitignore Setup .gitignore for generated files 2012-03-22 02:16:12 +01:00
Action.cpp Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
Action.h Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
BulletsModule.cpp Update status when bullet size is changed. 2011-06-04 12:50:39 +00:00
BulletsModule.h
ButtonController.cpp
ButtonController.h Fix doxygen output for grouped items. Without the /name tag doxygen shows the group name as the name of the first item. Moreover, the comment styles are somewhat standardized. 2010-01-27 18:10:33 +00:00
ButtonPolicy.cpp Revert r35760, as suggested by Vincent. 2010-10-21 19:33:29 +00:00
ButtonPolicy.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
CategorizedCombo.cpp Consider filtering when selecting from categorized combo (#8452) 2012-12-10 12:52:23 +01:00
CategorizedCombo.h Rescue monolithic build after 32fde61c8f. 2012-11-24 17:48:47 +01:00
CMakeLists.txt Adjust CMake for Qt5 2013-04-23 21:45:49 +02:00
ColorCache.cpp Set url color from system theme. 2010-09-09 13:04:02 +00:00
ColorCache.h Finish implementation of "use system colors" checkbox. 2010-08-09 12:15:02 +00:00
CustomizedWidgets.cpp
CustomizedWidgets.h
Dialog.cpp Another assertion that got changed wrongly. 2013-04-27 18:12:27 -04:00
Dialog.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
DialogView.h DialogView: make GuiView the parent widget to partly solve bug #6710. 2010-10-21 13:40:49 +00:00
DockView.h close floating dock widgets (not currently docked) with escape keypress event 2011-09-29 18:52:36 +00:00
EmptyTable.cpp
EmptyTable.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
FancyLineEdit.cpp Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FancyLineEdit.h Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FileDialog.cpp LyX 2.1 will support only Qt>=4.5. 2012-11-04 01:22:32 +01:00
FileDialog.h Take Vincent's advice: using a pointer for selectedFilter 2011-10-15 13:32:14 +00:00
FindAndReplace.cpp Header cleanup cont. 2013-05-19 18:07:53 -07:00
FindAndReplace.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
FloatPlacement.cpp More include frenzy. 2010-10-31 01:04:03 +00:00
FloatPlacement.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiAbout.cpp GuiAbout: Add missing include 2013-05-15 07:47:02 +02:00
GuiAbout.h About box: Migrate to DialogView. 2010-01-23 20:29:00 +00:00
GuiAlert.cpp Avoid that, if an error dialog pops up during a long operation, it freezes LyX. 2012-08-18 22:45:21 +01:00
GuiApplication.cpp Seed Qt's random generator 2013-05-19 13:59:45 +02:00
GuiApplication.h Avoid that, if an error dialog pops up during a long operation, it freezes LyX. 2012-08-18 22:45:21 +01:00
GuiBibitem.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiBibitem.h Migrate GuiBibitem to InsetParamsWidget. 2010-02-23 21:24:24 +00:00
GuiBibtex.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiBibtex.h
GuiBox.cpp Fix empty width support for Box inset 2013-05-24 15:44:59 +02:00
GuiBox.h support for \mbox and \fbox 2013-03-22 01:33:58 +01:00
GuiBranch.cpp Migrate Branch dialog to InsetParamsWidget 2010-02-19 20:57:25 +00:00
GuiBranch.h Migrate Branch dialog to InsetParamsWidget 2010-02-19 20:57:25 +00:00
GuiBranches.cpp Fix monolithic build (bug #8079) 2012-03-24 15:25:30 +01:00
GuiBranches.h Fix handling of the add branch textfield in GuiBranches 2012-03-03 14:39:32 +00:00
GuiChanges.cpp Fix bug #4213: Change tracking support for tex2lyx. 2011-11-06 17:03:59 +00:00
GuiChanges.h
GuiCharacter.cpp More llvm/clang warnings 2013-05-02 18:27:32 +02:00
GuiCharacter.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
GuiCitation.cpp Constify some catches and others 2012-09-17 04:05:34 -04:00
GuiCitation.h Move the citation engine machinery to layouts. 2012-03-01 00:41:30 +00:00
GuiClipboard.cpp Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiClipboard.h Implement paste from LaTeX and HTML (bug #3096) 2013-04-14 19:45:36 +02:00
GuiCommandBuffer.cpp Constify some catches and others 2012-09-17 04:05:34 -04:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompare.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiCompare.h Some cosmetics (from my local cosmetics branch). 2010-10-18 14:20:03 +00:00
GuiCompareHistory.cpp Add very simple revision comparison for git. 2013-02-09 19:35:22 -08:00
GuiCompareHistory.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiCompleter.cpp Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiCompleter.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiDelimiter.cpp Full delimiter support for llbracket and rrbracket 2012-12-16 15:49:42 +01:00
GuiDelimiter.h
GuiDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiDialog.h Typos in the comment. 2011-02-13 09:59:14 +00:00
GuiDocument.cpp New \cite_engine_type default. 2013-05-16 20:39:23 +02:00
GuiDocument.h A first batch of potential bugs spotted by llvm/clang 2013-05-02 16:38:25 +02:00
GuiErrorList.cpp Generalize check to generic non-editable insets. 2011-04-05 15:40:00 +00:00
GuiErrorList.h Fix bug #6462: Out-of-bounds index in GuiErrorList::goTo when new buffer is active. 2010-03-12 15:06:13 +00:00
GuiERT.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiERT.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiExternal.cpp Move readBB_from_PSFile() out of support (no code change), 2012-02-15 20:50:52 +00:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp A first batch of potential bugs spotted by llvm/clang 2013-05-02 16:38:25 +02:00
GuiFontLoader.h
GuiFontMetrics.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiFontMetrics.h Avoid narrowing in array initializator 2012-01-07 18:29:07 +00:00
GuiGraphics.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
GuiGraphics.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiGraphicsUi.h
GuiHSpace.cpp Simplify code a bit. 2011-11-23 16:49:34 +00:00
GuiHSpace.h InsetSpace support for 2011-08-29 14:07:30 +00:00
GuiHyperlink.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiHyperlink.h Migrate GuiHyperlink to InsetParamsDialog. 2010-10-27 17:02:42 +00:00
GuiIdListModel.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiIdListModel.h
GuiImage.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
GuiImage.h
GuiInclude.cpp Fix the file filters for InsetInclude. 2011-09-13 20:43:06 +00:00
GuiInclude.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp Don't allow newline characters in document settings. 2011-09-24 16:39:23 +00:00
GuiIndices.h Rename QLineEdit widgets to have a LE suffix (consistent within GuiDocument). 2011-09-24 16:39:20 +00:00
GuiInfo.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiInfo.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiKeySymbol.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiKeySymbol.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiLabel.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiLabel.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiLine.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiLine.h GuiLine: honor Abdel as author 2010-09-17 01:32:23 +00:00
GuiListings.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiListings.h
GuiLog.cpp Highlight warning and errors in the BibTeX log. 2013-01-15 16:13:20 +01:00
GuiLog.h
GuiMathMatrix.cpp GuiMathMatrix.cpp: remove an unused header 2013-05-14 02:26:22 +02:00
GuiMathMatrix.h GuiMathMatrix: 2010-09-24 03:44:34 +00:00
GuiNomenclature.cpp Implement GuiNomenclature::initialiseParams(), thus restoring the 2011-09-11 14:14:04 +00:00
GuiNomenclature.h Implement GuiNomenclature::initialiseParams(), thus restoring the 2011-09-11 14:14:04 +00:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiPainter.h Factor out painting of text decorations 2012-05-02 18:02:17 +02:00
GuiParagraph.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiParagraph.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Only show the configuration of theme icons on X11 2013-05-14 18:04:17 +02:00
GuiPrefs.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPrint.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiPrint.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPrintindex.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiPrintindex.h
GuiPrintNomencl.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiPrintNomencl.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiProgress.cpp Fix bug #8032 (timeout when using the Sweave module) 2012-02-18 14:16:25 +00:00
GuiProgress.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiProgressView.cpp Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiProgressView.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiRef.cpp GuiRef: only enable "Group" CB if non-empty refs 2013-04-22 15:39:16 -04:00
GuiRef.h Fix issues with xref dialog in read-only documents (#8177) 2012-09-29 16:12:31 +02:00
GuiSearch.cpp
GuiSearch.h
GuiSelection.cpp
GuiSelection.h
GuiSelectionManager.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiSelectionManager.h Remove ; from end of function definitions 2013-05-12 13:04:18 +02:00
GuiSendto.cpp Do not sort formats in BufferParams::exportableFormats 2013-03-24 18:06:32 +01:00
GuiSendto.h
GuiSetBorder.cpp qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiSetBorder.h qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiShowFile.cpp support: 2010-04-21 01:19:28 +00:00
GuiShowFile.h
GuiSpellchecker.cpp Fix bug #8238: correct the forward argument of replace2string() in on_replacePB_clicked(). 2012-07-27 00:34:17 +02:00
GuiSpellchecker.h Fixes the following issues: 2011-04-08 13:26:45 +00:00
GuiSymbols.cpp Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
GuiSymbols.h
GuiTabular.cpp GuiTabular: disabling is now done on textChanged() 2013-03-19 14:48:20 -04:00
GuiTabular.h Fix #7021: the problem was that activating the border combo was triggering dialogToParams() and thus disallowed because of the empty value. 2010-12-04 10:55:03 +00:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp Also display the info about BibTeX databases in the TeX info panel. 2011-12-03 22:24:58 +00:00
GuiTexinfo.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiThesaurus.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiThesaurus.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToc.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiToc.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToolbar.cpp Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToolbar.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiView.cpp Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiView.h Fix zombie toolbars (bug 8520) 2013-05-19 22:17:16 +02:00
GuiViewSource.cpp Another try at making the source view dock arrange itself. 2013-05-07 11:30:46 +02:00
GuiViewSource.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiVSpace.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiVSpace.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiWorkArea_Private.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiWorkArea.cpp A first batch of potential bugs spotted by llvm/clang 2013-05-02 16:38:25 +02:00
GuiWorkArea.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp correct icon size in math panels 2010-09-24 12:59:43 +00:00
IconPalette.h
InGuiThread.cpp check also if there is a QApplication instance 2010-11-01 21:32:59 +00:00
InGuiThread.h LyX 2.1 will support only Qt>=4.5. 2012-11-04 01:22:32 +01:00
InsertTableWidget.cpp More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsertTableWidget.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsetParamsDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
InsetParamsDialog.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
InsetParamsWidget.cpp set eol-style 2010-11-18 19:50:29 +00:00
InsetParamsWidget.h set eol-style 2010-11-18 19:50:29 +00:00
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LayoutBox.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
LayoutBox.h Cleanup private part of Layout Box on destructor (probably not really an 2011-10-15 13:34:14 +00:00
LengthCombo.cpp Move LengthCombo into namespace lyx::frontend 2012-12-17 21:38:57 +01:00
LengthCombo.h Move LengthCombo into namespace lyx::frontend 2012-12-17 21:38:57 +01:00
LyXFileDialog.cpp Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
LyXFileDialog.h
Makefile.am Split the overcrowded and chaotic UI pref pane into two (#7524) 2013-03-02 12:24:32 +01:00
Menus.cpp Remove the 'running' booleans quit and optional 2013-05-13 11:37:26 +02:00
Menus.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
PanelStack.cpp Fix assert: Do not use translated names as keys 2013-05-13 10:00:57 +02:00
PanelStack.h Add a search box to the Document Settings and Preferences dialog. 2011-06-05 17:54:27 +00:00
pch.h
qt_helpers.cpp Fix empty width support for Box inset 2013-05-24 15:44:59 +02:00
qt_helpers.h Fix empty width support for Box inset 2013-05-24 15:44:59 +02:00
qt_i18n.h
README
TocModel.cpp Header cleanup cont. 2013-05-22 19:58:58 -07:00
TocModel.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
TocWidget.cpp A first batch of potential bugs spotted by llvm/clang 2013-05-02 16:38:25 +02:00
TocWidget.h Attempt to workaround movement and editation slowness. 2010-12-19 22:27:21 +00:00
Toolbars.cpp An IPA toolbar 2012-08-21 14:56:34 +02:00
Toolbars.h An IPA toolbar 2012-08-21 14:56:34 +02:00
Validator.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
Validator.h "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.