lyx_mirror/src/frontends/qt4
Jean-Marc Lasgouttes f3cdf74e68 Remember the last used QTextLayout object
This crude caching mecanism is useful in the particular case of a screen with many misspelling dotted lines. In this case, it is necessary to build a QTextLayout in order to know where to put the start/end of the spell line. Since rows typically contains text snippets longer than a word, we may be in a situation where the same QTextLayout is constructed repeatedly.

This commit is useful in this particular use case, and should not be costly in other cases. A better fix would be to remember the QTextLayout associated to each row element. This is a bit more work, so this fix should be sufficient for now.

Additionally, do not paint misspelled marks when painting is disabled.

Fixes bug #9890.
2015-12-09 11:57:52 +01:00
..
ui Replace the translatable latexism 'longtable' with 'multi-page table' in UI. 2015-11-16 10:29:53 +01:00
.gitignore Setup .gitignore for generated files 2012-03-22 02:16:12 +01:00
Action.cpp Compilation fix for windows 2015-07-16 09:48:57 +02:00
Action.h Even more llvm/clang warnings 2013-05-02 19:22:10 +02:00
BulletsModule.cpp Update status when bullet size is changed. 2011-06-04 12:50:39 +00:00
BulletsModule.h
ButtonController.cpp
ButtonController.h
ButtonPolicy.cpp
ButtonPolicy.h
CategorizedCombo.cpp Squash warnings reported by gcc 4.9 2015-01-14 11:52:14 +01:00
CategorizedCombo.h Rescue monolithic build after 32fde61c8f. 2012-11-24 17:48:47 +01:00
CMakeLists.txt Add Qt's Svg module to the list of used modules. This is required to allow the use of e.g. the QSvgRenderer class. 2015-05-19 22:46:26 +02:00
ColorCache.cpp
ColorCache.h
CustomizedWidgets.cpp Do not pass objects by value 2015-09-12 19:22:51 +02:00
CustomizedWidgets.h Do not pass objects by value 2015-09-12 19:22:51 +02:00
Dialog.cpp If there is an inset at cursor, connect the dialog with that, not the containing one 2015-05-26 19:33:07 +02:00
Dialog.h Remove some header leftovers based on Scott's script hints. 2013-05-02 00:30:16 -07:00
DialogView.h
DockView.h close floating dock widgets (not currently docked) with escape keypress event 2011-09-29 18:52:36 +00:00
EmptyTable.cpp sign. 2015-05-02 11:38:46 +02:00
EmptyTable.h sign. 2015-05-02 11:38:46 +02:00
FancyLineEdit.cpp Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FancyLineEdit.h Prepare LyX code to compile and link with Qt5: 2013-02-03 19:26:21 +01:00
FileDialog.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
FileDialog.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
FindAndReplace.cpp Create proper undo groups for advanced find and replace 2015-05-22 16:42:10 +02:00
FindAndReplace.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
FloatPlacement.cpp Add more Float tags to allow to disable wide and sideways feature 2015-05-22 18:59:17 +02:00
FloatPlacement.h Add more Float tags to allow to disable wide and sideways feature 2015-05-22 18:59:17 +02:00
GuiAbout.cpp GuiAbout: Detect and provide links to trac 2015-05-24 14:51:47 +02:00
GuiAbout.h
GuiAlert.cpp Add missing breaks 2015-09-12 19:58:15 +02:00
GuiApplication.cpp Remove unneeded png images. 2015-12-07 19:14:44 +01:00
GuiApplication.h Fix compilation with qt5 and c++11 combined. 2015-08-24 21:05:48 +02:00
GuiBibitem.cpp Improve read-only mode of InsetParams derived dialogs 2015-03-30 14:44:11 +02:00
GuiBibitem.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiBibtex.cpp Assure we use docstring. 2015-11-16 08:21:53 +01:00
GuiBibtex.h
GuiBox.cpp Factor out multiply used ColorSorter. 2015-11-16 08:19:16 +01:00
GuiBox.h Fix up GuiBox (use proper data/view separation and clean up) 2015-05-16 11:27:13 +02:00
GuiBranch.cpp Implement checkWidgets in the remaining InsetParamsWidget derived dialogs. 2015-04-02 17:03:08 +02:00
GuiBranch.h Implement checkWidgets in the remaining InsetParamsWidget derived dialogs. 2015-04-02 17:03:08 +02:00
GuiBranches.cpp Fix cppcheck variable scope warnings 2015-09-20 10:42:35 +02:00
GuiBranches.h Fix handling of the add branch textfield in GuiBranches 2012-03-03 14:39:32 +00:00
GuiChanges.cpp Fix bug #4213: Change tracking support for tex2lyx. 2011-11-06 17:03:59 +00:00
GuiChanges.h
GuiCharacter.cpp Factor out multiply used ColorSorter. 2015-11-16 08:19:16 +01:00
GuiCharacter.h Use view/data separation for GuiCharacter colors, which makes it possible to sort the colors 2015-05-17 17:15:01 +02:00
GuiCitation.cpp Fix C++11 std::regex incompatibility 2015-11-24 20:31:14 +01:00
GuiCitation.h Decrease height of citation dialog by using a QToolBox 2015-07-30 10:09:21 +02:00
GuiClipboard.cpp Small clean-up to debug support 2015-07-08 11:03:42 +02:00
GuiClipboard.h GuiLog: Use GuiClipboard to put the log on the clipboard 2014-04-29 15:38:35 +02:00
GuiCommandBuffer.cpp Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCommandBuffer.h Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCommandEdit.cpp Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCommandEdit.h Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCompare.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiCompare.h
GuiCompareHistory.cpp Add very simple revision comparison for git. 2013-02-09 19:35:22 -08:00
GuiCompareHistory.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiCompleter.cpp Consistency of ellipses across the UI 2015-10-05 21:16:16 +01:00
GuiCompleter.h Header cleanup cont. 2013-05-19 18:07:53 -07:00
GuiDelimiter.cpp Extend the fix for #5760 to the cygwin xcb backend. 2015-05-30 17:25:36 +02:00
GuiDelimiter.h
GuiDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiDialog.h
GuiDocument.cpp Store both sets of font selections 2015-11-09 07:36:42 +01:00
GuiDocument.h Store both sets of font selections 2015-11-09 07:36:42 +01:00
GuiErrorList.cpp Show Anyway button needs to be enabled/disabled in paramsToDialog. 2015-04-05 10:50:30 +02:00
GuiErrorList.h Button for showing PDF if compilation error 2015-04-04 13:13:19 -04:00
GuiERT.cpp Implement checkWidgets in the remaining InsetParamsWidget derived dialogs. 2015-04-02 17:03:08 +02:00
GuiERT.h Implement checkWidgets in the remaining InsetParamsWidget derived dialogs. 2015-04-02 17:03:08 +02:00
GuiExternal.cpp Remove relative units from bounding box 2015-07-18 16:41:52 +02:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp Use a QCache for string metrics 2015-11-17 09:38:16 +01:00
GuiFontLoader.h
GuiFontMetrics.cpp Remember the last used QTextLayout object 2015-12-09 11:57:52 +01:00
GuiFontMetrics.h Use a QCache for string metrics 2015-11-17 09:38:16 +01:00
GuiGraphics.cpp Remove unused variables 2015-10-10 21:28:28 +02:00
GuiGraphics.h Fix aspectratio UI 2015-01-04 10:05:42 +01:00
GuiGraphicsUi.h
GuiHSpace.cpp HSpace/VSpace: use a _signed_ length validator in the dialogs. 2015-06-26 13:19:12 +02:00
GuiHSpace.h Fix enabling/disabling in InsetParams derived dialogs (#9541) 2015-05-11 11:35:02 +02:00
GuiHyperlink.cpp Improve read-only mode of InsetParams derived dialogs 2015-03-30 14:44:11 +02:00
GuiHyperlink.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiIdListModel.cpp Audit all the LASSERT calls, and try to do something sensible at 2013-04-25 17:27:10 -04:00
GuiIdListModel.h
GuiImage.cpp Support units in external inset bbox 2015-07-16 22:06:35 +02:00
GuiImage.h
GuiInclude.cpp Remove unused variables found by cppcheck 2015-09-20 21:39:59 +02:00
GuiInclude.h
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp Fix cppcheck variable scope warnings 2015-09-20 10:42:35 +02:00
GuiIndices.h GuiIndices: Improve widget disabling and account for read only status 2015-06-03 16:54:54 +02:00
GuiInfo.cpp GuiInfo: implement checkWidgets. 2015-04-01 10:07:20 +02:00
GuiInfo.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiKeySymbol.cpp For Mac OS: Additional check for Control and Meta modifier swap state. 2015-10-24 21:08:10 +02:00
GuiKeySymbol.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiLabel.cpp Improve read-only mode of InsetParams derived dialogs 2015-03-30 14:44:11 +02:00
GuiLabel.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiLine.cpp Improve read-only mode of InsetParams derived dialogs 2015-03-30 14:44:11 +02:00
GuiLine.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiListings.cpp This is the result of an audit of all static variables, looking 2014-04-21 11:51:57 -04:00
GuiListings.h
GuiLog.cpp Amend f441590c 2015-11-03 15:27:25 +00:00
GuiLog.h Add "Open Containing Directory" button to the log dialog (#9211, #9834) 2015-11-03 03:54:52 +00:00
GuiMathMatrix.cpp Fix bug #9153 (Using mathpanel to insert matrix creates extra space on top) 2014-06-06 16:14:24 +02:00
GuiMathMatrix.h
GuiNomenclature.cpp Improve read-only mode of InsetParams derived dialogs 2015-03-30 14:44:11 +02:00
GuiNomenclature.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp Fix drawing with pixmap cache 2015-10-19 16:38:05 +02:00
GuiPainter.h Fix drawing with pixmap cache 2015-10-19 16:38:05 +02:00
GuiParagraph.cpp GuiParagraph: Fix remaining glitch when entering custom line spread 2015-06-13 12:31:03 +02:00
GuiParagraph.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Update previews when turned on in prefs (#9507) 2015-11-30 18:51:05 -05:00
GuiPrefs.h Update previews when turned on in prefs (#9507) 2015-11-30 18:51:05 -05:00
GuiPrintindex.cpp
GuiPrintindex.h
GuiPrintNomencl.cpp Fix enabling/disabling in InsetParams derived dialogs (#9541) 2015-05-11 11:35:02 +02:00
GuiPrintNomencl.h No need for default argument 2015-04-02 16:32:04 +02:00
GuiProgress.cpp On Linux show in crash message box the backtrace 2014-06-14 11:25:25 +02:00
GuiProgress.h On Linux show in crash message box the backtrace 2014-06-14 11:25:25 +02:00
GuiProgressView.cpp Fix cppcheck variable scope warnings 2015-09-20 10:42:35 +02:00
GuiProgressView.h Header cleanup cont. 2013-05-20 18:47:16 -07:00
GuiRef.cpp Fix indentation 2015-05-17 17:27:27 +02:00
GuiRef.h Fix issues with xref dialog in read-only documents (#8177) 2012-09-29 16:12:31 +02:00
GuiSearch.cpp Style 2014-02-04 10:37:29 +01:00
GuiSearch.h Adding wrap-around pop-up question to simple find and replace dialog (fixing enhancement request #1262). 2013-07-21 17:51:53 +01:00
GuiSelection.cpp Use the cached value GuiSelection::selection_supported_ 2014-04-29 15:17:15 +02:00
GuiSelection.h
GuiSelectionManager.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiSelectionManager.h Remove ; from end of function definitions 2013-05-12 13:04:18 +02:00
GuiSendto.cpp Do not sort formats in BufferParams::exportableFormats 2013-03-24 18:06:32 +01:00
GuiSendto.h
GuiSetBorder.cpp Disable setting vertical lines when using a formal table 2015-11-02 15:58:40 +01:00
GuiSetBorder.h qt5: Use Qt::WindowFlags instead of Qt::WFlags 2012-12-15 11:07:35 +01:00
GuiShowFile.cpp
GuiShowFile.h
GuiSpellchecker.cpp #9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5. 2014-08-25 20:08:59 +02:00
GuiSpellchecker.h Fixes the following issues: 2011-04-08 13:26:45 +00:00
GuiSymbols.cpp Fix cppcheck variable scope warnings 2015-09-20 10:42:35 +02:00
GuiSymbols.h
GuiTabular.cpp Disable setting vertical lines when using a formal table 2015-11-02 15:58:40 +01:00
GuiTabular.h Fix enabling/disabling in InsetParams derived dialogs (#9541) 2015-05-11 11:35:02 +02:00
GuiTabularCreate.cpp Use EmptyTable widget in TabularCreate dialog. 2015-05-01 18:11:57 +02:00
GuiTabularCreate.h
GuiTexinfo.cpp Also display the info about BibTeX databases in the TeX info panel. 2011-12-03 22:24:58 +00:00
GuiTexinfo.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiThesaurus.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiThesaurus.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToc.cpp Remove C-style casts found by cppcheck 2015-10-10 21:44:08 +02:00
GuiToc.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
GuiToolbar.cpp Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiToolbar.h Simplify the code for "auto" toolbars handling 2015-06-18 15:51:53 +02:00
GuiView.cpp Whitespace. 2015-11-29 11:25:08 -05:00
GuiView.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
GuiViewSource.cpp Amend 789745df 2015-11-15 12:18:47 +00:00
GuiViewSource.h TexRow info in source panel and gotoCursor() for debugging 2015-10-19 06:55:17 +01:00
GuiVSpace.cpp HSpace/VSpace: use a _signed_ length validator in the dialogs. 2015-06-26 13:19:12 +02:00
GuiVSpace.h Implement checkWidgets in the remaining InsetParamsWidget derived dialogs. 2015-04-02 17:03:08 +02:00
GuiWorkArea_Private.h Squash warnings reported by gcc 4.9 2015-01-14 11:52:14 +01:00
GuiWorkArea.cpp Add missing intializations 2015-10-10 21:04:28 +02:00
GuiWorkArea.h Implement and bind buffer-move-{next,previous} 2015-04-08 14:12:52 -04:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp
IconPalette.h
InGuiThread.cpp
InGuiThread.h LyX 2.1 will support only Qt>=4.5. 2012-11-04 01:22:32 +01:00
InsertTableWidget.cpp Compilation fix for windows 2015-07-16 09:48:57 +02:00
InsertTableWidget.h More llvm/clang warnings 2013-05-02 18:27:32 +02:00
InsetParamsDialog.cpp Disable Apply button in InsetParams dialogs if there is no inset to apply to. 2015-11-19 15:48:49 +01:00
InsetParamsDialog.h Header cleanup cont. 2013-05-22 19:58:58 -07:00
InsetParamsWidget.cpp Fix warning 2015-03-31 17:08:04 +02:00
InsetParamsWidget.h Improve read-only mode of InsetParams derived dialogs 2015-03-30 14:44:11 +02:00
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LayoutBox.cpp Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
LayoutBox.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
LengthCombo.cpp Remove relative units from bounding box 2015-07-18 16:41:52 +02:00
LengthCombo.h Remove relative units from bounding box 2015-07-18 16:41:52 +02:00
LyXFileDialog.cpp Fix file dialogs with Qt 5.2.0 and later. 2013-12-24 17:21:56 +01:00
LyXFileDialog.h
Makefile.am Remove unneeded png images. 2015-12-07 19:14:44 +01:00
Menus.cpp Capitalization 2015-11-03 03:54:52 +00:00
Menus.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
PanelStack.cpp Prefer svg icons. 2015-03-13 00:47:21 +01:00
PanelStack.h Add a search box to the Document Settings and Preferences dialog. 2011-06-05 17:54:27 +00:00
qt_helpers.cpp Factor out multiply used ColorSorter. 2015-11-16 08:19:16 +01:00
qt_helpers.h Factor out multiply used ColorSorter. 2015-11-16 08:19:16 +01:00
qt_i18n.h
README
TocModel.cpp Fix compilation with MSVC in c++98 mode 2015-10-01 21:51:08 +01:00
TocModel.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
TocWidget.cpp Enhancements and bugfixes to the TOCs 2015-10-01 21:44:22 +01:00
TocWidget.h
Toolbars.cpp Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
Toolbars.h Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
Validator.cpp Fix problems with immediate apply and length validators 2015-05-20 19:13:12 +02:00
Validator.h Fix problems with immediate apply and length validators 2015-05-20 19:13:12 +02:00

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.