lyx_mirror/src
Abdelrazak Younes 3461169526 Patch by Vincent that solves a number of problems related to the painting of a selection:
1. When a listing is inserted in a bit of text, the line above the listing is not drawn over the full width like it is done for lines above other insets. This is because InsetListing has a AlignLeft alignment. Now, if you start selecting downwards with the mouse in this empty area, strange selection drawings appear (see attachment).
This is caused by the fact that starting your selection at such a place, causes beg.boundary() to be true in TextMetrics::drawRowSelection(..). This is correct, but this value is true for _all_ selected lines. Now, the selection acts as if it is RTL text. Therefore, just like for end.boundary, this value needs to be reset for every line.
2. Starting your selection in an end margin often causes the selection in this end margin to be painted later. This is because when starting your selection in an end margin, you may have set a (possible empty) selection before really selecting the end margin. The problem is that the checksum (computed later) is the same for this empty selection and for the end margin selection. Therfore, we need a call to cur.setSelection() before evaluating cur.selection().
 
3. In the following two lines, it is assumed that there is only an end margin to be painted if the selection extends to the next paragraph. This is not true for the above described case of an AlignLeft Inset. Then, the margin has also be drawn within a paragraph
 
4. The end and begin margins are only painted when the selection extends into the following or previous paragraph. This difference is not resembled in the checksum if you first select a row completely and then procede to the next or previous paragraph as the selection remains at the end of a row. This also holds for the AlignLeft case. Therefore I added a term to the checksum to monitor whether the end and begin margins need to be drawn.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26399 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-14 14:32:40 +00:00
..
client Remove our in tree gettext version and replace with a mechanism to import it. 2008-06-06 15:25:55 +00:00
frontends Paragraph::inInset() shall not be used if the owner inset was not initialized. Make this rule clear and unavoidable. 2008-09-13 17:01:54 +00:00
graphics ** proper implementation of pLaTeX by Tetsuya Makimura and me, fixes many remaining problems and bugs with language "japanese" (bugs 4863, 4290, 4700 and partially 4697) ** 2008-08-18 17:26:09 +00:00
insets clean up horizontal tabular line latex-output 2008-09-14 12:31:58 +00:00
lyxled next try... 2008-04-02 23:06:22 +00:00
mathed Revert 26348 and 26350. Wrong solution. 2008-09-10 14:36:38 +00:00
support Add a new debug channel UNDO (in place of the unused ROFF) 2008-08-15 19:09:42 +00:00
tex2lyx * update tex2lyx man page, mostly done bei Uwe (bug 2770). 2008-07-28 07:52:27 +00:00
ASpell_local.h
ASpell.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
Author.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
Author.h
BiblioInfo.cpp Coding style 2008-09-08 01:18:33 +00:00
BiblioInfo.h Implement a cache for BibTeX data. There was a cache of sorts already in InsetCitation, but that was being used only to cache the labels. So that has been moved to Buffer, and everything else that needs access to BibTeX data should call either Buffer::localBibInfo(), which gives you the BiblioInfo for this Buffer, or Buffer::masterBibInfo(), which gives you the BiblioInfo for the Buffer's master, if it has one, or for it, otherwise. Normally, what you want is masterBibInfo(). 2008-04-25 20:03:03 +00:00
Bidi.cpp
Bidi.h
boost.cpp Sanitize LyX singleton access by getting rid of ref() and cref() methods. 2008-07-14 08:35:00 +00:00
Box.cpp
Box.h
BranchList.cpp Simplify things just a little bit. 2008-05-27 18:57:16 +00:00
BranchList.h Simplify things just a little bit. 2008-05-27 18:57:16 +00:00
buffer_funcs.cpp * make sure that the reference cache, buffer_ pointers and macros are updated 2008-08-13 10:36:43 +00:00
buffer_funcs.h
Buffer.cpp Coding style 2008-09-08 01:18:33 +00:00
Buffer.h Move child document closing from InsetInclude dtor to Buffer parent dtor. Fix http://bugzilla.lyx.org/show_bug.cgi?id=5047 2008-07-20 17:52:55 +00:00
BufferList.cpp BufferList::bufferNum() and getFileNames(): migrate to FileName/FileNameList 2008-07-29 08:52:25 +00:00
BufferList.h BufferList::bufferNum() and getFileNames(): migrate to FileName/FileNameList 2008-07-29 08:52:25 +00:00
BufferParams.cpp various listings fixes by Vincent, see http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg143302.html 2008-09-08 21:51:38 +00:00
BufferParams.h Support for removing "default" modules. 2008-07-27 17:46:27 +00:00
BufferView.cpp Fix bug 5065: DEPM fails with "cursor follows scrollbar" 2008-08-14 09:59:04 +00:00
BufferView.h Fix PageDown/Up when at bottom/top of the document. Now the cursor moves to the bottom/top position. This also fixes http://bugzilla.lyx.org/show_bug.cgi?id=4384 2008-07-04 11:33:28 +00:00
Bullet.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
Bullet.h
Changes.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
Changes.h
Chktex.cpp
Chktex.h
Citation.h Cosmetics. 2008-04-20 16:34:30 +00:00
CmdDef.cpp remove unneeded includes. 2008-05-06 06:48:38 +00:00
CmdDef.h
Color.cpp specify a background color for listings and allow the user to change it, patch by Vincent 2008-09-08 21:38:01 +00:00
Color.h
ColorCode.h specify a background color for listings and allow the user to change it, patch by Vincent 2008-09-08 21:38:01 +00:00
CompletionList.h cosmetics/#include cleanup 2008-03-15 00:22:54 +00:00
Converter.cpp Refresh before checking for equality. Solves problem noted by Bennett. 2008-07-29 18:16:05 +00:00
Converter.h
ConverterCache.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
ConverterCache.h
CoordCache.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
CoordCache.h
Counters.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
Counters.h two uninitialized variables uncovered by valgrind, and a gcc warning 2008-03-13 10:28:02 +00:00
Cursor.cpp When only selecting the end_margin between 'after i-1' and 'before i', the 2008-09-13 23:03:33 +00:00
Cursor.h Let doxygen document this. 2008-09-12 10:42:23 +00:00
CursorSlice.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
CursorSlice.h Cosmetics. 2008-02-11 08:03:03 +00:00
CutAndPaste.cpp Paragraph::inInset() shall not be used if the owner inset was not initialized. Make this rule clear and unavoidable. 2008-09-13 17:01:54 +00:00
CutAndPaste.h constification without any code change. This is part of and effort to see whether BufferView::cursor() could be made const 2008-08-13 13:46:19 +00:00
DepTable.cpp
DepTable.h
Dimension.cpp
Dimension.h
DispatchResult.h
DocIterator.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
DocIterator.h Add missing operator>= to DocIterator 2008-08-12 09:51:00 +00:00
Encoding.cpp ** proper implementation of pLaTeX by Tetsuya Makimura and me, fixes many remaining problems and bugs with language "japanese" (bugs 4863, 4290, 4700 and partially 4697) ** 2008-08-18 17:26:09 +00:00
Encoding.h ** proper implementation of pLaTeX by Tetsuya Makimura and me, fixes many remaining problems and bugs with language "japanese" (bugs 4863, 4290, 4700 and partially 4697) ** 2008-08-18 17:26:09 +00:00
ErrorList.cpp
ErrorList.h
Exporter.cpp
Exporter.h
factory.cpp Pass Buffer in InsetQuote ctor. Patch fro Richard. 2008-09-06 14:04:01 +00:00
factory.h
Floating.cpp
Floating.h
FloatList.cpp Remove comment. This issue no longer seems to exist. 2008-03-07 03:42:39 +00:00
FloatList.h
Font.cpp Fix part of bug 4836 2008-05-07 23:33:56 +00:00
Font.h
FontEnums.h
FontInfo.cpp a bit of compilation unbreaking 2008-05-06 10:22:25 +00:00
FontInfo.h
FontList.cpp simplify code by using fontIterator() 2008-07-16 12:40:10 +00:00
FontList.h
Format.cpp
Format.h
FuncCode.h Add completion-accept lfun. 2008-09-08 00:24:47 +00:00
FuncRequest.cpp s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
FuncRequest.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
FuncStatus.cpp FuncStatus::enabled(bool) --> FuncStatus::setEnabled(bool) 2008-05-29 15:14:00 +00:00
FuncStatus.h FuncStatus::enabled(bool) --> FuncStatus::setEnabled(bool) 2008-05-29 15:14:00 +00:00
Graph.cpp
Graph.h
InsetIterator.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
InsetIterator.h
InsetList.cpp Fix http://bugzilla.lyx.org/show_bug.cgi?id=5132 2008-08-07 08:50:41 +00:00
InsetList.h Fix http://bugzilla.lyx.org/show_bug.cgi?id=5132 2008-08-07 08:50:41 +00:00
Intl.cpp header cleanup 2008-02-18 07:14:42 +00:00
Intl.h
ISpell.cpp
ISpell.h
KeyMap.cpp cosmetics 2008-04-03 21:36:57 +00:00
KeyMap.h cosmetics, maily s/NULL/0/g as hinted by Joost 2008-04-07 20:43:02 +00:00
KeySequence.cpp More work on the Shortcuts UI: 2008-07-22 08:29:50 +00:00
KeySequence.h More work on the Shortcuts UI: 2008-07-22 08:29:50 +00:00
Language.cpp Revamp of the character dialog: 2008-05-07 18:53:48 +00:00
Language.h Revamp of the character dialog: 2008-05-07 18:53:48 +00:00
LaTeX.cpp * separate nomencl processing command from index processing command, since nomencl 2008-08-23 09:44:00 +00:00
LaTeX.h
LaTeXFeatures.cpp various listings fixes by Vincent, see http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg143302.html 2008-09-08 21:51:38 +00:00
LaTeXFeatures.h ** subfig support ** 2008-03-02 11:30:50 +00:00
Layout.cpp Improve the local layout feature by better handling of unknown textclass, unknown layouts, and switch between textclasses. 2008-07-11 02:43:02 +00:00
Layout.h Improve the local layout feature by better handling of unknown textclass, unknown layouts, and switch between textclasses. 2008-07-11 02:43:02 +00:00
LayoutEnums.h
LayoutFile.cpp 'Default'-->'Empty' in Bo's recent commit. Default means something else in the code. 2008-07-11 03:41:56 +00:00
LayoutFile.h Add UseModule tag for layout files. This allows the AMS files, in particular, to "require" the 2008-07-25 15:51:27 +00:00
Length.cpp
Length.h cosmetics 2008-03-26 18:53:57 +00:00
lengthcommon.cpp
Lexer.cpp Correctly handle quotation marks in command preferences (bug 2016): 2008-05-05 13:53:28 +00:00
Lexer.h Correctly handle quotation marks in command preferences (bug 2016): 2008-05-05 13:53:28 +00:00
LyX.cpp Some locale related cleanup. JMarc, please when you come back, review this. It is working fine in all my testings though. 2008-07-28 11:26:46 +00:00
LyX.h MSVC compile fix :-) 2008-07-14 11:33:04 +00:00
LyXAction.cpp typo 2008-09-08 00:28:32 +00:00
LyXAction.h typo 2008-06-20 08:26:03 +00:00
lyxfind.cpp Bug 5173: Undo Grouping 2008-08-15 19:24:56 +00:00
lyxfind.h Fix LFUN_WORD_FIND 2008-02-10 18:52:32 +00:00
LyXFunc.cpp * separate nomencl processing command from index processing command, since nomencl 2008-08-23 09:44:00 +00:00
LyXFunc.h Add some constness where we can. 2008-05-22 14:02:35 +00:00
LyXRC.cpp * separate nomencl processing command from index processing command, since nomencl 2008-08-23 09:44:00 +00:00
LyXRC.h * separate nomencl processing command from index processing command, since nomencl 2008-08-23 09:44:00 +00:00
LyXVC.cpp VCS: Towards statusbar info. 2008-07-29 13:14:51 +00:00
LyXVC.h VCS: Towards statusbar info. 2008-07-29 13:14:51 +00:00
lyxwinres.rc
main.cpp
Makefile.am Implement the EnsureMath inset in mathed for nesting math mode in text mode. 2008-09-04 22:24:07 +00:00
MetricsInfo.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
MetricsInfo.h
ModuleList.cpp a bit of compilation unbreaking 2008-05-06 10:22:25 +00:00
ModuleList.h
Mover.cpp
Mover.h
output_docbook.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
output_docbook.h
output_latex.cpp final final touch. 2008-08-19 07:51:40 +00:00
output_latex.h *** sanitize listing's encoding handling *** 2008-07-20 17:14:10 +00:00
output_plaintext.cpp fix crash: Copying the paragraphs invalidate the referenced Buffer so a new setBuffer() would be necessary, in it preferable and faster to just use a const ref. 2008-09-06 13:49:10 +00:00
output_plaintext.h
output.cpp
output.h
OutputParams.cpp Fix rest of bug 4886, following Richard's advices. 2008-09-10 16:02:32 +00:00
OutputParams.h Fix rest of bug 4886, following Richard's advices. 2008-09-10 16:02:32 +00:00
paper.h
paragraph_funcs.cpp Paragraph::inInset() shall not be used if the owner inset was not initialized. Make this rule clear and unavoidable. 2008-09-13 17:01:54 +00:00
paragraph_funcs.h remove invalid comment 2008-05-29 11:25:01 +00:00
Paragraph.cpp exit(10) was a bit extreme... replace with a Buffer exception. 2008-09-13 17:12:01 +00:00
Paragraph.h Paragraph::inInset() shall not be used if the owner inset was not initialized. Make this rule clear and unavoidable. 2008-09-13 17:01:54 +00:00
ParagraphList.h
ParagraphMetrics.cpp Patch by Vincent that solves a number of problems related to the painting of a selection: 2008-09-14 14:32:40 +00:00
ParagraphMetrics.h
ParagraphParameters.cpp Remove some unused code, and replace with a comment. 2008-08-14 07:03:46 +00:00
ParagraphParameters.h Remove some unused code, and replace with a comment. 2008-08-14 07:03:46 +00:00
ParIterator.cpp * ParConstIterator::push_back(): new method for easier iterative construction. 2008-02-15 08:32:27 +00:00
ParIterator.h * ParConstIterator::push_back(): new method for easier iterative construction. 2008-02-15 08:32:27 +00:00
pch.h
PDFOptions.cpp Cosmetics. 2008-03-05 08:55:49 +00:00
PDFOptions.h Add FIXMEs wrt unicode. 2008-05-26 18:37:42 +00:00
PrinterParams.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
PrinterParams.h cosmetics 2008-04-19 20:39:48 +00:00
PSpell.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
PSpell.h
Row.cpp Patch by Vincent that solves a number of problems related to the painting of a selection: 2008-09-14 14:32:40 +00:00
Row.h Patch by Vincent that solves a number of problems related to the painting of a selection: 2008-09-14 14:32:40 +00:00
rowpainter.cpp more appropriate behaviour on assert 2008-08-24 21:24:21 +00:00
rowpainter.h API cosmetics 2008-02-27 23:03:26 +00:00
Section.cpp
Section.h
Server.cpp * Doxy. 2008-07-07 17:26:07 +00:00
Server.h
ServerSocket.cpp a bit of compilation unbreaking 2008-05-06 10:22:25 +00:00
ServerSocket.h
Session.cpp Re-engineer the toolbar support code: 2008-05-27 11:15:17 +00:00
Session.h Sanitize LyX singleton access by getting rid of ref() and cref() methods. 2008-07-14 08:35:00 +00:00
sgml.cpp remove unneeded includes. 2008-05-06 06:48:38 +00:00
sgml.h
Spacing.cpp
Spacing.h
SpellBase.cpp
SpellBase.h
TexRow.cpp header cleanup 2008-02-18 07:14:42 +00:00
TexRow.h
TexStream.cpp
TexStream.h
Text2.cpp rev26385: don't know why but some file were not committed... 2008-09-13 20:19:32 +00:00
Text3.cpp If we call cur.setSelection() in line Text3.cpp:1256 we should require some 2008-09-13 22:59:09 +00:00
Text.cpp rev26385: don't know why but some file were not committed... 2008-09-13 20:19:32 +00:00
Text.h constification without any code change. This is part of and effort to see whether BufferView::cursor() could be made const 2008-08-13 13:46:19 +00:00
TextClass.cpp Coding style 2008-09-08 01:18:33 +00:00
TextClass.h A bit more empty-->plain. I've also changed createEmptyLayout() to createBasicLayout(), 2008-08-01 21:13:03 +00:00
TextMetrics.cpp Patch by Vincent that solves a number of problems related to the painting of a selection: 2008-09-14 14:32:40 +00:00
TextMetrics.h Patch by Vincent that solves a number of problems related to the painting of a selection: 2008-09-14 14:32:40 +00:00
Thesaurus.cpp
Thesaurus.h
TocBackend.cpp Simplify TocModel by using UserRole data. 2008-06-12 15:31:10 +00:00
TocBackend.h cosmetics; compile fix 2008-06-12 16:46:46 +00:00
Trans.cpp fix Bug 4119: LFUN accent-special-caron is obsolete 2008-05-07 11:17:43 +00:00
Trans.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
Undo.cpp Bug 5173: Undo Grouping 2008-08-15 19:24:56 +00:00
Undo.h Bug 5173: Undo Grouping 2008-08-15 19:24:56 +00:00
update_flags.h
Variables.cpp
Variables.h
VCBackend.cpp VCS: Better output for svn checkout. 2008-08-01 14:18:41 +00:00
VCBackend.h VCS: Towards statusbar info. 2008-07-29 13:14:51 +00:00
version.cpp
version.h
VSpace.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
VSpace.h
WordLangTuple.h
WordList.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
WordList.h * paragraph support for the global word list. To make it buffer 2008-02-26 13:07:59 +00:00