Commit Graph

33103 Commits

Author SHA1 Message Date
Jean-Marc
3705fd4eba Fix uninitialized members in Cursor and CursorData constructors
Fix coverity issues 23401, 23407, 23416 and 23429.
2015-03-04 23:00:07 +01:00
Jean-Marc
0fbc402141 Fix unitialized members in CacheItem
Fixes coverity issue 23380.
2015-03-04 22:50:37 +01:00
Jean-Marc
8d882e662b Add test for null buffer
This is actually not needed in practice.

Fixes coverity issue 23306.
2015-03-04 22:46:48 +01:00
Jean-Marc
a5a01b6af3 Fix uninitialized members in Compare::Impl
Fixes coverity issue 23418.
2015-03-04 22:35:40 +01:00
Jean-Marc
08c9f208fb Pass parameters by reference (performance)
Fixes coverity issues 23339 and 23347.

Some additional spacing changes sneaked in.
2015-03-04 22:26:28 +01:00
Jean-Marc
fbe333245e Fix unintialized member of BufferView::Private
Fixes coverity issue 23404.
2015-03-04 22:17:51 +01:00
Jean-Marc
fac7cb922a Fix missing break in switch
Fixes coverity issue 23350.
2015-03-04 22:13:20 +01:00
Jean-Marc Lasgouttes
9448e89879 Remove unused variable BufferParams::quotes_times
This was pointed out inadvertently by coverity issue 23484: the
variable was not properly initialized.
2015-03-04 18:21:58 +01:00
Jean-Marc Lasgouttes
0552563c99 Initialize Buffer::Impl members correctly
In practice the variables were initialized later as needed.

Fixes coverity issue 23497.
2015-03-04 17:57:29 +01:00
Jean-Marc Lasgouttes
1d2b7fb1ec Initialize object properly
Fixes coverity issue 23363
2015-03-04 17:48:44 +01:00
Enrico Forestieri
afeae62f3f Update cygwin script.
Recent versions of the cygwin X11 server come with a startup script
that explicitly uses '-nolisten tcp' for improved security. This means
that mentioning a host part in the DISPLAY variable precludes correct
operation. So, leave blank the host part such that only local connections
are attempted. Even if a user can override this setting in the own
~/.lyxprofile, novice users (and even experienced ones, at first) would be
probably confused by the "Error: Can't open display: localhost:0" message
and thus it is better to make this work out of the box.
2015-03-03 18:17:37 +01:00
Enrico Forestieri
b4b02da31f Add another bunch of missing svg icons.
I also tweaked some existing icons to make them look better at default size.
Moreover, some text was replaced with paths, because the required font may
not exist on a system and font substitution would take place, making the
icons look different on different systems.
2015-03-03 15:43:10 +01:00
Jean-Marc Lasgouttes
d33f4c91f2 Allow automake 1.15. 2015-03-03 10:59:11 +01:00
Georg Baum
c0041e7fa5 Fix stupid copy-paste error
Now the conversion to 2.1.x works again
2015-03-02 20:57:26 +01:00
Kornel Benko
8aa9c11901 update sk.po 2015-03-02 19:35:39 +01:00
Georg Baum
317b29dc6d Fix lyx2lyx conversion for file insets
Both the hyphen and special phrase conversion did not exclude insets which
reference external files. This was wrong since LyX does not replace
\SpecialCharNoPassThru etc for these insets.
2015-03-01 22:16:45 +01:00
Jean-Marc Lasgouttes
83073aec3a Record undo properly when changing multiple paragraphs parameters
Fixes bug 9437.
2015-03-01 16:25:19 +01:00
Jean-Marc Lasgouttes
536cd8ecd8 Fix cursor position before a virtual element
When there is a virtual element like an end-of-paragraph marker, the cursor should be on the left (in RTL text).

This problem was created by 46ee6799.
2015-03-01 15:59:00 +01:00
Georg Baum
3e9e6e344a Replace automatic logofication with insets
Previously, LyX did replace some words with typeset logos, and there was no
way to prvent this except putting them, in ERT (bug #4752). Now we have
special insets for these words, and standard text is left alone.
2015-03-01 11:16:57 +01:00
Georg Baum
d50154ab04 Fix wrong CommandInset lyx2lyx conversion
Thanks to Scott for testing. Command insets do not use InsetText for the
arguments, so users have to write them in LaTeX syntax (this is bug #4595).
Therefore we must leave hyphens alone in these insets.
2015-03-01 10:52:13 +01:00
Jean-Marc Lasgouttes
776a4f53c2 Revert some other dubious "improvements" in b627b870 2015-02-28 23:41:20 +01:00
Georg Baum
e76fc73040 Fix \nobreakdash- roundtrip in moving args
Previously, tex2lyx did not remove the \protect which is output by LyX in
front of \nobreakdash- if needed. Now tex2lyx removes it unconditionally (like
it does elsewhere), because LyX will add it if needed.
2015-02-27 22:06:11 +01:00
Uwe Stöhr
caf102558c documentation: port recent changes to master 2015-02-27 01:19:40 +01:00
Uwe Stöhr
d4b92d8a6d Installer: slovak.nsh: translation update by Kornel 2015-02-27 01:11:00 +01:00
Georg Baum
d49051d99f Fix hyphen conversion in passThru insets
The old hyphen replacement code did not convert hyphens if the condition
style.pass_thru || runparams.pass_thru
was met. style.pass_thru got set from inset owner (isPassThru()). Therefore
we have to consider this for the new replacement code as well.
2015-02-26 22:55:20 +01:00
Georg Baum
93be0e08a1 whitespace 2015-02-26 20:43:05 +01:00
Georg Baum
ddb82b74f0 Make convert_dashes and revert_dashes symmetric
Otherwise we could destroy math stuff.
2015-02-26 20:34:36 +01:00
Richard Heck
db954b5dc0 Add comment, so that does not happen again. 2015-02-24 20:07:32 -05:00
Richard Heck
94a5481a17 Partially revert b627b870, which broke cursor movement. 2015-02-24 20:04:59 -05:00
Georg Baum
8aa37c43a1 Fix plaintext output of dashes (bug #3647)
Previously, consecutive dashes in .lyx files were combined to endash and emdash
in some cases, and in other cases they were output as is. This made the code
complicated, and resulted in inconsitencies ((bug #3647).
Now, a dash in a .lyx file is always a dash in the output, for all flavours.
The special handling is moved to the input side, so that you still get an
endash if you type two hyphens. If needed, this can be changed or made
customizable without the need to update the file format again. Many thanks
for the fruitful mailing list dicsussion, which contributed significantly to
the final version.
2015-02-24 22:06:12 +01:00
Richard Heck
fc9e6326b9 Micro-optimization. 2015-02-24 13:43:33 -05:00
Jean-Marc Lasgouttes
b627b8701b Some performance stuff reported by cppcheck 2015-02-24 18:38:20 +01:00
Juergen Spitzmueller
3d01021c88 Check for ugm font availability
Fixes: #9429
2015-02-24 07:58:40 +01:00
Uwe Stöhr
9ced7384eb UserGuide.lyx: port recent changes from branch 2015-02-24 01:56:27 +01:00
Uwe Stöhr
4ca722b4ed French manuals: sync with branch 2015-02-24 01:14:40 +01:00
Enrico Forestieri
bbc63daa9e Update it.po 2015-02-23 01:53:14 +01:00
Enrico Forestieri
b12ba1dd12 Missing svg icons for the default set.
I am also replacing some existing icons with reworked ones that
look better at small sizes. I think that these icons are now
comparable to the png ones as regards quality at the default size.
2015-02-23 00:23:54 +01:00
Scott Kostyshak
58f428d57c Whitespace 2015-02-21 14:09:02 -05:00
Scott Kostyshak
29e96634df ctests: invert some of the PDF-comment tests
Only pdflatex is expected to work reliably.
lualatex also appears to compile.
2015-02-21 14:08:54 -05:00
Jean-Marc Lasgouttes
143c136a7f Do not read array before checking the bounds
Fixes coverity issue 23377
2015-02-20 16:51:20 +01:00
Jean-Marc Lasgouttes
2694fde47d Initialize variable properly.
This fixes coverity issue 23503.
2015-02-20 16:47:27 +01:00
Jean-Marc Lasgouttes
fd7aa2d62d Do not mix several names for the same variable
This confuses coverity, but is probably harmless.

Fxies coverity issue 23374
2015-02-20 16:37:06 +01:00
Jean-Marc Lasgouttes
d9c9c6b36d Remove C-isms in isValidLength
This fixes coverity issue 23349, with a potential out-of-bounds write to the pattern array.
2015-02-20 16:16:31 +01:00
Jean-Marc Lasgouttes
053d02d176 Don't try to show 1000 as a roman number
Fixes coverity issue 23360.
2015-02-20 15:59:19 +01:00
Jean-Marc Lasgouttes
edddb47bae whitespace 2015-02-20 15:57:45 +01:00
Jean-Marc Lasgouttes
01691cde49 Fix uninitialized variable
Fixes coverity issue 23446.
2015-02-20 15:53:19 +01:00
Jean-Marc Lasgouttes
4a439d6ac0 Do not create a new socket if the max. number of clients is attained
Fixes coverity issue 23431.
2015-02-20 15:46:34 +01:00
Jean-Marc Lasgouttes
3db4b23b3f Fix memory leak in TImer class.
This is not really important since the class is currently not used.

This is coverity issue 23291.
2015-02-20 15:39:45 +01:00
Jean-Marc Lasgouttes
eb4f963eef Main argument of a subfloat is not a moving argument
Fixes bug: #9421
2015-02-20 11:51:40 +01:00
Juergen Spitzmueller
fb6665becb Comment out FontEncoding for Hebrew
This needs a specific loading order, which is handled by Hebrew babel itself.
2015-02-19 10:37:05 +01:00