Juergen Spitzmueller
e31364fdcb
whitespace
2020-02-15 09:26:43 +01:00
Juergen Spitzmueller
195393f401
Fix Python detection on windows
...
Patch by Eugene Chornyi
2020-02-15 09:26:08 +01:00
Stephan Witt
6dab8739eb
Avoid uninitialized position variables in case of current inset not doing the assignment
2020-02-14 12:11:10 +01:00
Stephan Witt
aca95619b8
Avoid potential leak of memory pointed to by QStandardItem catItem
2020-02-13 16:39:14 +01:00
Richard Kimberly Heck
b175f5a315
Fix bug #11737 .
...
We need to use the FileName methods when moving or removing a file,
so that refresh() gets called.
(cherry picked from commit d930913898
)
2020-02-13 00:11:23 -05:00
Juergen Spitzmueller
40b1a6f9b1
Revert "Fix bug #11712."
...
This breaks on Linux
This reverts commit fdf81a9bab
.
2020-02-12 16:11:01 +01:00
Richard Kimberly Heck
fdf81a9bab
Fix bug #11712 .
...
Fixes some escaping issues on Windows especially
Patch from Eugene.
2020-02-12 09:25:13 -05:00
Stephan Witt
e900b61d46
Make cell index of tabular local for column loop.
2020-02-12 12:32:31 +01:00
Stephan Witt
3ee1bcad04
Remove another unnecessary assignment
2020-02-12 12:28:18 +01:00
Enrico Forestieri
926c846abb
Remove unnecessary assignments
2020-02-10 21:59:52 +01:00
Enrico Forestieri
536d476d38
Make sure to not dereference a null pointer.
2020-02-10 21:54:07 +01:00
Juergen Spitzmueller
b8546139c8
Properly resize columns of child document table widget
2020-02-07 17:23:14 +01:00
Juergen Spitzmueller
4fd4310ea7
Indentation fixes
2020-02-07 16:03:56 +01:00
Stephan Witt
59fa0b2592
Fix a crash with uninitialized buffer member of MathData
...
See the details here: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210294.html
2020-02-07 10:17:33 +01:00
Stephan Witt
a50e07db46
update canAutoOpenFile/autoOpenFile implementation to new MacOSX API, avoid deprecated calls
2020-02-06 21:52:46 +01:00
Richard Kimberly Heck
5188f0fcff
Don't need to remove the file if it doesn't exist. (This would cause a five second delay in that case.)
2020-02-03 11:37:12 -05:00
Scott Kostyshak
05f2494008
Remove a finishUndo() after a recordUndo()
...
finishUndo() is only helpful in the presence of undos of type INSERT
or DELETE.
See the following ML thread for details:
https://www.mail-archive.com/search?l=mid&q=b721c098-c7ee-d12f-1cdf-067dda9aa5cf%40lyx.org
2020-02-02 16:10:59 -05:00
Juergen Spitzmueller
dce9e44a14
Ignore geometry-related settings if the class provides geometry
...
Fixes #11724
2020-01-29 11:25:01 +01:00
Jean-Marc Lasgouttes
4d6041a7b6
Adopt a 'belt and braces' approach to bidi forcing
...
There are two techniques that I know of for forcing the direction of a
string, regardlessly of whether its contents is naturally LtR, RtL or
undecided.
1/ The unicode LTR/LTR override characters. This is supposed to be the
clean way, however, it does not seem to work with Qt 5.14 (see
#11691 ).
2/ The undocumented QTextLayout::setFlags method. This is used
internally and allows to pass the (undocumented) flags
Qt::TextForceRightToLeft and Qt::TextForceLeftToRight. This was
used until we had issues with Qt 5.11 (see #11284 ).
In order to get the best of both worlds, this patch allows to enable
those two methods separately, and actually enables both at the same
time by default!
(hopefully) Fixes bug #11691 .
2020-01-27 23:23:10 +01:00
Jean-Marc Lasgouttes
4f4d52e8c0
Fix warning with --disable-nls
2020-01-27 15:34:27 +01:00
Jean-Marc Lasgouttes
9017581ecf
Fix distcheck target
...
1/ The most annoying part was the error in po/. It turns out that reading
and understanding the po/Makevars file was the key. A simple change of
variable ensures that "make dist" does not try to rebuild lyx.pot.
2/ The way tests in src/ are defined meant that the
dependency-tracking files were not all deleted. This should be OK now.
2020-01-26 20:31:03 +01:00
Juergen Spitzmueller
62a2b69bb0
Remove terminating linebreak
2020-01-16 10:19:52 +01:00
Jean-Marc Lasgouttes
ba79a4b89e
Make graĥics and external insets tighter
...
Now RenderGraphics adds offsets that depends on its parent inset.
These offsets are set to 0 for InsetGraphics and InsetExternal. A nice
consequence is that icons shown by Info inset stick out less on screen.
As an unrelated change, the "private:" specifier of these two insets
is moved to a more reasonable place.
2020-01-15 16:00:02 +01:00
Jean-Marc Lasgouttes
7d3d07ff40
Fixup eeb4187a
: copy-paste errors
2020-01-15 15:19:38 +01:00
Jean-Marc Lasgouttes
eeb4187a28
Remove some spacing above InsetColapsible when possible
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
9176e60b7b
Make script inset much tighter in texted.
...
We use the fact that offsets can be set separately for each inset.
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
0ef2c192c0
Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values
...
The basic value is Inset::textOffset(BufferView*), which can in theory
change with the BufferView zoom and dpi. It is hardcoded to 4 for now.
Moreover, we introduce the virtual inset methods
(top|bottom|left|right)Offset, which can be tweaked for each inset.
No change intended (for now).
2020-01-15 11:13:54 +01:00
Juergen Spitzmueller
8bd47bda8c
Improve comments
2020-01-15 08:40:51 +01:00
Juergen Spitzmueller
a940e9d709
Cross out ct-deleted tabular rows/columns in workarea
2020-01-15 08:37:35 +01:00
Pavel Sanda
8c4d6bbba6
endl needs ostream header here.
2020-01-14 21:59:05 +01:00
Juergen Spitzmueller
218731c3eb
Whitespace
2020-01-14 16:23:09 +01:00
Juergen Spitzmueller
1e5f252667
Account for bidi (swapped columns) when calculation clines
...
Fixes #11717
2020-01-14 16:15:49 +01:00
Juergen Spitzmueller
66c5d055e7
Do not output deleted rows columns if show changes in output is false
2020-01-14 13:03:12 +01:00
Juergen Spitzmueller
78ac0b4266
Fix typo in tooltip
2020-01-14 13:02:40 +01:00
Jean-Marc Lasgouttes
a187cbeb64
Rename PainterMetrics::change_ to change
...
This is not a private variable.
2020-01-14 11:50:44 +01:00
Jean-Marc Lasgouttes
5bb9ded4d6
Streamline RowPainter a bit
2020-01-14 11:42:01 +01:00
Juergen Spitzmueller
b5856628f1
Set changed status for changed column/row cells in updateIndexes()
2020-01-14 10:39:42 +01:00
Juergen Spitzmueller
2a48fbbf7f
Some polishment.
2020-01-14 09:55:16 +01:00
Juergen Spitzmueller
33133733ae
Record change author and time for tracked columns/rows
...
This now uses a real change object
2020-01-14 09:28:36 +01:00
Juergen Spitzmueller
194298045c
Color lines of added/deleted rows/columns
2020-01-13 19:02:48 +01:00
Jean-Marc Lasgouttes
cbabff4686
Do make changebar shorter for last row
...
I do not know what the intent was, but it is ugly.
2020-01-13 17:42:31 +01:00
Jean-Marc Lasgouttes
93794d6fea
Implement isChanged for tabular inset.
2020-01-13 16:35:15 +01:00
Jean-Marc Lasgouttes
b0371714a0
Only show pencil change mark when inset is collapsed
2020-01-13 16:35:15 +01:00
Juergen Spitzmueller
5fc2662b13
Add pref to keep ct markup on copy/paste
...
Fixes #10278 , #10128
2020-01-13 15:20:48 +01:00
Jean-Marc Lasgouttes
1baa8cdc93
When iterator is in a table cell, set Changed indicator for the right inset.
2020-01-13 15:08:50 +01:00
Juergen Spitzmueller
c6ef96ea36
Prevent NULL pointer
2020-01-13 13:03:52 +01:00
Juergen Spitzmueller
adfd38e4ef
Fix backspace deletion of selected items with change tracking
...
Move cursor at beginning of selection after deletion. Else backspace
operation gets stuck in a loop (tries to remove the selection again
and again).
This also fixes backspace deletion of insets with confirmDeletion() == true.
Fixes #11630
2020-01-13 09:48:56 +01:00
Juergen Spitzmueller
ff85641cc0
Whitespace
2020-01-13 09:21:32 +01:00
Juergen Spitzmueller
a450797b2a
Rest in peace, dvipost!
2020-01-13 08:59:26 +01:00
Jean-Marc Lasgouttes
e340f46476
Fixup bf7f4d71
: Let changeRefsIfUnique handle undo
...
This allows for a much lower memory consumption than a plain
recordUnfoFullBuffer.
Related to bug 6494.
2020-01-12 22:18:36 +01:00