Juergen Spitzmueller
134cb3b265
Consider parbreakIsNewline in plaintext output
...
Fixes #11886
2020-06-11 10:20:27 +02:00
Juergen Spitzmueller
cbe75042c0
Do not track row/column deletion in paste_tabular
...
Fixes #11884 .
2020-06-07 19:18:00 +02:00
Jean-Marc Lasgouttes
2d48072e66
Get rid of Qt resources
...
It turns out that the resources were mostly not used anyway. Removing
them shrinks LyX binary by ~6MB.
Only autotools have been adapted. cmake will require the same
simplification.
2020-06-07 01:15:28 +02:00
Jean-Marc Lasgouttes
a71b96ac42
Fixup 74540c98
: handle selection for label background
...
74540c98
was a fixup of d207e85c
, which avoided using inset background
as inset label background.
d207e85c
introduced a background under inset labels to avoid fake bold
effect.
Hopefully, this last variation will be the right one !
2020-06-05 22:32:58 +02:00
Richard Kimberly Heck
9f5491baf9
Internal buffers are valid
2020-06-01 12:23:20 -04:00
Juergen Spitzmueller
92ba05c53b
Assign InsetBibtex to appropriate toc level
...
Fixes #11863
2020-05-15 10:14:22 +02:00
Richard Kimberly Heck
97bbcf2b9b
Remove include no longer needed
2020-05-13 14:54:16 -04:00
Richard Kimberly Heck
b0def618f8
Simplify.
2020-05-13 14:49:01 -04:00
Richard Kimberly Heck
5353cf90c0
Replace functors in ExternalTemplate.cpp.
2020-05-13 14:42:52 -04:00
Richard Kimberly Heck
c506f304bc
Fix a number of issues that were stopping compilation with MSVC 19.
...
Patch from Thibaut Cuvelier, modified slightly by me (mostly for style).
2020-05-04 19:45:58 -04:00
Richard Kimberly Heck
d6a7ec506e
s/requires_/required_/ for code consistency
2020-05-04 14:05:44 -04:00
Juergen Spitzmueller
210c4aa9a2
Use translated GUI name of counter in button label
2020-05-04 09:28:07 +02:00
Juergen Spitzmueller
5171b7ea6c
Keep sort order of counter actions
2020-05-04 09:22:35 +02:00
Juergen Spitzmueller
6e5f90f72f
Fix capitalization
...
We use sentence casing in combo boxes.
2020-05-03 09:13:41 +02:00
Richard Kimberly Heck
9e4709e4de
Avoid a copy
2020-05-03 02:52:56 -04:00
Richard Kimberly Heck
16e7f26cec
requires is a keyword in C++2a
2020-05-03 02:18:17 -04:00
Richard Kimberly Heck
c37500050d
More polishing of counter dialog. Thanks to Jürgen for help.
...
Also, remove the 'display value' option. We will move this to InsetInfo
at some point.
2020-05-02 20:33:03 -04:00
Juergen Spitzmueller
3d630f49c4
Fix broken mark with multiple citations
...
Patch by Patrick De Visschere (modified by me)
2020-05-02 08:55:58 +02:00
Richard Kimberly Heck
8a4bb40c7e
Fix typo.
2020-05-01 19:47:50 -04:00
Richard Kimberly Heck
bc4ca12ab5
Polish the counter UI a bit and add some to the documentation.
2020-05-01 19:03:54 -04:00
Richard Kimberly Heck
de40b09474
Fix thinkos for counter value type
2020-04-30 23:46:18 -04:00
Richard Kimberly Heck
684d27c0fb
New counter manipulation inset.
...
This inset allows counters to be set, reset, saved, restored, etc,
both in the LyX GUI and in the output; optionally, the effect can be
limited to the GUI. Of course, LaTeX provides means for doing all of
these things, so they could previously be done with ERT, as far as
the output is concerned. But there was no mechanism for manipulating
counters in the GUI and none for other output formats.
2020-04-30 23:09:36 -04:00
Richard Kimberly Heck
7d36b9e4fa
Remove method that is now unneeded.
2020-04-25 22:27:09 -04:00
Richard Kimberly Heck
e4da314522
Try to fix bug #6505 .
...
Keep track of nested includes and just refuse to re-enter a file
we're already in the process of handling.
There's a question whether we should do this in updateBuffer and
validate, or whether we should do it separately. For now, this seems
to work.
2020-04-25 22:22:58 -04:00
Richard Kimberly Heck
aa794a8806
Return early from the short path.
2020-04-25 17:33:49 -04:00
Richard Kimberly Heck
f1d5926a5d
Fix warnings.
2020-04-25 01:26:37 -04:00
Juergen Spitzmueller
9e71bdfd32
fix comment
2020-04-18 08:01:39 +02:00
Juergen Spitzmueller
d9b884341c
Reset failedtoload_ bool when include inset params are changed ( #11842 )
2020-04-17 10:19:46 +02:00
Juergen Spitzmueller
2748e33be5
Fix indentation
2020-04-06 16:29:34 +02:00
Juergen Spitzmueller
c0adb03a7a
Fix quotation marks in PDF TOC
2020-04-06 08:53:29 +02:00
Juergen Spitzmueller
1e34871d38
Prevent wrong reference to duplicated (but deleted) label
...
Fixes #11803
2020-03-29 17:47:59 +02:00
Pavel Sanda
426ca3a5d6
Let hyperlink insets to be longer if name is given.
...
Thanks to Oystein Senneset Haaland.
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210882.html
2020-03-25 07:40:27 +01:00
Juergen Spitzmueller
52cd43dfdc
Paste some special chars as insets
...
See #11790
2020-03-23 12:07:47 +01:00
Juergen Spitzmueller
1e409a1a75
Properly resolve tracked changes when pasting multiple tabular cells
...
Fixes #11791
2020-03-21 15:54:37 +01:00
Richard Kimberly Heck
7c7ea3113f
Use ranges and fix nullptr warnings.
2020-03-16 01:31:30 -04:00
Juergen Spitzmueller
b96ce9a9c1
Outliner: distinguish non-active refs from broken refs
...
See #11782
2020-03-14 16:29:53 +01:00
Juergen Spitzmueller
0f9ef6877c
Add active refs to non-active labels to brokenrefs toc
2020-03-14 15:35:47 +01:00
Juergen Spitzmueller
a1da60642c
Add outliner section for broken refs and citations
2020-03-14 15:18:28 +01:00
Juergen Spitzmueller
4ddc9e2501
Color broken citations, xrefs, and includes
...
Fixes #11503
2020-03-14 14:17:30 +01:00
Scott Kostyshak
36208d488e
Fix preview check box for include insets
...
GuiInclude::initialiseParams() calls InsetCommand::string2params()
which calls InsetCommandParams::clear(), however this last function
did not reset the special "preview_" parameter. Now this parameter
is reset to false as part of clear().
The ParamData class documents (see InsetCommandParams.h) the
following:
// No parameter may be named "preview", because that is a required
// flag for all commands.
Thus, we must handle preview_ separately from the other parameters.
This commit fixes #11779 .
2020-03-13 10:16:24 -04:00
Juergen Spitzmueller
3bd03709fd
Consider CT underlining pref in captions markup
2020-03-07 07:28:37 +01:00
Juergen Spitzmueller
5e21a8fbf7
Markup changed captions in workarea by underline and strikeout, resp.
2020-03-06 18:58:25 +01:00
Juergen Spitzmueller
f5a2d770b8
Footnote: (re-)add a fallback dummy counter
2020-03-06 18:21:18 +01:00
Juergen Spitzmueller
b8cac52759
Use real counter in deleted footnotes
2020-03-06 18:16:34 +01:00
Juergen Spitzmueller
339424ce00
Handle deleted BibTeX/Biblatex bibliographies
...
Since we cannot strike-out these, we output a placeholder when
show changes in output is active.
Fixes #11762
2020-03-06 13:49:10 +01:00
Juergen Spitzmueller
d94b708a0f
Tell updateBuffer whether an inset is deleted.
...
Fixes #11747
2020-03-06 13:23:01 +01:00
Richard Kimberly Heck
21b4ecca7f
Apparently, "requires" is a keyword in C++2a.
2020-02-28 00:28:18 -05:00
Richard Kimberly Heck
2e444dd657
Fix problem with validation when using InsetLayout.
2020-02-26 22:19:36 -05:00
Jean-Marc Lasgouttes
74540c9896
Fixup d207e85c
: paint sublabel with the correct background color
...
The above mentionned patch did paint the background of the sublabel to
avoid "bold-like" effect. However the correct backgound color is the
row's one, not the inset's one.
2020-02-24 10:41:18 +01:00
Stephan Witt
e900b61d46
Make cell index of tabular local for column loop.
2020-02-12 12:32:31 +01:00
Juergen Spitzmueller
62a2b69bb0
Remove terminating linebreak
2020-01-16 10:19:52 +01:00
Jean-Marc Lasgouttes
ba79a4b89e
Make graĥics and external insets tighter
...
Now RenderGraphics adds offsets that depends on its parent inset.
These offsets are set to 0 for InsetGraphics and InsetExternal. A nice
consequence is that icons shown by Info inset stick out less on screen.
As an unrelated change, the "private:" specifier of these two insets
is moved to a more reasonable place.
2020-01-15 16:00:02 +01:00
Jean-Marc Lasgouttes
7d3d07ff40
Fixup eeb4187a
: copy-paste errors
2020-01-15 15:19:38 +01:00
Jean-Marc Lasgouttes
eeb4187a28
Remove some spacing above InsetColapsible when possible
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
9176e60b7b
Make script inset much tighter in texted.
...
We use the fact that offsets can be set separately for each inset.
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
0ef2c192c0
Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values
...
The basic value is Inset::textOffset(BufferView*), which can in theory
change with the BufferView zoom and dpi. It is hardcoded to 4 for now.
Moreover, we introduce the virtual inset methods
(top|bottom|left|right)Offset, which can be tweaked for each inset.
No change intended (for now).
2020-01-15 11:13:54 +01:00
Juergen Spitzmueller
8bd47bda8c
Improve comments
2020-01-15 08:40:51 +01:00
Juergen Spitzmueller
a940e9d709
Cross out ct-deleted tabular rows/columns in workarea
2020-01-15 08:37:35 +01:00
Juergen Spitzmueller
218731c3eb
Whitespace
2020-01-14 16:23:09 +01:00
Juergen Spitzmueller
1e5f252667
Account for bidi (swapped columns) when calculation clines
...
Fixes #11717
2020-01-14 16:15:49 +01:00
Juergen Spitzmueller
66c5d055e7
Do not output deleted rows columns if show changes in output is false
2020-01-14 13:03:12 +01:00
Jean-Marc Lasgouttes
a187cbeb64
Rename PainterMetrics::change_ to change
...
This is not a private variable.
2020-01-14 11:50:44 +01:00
Juergen Spitzmueller
b5856628f1
Set changed status for changed column/row cells in updateIndexes()
2020-01-14 10:39:42 +01:00
Juergen Spitzmueller
2a48fbbf7f
Some polishment.
2020-01-14 09:55:16 +01:00
Juergen Spitzmueller
33133733ae
Record change author and time for tracked columns/rows
...
This now uses a real change object
2020-01-14 09:28:36 +01:00
Juergen Spitzmueller
194298045c
Color lines of added/deleted rows/columns
2020-01-13 19:02:48 +01:00
Jean-Marc Lasgouttes
93794d6fea
Implement isChanged for tabular inset.
2020-01-13 16:35:15 +01:00
Jean-Marc Lasgouttes
b0371714a0
Only show pencil change mark when inset is collapsed
2020-01-13 16:35:15 +01:00
Jean-Marc Lasgouttes
e340f46476
Fixup bf7f4d71
: Let changeRefsIfUnique handle undo
...
This allows for a much lower memory consumption than a plain
recordUnfoFullBuffer.
Related to bug 6494.
2020-01-12 22:18:36 +01:00
Jean-Marc Lasgouttes
4a4ded2297
Reimplement computation of change tracking status
...
This is a reimplementation of 6d4e6aad
that is both simpler and more
complete.
This uses the updateBuffer mechanism to implement a fully working
version of Inset::isChanged(). Now the function returns true for an
inset that contains an inset that contains a change, for example.
Moverover Buffer::areChangesPresent() is merely a proxy for
Buffer::inset().isChanged().
2020-01-12 20:26:35 +01:00
Jean-Marc Lasgouttes
ce950f1ea5
Fixup b321bb1a
: set changebar when inset contains changes
...
Add Paragraph::isChanged() and InetText::isCgchanged() which indicate
the presence of a change in the relevant object.
Sets Row::needsChangebar() when adding an inset that contains changes.
Related to bug #8645 .
2020-01-12 20:26:35 +01:00
Juergen Spitzmueller
bbc6ea4a5f
Implement change tracking of column/row addition/deletion
...
Fixes #8469
File format change
2020-01-11 16:17:04 +01:00
Juergen Spitzmueller
c77999a5f3
Add buffer param to opt-out fragile content movement
...
Fixes #11714
File format change
2020-01-10 10:21:09 +01:00
Juergen Spitzmueller
79674c7632
Track changes in InsetCommands
2019-12-31 15:46:03 +01:00
Juergen Spitzmueller
affc006bae
Honor change tracking when automatically renaming refs to labels
...
Fixes rest of #11556
2019-12-31 12:29:53 +01:00
Juergen Spitzmueller
a5db5d4c90
whitespace
2019-12-30 16:28:15 +01:00
Juergen Spitzmueller
8a17cc01e0
Implement (basic) ct for tabular-feature delete-row and delete-column
...
Fixes part of #8469
For a proper fix that works with change-reject as well as with hide
changes in output, we need to implement
ct information in tabular's row and column.
2019-12-29 14:09:52 +01:00
Juergen Spitzmueller
b37b39365f
Remove obsolete FIXMEs
2019-12-29 12:07:55 +01:00
Juergen Spitzmueller
e65fdc6a51
Track change of label name
...
Fixes #11556
2019-12-29 11:01:18 +01:00
Juergen Spitzmueller
b321bb1aed
Indicate change of content in label of collapsed collapsible
...
Fixes #8645
2019-12-29 09:46:18 +01:00
Juergen Spitzmueller
89b5607e0a
Centralize code to markup deleted complex objects (with tikz) in output
...
This fixes #9293
2019-12-28 13:43:17 +01:00
Juergen Spitzmueller
da5ad1736a
Handle change-accept and change-reject in multi-cell selection
...
Fixes #8426
2019-12-27 12:05:56 +01:00
Juergen Spitzmueller
7c63896c60
CT: Mark deleted floats in output
...
Fixes #11175
2019-12-27 09:50:11 +01:00
Jean-Marc Lasgouttes
aeed6fb8fa
Do not check again and again for non existing files
...
If the file of an InsetInclude does not exist, loadIfNeeded will try
again and again to look for it. This is very bad for files with many
include insets, especially on windows.
Fixes bug #11656 .
2019-12-26 16:45:40 +01:00
Juergen Spitzmueller
e5a9d09870
Mark deleted graphics in output
...
Fixes #11687
2019-12-26 07:15:37 +01:00
Scott Kostyshak
79787c2274
Correct typo in method name getDescendants()
...
When used as an adjective, both variants "descendent" and
"descendant" are acceptable, but when used as a noun only
"descendant" should be used.
For a reference, see here:
https://en.wiktionary.org/wiki/descendent#Noun
2019-12-15 23:36:17 -05:00
Scott Kostyshak
989a49f377
Remove execute permission from two source files
2019-12-15 23:32:29 -05:00
Scott Kostyshak
f1accdebf3
Refresh previews on branch toggle
...
We only referesh previews if the branch that is toggled exists in a
descendant. This code could be further optimized, as noted in the
comments.
For relevant discussion, see the following ML thread:
https://www.mail-archive.com/search?l=mid&q=20191209022030.d6gyy3abdectr3yz%40tallinn
2019-12-11 11:48:56 -05:00
Scott Kostyshak
c61472303e
Fix crash due to encoding issues with child doc
...
This crash occurred starting with 553bebc3
, and can be triggered
when preview is enabled both in preferences and in a child document
inset. For a minimal example, see the following ML thread:
https://www.mail-archive.com/search?l=mid&q=20191209002609.6fao3dljtf3ohl25%40tallinn
This fix restores behavior to before that commit for the case when
oldEnc is 0.
2019-12-10 09:17:49 -05:00
Jean-Marc Lasgouttes
5ac3b88007
Disable inset-dissolve in table cells
...
This is better than making sure that the inset has exactly one cell.
In the future, inset-dissolve could be extended to dissolve all the
cells contents in the enclosing text.
Note that this check does not appear in mathed, and using dissolve in
e.g. fraction inset may lead to data loss (only current cell contents
is preserved).
2019-12-06 09:54:43 +01:00
Pavel Sanda
88ff1686bc
typo
2019-11-21 17:13:47 +01:00
Pavel Sanda
ae16abf57a
Reduce number of strings (the same one in buffer).
2019-11-21 17:11:09 +01:00
Juergen Spitzmueller
1a1adbc821
Handle paragraph direction switch in captions (with polyglossia/bidi)
2019-11-19 13:45:35 +01:00
Juergen Spitzmueller
967158c054
Always use local font switches in table cells.
2019-11-17 11:07:18 +01:00
Juergen Spitzmueller
3c0e0f8a29
Polish warning
2019-10-26 09:10:40 +02:00
Juergen Spitzmueller
1c0572f1ab
Validate if graphics path is encodable
...
Fixes #11688
2019-10-26 08:33:51 +02:00
Jean-Marc Lasgouttes
912704511b
Make some constructors explicit
...
Spotted by cppcheck.
2019-09-17 23:15:09 +02:00
Jean-Marc Lasgouttes
3fffa6eb83
Fix cut-n-paste error
...
Spotted by cppcheck.
2019-09-16 00:47:47 +02:00
Jean-Marc Lasgouttes
3aba81cf6a
Many small code cleanups suggested by cppcheck
2019-09-16 00:45:20 +02:00
Jean-Marc Lasgouttes
7c1891e0b4
Remove unused private members.
...
Spotted by cppcheck.
2019-09-16 00:17:08 +02:00