anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-16 07:55:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
43,927 Commits 31 Branches 172 Tags 617 MiB
5c055034c2
Commit Graph

9593 Commits

Author SHA1 Message Date
Juergen Spitzmueller
958213ee52 Improve instant search 2021-02-15 14:12:07 +01:00
Juergen Spitzmueller
f4a91f6e9e Correct tooltip 2021-02-15 11:32:42 +01:00
Juergen Spitzmueller
f59b8cb657 GuiSearch: Add auto-wrap option 2021-02-15 11:30:03 +01:00
Juergen Spitzmueller
22542700a7 Attempt at "search as you type" 2021-02-15 10:53:23 +01:00
Stephan Witt
3841304f80 Use explicit initialization for plain pointer to buffer view. 2021-02-15 10:03:39 +01:00
Juergen Spitzmueller
d85c09ae14 GuiSearch: Replace icons on buttons by characters 2021-02-15 08:57:13 +01:00
Juergen Spitzmueller
7869437691 Forgot l7n flag 2021-02-15 08:42:15 +01:00
Pavel Sanda
b497baeea3 Guisearch Qt4 compatibility 2021-02-14 22:44:33 +01:00
Stephan Witt
d65e7a8c87 Additional check for clipboards find buffer support - otherwise Qt complains with unsupported clipboard mode 2021-02-14 22:18:07 +01:00
Stephan Witt
3d616bfc79 #11925 Remove the gap between button frame and button background (by Daniel Ramoeller) 2021-02-14 19:04:52 +01:00
Juergen Spitzmueller
c4c62f7185 Remove duplicate header 2021-02-14 19:03:31 +01:00
Stephan Witt
a476cc4839 #8055 add support for system-wide find buffer on Mac 
Command-E is standard for paste to find buffer on Mac. That's why the key binding is changed appropriately.
 2021-02-14 18:56:25 +01:00
Stephan Witt
0bd9a8be3d Proper initialization of private member bv_ of GuiSearchWidget 2021-02-14 18:48:42 +01:00
Juergen Spitzmueller
4db1a08450 Let replace combo enabled if replace buttons are disabled. 2021-02-14 18:23:54 +01:00
Juergen Spitzmueller
1cc615fa95 Remove empty layout 2021-02-14 18:20:27 +01:00
Juergen Spitzmueller
234c6b5c8b Remove resolved FIXME 2021-02-14 18:15:33 +01:00
Juergen Spitzmueller
28239bf996 Frame takes less space than GroupBox 2021-02-14 18:12:38 +01:00
Richard Kimberly Heck
7c9eaa248d nullptr 2021-02-14 12:05:45 -05:00
Richard Kimberly Heck
fe38f02cde Update release notes for bookmark shortcuts 2021-02-14 11:46:27 -05:00
Richard Kimberly Heck
98f3ef0924 Amend 2baa3a46a6. 2021-02-14 11:41:25 -05:00
Juergen Spitzmueller
2baa3a46a6 Transform simple search dialog to dock widget (#2625) 
Also solves #8054
 2021-02-14 17:18:00 +01:00
Richard Kimberly Heck
c6dfc70367 Show python info in About LyX 2021-02-13 11:53:14 -05:00
Juergen Spitzmueller
f8021672ad Address some deprecation warnings 2021-02-13 15:23:45 +01:00
Juergen Spitzmueller
9089839055 Resolve accelerator conflicts 2021-02-13 07:57:10 +01:00
Juergen Spitzmueller
fbef5e687a Use dialog-show in icon names 
(and search for them also with dialog-toggle counterpart lfuns)

Fixes #12137
 2021-02-12 12:18:51 +01:00
Juergen Spitzmueller
d1ea8a40af GuiSearch: catch global shortcuts to find forwards/backwards (#11170) 2021-02-12 10:50:47 +01:00
Juergen Spitzmueller
9721a5cc6b Set GUI name for local greyedouttext color (#12130) 2021-02-11 09:05:42 +01:00
Juergen Spitzmueller
456b2b0e8b Fix indentation 2021-02-11 08:08:37 +01:00
Juergen Spitzmueller
2175899f17 Re-initiate module filter after dialog re-opening (#12128) 2021-02-11 08:07:55 +01:00
Juergen Spitzmueller
ad1e7da1fb Assure filtered module items are not editable (#12127) 2021-02-11 07:57:09 +01:00
Juergen Spitzmueller
65f96abfec Make delimiter icons a bit smaller 2021-02-10 11:40:56 +01:00
Juergen Spitzmueller
c2822d684b Add LFUN_LYXFILES_OPEN 
This opens the new templates/examples dialog and creates a view if
necessary (#12106).
 2021-02-10 09:36:32 +01:00
Juergen Spitzmueller
7cccfe5515 BulletsModule: disable size widget with custom bullet (#12011) 2021-02-09 11:01:45 +01:00
Juergen Spitzmueller
11b7714fc1 Use SVG icons in itemize bullet selector 
This scales much better than the current png solution, is HiDPI- and
darkmode-ready
 2021-02-09 10:32:16 +01:00
Stephan Witt
80e20e86be #11682 amend change 4d4dc96b06 - check Qt version for all Qt::ApplicationState occurances 2021-02-08 09:04:18 +01:00
Stephan Witt
4d4dc96b06 #11682 open new window on Mac if there is none and LyX is activated via dock 2021-02-07 18:53:40 +01:00
Juergen Spitzmueller
233cfed333 GuiDelimiter: properly calculate widget width 2021-02-07 17:24:59 +01:00
Juergen Spitzmueller
0afae1f97d GuiDelimiter: fix tabstop access 
DialogButtonBox not yet included, though.
 2021-02-07 17:00:20 +01:00
Juergen Spitzmueller
fa56a5eb98 Adjust selection color of delimiter icons 2021-02-07 12:32:11 +01:00
Juergen Spitzmueller
5c1a6468ac GuiDelimiter: use highlight text color if icon is selected 2021-02-06 16:25:55 +01:00
Juergen Spitzmueller
7c33e2fc08 GuiDelimiter: store delimiter name in UserRole 2021-02-06 15:33:13 +01:00
Juergen Spitzmueller
1fe75ae72c GuiDelimiter: cleanup and fix crash 2021-02-06 15:09:54 +01:00
Juergen Spitzmueller
fcc832ebeb GuiDelimiter: use SVG icons rather than relying on font (#12085) 2021-02-06 14:05:46 +01:00
Pavel Sanda
ded8c873f4 Attempt on #12066. 
Some lfuns are handled directly in GuiApplication while handling
of menu hiding in fullscreen was done on the level of GuiView.

We'll see if this code movement breaks in different scenarios,
but quick grep suggested that the only other way to guiview
dispatch is through drag&drop when menu isn't involved.
 2021-02-03 22:06:14 +01:00
Jean-Marc Lasgouttes
9f899a17fa Force redraw of all bufferviews after zoom in/out 
Add a new ForceAll update flag that forces to update metrics and
redraw all buffer views.

The situation in multi windows setting is very fragile and will need
to be adressed properly in the 2.5 cycle.
 2021-02-03 15:42:11 +01:00
Richard Kimberly Heck
bd0044f9d5 Fix bug #11351. 
Patch from Daniel.
 2021-02-02 17:34:25 -05:00
Juergen Spitzmueller
1bc7e73c74 Fix highlighting of cursor context in View Source (#12099) 
This also considers dark mode,
 2021-01-31 17:54:54 +01:00
Jean-Marc Lasgouttes
b1efc5a48e Initialize properly IconInfo struct 
Spotted by coverity.
 2021-01-29 18:57:13 +01:00
Jean-Marc Lasgouttes
dca5646163 LengthValidator: initialize properly positive_ 
Spotted by coverity.
 2021-01-29 18:17:16 +01:00
Enrico Forestieri
070270fdc7 Avoid deprecation warnings 
In Qt 5.15 many deprecation warnings are issued, presumably for
helping the port to Qt 6. They are really a load but can be
shuten up by using -DQT_NO_DEPRECATED_WARNINGS, except for the ones
about MidButton, AdjustToMinimumContentsLength, and DefaultLocaleLongDate.

This change should not affect compilation with Qt 4, as all changes are
backward compatible (only Qt versions prior 4.5 could be affected).
 2021-01-29 13:12:29 +01:00
Richard Kimberly Heck
10c7954ffb Const 2021-01-25 14:35:37 -05:00
Jean-Marc Lasgouttes
6bf8a0ade8 Disable respectOSkbd checkbox 
This is not ready yet. See discussion in #6450.
 2021-01-25 18:35:41 +01:00
Juergen Spitzmueller
b90c3fdfa1 GuiTabular: only apply changed features (#10450) 2021-01-25 11:00:06 +01:00
Juergen Spitzmueller
e2a66df3b8 LFUN_FILE_OPEN: Strip quotes from argument (#12091) 2021-01-24 14:48:55 +01:00
Juergen Spitzmueller
06605a587f Account for spaces in paths to templates (#12082) 2021-01-20 17:05:10 +01:00
Juergen Spitzmueller
ee475b62fa Do not rely on hardcoded color when determining boxbgcolor 2021-01-20 14:15:48 +01:00
Juergen Spitzmueller
024980cf43 Do not rely on hardcoded color when determining notefontcolor 2021-01-20 13:58:24 +01:00
Juergen Spitzmueller
b1afdf1c19 Correct disabled graphics scale string (#9443) 2021-01-20 12:06:22 +01:00
Juergen Spitzmueller
3f1799b2c8 Add method to check whether LyX runs in dark mode 2021-01-19 09:21:36 +01:00
Juergen Spitzmueller
29f98ab245 Use isDarkMode() method 2021-01-19 08:37:05 +01:00
Juergen Spitzmueller
9a6f7ece97 Add option to revert graphics colors in dark mode (#12076) 
This amends [5d47a7ee57506/lyxgit]
 2021-01-18 10:46:16 +01:00
Juergen Spitzmueller
057753dc75 Allow semantic colors in branches and use semantic background color by default 
Addresses most crucial part of #12075

File format change
 2021-01-18 09:56:53 +01:00
Juergen Spitzmueller
a4e6f0dead Add some more hints to empty margin widgets (#11424) 2021-01-17 17:49:45 +01:00
Juergen Spitzmueller
5d47a7ee57 Try to automatically handle transparent pictures in darkmode (#12076) 
We'll see how this plays in practice.
 2021-01-17 11:03:21 +01:00
Juergen Spitzmueller
606a404632 Extend non-default margins tooltip (#11424) 2021-01-17 10:18:45 +01:00
Richard Kimberly Heck
fd74bddffc Keep dialog connected to cross-ref inset after Apply. 
This does not actually have any effect yet, due to the fact that
disconnectAfterApply returns true (and this is a GuiDialog).
 2021-01-15 11:12:25 -05:00
Richard Kimberly Heck
a9bb062fc3 Keep dialog connected to External inset after Apply 2021-01-15 11:12:25 -05:00
Richard Kimberly Heck
bd555eebe2 Keep dialog connected to BibTeX inset after Apply 2021-01-15 11:12:25 -05:00
Richard Kimberly Heck
997bf3ecb7 Revert unintended commit from before 2021-01-15 11:12:25 -05:00
Richard Kimberly Heck
9504ec84c5 Simplify and polish 2021-01-13 14:42:26 -05:00
Richard Kimberly Heck
d41ec3368d Fix bug #10635 2021-01-13 14:38:48 -05:00
Stephan Witt
2844a4ec06 drop unintented static declaration from local temporary variable (formerly a global static constant) 2021-01-10 22:03:19 +01:00
Richard Kimberly Heck
98bfbe9ddf Fix bug #6128. 2021-01-10 02:40:12 -05:00
Richard Kimberly Heck
12bb380941 Fix bug #5972: Count words in citations (approximately). 2021-01-10 01:43:34 -05:00
Richard Kimberly Heck
ed2d3e199f Fix bug #4241: Addition to Intro 2021-01-09 22:17:52 -05:00
Richard Kimberly Heck
9446aa3640 Fix bug #11030. 
Factor out the code that connects to a newly created dialog and then
use that also in GuiGraphics.

There must be many other dialogs that need this same treatment....
 2021-01-09 20:33:23 -05:00
Juergen Spitzmueller
73df32bec4 Disambiguate homographic inflections 
These are not homographic in other languages
(e.g. German "Öffnen" vs. "Geöffnet")
 2021-01-09 09:44:38 +01:00
Juergen Spitzmueller
e947cdab3e Properly disable Apply/OK in InsetParamsDialog (#11440) 2021-01-07 13:28:10 +01:00
Juergen Spitzmueller
7a992bb699 GuiParagraph: apply pending changes when setting "immediate apply" (#11592) 2021-01-07 13:06:15 +01:00
Jean-Marc Lasgouttes
99e636ae7b Display bookmarks in the workarea. 
The bookmarks are added as virtual elements in display Rows. Bookmarks
are shown with circled numbers. A new color "bookmarks" has been
added. Currently bookmark 0 (the return position) is not displayed
because it is very disturbing in practice.

To make this work, a new method BookmarksSection::bookmarksInPar
retuns the list of bookmarks in a paragraph along with their position.

Force redraw when using bookmark-save and bookmark-clear.

Fixes bug #2496.
 2021-01-06 20:20:03 +01:00
Jean-Marc Lasgouttes
b64b1aa85e Fix use of BookmarkSection::size() 
The value was 9 instead of 10, which forced its users to use unusual code.
 2021-01-06 19:33:20 +01:00
Richard Kimberly Heck
40603a7552 Fix bug #3964. 
As suggested there, we attach ourselves to the newly created inset,
if we in fact just created an inset. (This will only matter if Apply
was clicked, so the dialog is still open, but I did the calcuation
anyway, as it seems cheap enough.)  This allows the user to modify
that inset (e.g., change the format) and also prevents another click
on Apply, or OK, from creating another dialog.

I've also removed the override of disconnectOnApply(). It does not
work, anyway, I think because it only works with GuiDialog, not with
DialogView-based dialogs.
 2021-01-06 03:50:47 -05:00
Richard Kimberly Heck
cf07d4825f Fix bug #11104. Activate refstyle support for InsetMathRef. 
At the moment, there is no support for plurals and capitalization.
A long comment explains why. Support could be added for that without
a format change.
 2021-01-05 18:17:53 -05:00
Richard Kimberly Heck
14c2f5d954 Fix comment 2021-01-05 17:45:50 -05:00
Richard Kimberly Heck
bbffbf92ac Remove elipses from "Open" buttons in About LyX dialog. Fixes #12019. 2021-01-04 14:53:41 -05:00
Yuriy Skalko
a0b65e9bf8 Define keyboard codes for Cyrillic letters, enable shortcuts using them 2021-01-04 12:00:50 +02:00
Richard Kimberly Heck
d4757eace0 Fix bug #11568. 
We can't rely on allow_async to tell us whether to put_in_tmpdir.
 2021-01-03 22:56:05 -05:00
Richard Kimberly Heck
4cee3478f7 nullptr 2021-01-03 22:36:04 -05:00
Richard Kimberly Heck
e31eadfd37 We don't need to reload a dirty file. Fixes #11788. 2021-01-03 19:58:19 -05:00
Yuriy Skalko
d3ca28b468 Amend 3971b1b35e, also fix warnings for older compilers 2020-12-29 16:30:16 +02:00
Yuriy Skalko
3971b1b35e Fix C++20 warning on implicit capture of this via [=] 2020-12-28 23:26:14 +02:00
Juergen Spitzmueller
2af8e661a3 Re-enable input of non-LyX files (e.g., tex, pgf) (#12056) 
This amends [a385b7dc2b58/lyxgit]
 2020-12-28 09:58:30 +01:00
Juergen Spitzmueller
f661469734 Implement sane UI for switching tristate toolbars (#6364) 
Also fix toolbar toggling with AllowAuto which was broken since
a long time.
 2020-12-17 10:15:18 +01:00
Juergen Spitzmueller
7e11cb2b37 Whitespace 2020-12-17 10:10:56 +01:00
Jean-Marc Lasgouttes
209a3ce618 Dialog.h and DialogFactory.h are not moc-able 2020-12-15 11:53:06 +01:00
Juergen Spitzmueller
9bf3a5a778 Add some documentation 2020-12-15 09:52:52 +01:00
Juergen Spitzmueller
1a0b842e66 Do not close spellchecker after "Replace All" (#11310) 
Wrong use of wrapAround here
 2020-12-15 09:46:32 +01:00
Juergen Spitzmueller
34c166f45f One more nullptr 2020-12-15 08:53:41 +01:00
Juergen Spitzmueller
47de618de8 Fix nullptr warning 2020-12-15 08:36:17 +01:00
Juergen Spitzmueller
2d553ec5b9 Amend 24b71d30d5 (#12048) 2020-12-14 14:19:08 +01:00
Yuriy Skalko
bda4570400 Use new signal library nod instead of boost::signals2 
Thanks Enrico for updating autotools files.
 2020-12-13 23:11:19 +02:00
Juergen Spitzmueller
148748b0c2 Make InsetInfo math/IPA icons visible in dark mode 
This does not show the real colors, but the icons are at least readable.
 2020-12-13 09:51:32 +01:00
Juergen Spitzmueller
33fb7ed258 Ditch deprecation warning 2020-12-12 14:16:34 +01:00
Juergen Spitzmueller
882f06121b Use semantic latex and math colors for dark theme icon overlay 2020-12-12 10:56:51 +01:00
Juergen Spitzmueller
704331fdcd Add dark theme colors to semantic colors (#8325) 2020-12-12 10:56:05 +01:00
Stephan Witt
7b41faabae amend 99b1488f0e - on Mac the include is needed 2020-12-11 18:42:04 +01:00
Juergen Spitzmueller
a06cdfa073 Adapt math and IPA panels to dark theme (#5636) 2020-12-11 09:08:41 +01:00
Juergen Spitzmueller
b2ab394832 Remove unused function 2020-12-11 09:08:10 +01:00
Juergen Spitzmueller
f9b817676a Search ipa image dir befor top dir 
Else the unknown icon is found before the proper icon.

This unbreaks IPA panel top icons
 2020-12-10 07:08:04 +01:00
Jean-Marc Lasgouttes
1dcb08104c Make spellchecker work in read-only document 
Mistakes are visible but word replacement is disabled. Disable relevant
widgets depending on the situation.

Move updateView code to SpellcheckerWidget::Private.
 2020-12-07 18:33:45 +01:00
Yuriy Skalko
ccbfd22f56 Move implementation details to constructors. Amend 78f457796c 2020-12-06 20:51:11 +02:00
Yuriy Skalko
e292dd70bf More enums & includes refactoring 2020-12-06 18:26:41 +02:00
Juergen Spitzmueller
b57b4a3e12 Clarify documentation if "Keep change markup on paste" pref 2020-12-06 17:04:17 +01:00
Yuriy Skalko
78f457796c Implement proper Dialog factory instead of implicit link-time dependencies 2020-12-06 17:37:39 +02:00
Richard Kimberly Heck
41216228c0 Change name in source files 2020-12-05 17:17:02 -05:00
Jean-Marc Lasgouttes
4f8cfca117 Update handling of read-only for Thesaurus 
Remove dummy calls to ButtonController::addReadOnly().

Properly disable stuff for read-only documents.

Streamline code.
 2020-12-05 20:27:46 +01:00
Jean-Marc Lasgouttes
f02311241a Make Merge Changes dialog work in read only. 
Make LFUN_CHANGES_MERGE active in read-only documents.

Remove dummy call to ButtonController::addReadonly and replace with
proper code.
 2020-12-05 19:53:30 +01:00
Jean-Marc Lasgouttes
c30b0aac4b Disable some Adv F&R widgets for read-only documents 2020-12-03 18:04:23 +01:00
Jean-Marc Lasgouttes
24b71d30d5 Fix disabling of widgets for (simple) Search dialog 
This allows to remove the calls to ButtonController::addReadonly,
which are placebo since 78ade7e6.
 2020-12-03 15:44:55 +01:00
Yuriy Skalko
e0f553b941 Fix warnings and use range-based loop 2020-12-03 00:38:05 +02:00
Juergen Spitzmueller
560d2df70c Capitalization fixes 2020-12-02 14:52:51 +01:00
Jean-Marc Lasgouttes
26135330bc Simplify GuiWorkarea::Private constructor 
Also use the newly introduced platformName() for Qt4.
 2020-12-01 11:26:01 +01:00
Yuriy Skalko
c0a5987181 Better naming for enums 2020-12-01 00:46:21 +02:00
Yuriy Skalko
890ca6df7b Refactor KernelDocType enum 2020-12-01 00:46:16 +02:00
Yuriy Skalko
6354ad60b4 Refactor InsetQuotes.h enums 2020-12-01 00:46:09 +02:00
Yuriy Skalko
ec5c7b905b Move Inset.h include from .h to .cpp 2020-11-30 13:05:08 +02:00
Yuriy Skalko
ecf62a8f21 Refactor OutputParams 
Now all Inset hierarchy uses OutputParams.h included in Inset.h.
Forward declare some enums to reduce header dependencies.
 2020-11-30 13:05:03 +02:00
Yuriy Skalko
99b1488f0e Cleanup included headers 2020-11-30 13:04:54 +02:00
Kornel Benko
a171c651a6 Revert "Amend 3093789e for cmake build" 
This reverts commit b3d43404f4.
 2020-11-30 10:19:22 +01:00
Yuriy Skalko
89d05890bf Simplify KeyModifier 2020-11-30 10:44:28 +02:00
Yuriy Skalko
7779316e6c Include standard <regex> 2020-11-29 15:27:28 +02:00
Kornel Benko
b3d43404f4 Amend 3093789e for cmake build 2020-11-29 10:04:54 +01:00
Yuriy Skalko
9b0cd3c970 Fix buffer over-read on last Unicode code points 2020-11-29 00:25:24 +02:00
Yuriy Skalko
813eb0f9f7 Cleanup included headers 2020-11-29 00:25:14 +02:00
Jean-Marc Lasgouttes
3093789e8d remove most traces of boost::regex 
1/ remove boost regex code from 3rdparty/boost. Only the cmake stuff remains.

2/ remove traces of BOOST_LIB since there is no need anymore to
   compile boost stuff.

3/ remove traces of boost regexp in config/lyxinclude.m4 and INSTALL

4/ require gcc 4.9 as minimal version in autoconf.

Unfortunately, the net gain is only 10% of included boost size (now 21M).
 2020-11-28 19:59:17 +01:00
Yuriy Skalko
f3ec89cfa1 Always use std::regex 
Since now minimum supported GCC is 4.9.
 2020-11-27 12:39:59 +02:00
Yuriy Skalko
6a21ec854b Move several common types to support/types.h 2020-11-27 12:16:22 +02:00
Jean-Marc Lasgouttes
4b15d64f51 Remove deprecated enum value with Qt5 2020-11-27 10:23:49 +01:00
Jean-Marc Lasgouttes
c68be9a9be Improve some debug messages 
The current code did not give much information.

I am not sure why the <<FontInfo operator is not defined in
FontInfo.h, but I figured that it was not necessary to understand that
now.
 2020-11-26 11:09:17 +01:00
Yuriy Skalko
0a8d3c9887 Fix loop variable, amend d8e8a93a58 2020-11-25 23:16:51 +02:00
Yuriy Skalko
b3be47765b Fix memory leak 2020-11-25 02:43:26 +02:00
Yuriy Skalko
43b16548b4 Cleanup headers 2020-11-25 02:43:16 +02:00
Jean-Marc Lasgouttes
8673c5ac28 Forgot this. 2020-11-24 21:20:25 +01:00
Jean-Marc Lasgouttes
1b3ffa6627 Rewrite (again!) the code for caret drawing 
The caret geometry is now computed in BufferView as a list of shapes
(caret, horizontal l-shape if needed, completion triangle if needed)
kept in a variable of type CaretGeometry.

The code in WorkArea.cpp only has to draw these shapes. The
CaretWidget (which never was a widget) in GuiWorkArea.cpp is gone
now.

As a consequence, the bounding box for the cursor is known precisely
and therefore rows should be repainted correctly now. This avoids
caret droppings.

Fixes bug #12024.
 2020-11-24 20:12:42 +01:00
Jean-Marc Lasgouttes
ba8ca0e384 Correct caret position from the start 2020-11-21 19:39:48 +01:00
Yuriy Skalko
cbad214cdd Refactor checksum calculation 2020-11-21 20:32:43 +02:00
Yuriy Skalko
0b1e0b8610 Remove unused headers 2020-11-21 20:32:30 +02:00
Yuriy Skalko
7ca2f2b58d Use range-based loops 2020-11-21 20:32:16 +02:00
Pavel Sanda
4eb791ff18 Erase white frame in fullscreen mode. 
Since Qt 5.9.4 one can't set negative margins unless explicitely
allowed by a new flag. This brought back the white frame in
fullscreen mode.

https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg214002.html
 2020-11-21 16:02:54 +01:00
Yuriy Skalko
2941bc0198 Add more override specifiers 2020-11-21 00:32:40 +02:00
Kornel Benko
5474c3fb4b Missing '{' 2020-11-20 16:32:51 +01:00
Jean-Marc Lasgouttes
d8e8a93a58 Use range-based loops in GuiView 2020-11-20 15:14:21 +01:00
Sam Crawley
f457a32a13 Fix issue in running compare from the command line 
Because Compare uses threads, we need to make sure it is finished when a
compare is executed from the command line. This was a problem for command
sequences, because the next command would start running before the compare
was done, and the buffer with differences was available.

So this commit adds the "run-blocking" parameter when using
LFUN_DIALOG_SHOW to run a Compare. When calling Compare with run-sync, the
LFUN will wait for the compare worker thread to finish before returning and
possibly running the next command.
 2020-11-15 10:35:28 +01:00
Jean-Marc Lasgouttes
222a317dd2 Store correctly the window position with Wayland 
To do this, hard-coded test for xcb had to be replaced with a call to
platformName(). Since this method does not exist in Qt4, we emulate
it.

Note that Qt5 uses xcb bindings for X11 system, while Qt4 relies on
older X11 bindings. We return platorm == "qt4x11" in this case.

Fixes bug #11746.
 2020-11-14 17:55:59 +01:00
Richard Kimberly Heck
cfd19d86be whitespace and style 2020-11-02 11:45:09 -05:00
Yuriy Skalko
d38eddb397 Match header/source function argument naming 2020-11-01 22:23:44 +02:00
Yuriy Skalko
5061db891c Use const references 2020-11-01 22:23:26 +02:00
Yuriy Skalko
dbe35af542 Simplify with std::map::insert 2020-11-01 22:22:27 +02:00
Richard Kimberly Heck
ca3077b40b Change the logic of the indentation setting. 
The option here is to NOT indent the paragraph, so make that clear.
As it was, we would set "Indent" to false in the case of paragraphs
that do not permit indentation and then write that, uselessly, to the
LyX file if we wrote any other option (and then keep writing it, even
if other options were removed). Now, we will write it only if it's been
explicitly set.
 2020-10-30 13:34:36 -04:00
Richard Kimberly Heck
cc1d3b78c9 Const 2020-10-29 18:25:33 -04:00
Yuriy Skalko
f1926251c0 Move Windows-specific stuff into os_win32.h 2020-10-25 19:59:03 +02:00
Yuriy Skalko
10272e4747 Move include of own header to the top. Fix dependencies 2020-10-25 19:58:57 +02:00
Yuriy Skalko
4ece87c324 Fix obsoleted Qt values 
All new values exist in Qt 4.8.7.
 2020-10-25 09:28:46 +02:00
Yuriy Skalko
a7018252b7 Constify 2020-10-25 09:28:34 +02:00
Jean-Marc Lasgouttes
21422dd652 Replace QFontMetrics::width() by horizontalAdvance() in Qt>=5.11 
The method horizontalAdvance() replaces width() starting with Qt 5.11.
To handle this, all direct calls to QFontMetrics::width() are replaced
by calls to GuiFontMetrics::width(), and the code for
GuiFontMetrics::width(QChar) uses horizontalAdvance on newer Qt
versions.
 2020-10-24 19:52:18 +02:00
Pavel Sanda
8af747c9d9 Revert da8b5de97 because of MSVC 2017. 
In GCC `min` is defined via including <vector>.
 2020-10-24 12:06:54 +02:00
Yuriy Skalko
c928714b0b Unify naming of menu items 2020-10-23 10:23:01 +03:00
Yuriy Skalko
af29f02dd8 Reduce includes in header files (2) 2020-10-19 18:01:17 +03:00
Yuriy Skalko
d25c10ed81 Remove duplicate and unused header includes in .cpp files 2020-10-19 18:01:11 +03:00
Yuriy Skalko
65c88f0a0a Remove redundant const & for primitive types 2020-10-19 12:50:07 +03:00
Yuriy Skalko
ce0e192689 Move Cursor.h from TocWidget.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
fbefdb10a5 Move Cursor.h from Clipboard.h 2020-10-16 08:02:51 +03:00
Pavel Sanda
2b02b73f4a Move <QTimer> from TocWidget.h 2020-10-14 14:48:41 +02:00
Pavel Sanda
bd33601512 Move <QTimer> from GuiViewSource.h 2020-10-14 14:37:38 +02:00
Pavel Sanda
85eec10e4b Move <QKeyEvent> from DockView.h 2020-10-14 14:35:29 +02:00
Pavel Sanda
61824e057e Move GuiView.h from DockView.h 2020-10-14 14:28:47 +02:00
Pavel Sanda
57703d51c6 <QCloseEvent> DialogView.h -> DialogView.cpp 2020-10-14 13:57:30 +02:00
Pavel Sanda
f1b147cc97 include "GuiView.h": DialogView.h -> DialogView.cpp 2020-10-14 13:53:40 +02:00
Pavel Sanda
da8b5de973 Move <algorithm> from DocIterator.h 2020-10-14 13:01:30 +02:00
Jean-Marc Lasgouttes
310c94c48c Fix display of caret completion indicator 
The zooming algorithm based on caret width was deeply flawed. It is
not replaced with a formula based on caret height.

Fixes bug #12000.
 2020-10-13 17:09:33 +02:00
Yuriy Skalko
2a594d3e90 Remove unused forward declarations 2020-10-13 09:57:36 +03:00
Thibaut Cuvelier
92b9c82dea Fix compilation on Visual C++. 
Without this patch, there would be errors like these (warnings turned into errors):

D:\LyX\lyx-unstable\src\frontends\qt\GuiView.cpp(2413): error C4101: 'e': unreferenced local variable
D:\LyX\lyx-unstable\src\frontends\qt\GuiView.cpp(4879): error C4101: 'ex': unreferenced local variable
 2020-10-12 19:21:58 +02:00
Yuriy Skalko
238fd9ac50 Right exception rethrowing 2020-10-12 15:14:55 +02:00
Yuriy Skalko
919a06718a Constify 2020-10-12 15:06:16 +02:00
Richard Kimberly Heck
2dc4277452 Const 2020-10-10 17:12:50 -04:00
Yuriy Skalko
7d38a4d126 Loop refactoring 2020-10-09 09:04:20 +03:00
Pavel Sanda
ffbcac3dde Add few examples for lineno options. 
It's actually pretty hard to get that from the manual.
 2020-10-06 15:05:11 +02:00
Jean-Marc Lasgouttes
c46f3b8f31 remove unused variable 2020-10-05 15:11:51 +02:00
Yuriy Skalko
c5ae08f0b8 Amend efc0877f 
Add the last `override`s.
 2020-10-05 15:03:13 +02:00
Yuriy Skalko
fe85162a29 Refactoring 2020-10-05 14:55:00 +02:00
Yuriy Skalko
d82adc625b Amend efc0877f 
Add more `override` specifiers. Replace `throw()` to `noexcept`.
 2020-10-05 09:37:15 +02:00
Yuriy Skalko
14b0da28c2 Amend efc0877f 2020-10-03 21:17:17 +02:00
Yuriy Skalko
715b8cda54 Refactoring based on cppcheck suggestions 2020-10-03 13:39:51 +02:00
Yuriy Skalko
efc0877f8f Add override specifiers to improve code maintainability 2020-10-03 12:43:48 +02:00
Jean-Marc Lasgouttes
7f1b1729b4 Cleanup the caret geometry code 
Intended changes:

* code is shorter and cleaner

* caret scales better with zoom when cursor_width=0: completion
  indicator, l-shaped cursor...

Details:

* Rename BufferView::getPosAndHeight to getPosAndDim because ascent is
  needed too and width could in the future be set depending on font.

* Get rid of rect_ in CaretWidget and record a Dimension (and y value) instead.
  Remove also caret_width_ and slant_, replace rtl_ with dir.

* Make CaretWidget members public and lose the trailing _.

* change CaretWidget::update to read its parameters from current bufferview.
 2020-10-01 13:17:01 +02:00
Pavel Sanda
ad475adfd3 amend 6d6fc761be 2020-09-28 16:44:12 +02:00
Pavel Sanda
6d6fc761be Qt4 compilable again 2020-09-28 16:34:42 +02:00
Yuriy Skalko
e47092044b Use real italic slope for slanted caret 2020-09-28 14:30:05 +02:00
Jean-Marc Lasgouttes
967f4d661e Remove default parameter of UndoGroupHelper constructor 
This can lead to mistakes. If no buffer is required at the beginning,
it is better to pass 'nullptr' explicitly.

Fix a case of missing parameter in GuiCompleter (introduced at
f3656600). This avoids some spurious "There is no group open (creating
one)" messages.
 2020-09-23 17:33:17 +02:00
Daniel Ramoeller
9a1f732664 Show slanted caret (cursor) when text style emphasis/italics/slanted. 
Fixes for bug #11428. Emphasis is used regularly and it is helpful to
see whether the next text will be written emphasized directly from the
cursor.

This is also implemented in MS Word and Google docs but not in
LibreWriter.

Also fixes the caret for RTL languages whose width was previously
extended into the wrong direction.
 2020-09-18 13:27:06 +02:00