Juergen Spitzmueller
195393f401
Fix Python detection on windows
...
Patch by Eugene Chornyi
2020-02-15 09:26:08 +01:00
Stephan Witt
6dab8739eb
Avoid uninitialized position variables in case of current inset not doing the assignment
2020-02-14 12:11:10 +01:00
Stephan Witt
aca95619b8
Avoid potential leak of memory pointed to by QStandardItem catItem
2020-02-13 16:39:14 +01:00
Richard Kimberly Heck
b175f5a315
Fix bug #11737 .
...
We need to use the FileName methods when moving or removing a file,
so that refresh() gets called.
(cherry picked from commit d930913898
)
2020-02-13 00:11:23 -05:00
Juergen Spitzmueller
40b1a6f9b1
Revert "Fix bug #11712."
...
This breaks on Linux
This reverts commit fdf81a9bab
.
2020-02-12 16:11:01 +01:00
Richard Kimberly Heck
fdf81a9bab
Fix bug #11712 .
...
Fixes some escaping issues on Windows especially
Patch from Eugene.
2020-02-12 09:25:13 -05:00
Stephan Witt
e900b61d46
Make cell index of tabular local for column loop.
2020-02-12 12:32:31 +01:00
Stephan Witt
3ee1bcad04
Remove another unnecessary assignment
2020-02-12 12:28:18 +01:00
Enrico Forestieri
926c846abb
Remove unnecessary assignments
2020-02-10 21:59:52 +01:00
Enrico Forestieri
536d476d38
Make sure to not dereference a null pointer.
2020-02-10 21:54:07 +01:00
Juergen Spitzmueller
b8546139c8
Properly resize columns of child document table widget
2020-02-07 17:23:14 +01:00
Juergen Spitzmueller
4fd4310ea7
Indentation fixes
2020-02-07 16:03:56 +01:00
Stephan Witt
59fa0b2592
Fix a crash with uninitialized buffer member of MathData
...
See the details here: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210294.html
2020-02-07 10:17:33 +01:00
Stephan Witt
a50e07db46
update canAutoOpenFile/autoOpenFile implementation to new MacOSX API, avoid deprecated calls
2020-02-06 21:52:46 +01:00
Richard Kimberly Heck
5188f0fcff
Don't need to remove the file if it doesn't exist. (This would cause a five second delay in that case.)
2020-02-03 11:37:12 -05:00
Scott Kostyshak
05f2494008
Remove a finishUndo() after a recordUndo()
...
finishUndo() is only helpful in the presence of undos of type INSERT
or DELETE.
See the following ML thread for details:
https://www.mail-archive.com/search?l=mid&q=b721c098-c7ee-d12f-1cdf-067dda9aa5cf%40lyx.org
2020-02-02 16:10:59 -05:00
Juergen Spitzmueller
dce9e44a14
Ignore geometry-related settings if the class provides geometry
...
Fixes #11724
2020-01-29 11:25:01 +01:00
Jean-Marc Lasgouttes
4d6041a7b6
Adopt a 'belt and braces' approach to bidi forcing
...
There are two techniques that I know of for forcing the direction of a
string, regardlessly of whether its contents is naturally LtR, RtL or
undecided.
1/ The unicode LTR/LTR override characters. This is supposed to be the
clean way, however, it does not seem to work with Qt 5.14 (see
#11691 ).
2/ The undocumented QTextLayout::setFlags method. This is used
internally and allows to pass the (undocumented) flags
Qt::TextForceRightToLeft and Qt::TextForceLeftToRight. This was
used until we had issues with Qt 5.11 (see #11284 ).
In order to get the best of both worlds, this patch allows to enable
those two methods separately, and actually enables both at the same
time by default!
(hopefully) Fixes bug #11691 .
2020-01-27 23:23:10 +01:00
Jean-Marc Lasgouttes
4f4d52e8c0
Fix warning with --disable-nls
2020-01-27 15:34:27 +01:00
Jean-Marc Lasgouttes
9017581ecf
Fix distcheck target
...
1/ The most annoying part was the error in po/. It turns out that reading
and understanding the po/Makevars file was the key. A simple change of
variable ensures that "make dist" does not try to rebuild lyx.pot.
2/ The way tests in src/ are defined meant that the
dependency-tracking files were not all deleted. This should be OK now.
2020-01-26 20:31:03 +01:00
Juergen Spitzmueller
62a2b69bb0
Remove terminating linebreak
2020-01-16 10:19:52 +01:00
Jean-Marc Lasgouttes
ba79a4b89e
Make graĥics and external insets tighter
...
Now RenderGraphics adds offsets that depends on its parent inset.
These offsets are set to 0 for InsetGraphics and InsetExternal. A nice
consequence is that icons shown by Info inset stick out less on screen.
As an unrelated change, the "private:" specifier of these two insets
is moved to a more reasonable place.
2020-01-15 16:00:02 +01:00
Jean-Marc Lasgouttes
7d3d07ff40
Fixup eeb4187a
: copy-paste errors
2020-01-15 15:19:38 +01:00
Jean-Marc Lasgouttes
eeb4187a28
Remove some spacing above InsetColapsible when possible
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
9176e60b7b
Make script inset much tighter in texted.
...
We use the fact that offsets can be set separately for each inset.
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
0ef2c192c0
Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values
...
The basic value is Inset::textOffset(BufferView*), which can in theory
change with the BufferView zoom and dpi. It is hardcoded to 4 for now.
Moreover, we introduce the virtual inset methods
(top|bottom|left|right)Offset, which can be tweaked for each inset.
No change intended (for now).
2020-01-15 11:13:54 +01:00
Juergen Spitzmueller
8bd47bda8c
Improve comments
2020-01-15 08:40:51 +01:00
Juergen Spitzmueller
a940e9d709
Cross out ct-deleted tabular rows/columns in workarea
2020-01-15 08:37:35 +01:00
Pavel Sanda
8c4d6bbba6
endl needs ostream header here.
2020-01-14 21:59:05 +01:00
Juergen Spitzmueller
218731c3eb
Whitespace
2020-01-14 16:23:09 +01:00
Juergen Spitzmueller
1e5f252667
Account for bidi (swapped columns) when calculation clines
...
Fixes #11717
2020-01-14 16:15:49 +01:00
Juergen Spitzmueller
66c5d055e7
Do not output deleted rows columns if show changes in output is false
2020-01-14 13:03:12 +01:00
Juergen Spitzmueller
78ac0b4266
Fix typo in tooltip
2020-01-14 13:02:40 +01:00
Jean-Marc Lasgouttes
a187cbeb64
Rename PainterMetrics::change_ to change
...
This is not a private variable.
2020-01-14 11:50:44 +01:00
Jean-Marc Lasgouttes
5bb9ded4d6
Streamline RowPainter a bit
2020-01-14 11:42:01 +01:00
Juergen Spitzmueller
b5856628f1
Set changed status for changed column/row cells in updateIndexes()
2020-01-14 10:39:42 +01:00
Juergen Spitzmueller
2a48fbbf7f
Some polishment.
2020-01-14 09:55:16 +01:00
Juergen Spitzmueller
33133733ae
Record change author and time for tracked columns/rows
...
This now uses a real change object
2020-01-14 09:28:36 +01:00
Juergen Spitzmueller
194298045c
Color lines of added/deleted rows/columns
2020-01-13 19:02:48 +01:00
Jean-Marc Lasgouttes
cbabff4686
Do make changebar shorter for last row
...
I do not know what the intent was, but it is ugly.
2020-01-13 17:42:31 +01:00
Jean-Marc Lasgouttes
93794d6fea
Implement isChanged for tabular inset.
2020-01-13 16:35:15 +01:00
Jean-Marc Lasgouttes
b0371714a0
Only show pencil change mark when inset is collapsed
2020-01-13 16:35:15 +01:00
Juergen Spitzmueller
5fc2662b13
Add pref to keep ct markup on copy/paste
...
Fixes #10278 , #10128
2020-01-13 15:20:48 +01:00
Jean-Marc Lasgouttes
1baa8cdc93
When iterator is in a table cell, set Changed indicator for the right inset.
2020-01-13 15:08:50 +01:00
Juergen Spitzmueller
c6ef96ea36
Prevent NULL pointer
2020-01-13 13:03:52 +01:00
Juergen Spitzmueller
adfd38e4ef
Fix backspace deletion of selected items with change tracking
...
Move cursor at beginning of selection after deletion. Else backspace
operation gets stuck in a loop (tries to remove the selection again
and again).
This also fixes backspace deletion of insets with confirmDeletion() == true.
Fixes #11630
2020-01-13 09:48:56 +01:00
Juergen Spitzmueller
ff85641cc0
Whitespace
2020-01-13 09:21:32 +01:00
Juergen Spitzmueller
a450797b2a
Rest in peace, dvipost!
2020-01-13 08:59:26 +01:00
Jean-Marc Lasgouttes
e340f46476
Fixup bf7f4d71
: Let changeRefsIfUnique handle undo
...
This allows for a much lower memory consumption than a plain
recordUnfoFullBuffer.
Related to bug 6494.
2020-01-12 22:18:36 +01:00
Jean-Marc Lasgouttes
4a4ded2297
Reimplement computation of change tracking status
...
This is a reimplementation of 6d4e6aad
that is both simpler and more
complete.
This uses the updateBuffer mechanism to implement a fully working
version of Inset::isChanged(). Now the function returns true for an
inset that contains an inset that contains a change, for example.
Moverover Buffer::areChangesPresent() is merely a proxy for
Buffer::inset().isChanged().
2020-01-12 20:26:35 +01:00
Jean-Marc Lasgouttes
dba1e40b52
Revert "Automatically show the review toolbar if the document has tracked changes"
...
We will replace this with a better solution
For now, only keep
- Changes::isChanged()
- Buffer::areChangesPresent(), replaced by a dummy function
Next step will be to provide a working areChangesPresent() and to
compute Inset::isChanged in updateBuffer.
This reverts commit 6d4e6aad24
.
2020-01-12 20:26:35 +01:00
Jean-Marc Lasgouttes
ce950f1ea5
Fixup b321bb1a
: set changebar when inset contains changes
...
Add Paragraph::isChanged() and InetText::isCgchanged() which indicate
the presence of a change in the relevant object.
Sets Row::needsChangebar() when adding an inset that contains changes.
Related to bug #8645 .
2020-01-12 20:26:35 +01:00
Enrico Forestieri
45f8254cbd
Fix bug #11716
...
Close \lyx*displayobjdeleted so that the correct macro is used for
the following deleted material.
2020-01-12 18:35:15 +01:00
Juergen Spitzmueller
ac8aa981db
Do not track deletion of empty paragraph
...
Fixes #10412
2020-01-11 18:11:26 +01:00
Juergen Spitzmueller
4718d63fc3
Output proper driver to changebar package when using dvi chain
...
Else the bars are not shown
2020-01-11 16:51:00 +01:00
Juergen Spitzmueller
bbc6ea4a5f
Implement change tracking of column/row addition/deletion
...
Fixes #8469
File format change
2020-01-11 16:17:04 +01:00
Jean-Marc Lasgouttes
bf7f4d716c
Avoid blinking change tracking cur for math inset.
...
Since there is a margin above and below the inset, there is no problem
for putting it higher.
Fixes bug #11684 .
2020-01-11 13:39:20 +01:00
Juergen Spitzmueller
c77999a5f3
Add buffer param to opt-out fragile content movement
...
Fixes #11714
File format change
2020-01-10 10:21:09 +01:00
Jean-Marc Lasgouttes
09130d7a62
Update to boost 1.72
...
This requires to add a assertion_failed_msg handler. Take this
occasion to cleanup and uniformize the various boost.cpp files that we
have.
This adds 50k line of whatever to the source code.
2020-01-07 16:27:23 +01:00
Jean-Marc Lasgouttes
294969c6a2
Improve Update::FitCursor when there is a selection
...
It is better indeed to try to make the whole selection fit on screen.
Fixes bug #11012 .
2020-01-07 10:13:09 +01:00
Juergen Spitzmueller
224bc7de6e
Fix copy-paste error (spotted by coverity)
2020-01-03 13:39:50 +01:00
Kornel Benko
ae7a7fa882
Adv search: fix handling of multiple params of a latex command
...
Fix the case of possibly nested parentheses
2020-01-03 13:11:47 +01:00
Juergen Spitzmueller
dc41c1f6df
New helper lfun ifrelatives
...
This executes a command only if a buffer has either a master or children
Helps to disable master-related items in the UI
2020-01-02 14:09:24 +01:00
Juergen Spitzmueller
3f7b8db1b1
Further improve status check of master-buffer-forall
2020-01-02 14:09:01 +01:00
Kornel Benko
49aaf95894
Fix handling of doRemove in advanced search
...
Amend 11c47ddf
2020-01-01 14:03:21 +01:00
Juergen Spitzmueller
af9651a6a5
Slightly better status of master-buffer-forall
2019-12-31 18:46:33 +01:00
Juergen Spitzmueller
79674c7632
Track changes in InsetCommands
2019-12-31 15:46:03 +01:00
Juergen Spitzmueller
11c47ddfcf
Do not copy deleted text to external clipboard
...
Fixes #10416
2019-12-31 13:47:06 +01:00
Juergen Spitzmueller
affc006bae
Honor change tracking when automatically renaming refs to labels
...
Fixes rest of #11556
2019-12-31 12:29:53 +01:00
Juergen Spitzmueller
69792bbaa5
Implement master-buffer-forall
...
Similar to buffer-forall with the notable exception that its scope is
limited to the files of a project (master and all children)
2019-12-31 12:27:00 +01:00
Juergen Spitzmueller
a5db5d4c90
whitespace
2019-12-30 16:28:15 +01:00
Juergen Spitzmueller
ada07d0bf1
Amend dc174db6c1
2019-12-30 13:25:49 +01:00
Juergen Spitzmueller
adc90a5570
Fix some regressions with ct-struckout underlined display math
2019-12-30 13:00:03 +01:00
Kornel Benko
48c7d9b028
Do not search in deleted text in change tracking mode
2019-12-29 17:42:18 +01:00
Juergen Spitzmueller
8a17cc01e0
Implement (basic) ct for tabular-feature delete-row and delete-column
...
Fixes part of #8469
For a proper fix that works with change-reject as well as with hide
changes in output, we need to implement
ct information in tabular's row and column.
2019-12-29 14:09:52 +01:00
Juergen Spitzmueller
b37b39365f
Remove obsolete FIXMEs
2019-12-29 12:07:55 +01:00
Juergen Spitzmueller
e65fdc6a51
Track change of label name
...
Fixes #11556
2019-12-29 11:01:18 +01:00
Juergen Spitzmueller
2fc0fdb3e4
Assure deleted display objects start on new line
2019-12-29 10:10:14 +01:00
Juergen Spitzmueller
b321bb1aed
Indicate change of content in label of collapsed collapsible
...
Fixes #8645
2019-12-29 09:46:18 +01:00
Juergen Spitzmueller
89b5607e0a
Centralize code to markup deleted complex objects (with tikz) in output
...
This fixes #9293
2019-12-28 13:43:17 +01:00
Juergen Spitzmueller
f686a97fd8
Restructure ct LaTeX markup
...
This makes it easier to redefine the markup only.
2019-12-28 13:41:19 +01:00
Juergen Spitzmueller
80361eb1eb
Do not track changes while accepting/rejecting all changes
...
Fixes #7487
2019-12-27 14:49:51 +01:00
Juergen Spitzmueller
b2c2a6e15d
Correctly handle deleted text on inset-dissolve
...
Part of #10128
2019-12-27 14:32:20 +01:00
Juergen Spitzmueller
28da0f4360
Properly nest \lyxdeleted within text markup
...
Fixes #8807
2019-12-27 13:56:53 +01:00
Juergen Spitzmueller
6964886daf
Consider deleted spaces in spell checking
...
Addresses part of #11470
2019-12-27 13:01:35 +01:00
Juergen Spitzmueller
da5ad1736a
Handle change-accept and change-reject in multi-cell selection
...
Fixes #8426
2019-12-27 12:05:56 +01:00
Juergen Spitzmueller
c0f4eb0580
Introduce buffer-reset-export
...
Small helper lfun that makes LyX remove the aux file before doing the
next export. A bit more convenient than removing the files manually
or restarting LyX.
2019-12-27 11:06:34 +01:00
Juergen Spitzmueller
39bff52797
Increase lyxrc format
2019-12-27 11:06:11 +01:00
Juergen Spitzmueller
8e62dcc20f
Add pref option to disable underlining of added text (in workarea)
...
Addresses #10102
2019-12-27 10:35:52 +01:00
Juergen Spitzmueller
7c63896c60
CT: Mark deleted floats in output
...
Fixes #11175
2019-12-27 09:50:11 +01:00
Juergen Spitzmueller
117e63b01b
Correctly show merged paragraphs with ct in plain text output
...
Fixes #3137
2019-12-27 09:01:06 +01:00
Juergen Spitzmueller
c096382beb
Initialize correct font in description label with ct
...
Fixes #10811
2019-12-27 08:42:43 +01:00
Jean-Marc Lasgouttes
aeed6fb8fa
Do not check again and again for non existing files
...
If the file of an InsetInclude does not exist, loadIfNeeded will try
again and again to look for it. This is very bad for files with many
include insets, especially on windows.
Fixes bug #11656 .
2019-12-26 16:45:40 +01:00
Juergen Spitzmueller
38ca174819
Fix crash
2019-12-26 16:36:25 +01:00
Juergen Spitzmueller
6ed3eb6833
Signify added/deleted apr break in ct output
...
Fixes #3159
2019-12-26 15:43:00 +01:00
Juergen Spitzmueller
dc174db6c1
Correctly handle deleted environments in ct
...
Fixes #10252
2019-12-26 15:24:48 +01:00
Juergen Spitzmueller
afb442c76c
Correctly show merged paragraphs with change tracking
...
Fixes #3136
2019-12-26 13:47:50 +01:00
Juergen Spitzmueller
54e10dc1ad
Fix assertion
2019-12-26 12:32:50 +01:00
Juergen Spitzmueller
d644ba0087
Do not output empty \item's or \commands with change tracking
...
unless "show in output" is selected.
Fixes #2861
2019-12-26 12:26:32 +01:00
Juergen Spitzmueller
90ae998287
Show modified text in merge changes dialog as far as possible
...
Fixes #1362
2019-12-26 11:17:09 +01:00