Jean-Marc Lasgouttes
4828dfb441
Indicate that we do not use a return value
...
Please Coverity.
2021-03-05 13:12:58 +01:00
Jean-Marc Lasgouttes
f5340fd6d9
Fix missing initialization
...
Spotted by Coverity.
2021-03-05 13:06:10 +01:00
Jean-Marc Lasgouttes
e6a7da3b22
Fix warning when not using Qt regexps
2021-03-05 11:54:11 +01:00
Juergen Spitzmueller
23fc1b270d
Remove redundant call (amend 2b7fae04f3
)
2021-03-05 07:54:17 +01:00
Juergen Spitzmueller
2b7fae04f3
Fix limiting of absurdly large input to thesaurus ( #10528 )
2021-03-05 07:51:49 +01:00
Juergen Spitzmueller
64095a0af2
Fix wrap with Spellchecker after ignore ( #10383 )
2021-03-04 18:02:04 +01:00
Juergen Spitzmueller
a57cdd0d30
Remove confusing and unusual "Find Next" button from spellchecker dialog ( #8931 )
2021-03-04 16:54:01 +01:00
Juergen Spitzmueller
8718d01770
Style
2021-03-04 14:52:39 +01:00
Juergen Spitzmueller
5920591b52
refillToolbars() does not need to be public
2021-03-04 14:51:58 +01:00
Juergen Spitzmueller
812b6f7d69
Allow for runtime (dark/light) mode switch
2021-03-04 12:35:38 +01:00
Enrico Forestieri
be2c12ba40
Fix bug #9601
...
Make sure emphasized text in mathed has correct shape and color.
2021-03-04 11:58:44 +01:00
Jean-Marc Lasgouttes
009efa195b
Avoid pointless 'undefined flex inset' errors
...
When switching class, it does not make sense to flag flex insets that
are undefined if they were already undefined before.
Part of bug #12163 .
2021-03-04 10:08:46 +01:00
Daniel Ramoeller
fde432493d
Fix Disable Editing "Lock" icon protrudes into tab title on macOS
...
On macOS the Disable Editing "Lock" icon protrudes into tab title
Also, since the close button is on the left, the lock is better positioned on the right.
The detour via QIcon is to avoid a pixelated pixmap (because in LyX pixmaps don't adjust by default to the device's pixel ratio correctly).
Also
Fix for bug #12160 .
2021-03-02 18:38:14 +01:00
Jean-Marc Lasgouttes
fbf22bb3f3
Fix random scrolling inside nested insets
...
Happened when the BufferView was resized (e.g. math toolbars were
displayed/hidden).
Backported from gadmm's lyx-unstable tree
https://gitlab.com/gadmm/lyx-unstable/-/commit/a868bc034cea4c
Possible fix to bug #7457 .
2021-03-02 18:10:12 +01:00
Juergen Spitzmueller
e2f3dd5f6a
Consider selection scope when DEPM after CT acceptance/rejection ( #2166 )
...
This fixes a crash and DEPM overshooting.
2021-03-02 09:15:33 +01:00
Juergen Spitzmueller
d49c4abb43
Merge branch 'master' of git.lyx.org:lyx
2021-03-02 08:36:42 +01:00
Jean-Marc Lasgouttes
f92f2f95ff
Cleanup High DPI support
...
Disable for Qt >= 6 (this is the default now).
Disable for macOS (does it in its own way).
2021-03-02 08:22:02 +01:00
Juergen Spitzmueller
f28affd421
Merge branch 'master' of git.lyx.org:lyx
2021-03-02 07:04:03 +01:00
Jean-Marc Lasgouttes
234886f6eb
Add Qt platform name in About dialog
2021-03-01 19:15:49 +01:00
Enrico Forestieri
bb2c1c3485
Amend c2facb8c
...
Make sure the base of a script is not empty before accessing it.
2021-03-01 10:08:08 +01:00
Enrico Forestieri
52ce0ff49a
Fix bug #11007
...
The math color inset inherits the mode of the containing inset.
This mode is inferred by the kind of font in effect. Setting the
right mode allows to insert spaces where these should be allowed.
Another small glitch was that the selection was always parsed in
math mode, so that any space was swallowed, even if the inset would
allow them.
2021-02-28 22:32:11 +01:00
Juergen Spitzmueller
0e54e01756
grammar
2021-02-28 17:38:01 +01:00
Juergen Spitzmueller
939dc4076f
Prevent infinite loop with instant search on Mac ( #12161 )
...
The search dialog was repeatedly feeded with the same string, and a
new search was triggered.
2021-02-28 17:36:06 +01:00
Enrico Forestieri
61db164302
Fix bug #11444
2021-02-28 14:56:42 +01:00
Juergen Spitzmueller
1205018286
Use a proper filter bar in the outliner
2021-02-28 13:57:24 +01:00
Daniel Ramoeller
2a8cac75f4
Adjust adv. find & replace pane spacing
...
Partial fix of bug #12152 .
2021-02-28 13:13:30 +01:00
Daniel Ramoeller
11548c523a
Adjust code preview spacing
...
Partial fix of bug #12152 .
2021-02-28 13:10:03 +01:00
Daniel Ramoeller
55f2445278
Adjust outliner spacing
...
Partial fix for #12152 .
2021-02-28 13:06:14 +01:00
Juergen Spitzmueller
5573825202
HiDPI support for search indicators ( #12162 )
...
Requires Qt5
2021-02-28 12:35:29 +01:00
Richard Kimberly Heck
170f06089d
Add a bit of debugging code
2021-02-27 20:34:29 -05:00
Enrico Forestieri
7b526d6461
Fix bug #3751
...
We lack the necessary font (cmb10) for drawing bold uppercase greek
letters. It would be overkill adding it for this sole purpose, so
adopt the same poor man's bold strategy used with \boldsymbol.
2021-02-27 21:40:28 +01:00
Richard Kimberly Heck
0895b76f1e
Fix bug #12169
...
Patch from Daniel.
2021-02-27 13:27:05 -05:00
Enrico Forestieri
195b928f92
Fix bug #3294
2021-02-27 14:49:55 +01:00
Kornel Benko
a3e10cd067
FindAdv: Added handling of some chars found in unnicodesymbols
2021-02-27 14:14:28 +01:00
Enrico Forestieri
c2facb8c56
Fix cursor navigation in \overbrace and \underbrace
...
Due to the way these decorations are implemented, entering
them with the cursor (either form right or left) required
pressing two times cursor left or right.
Fixes #2264
2021-02-26 20:30:41 +01:00
Daniel Ramoeller
d74367a96e
Use document mode on work area and docks on macOS
...
- More fittingly (plain) looking tabs for documents and docks.
- Also macOS fix for bug #9391 .
2021-02-26 20:01:43 +01:00
Jean-Marc Lasgouttes
42b23f3fb2
Display bookmarks in the workarea (take 2).
...
The bookmarks are shown with circled numbers in the right margin (or
the left margin in RTL mode). A new color "bookmarks" has been added.
Currently bookmark 0 (the return position) is not displayed because it
is very disturbing in practice.
To make this work, a new method BookmarksSection::bookmarksInPar
retuns the list of bookmarks in a paragraph along with their position.
Force redraw when using bookmark-save and bookmark-clear.
Caveats:
- this solution does not show the precise position of the bookmark
(this is supposedly not a problem).
- if several bookmarks are on the same row, they will currently be
garbled. It would be easy to make sure that only one is shown ; what
would be more difficult would be to move the second bookmark lower.
- it is possible to make sure that the markers are correctly centered
in the margin, and that the margin size is large enough to hold the
marker (I did not try all fonts).
Fixes bug #2496 .
2021-02-26 19:09:25 +01:00
Jean-Marc Lasgouttes
e4ab91d802
Revert "Display bookmarks in the workarea."
...
This will be replaced by a different version.
This reverts commit 99e636ae7b
.
2021-02-26 18:07:39 +01:00
Richard Kimberly Heck
946d112ee6
Allow to call cap::switchBetweenClasses without an ErrorList.
...
It turns out that we usually don't care about the errors and so
were creating dummy ErrorList objects in several places.
2021-02-25 21:49:50 -05:00
Jean-Marc Lasgouttes
3e3ad2937c
Remove assertion that is not necessary.
...
It may happen that there are errors when doing undo, crashing does not
help in this case.
Fixes bug #12163 .
2021-02-25 20:00:41 +01:00
Jean-Marc Lasgouttes
d7a4f47e7d
Improve HiDpi handling
...
Add code stolen from QBitTorrent that enables properly HiDpi handling.
HighDpi support is set by default starting with Qt 5.6.
Support for fractional scaling is added for Qt >= 5.14.
Hopefully fixes bug #12060 .
2021-02-25 19:24:22 +01:00
Enrico Forestieri
3cf5a064db
Amend 368e983a
2021-02-23 21:48:54 +01:00
Enrico Forestieri
368e983abb
Fix bug #12165
2021-02-23 20:00:50 +01:00
Jean-Marc Lasgouttes
f59dafe898
Fix cursor position when undoing inset-dissolve.
...
When invoking inset-dissolve with the cursor in front of the inset,
add recordUndo call to make sure that the cursor is at the right
class.
Fixes bug #12164 .
2021-02-23 19:24:54 +01:00
Enrico Forestieri
2629bd6dfb
Improve fix for #12153
...
Use a WYSIWYM approach instead of a WYSIWYG one.
2021-02-23 17:34:19 +01:00
Juergen Spitzmueller
55da675efa
FancyLineEdit: use QLineEdit's own clear button with Qt >= 5.2
2021-02-23 16:53:15 +01:00
Jean-Marc Lasgouttes
a5fd5d3cd2
"12 pixels ought to be enough for anyone"
...
Fixes bug #12153 .
2021-02-22 19:35:08 +01:00
Daniel Ramoeller
e050435314
Adjust label size to directory names in About
...
Fix for bug #11946 .
2021-02-22 07:19:28 +01:00
Jean-Marc Lasgouttes
41d29ce387
Reduce the value of (above|below)displayskip
...
The value of 10pt is too large, use a 'mean' value of 8.5pt.
Tentative fix to bug #12153 .
2021-02-21 20:40:09 +01:00
Pavel Sanda
9e734339e9
Compile with gcc 4.9 again.
2021-02-21 20:05:06 +01:00
Thibaut Cuvelier
5b9929c9d7
Amend 61657bd610
...
Restore indentation to be more consistent.
2021-02-21 13:15:10 +01:00
Enrico Forestieri
4e0d7f753b
Draw real dots
...
A new method for drawing ellipses has been added to the painter
and used for drawing real dots for math decorations and the various
\cdots, \ddots, \vdots, etc., latex commands.
2021-02-21 00:39:12 +01:00
Thibaut Cuvelier
61657bd610
DocBook: convert a first ERT.
2021-02-20 20:29:34 +01:00
Juergen Spitzmueller
269c583967
ProgressView: fix initial tab.
2021-02-20 08:10:01 +01:00
Richard Kimberly Heck
9c5f743575
Fix bug #12152 .
...
Patch from Daniel.
2021-02-19 17:31:36 -05:00
Thibaut Cuvelier
358e4ace56
DocBook: implement prepended/appended arguments for all kinds of elements.
...
Previously, it was just in InsetText.
2021-02-19 17:38:38 +01:00
Kornel Benko
77e8037f84
FindAdv: Do not distinguish between different math constructs
...
This means that searching math-mode will find instances also in
math-environments like align*, multline, ...
2021-02-19 17:12:38 +01:00
Yuriy Skalko
110862b09f
Fix setting of math matrix size with mouse
2021-02-19 18:06:04 +02:00
Enrico Forestieri
7114de5175
Fix bug #12148
2021-02-19 02:19:06 +01:00
Juergen Spitzmueller
ed2f3dae5c
Select search string after inserting from find buffer
2021-02-18 15:56:32 +01:00
Jean-Marc Lasgouttes
65b674ba4e
Fix a crash when closing tabs
...
Although I do not know how to reproduce the crash, the change makes sense.
This is backported from gadmm's lyx-unstable tree
261ce4ea98
2021-02-18 15:54:29 +01:00
Juergen Spitzmueller
9ee73dbb30
GuiSearch: properly display indicators in dark mode
2021-02-18 15:44:27 +01:00
Daniel Ramoeller
672ff09634
Fix Undo with search-string-set
...
Makes it possible to use the find combobox's internal undo feature to undo a set search string.
2021-02-18 13:09:30 +01:00
Juergen Spitzmueller
b6945764a4
Do not report false find with empty string in instant search
2021-02-18 13:00:41 +01:00
Juergen Spitzmueller
a7e6dcc31d
GuiSearch: make search options visible/accessible in minimal mode
2021-02-18 07:33:26 +01:00
Scott Kostyshak
6e8b3906df
Fix an instance of -Werror=misleading-indentation
...
Full GCC output is:
/home/scott/lyxbuilds/master/repo/src/insets/InsetText.cpp: In member function ‘void lyx::InsetText::docbook(lyx::XMLStream&, const lyx::OutputParams&, lyx::InsetText::XHTMLOptions) const’:
/home/scott/lyxbuilds/master/repo/src/insets/InsetText.cpp:713:5: error: this ‘for’ clause does not guard... [-Werror=misleading-indentation]
713 | for (auto const & arg : appendedArguments)
| ^~~
/home/scott/lyxbuilds/master/repo/src/insets/InsetText.cpp:717:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘for’
717 | if (writeOuterTag) {
| ^~
2021-02-17 23:01:54 -05:00
Thibaut Cuvelier
6df4597e02
DocBook: force paragraphs in HTML cells to allow for nested tables.
...
CALS still invalid because it forbids nested tables.
2021-02-17 23:32:23 +01:00
Thibaut Cuvelier
da92c9a950
DocBook: spurious spaces in table attributes.
2021-02-17 23:25:41 +01:00
Thibaut Cuvelier
bfa67b1f88
DocBook: TODO is outdated, table type is checked within docbookRow.
2021-02-17 22:55:37 +01:00
Thibaut Cuvelier
adc7820d45
DocBook: add support for DocBookArgumentAfterMainTag.
2021-02-17 21:09:21 +01:00
Enrico Forestieri
2fdee24959
Correctly show deleted url with change tracking
...
This fixes the issue reported here:
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg202545.html
I could not find an open ticket about it.
2021-02-17 19:51:01 +01:00
Juergen Spitzmueller
80cb0650e4
Clean up previous selections with empty searchstr on instant
2021-02-17 16:55:55 +01:00
Juergen Spitzmueller
ab1cc8e1c2
Consider case (in)sensitivity when querying special char insets
2021-02-17 15:50:54 +01:00
Juergen Spitzmueller
ca160da07d
GuiSearch: separate findClicked() slot from more general function
...
the latter one is also accessed by different paths than clicking
2021-02-17 14:48:31 +01:00
Juergen Spitzmueller
180fca2fcd
Fix Find button with search as you type
2021-02-17 14:32:26 +01:00
Juergen Spitzmueller
05004e138f
FancyLineEdit: reformat using our indentation style
...
No change in function
2021-02-17 12:46:37 +01:00
Juergen Spitzmueller
50783d94a8
Advanced F&R: Improve code on Return key
2021-02-17 09:51:09 +01:00
Juergen Spitzmueller
a2a5656d07
Adv F&R: indicate search direction
2021-02-17 09:50:57 +01:00
Juergen Spitzmueller
5ed0dddcf2
Adv F&R: Fix accelerator conflicts
2021-02-17 09:49:25 +01:00
Juergen Spitzmueller
7ad70c908b
Add accelerator
2021-02-17 09:08:26 +01:00
Jean-Marc Lasgouttes
3f093dd103
Fixup 824d1c99
: do not change the semantics of leftMargin(pit_type)
...
In the row painter, when painting a centered label, one wants to get
the left/right margin of the non-first rows (without indent). It was a
bad idea to change leftMargin(pit) to do that, because its semantics
are unclear and the the code depends on the fact that this function does
strange things when the paragraph is empty...
Fixes bug #12118 .
2021-02-16 20:27:48 +01:00
Juergen Spitzmueller
fe44b3c0fa
GuiSpellchecker: resolve accelerator conflicts
2021-02-16 19:13:13 +01:00
Juergen Spitzmueller
76db3c3f85
GuiThesaurus: complement lyxfind options
2021-02-16 16:33:30 +01:00
Juergen Spitzmueller
109e98d945
GuiSearch: Properly delegate focus
2021-02-16 13:30:31 +01:00
Jean-Marc Lasgouttes
a7c1a39b5b
Make selections vertically tighter.
...
Introduce a new Row::contents_dim(), which height is restricted to the
row contents and does not contain any extra vertical spacing.
Rely on this for painting selections: if the selection starts on row,
for example, the ascent of the contents dim is considered. If ot was
started above, then the full dim is used.
Fixes bug #3899 .
2021-02-16 12:29:40 +01:00
Jean-Marc Lasgouttes
090e9a6c36
Keep the useful parts of reverted commits
...
Keep from 907f0207
the introduction of BufferView::top/bottomMargin()
and the setting of the top/bottom margin of the document. The
difference is that the extra height is still added to the relevant
rows, and not only to the paragraph metrics.
Keep from f41ca959
the reduction of top/bottom margin for Adv F&R
workareas.
2021-02-16 12:29:40 +01:00
Jean-Marc Lasgouttes
a40ca1430e
Revert "Improve handling of top and bottom margin"
...
This reverts commit 907f020724
.
2021-02-16 12:29:40 +01:00
Jean-Marc Lasgouttes
810b86560a
Revert "Reduce top/bottom margin for Adv F&R workareas"
...
This reverts commit f41ca959fd
.
2021-02-16 12:29:40 +01:00
Jean-Marc Lasgouttes
2c2ae5ecd8
Revert "Fix correction of row in getPitAndRowNearY"
...
This reverts commit 08a3405181
.
2021-02-16 12:29:40 +01:00
Jean-Marc Lasgouttes
f6c87c63c1
Revert "Make sure that top/bottom margins are visible when needed"
...
This reverts commit a78eb4471f
.
2021-02-16 12:29:40 +01:00
Juergen Spitzmueller
213a3bc557
Add/fix some tooltips
2021-02-16 10:02:47 +01:00
Juergen Spitzmueller
119e8c08d4
Fix replace all in selection with change tracking
2021-02-16 09:42:17 +01:00
Pavel Sanda
1ba3307226
GuiSearch did not work with num. keypad enter
2021-02-16 08:52:21 +01:00
Juergen Spitzmueller
5980afaee0
Add support for search/replace within selection ( #2548 )
2021-02-16 08:11:09 +01:00
Juergen Spitzmueller
df4da34836
GuiCitation: Add missing connection
2021-02-16 07:32:01 +01:00
Enrico Forestieri
a0a0119b48
Account for true dpi
...
We have to account for the physical rather than logical dpi.
See #12132 .
2021-02-15 22:43:36 +01:00
Richard Kimberly Heck
01dc665a25
Make continuous spellcheck the default.
...
Convert old preferences to preserve previous setting, as well.
2021-02-15 11:03:43 -05:00
Richard Kimberly Heck
93e7ab1f3e
Do not write \default_view_format if it is empty.
2021-02-15 10:55:37 -05:00
Juergen Spitzmueller
c4fbd0d913
Initialize F&R dialog with selected text ( #8448 )
2021-02-15 16:04:17 +01:00
Richard Kimberly Heck
bdd7e26b3e
Fix warning
2021-02-15 09:48:37 -05:00