Commit Graph

39506 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
7f177d8d4a Improve DEPM when change tracking is on
A typical problem when change tracking is on is:
1/ insert a new space between two words (as if you want to insert a new one)
2/ move the cursor
3/ see how one has one inserted and one deleted space, whereas one would expect nothing.

The problem is fixed in a general way in master, but here we propose
a simpler one, where the spaces that we keep are the ones at the end
of the sequence of spaces.

Part of #11412.
2019-02-15 11:04:28 +01:00
Jean-Marc Lasgouttes
484128d05b Fix position of cursor when DEPM is used in change tracking mode
When change tracking is active, it may happen that spaces are marked
as deleted instead of being removed. Therefore it is better to measure
the change of size of the paragraph to know how to offset the cursor.

Moreover, it the cursor was strictly after the start of the sequence
of spaces, we ensure that it is still the case.

This commit is _not_ a backport from master, which has diverged.

Part of bug #11412/
2019-02-15 11:03:17 +01:00
Jean-Marc Lasgouttes
c44dc071a5 Fix DEPM at end of paragraph
Remove special handling of spaces at end of paragraph. Now they are
handled like interword spaces by both DEPM methods.

Fix off-by-one error in loop when testing for end of paragraph.

Part of bug #11412.

(adapted from commit c00234503f)
2019-02-15 11:01:29 +01:00
Juergen Spitzmueller
130a555796 Fix IPA icons
Convert text to path and fix the most salient drawing issues.
2019-02-11 16:47:36 +01:00
Jean-Marc Lasgouttes
96ef3d320b Fix Visual C++ warning
(cherry picked from commit 2215f4c2b4)
2019-02-11 10:54:58 +01:00
Jean-Marc Lasgouttes
4c18a49c87 Fix algorithm for finding localized files
Now we search in priority with the GUI language, and then the
language(s) specified in the LANGUAGES environment variable.
Preoviously, the GUI language would only be considered when
LANGUAGES was not set (which was a bug).

Take this opportunity to remove old compatibility code from 2007.

(cherry picked from commit e203bf519b)
2019-02-07 10:19:28 +01:00
Enrico Forestieri
841f0fd3dd Fix bug #11484
When splitting parameters at commas, take into account that
commas inside curly braces are not parameter separators.

(cherry picked from commit 6316b9b7ae)
2019-02-05 14:57:18 +01:00
Juergen Spitzmueller
f785d63a0a ? and = must not be percent-encoded in hrefs
Fixes: #11482
(cherry picked from commit c2db448ff5)
2019-01-30 08:17:20 +01:00
Enrico Forestieri
cc033cbd21 Update it.po 2019-01-27 11:58:18 +01:00
Juergen Spitzmueller
33d48096c1 de.po 2019-01-25 15:02:00 +01:00
Pavel Sanda
14d766e2ae * cs.po 2019-01-23 23:11:36 +01:00
Daniel Ramoeller
b8e6527c79 Fix for #11294: Wrong description for Change bars module
(cherry picked from commit f71723c8f3)
2019-01-19 19:04:47 -05:00
Richard Kimberly Heck
8cbf1c7cec Rename emergency file when it is kept.
Otherwise, we will ask about it again next time, when the file
may have changed. Also, if we crash again, we'll over-write that
file, which we may not want to do.

See bug #11464.

(cherry picked from commit b804e8851c)
2019-01-17 23:01:54 -05:00
Jean-Marc Lasgouttes
aa2f5eb426 Allow to type a space in front of another one
This is a follow-up to 714b731e. This fixes the issue when the cursor
is in front of a space
  abc| def
and one inserts another space (to start a word). DEPM would eat one
space and produce
  abc |def
instead of
  abc | def

Additionally, fix the same_par boolean, wheich did not take the cell
index into account.

Related to ticket #11412.

(cherry picked from commit 7848d3c90c)
2019-01-16 10:38:47 +01:00
Enrico Forestieri
a54147d087 Remove PYTHONPATH from the environment on Windows
This make sure to use the the modules distributed with LyX,
avoiding reconfigure failures.

(cherry picked from commit ad0c9a548b)
2019-01-12 18:52:01 +01:00
Juergen Spitzmueller
177bf8dba8 force some symbols as macros with utf8-cjk
cherry-picked from
* 4786c59a8c
* 81af82d1e8
* c2d20645be
2019-01-12 17:40:55 +01:00
Juergen Spitzmueller
e27870db7a CJKutf8 is only to be used with the dedicated utf8-cjk encoding
cherry-picked from 9982651fd6
2019-01-12 17:40:19 +01:00
Juergen Spitzmueller
434842563a Add support for U+2693 (ANCHOR)
Fixes: #10706
(cherry picked from commit ead498f0a6)
2019-01-12 08:34:11 +01:00
Enrico Forestieri
3131873a6d Replace environment variables in PATH prefix
The PATH prefix modified through the GUI was set without
replacing embedded environment variables. This might have
caused problems on Windows with external python installations.

(cherry picked from commit 472bdf5910)
2019-01-11 23:01:18 +01:00
Juergen Spitzmueller
bfd86a947a Do not consider deleted labels in ambiguity check
This adds a new (boolean) parameter "active" to the label cache, where
we track whether a label is deleted in ct mode (the same could be done,
if wanted, for labels in notes and inactive branches).

Deleted (inactive) labels are neither considered in the uniqueness check
nor added to the outliner. This also means that undeleted references to
deleted labels are now (correctly) marked as BROKEN.

Cherry-picked from:

    [3ae6bff538/lyxgit]
    [a550a613e8/lyxgit]
    [c457ea90e/lyxgit]
    [5cfd25697/lyxgit]
    [5afacb144/lyxgit]
    [54366c38e/lyxgit]

Fixes: #6563
2019-01-09 09:06:53 +01:00
Juergen Spitzmueller
5f3c0d5aca When using polyglossia (bidi), paragraph directions don't need to be swapped
Bidi does that.

Fixes: #11399
(cherry picked from commit 9d20bc4e98)
2019-01-08 08:30:42 +01:00
Scott Kostyshak
45931f7a60 status.23x: correct typo from 822e0133
Thanks to José.
2019-01-07 12:15:16 -05:00
Scott Kostyshak
822e0133aa ko splash.lyx: specify "mj" as CJK font
Now (thanks to d193cd05), the Korean splash.lyx compiles
out-of-the-box with pdflatex.

Thanks to Jürgen.

(cherry picked from commit 0cfaf406c5)
2019-01-07 11:56:23 -05:00
Kornel Benko
ee4a95888f Enable error-free compilation of ko splash.lyx with xetex and lautex
This amends somehow 9238004c. Since the system font NanumMyeongjo
and the "mj" spec as CJK latex font are related, this change
seems appropriate.

(cherry picked from commit f092208c89)
2019-01-07 17:40:39 +01:00
Juergen Spitzmueller
7e2b29682c Don't output CJK environment with non-TeX fonts
This amends d193cd05a8.

(cherry picked from commit c9dd349bee)
2019-01-07 17:23:22 +01:00
Juergen Spitzmueller
8918075ed0 Properly implement CJKutf8
If we use that, the document actually needs to be in utf8 encoding, and
the CJK environment needs to account for it.

Candidate for stable.

(cherry picked from commit d193cd05a8)
2019-01-07 17:23:22 +01:00
Jean-Marc Lasgouttes
e8d96cb9b1 Fix display of gather in lefteqn mode
The column is flushed when the display of equations is flushed.

Not sure what to do with RtL languages.

Fixes bug 11324.

(cherry picked from commit 7cb0284a3f)
2019-01-07 11:41:35 +01:00
Stephan Witt
7dd5d6371f Add license info for inkscape start script
(cherry picked from commit a4d409b194)

Add status log for 2.3.x
2019-01-07 00:18:52 +01:00
Stephan Witt
432986e8f2 Correct converter configuration for inkscape on Mac
On Mac the inkscape binary is started by a wrapper script. This script changes the
working directory internally and fails to process files with relative path names.
The previous attempt to solve it was to pass the file names with absolute names
by prepending them with the $$p variable (representing the directory name of the files).
This broke the on screen conversion (used for SVGZ to PNG e.g. in the users guide)
because here the $$p variable is undefined.

Now the wrapper script of LyX which is used to locate the Inkscape.app bundle converts
the relative path names into absolute names and the $$p variable is removed from the
converter definitions for inkscape again.

(cherry picked from commit caa1dd2aee)
2019-01-07 00:18:52 +01:00
Richard Kimberly Heck
6bba2aa6a8 Remove now unused routine.
(cherry picked from commit d6b4db1a4f)
2019-01-06 17:51:17 -05:00
Richard Kimberly Heck
90d56cbb4a Use combo box data rather than looking up info from InsetRef.
(cherry picked from commit c4fdab6993)
2019-01-06 17:47:58 -05:00
Richard Kimberly Heck
982be56270 Remove debugging code.
(cherry picked from commit b91e2b9998)
2019-01-06 13:00:45 -05:00
Richard Kimberly Heck
6ac69a78f8 Fix problem caused by re-ordering of menu at 5f6332bf4.
This broke the activation and de-activation of plural, capitalize,
etc. I guess that tells us how much those get used....

(cherry picked from commit 9b3f9cc687)
2019-01-06 12:57:09 -05:00
Scott Kostyshak
5bcb0ca6d8 Bibliography.lyx: minor cosmetic changes
- Add note explaining this file should not be compiled on its own.
- Remove custom preamble.
- Remove setting of master document.

(cherry picked from commit 3ac2dd8e6c)
(cherry picked from commit 91d8aea8d3)
(cherry picked from commit 6e815d3eba)
2019-01-05 16:51:28 -05:00
Enrico Forestieri
bb4fca37be Update it.po 2019-01-05 21:57:12 +01:00
Jean-Marc Lasgouttes
85e693806e Allow toggling (no)limits only after mathop symbol
In particular, introduce the new InsetMathScript::allowLimits method
that checks for that and honor it in getStatus/ddoDispatch.

Do the same for (over|under)brace

(cherry picked from commit 7b7ed64a0e)
(cherry picked from commit 6cfd733dea)
2019-01-05 15:18:09 +01:00
Jean-Marc Lasgouttes
ca8f6c09b6 forgot this 2019-01-05 15:04:51 +01:00
Jean-Marc Lasgouttes
3a4c4605e9 Fix drawing of labels in insets
In many cases, the origin xo_ of insets was forgotten.

Also fix spacing between text and label in rtl

Fixes bug #11425.

(cherry picked from commit 5c1d65afee)
(cherry picked from commit 5fc035f99c)
2019-01-05 15:01:58 +01:00
Jean-Marc Lasgouttes
7f3407b89a Avoid crash when using inset-select-all in tabular
When changing cell idx, it is important to set the pit to a reasonable
value.

(cherry picked from commit a69e01d0b4)
2019-01-05 14:56:41 +01:00
Jean-Marc Lasgouttes
e73c0d6387 Fix vertical offset of fonts like MinionPro
For some reason, adding a LTR/RTL Override unicode character before a
MinionPro string increases the ascent of the line.

This creates vertical offset issues when painting if the ascent used
as reference is the one of the font. Use the QTextLine ascent instead
for better results.

This is a followup to 1bed76e2a.

Fixes (reopened) ticket #11284.
Fixes ticket #10532.
Fixes ticket #10767.

(cherry picked from commit d8498d4785)
2019-01-05 14:40:56 +01:00
Juergen Spitzmueller
08100f8b02 Always update bibfiles cache with bibliography environment before opening citation dialog
We need to do this unconditionally, since there is no (trivial and non-
awkward) way to update it when the bibliography paragraphs are modified.

Fixes: #4899
(cherry picked from commit 35534231d4)
2019-01-05 10:31:08 +01:00
Kornel Benko
db5fb78cfd Cmake lyx2lyx tests: Correct use of value for \use_non_tex_fonts
Amend eec3d1eb,7568571a
We are trying to check if the resulting file after lyx2lyx
is compilable, we have to ensure that copying the original file
to the test directory does not mangle use_non_tex_fonts-entry.

(cherry picked from commit c9e62dec53)
2019-01-05 09:03:23 +01:00
Kornel Benko
410054ba5e lyx2lyx tests: Use the temp-dir also for converted lyx files
Important if including data previously copied there.
Fixes test "export/doc/Additional_lyx22"

(cherry picked from commit 7568571a24)
2019-01-04 05:26:48 +01:00
Richard Kimberly Heck
3c4c5aa994 Fix bug #11432.
Take account of Layout::free_spacing.

(cherry picked from commit 6135824f40)
2019-01-03 19:18:22 -05:00
Jean-Marc Lasgouttes
1e2b503ac9 Remove premature (and bad) optimization
When blinking the caret, it looks like a cool idea to only update the
small rectangle containing the caret. Actually it is an awful idea, since
the paint event will paint some rows, and these rows will not be
properly painted outside of the small rectangle. Unfortunately, the
painter will skip those "painted" rows on next paint events.

This leads to painting errors that depend on the ordering of "real"
and "caret" paint events. This is the reason why they only appeared
with split screens.

Quote of the day: ``The real problem is that programmers have spent far
too much time worrying about efficiency in the wrong places and at the
wrong times; premature optimization is the root of all evil (or at
least most of it) in programming.''
-- Donald Knuth, The Art of Computer Programming.

Fixes bug #11354.

(cherry picked from commit fba9f5b9e8)
2019-01-03 13:52:40 +01:00
Jean-Marc Lasgouttes
b9116e8b81 Add override statements to please clang
Eventually, all overridden virtual methods should be marked properly.
Currently, clang only warns about those in classes that already use
override in at least one place (which was the case dor GuiApplication).

(cherry picked from commit c8f4b68423)
2019-01-03 10:22:11 +01:00
Kornel Benko
36aa0526e0 lyx2lyx tests: Copy also original lyx files to temp dir
Necessary only if the lyx-file includes some data from
a relative path, nonetheless it happens in some of our tests.
2019-01-03 08:56:29 +01:00
Kornel Benko
af7dba023b Amend 7e1ecb65, add Bibliography.lyx to the set of not tested subdocuments 2019-01-02 16:35:18 +01:00
Enrico Forestieri
e65e84878f Amend [324b8287/lyxgit]
Avoid a crash by checking that a cell is not empty before
accessing its content.

No status line is needed as this amends a previous commit.
2019-01-02 09:22:56 +01:00
Juergen Spitzmueller
19b12518fe Remove *.bbl and friends when invalidating the bib info cache
This avoids errors when switching engines.

The fix is already in master. We forgot to backport.
2018-12-31 09:46:08 +01:00