Richard Kimberly Heck
7c7ea3113f
Use ranges and fix nullptr warnings.
2020-03-16 01:31:30 -04:00
Juergen Spitzmueller
b96ce9a9c1
Outliner: distinguish non-active refs from broken refs
...
See #11782
2020-03-14 16:29:53 +01:00
Juergen Spitzmueller
0f9ef6877c
Add active refs to non-active labels to brokenrefs toc
2020-03-14 15:35:47 +01:00
Juergen Spitzmueller
a1da60642c
Add outliner section for broken refs and citations
2020-03-14 15:18:28 +01:00
Juergen Spitzmueller
4ddc9e2501
Color broken citations, xrefs, and includes
...
Fixes #11503
2020-03-14 14:17:30 +01:00
Scott Kostyshak
36208d488e
Fix preview check box for include insets
...
GuiInclude::initialiseParams() calls InsetCommand::string2params()
which calls InsetCommandParams::clear(), however this last function
did not reset the special "preview_" parameter. Now this parameter
is reset to false as part of clear().
The ParamData class documents (see InsetCommandParams.h) the
following:
// No parameter may be named "preview", because that is a required
// flag for all commands.
Thus, we must handle preview_ separately from the other parameters.
This commit fixes #11779 .
2020-03-13 10:16:24 -04:00
Juergen Spitzmueller
3bd03709fd
Consider CT underlining pref in captions markup
2020-03-07 07:28:37 +01:00
Juergen Spitzmueller
5e21a8fbf7
Markup changed captions in workarea by underline and strikeout, resp.
2020-03-06 18:58:25 +01:00
Juergen Spitzmueller
f5a2d770b8
Footnote: (re-)add a fallback dummy counter
2020-03-06 18:21:18 +01:00
Juergen Spitzmueller
b8cac52759
Use real counter in deleted footnotes
2020-03-06 18:16:34 +01:00
Juergen Spitzmueller
339424ce00
Handle deleted BibTeX/Biblatex bibliographies
...
Since we cannot strike-out these, we output a placeholder when
show changes in output is active.
Fixes #11762
2020-03-06 13:49:10 +01:00
Juergen Spitzmueller
d94b708a0f
Tell updateBuffer whether an inset is deleted.
...
Fixes #11747
2020-03-06 13:23:01 +01:00
Richard Kimberly Heck
21b4ecca7f
Apparently, "requires" is a keyword in C++2a.
2020-02-28 00:28:18 -05:00
Richard Kimberly Heck
2e444dd657
Fix problem with validation when using InsetLayout.
2020-02-26 22:19:36 -05:00
Jean-Marc Lasgouttes
74540c9896
Fixup d207e85c
: paint sublabel with the correct background color
...
The above mentionned patch did paint the background of the sublabel to
avoid "bold-like" effect. However the correct backgound color is the
row's one, not the inset's one.
2020-02-24 10:41:18 +01:00
Stephan Witt
e900b61d46
Make cell index of tabular local for column loop.
2020-02-12 12:32:31 +01:00
Juergen Spitzmueller
62a2b69bb0
Remove terminating linebreak
2020-01-16 10:19:52 +01:00
Jean-Marc Lasgouttes
ba79a4b89e
Make graĥics and external insets tighter
...
Now RenderGraphics adds offsets that depends on its parent inset.
These offsets are set to 0 for InsetGraphics and InsetExternal. A nice
consequence is that icons shown by Info inset stick out less on screen.
As an unrelated change, the "private:" specifier of these two insets
is moved to a more reasonable place.
2020-01-15 16:00:02 +01:00
Jean-Marc Lasgouttes
7d3d07ff40
Fixup eeb4187a
: copy-paste errors
2020-01-15 15:19:38 +01:00
Jean-Marc Lasgouttes
eeb4187a28
Remove some spacing above InsetColapsible when possible
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
9176e60b7b
Make script inset much tighter in texted.
...
We use the fact that offsets can be set separately for each inset.
2020-01-15 11:13:54 +01:00
Jean-Marc Lasgouttes
0ef2c192c0
Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values
...
The basic value is Inset::textOffset(BufferView*), which can in theory
change with the BufferView zoom and dpi. It is hardcoded to 4 for now.
Moreover, we introduce the virtual inset methods
(top|bottom|left|right)Offset, which can be tweaked for each inset.
No change intended (for now).
2020-01-15 11:13:54 +01:00
Juergen Spitzmueller
8bd47bda8c
Improve comments
2020-01-15 08:40:51 +01:00
Juergen Spitzmueller
a940e9d709
Cross out ct-deleted tabular rows/columns in workarea
2020-01-15 08:37:35 +01:00
Juergen Spitzmueller
218731c3eb
Whitespace
2020-01-14 16:23:09 +01:00
Juergen Spitzmueller
1e5f252667
Account for bidi (swapped columns) when calculation clines
...
Fixes #11717
2020-01-14 16:15:49 +01:00
Juergen Spitzmueller
66c5d055e7
Do not output deleted rows columns if show changes in output is false
2020-01-14 13:03:12 +01:00
Jean-Marc Lasgouttes
a187cbeb64
Rename PainterMetrics::change_ to change
...
This is not a private variable.
2020-01-14 11:50:44 +01:00
Juergen Spitzmueller
b5856628f1
Set changed status for changed column/row cells in updateIndexes()
2020-01-14 10:39:42 +01:00
Juergen Spitzmueller
2a48fbbf7f
Some polishment.
2020-01-14 09:55:16 +01:00
Juergen Spitzmueller
33133733ae
Record change author and time for tracked columns/rows
...
This now uses a real change object
2020-01-14 09:28:36 +01:00
Juergen Spitzmueller
194298045c
Color lines of added/deleted rows/columns
2020-01-13 19:02:48 +01:00
Jean-Marc Lasgouttes
93794d6fea
Implement isChanged for tabular inset.
2020-01-13 16:35:15 +01:00
Jean-Marc Lasgouttes
b0371714a0
Only show pencil change mark when inset is collapsed
2020-01-13 16:35:15 +01:00
Jean-Marc Lasgouttes
e340f46476
Fixup bf7f4d71
: Let changeRefsIfUnique handle undo
...
This allows for a much lower memory consumption than a plain
recordUnfoFullBuffer.
Related to bug 6494.
2020-01-12 22:18:36 +01:00
Jean-Marc Lasgouttes
4a4ded2297
Reimplement computation of change tracking status
...
This is a reimplementation of 6d4e6aad
that is both simpler and more
complete.
This uses the updateBuffer mechanism to implement a fully working
version of Inset::isChanged(). Now the function returns true for an
inset that contains an inset that contains a change, for example.
Moverover Buffer::areChangesPresent() is merely a proxy for
Buffer::inset().isChanged().
2020-01-12 20:26:35 +01:00
Jean-Marc Lasgouttes
ce950f1ea5
Fixup b321bb1a
: set changebar when inset contains changes
...
Add Paragraph::isChanged() and InetText::isCgchanged() which indicate
the presence of a change in the relevant object.
Sets Row::needsChangebar() when adding an inset that contains changes.
Related to bug #8645 .
2020-01-12 20:26:35 +01:00
Juergen Spitzmueller
bbc6ea4a5f
Implement change tracking of column/row addition/deletion
...
Fixes #8469
File format change
2020-01-11 16:17:04 +01:00
Juergen Spitzmueller
c77999a5f3
Add buffer param to opt-out fragile content movement
...
Fixes #11714
File format change
2020-01-10 10:21:09 +01:00
Juergen Spitzmueller
79674c7632
Track changes in InsetCommands
2019-12-31 15:46:03 +01:00
Juergen Spitzmueller
affc006bae
Honor change tracking when automatically renaming refs to labels
...
Fixes rest of #11556
2019-12-31 12:29:53 +01:00
Juergen Spitzmueller
a5db5d4c90
whitespace
2019-12-30 16:28:15 +01:00
Juergen Spitzmueller
8a17cc01e0
Implement (basic) ct for tabular-feature delete-row and delete-column
...
Fixes part of #8469
For a proper fix that works with change-reject as well as with hide
changes in output, we need to implement
ct information in tabular's row and column.
2019-12-29 14:09:52 +01:00
Juergen Spitzmueller
b37b39365f
Remove obsolete FIXMEs
2019-12-29 12:07:55 +01:00
Juergen Spitzmueller
e65fdc6a51
Track change of label name
...
Fixes #11556
2019-12-29 11:01:18 +01:00
Juergen Spitzmueller
b321bb1aed
Indicate change of content in label of collapsed collapsible
...
Fixes #8645
2019-12-29 09:46:18 +01:00
Juergen Spitzmueller
89b5607e0a
Centralize code to markup deleted complex objects (with tikz) in output
...
This fixes #9293
2019-12-28 13:43:17 +01:00
Juergen Spitzmueller
da5ad1736a
Handle change-accept and change-reject in multi-cell selection
...
Fixes #8426
2019-12-27 12:05:56 +01:00
Juergen Spitzmueller
7c63896c60
CT: Mark deleted floats in output
...
Fixes #11175
2019-12-27 09:50:11 +01:00
Jean-Marc Lasgouttes
aeed6fb8fa
Do not check again and again for non existing files
...
If the file of an InsetInclude does not exist, loadIfNeeded will try
again and again to look for it. This is very bad for files with many
include insets, especially on windows.
Fixes bug #11656 .
2019-12-26 16:45:40 +01:00
Juergen Spitzmueller
e5a9d09870
Mark deleted graphics in output
...
Fixes #11687
2019-12-26 07:15:37 +01:00
Scott Kostyshak
79787c2274
Correct typo in method name getDescendants()
...
When used as an adjective, both variants "descendent" and
"descendant" are acceptable, but when used as a noun only
"descendant" should be used.
For a reference, see here:
https://en.wiktionary.org/wiki/descendent#Noun
2019-12-15 23:36:17 -05:00
Scott Kostyshak
989a49f377
Remove execute permission from two source files
2019-12-15 23:32:29 -05:00
Scott Kostyshak
f1accdebf3
Refresh previews on branch toggle
...
We only referesh previews if the branch that is toggled exists in a
descendant. This code could be further optimized, as noted in the
comments.
For relevant discussion, see the following ML thread:
https://www.mail-archive.com/search?l=mid&q=20191209022030.d6gyy3abdectr3yz%40tallinn
2019-12-11 11:48:56 -05:00
Scott Kostyshak
c61472303e
Fix crash due to encoding issues with child doc
...
This crash occurred starting with 553bebc3
, and can be triggered
when preview is enabled both in preferences and in a child document
inset. For a minimal example, see the following ML thread:
https://www.mail-archive.com/search?l=mid&q=20191209002609.6fao3dljtf3ohl25%40tallinn
This fix restores behavior to before that commit for the case when
oldEnc is 0.
2019-12-10 09:17:49 -05:00
Jean-Marc Lasgouttes
5ac3b88007
Disable inset-dissolve in table cells
...
This is better than making sure that the inset has exactly one cell.
In the future, inset-dissolve could be extended to dissolve all the
cells contents in the enclosing text.
Note that this check does not appear in mathed, and using dissolve in
e.g. fraction inset may lead to data loss (only current cell contents
is preserved).
2019-12-06 09:54:43 +01:00
Pavel Sanda
88ff1686bc
typo
2019-11-21 17:13:47 +01:00
Pavel Sanda
ae16abf57a
Reduce number of strings (the same one in buffer).
2019-11-21 17:11:09 +01:00
Juergen Spitzmueller
1a1adbc821
Handle paragraph direction switch in captions (with polyglossia/bidi)
2019-11-19 13:45:35 +01:00
Juergen Spitzmueller
967158c054
Always use local font switches in table cells.
2019-11-17 11:07:18 +01:00
Juergen Spitzmueller
3c0e0f8a29
Polish warning
2019-10-26 09:10:40 +02:00
Juergen Spitzmueller
1c0572f1ab
Validate if graphics path is encodable
...
Fixes #11688
2019-10-26 08:33:51 +02:00
Jean-Marc Lasgouttes
912704511b
Make some constructors explicit
...
Spotted by cppcheck.
2019-09-17 23:15:09 +02:00
Jean-Marc Lasgouttes
3fffa6eb83
Fix cut-n-paste error
...
Spotted by cppcheck.
2019-09-16 00:47:47 +02:00
Jean-Marc Lasgouttes
3aba81cf6a
Many small code cleanups suggested by cppcheck
2019-09-16 00:45:20 +02:00
Jean-Marc Lasgouttes
7c1891e0b4
Remove unused private members.
...
Spotted by cppcheck.
2019-09-16 00:17:08 +02:00
Jean-Marc Lasgouttes
714113655a
Follow some of the performance advice from cppcheck
...
Most of that is changing string to string const &.
2019-09-13 16:23:49 +02:00
Richard Kimberly Heck
e71280221f
Fix nullptr warnings
2019-09-11 22:13:25 -04:00
Richard Kimberly Heck
05a446b77c
Fix bug #11636 .
...
Directories are created when files are copied, so we do not need
to do it prospectively here.
2019-09-11 20:54:42 -04:00
Richard Kimberly Heck
a20f3a0d52
Revert last two commits, which we pushed accidentally.
2019-09-11 20:47:07 -04:00
Richard Kimberly Heck
1fb308cd02
Whoops, forgot this part
2019-09-11 20:30:31 -04:00
Richard Kimberly Heck
26813996e2
Constify, largely for debugging purposes
2019-09-11 20:29:58 -04:00
Jean-Marc Lasgouttes
7c1c50d737
Enable dissolve in undefined Flex inset context menu
...
This is a hackish special case, so I had to add a hack...
Fixes bug #8650 .
2019-09-11 15:49:50 +02:00
Juergen Spitzmueller
cc3e227cba
Properly terminate command
2019-08-19 07:30:06 +02:00
Juergen Spitzmueller
7ca267e1fe
Fix coloured boxes in RTL with [pdf]latex ( #8642 )
2019-08-15 16:21:13 +02:00
Juergen Spitzmueller
4e74dd0d42
Fix greyedout note in RTL ( #8647 )
...
More complicated than I wished for, but color handling in RTL is
particularly tricky.
The three versions are needed due to the differences between [pdf]latex,
xetex, luatex/luabidi and luatex/babel.
2019-08-15 15:15:59 +02:00
Juergen Spitzmueller
2746fdf7dd
Correct ^ catcode for \cprotect
2019-08-14 18:32:34 +02:00
Juergen Spitzmueller
4b0069860c
InsetGraphics: use totalheight for height output
...
Graphics "height" is only the height above the baseline and thus not
what most people will expect. Also, using height can result in a
division by zero with rotation.
Use totalheight now since this means "height of the figure" (independent
of the baseline).
The custom options field can be used if height is really desired.
We handle this in conversion/reversion, respectively, so document
output will not change.
Hence, file format change.
Fixes : #9676
2019-08-14 16:55:43 +02:00
Juergen Spitzmueller
1929caf4b7
Re-fix #2005
...
Loading keyval does not work any longer. Fix it properly by de-activating
the equal character locally if graphics options use it.
2019-08-14 14:49:38 +02:00
Juergen Spitzmueller
f995fba310
Fix cprotect with Slovak
...
babel-slovak makes ^ active, though cprotect relies on it being
catcode 9 ("ignored"). Thus we locally change the catcode with Slovak.
2019-08-14 14:00:29 +02:00
Juergen Spitzmueller
ce447e1760
Deactivate active - in tables with \cline or \cmidrule
...
This introduces a new languages tag ActiveChar which also can be used
for similar cases.
2019-08-14 13:10:42 +02:00
Juergen Spitzmueller
28b126b100
Fix cline/cmidrule calculation once more
2019-08-14 11:25:31 +02:00
Juergen Spitzmueller
5621c12135
fix midrule calculation
2019-08-13 19:29:39 +02:00
Juergen Spitzmueller
b4e871e9ca
Fix comment
2019-08-11 08:21:33 +02:00
Juergen Spitzmueller
cce9adc185
Force LTR for numeric citations
...
Fixes : #3005
2019-08-11 08:15:57 +02:00
Juergen Spitzmueller
1386a3d8fd
Allow for multiple use of same key in qualified citation lists
...
File format change
Fixes : #11618 , #11632
2019-08-07 13:00:29 +02:00
Juergen Spitzmueller
231b36d950
Fix text direction of references with XeTeX/bidi
...
Fixes : #11626
2019-08-05 16:30:01 +02:00
Pavel Sanda
a6634f5bb3
git VCS: add support for short hashes in inset info ("Abbreviated revision").
...
Fixes bug #11620 .
Patch from Joel Kulesza.
2019-07-28 22:01:17 +02:00
Juergen Spitzmueller
b852df91bc
Localize the default decimal separator
...
Do not blindly use (English) "." as default, but the locale default of
the current context language.
Fixes : #7204
2019-07-22 08:05:28 +02:00
Jean-Marc Lasgouttes
c293be56bd
Rename frontend qt4 to qt
...
In particular, the directory frontends/qt4 is renamed to frontends/qt.
Many configurations file have to be updated. All mentions of qt4 in
the source have been audited, and changed to qt if necessary.
The only part that has not been updated is the CMake build system.
2019-07-20 23:39:40 +02:00
Juergen Spitzmueller
2b432ecb3a
Revert "Fix bug #11616 "
...
This reverts commit 2890b99a76
.
A real fix follows in a minute
2019-07-18 17:04:18 +02:00
Enrico Forestieri
2890b99a76
Fix bug #11616
...
Do not care about branches when no package language is used.
2019-07-17 21:30:24 +02:00
Richard Kimberly Heck
6960bab65c
Fix bug #11612 .
...
Register verbatim includes with the outliner.
2019-07-11 16:21:38 -04:00
Richard Kimberly Heck
83afe8aa19
Shorten labels.
2019-07-11 16:21:38 -04:00
Juergen Spitzmueller
04bd57a86a
Factor out test for bidi package (= XeTeX + polyglossia)
2019-07-11 10:31:10 +02:00
Juergen Spitzmueller
6f8db58778
LuaTeX (luabidi) does not swap table columns
...
This amends [21b347a2f8485/lyxgit].
2019-07-10 22:57:34 +02:00
Juergen Spitzmueller
623f7b4795
Truncate long citation label in the middle rather than the end.
...
Fixes : #10769
2019-07-09 14:48:11 +02:00
Juergen Spitzmueller
13b6632228
Add TextClass option BibInToc
...
Fixes #1889
2019-07-08 15:40:17 +02:00
Jean-Marc Lasgouttes
2b1515a936
Rename LM_ST_* to *_STYLE and FONT_SIZE_* to *_SIZE
...
This makes code more uniform. This is typically something that is done
at end of cycle to limit backport issues later.
2019-06-14 17:05:49 +02:00
Juergen Spitzmueller
c7efb677f8
New InsetLayout tag ParbreakIgnored
...
This effectively allow paragraph breaks in insets only for cosmetic
reasons (e.g., to align contents on different lines).
This is the last change necessary for an enhanced covington gloss support
(which uses the new covington gloss ui)
2019-06-02 18:16:30 +02:00