lyx_mirror/src/frontends/qt4
André Pönitz f4137a058e cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24335 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-18 20:45:21 +00:00
..
ui Embedding: remove embedding checkbox from Graphics, Include and External dialogs 2008-04-17 18:09:44 +00:00
Action.cpp * remove the need of an active GuiView 2008-03-14 16:33:16 +00:00
Action.h * remove the need of an active GuiView 2008-03-14 16:33:16 +00:00
BulletsModule.cpp
BulletsModule.h
ButtonController.cpp header cleanup 2008-02-18 07:14:42 +00:00
ButtonController.h Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
ButtonPolicy.cpp Silent a console warning, fixes http://bugzilla.lyx.org/show_bug.cgi?id=4667 2008-03-29 23:12:24 +00:00
ButtonPolicy.h
ColorCache.cpp
ColorCache.h
CustomizedWidgets.cpp more compile fixes 2008-02-18 09:55:14 +00:00
CustomizedWidgets.h
Dialog.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
Dialog.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
DialogView.h do what the FIXME suggested 2008-03-05 20:11:47 +00:00
DockView.h do what the FIXME suggested 2008-03-05 20:11:47 +00:00
EmptyTable.cpp
EmptyTable.h
FileDialog.cpp s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
FileDialog.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
FloatPlacement.cpp
FloatPlacement.h
GuiAbout.cpp * Some work was done in 2007 and 2008 which should deserve a copyright, no? 2008-03-14 23:32:34 +00:00
GuiAbout.h
GuiAlert.cpp disable annoying debug messages 2008-02-22 10:30:46 +00:00
GuiApplication.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiApplication.h simpliofy {Gui}FontLoader architecture a bit 2008-03-20 00:00:53 +00:00
GuiBibitem.cpp Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBibitem.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBibtex.cpp Return the right params[embed] from GuiBibtex.cpp, for safety reasons 2008-03-29 23:28:49 +00:00
GuiBibtex.h less string conversions as long as we stay in the frontend 2008-03-08 07:59:47 +00:00
GuiBox.cpp * src/frontends/qt4/GuiBox.cpp: 2008-04-04 13:33:52 +00:00
GuiBox.h remove InsetBoxMailer. 2008-03-27 07:26:37 +00:00
GuiBranch.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiBranch.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiBranches.cpp
GuiBranches.h
GuiChanges.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiChanges.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiCharacter.cpp less string conversions as long as we stay in the frontend 2008-03-08 07:59:47 +00:00
GuiCharacter.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
GuiCitation.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiCitation.h cosmetics/#include cleanup 2008-03-15 00:22:54 +00:00
GuiClipboard.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiClipboard.h * Support for graphics pasting (with most code in the frontend's GuiClipboard) 2008-02-03 10:43:03 +00:00
GuiCommandBuffer.cpp * completion infrastructure 2008-02-21 19:42:34 +00:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompleter.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiCompleter.h * even setModel can trigger focus events. So move also those into 2008-03-04 12:44:48 +00:00
GuiDelimiter.cpp simpliofy {Gui}FontLoader architecture a bit 2008-03-20 00:00:53 +00:00
GuiDelimiter.h
GuiDialog.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiDialog.h do what the FIXME suggested 2008-03-05 20:11:47 +00:00
GuiDocument.cpp Give us some useful tooltips for modules. 2008-04-17 03:27:20 +00:00
GuiDocument.h Give us some useful tooltips for modules. 2008-04-17 03:27:20 +00:00
GuiErrorList.cpp more compile fixes 2008-02-18 09:55:14 +00:00
GuiErrorList.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiERT.cpp this feels more natural... 2008-03-27 23:37:59 +00:00
GuiERT.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiExternal.cpp cosmetics 2008-04-18 20:14:20 +00:00
GuiExternal.h cosmetics 2008-04-18 20:45:21 +00:00
GuiFloat.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiFloat.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiFontLoader.h cleanup/compile fix 2008-03-20 00:19:10 +00:00
GuiFontMetrics.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiFontMetrics.h
GuiGraphics.cpp cosmetics 2008-04-18 19:17:11 +00:00
GuiGraphics.h cosmetics 2008-04-18 18:53:43 +00:00
GuiGraphicsUi.h
GuiHSpace.cpp * some UI clarification on \enspace vs. \enskip 2008-04-01 14:53:29 +00:00
GuiHSpace.h ** add support for protected horizontal fill. FILE FORMAT CHANGE. ** 2008-03-18 12:11:28 +00:00
GuiHyperlink.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiHyperlink.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiIdListModel.cpp Add an assertion so we don't see that bug again. 2008-04-17 13:15:27 +00:00
GuiIdListModel.h Fix a bug noticed by Stefan: that the module UI was broken. The problem was introduced at r23981. The data() and setData() methods must be kept in sync. 2008-04-17 02:43:57 +00:00
GuiImage.cpp
GuiImage.h
GuiInclude.cpp Embedding: disinfect GuiInclude.cpp, GuiExternal.cpp, and GuiGraphics.cpp 2008-04-17 18:19:17 +00:00
GuiInclude.h more of that 2008-03-06 00:07:19 +00:00
GuiKeySymbol.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiKeySymbol.h
GuiLabel.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiLabel.h header cleanup 2008-02-17 20:47:04 +00:00
GuiListings.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiListings.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiLog.cpp next try... 2008-04-02 23:06:22 +00:00
GuiLog.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiMath.cpp s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
GuiMath.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
GuiMathMatrix.cpp Factorize out the way window titles are handled. 2008-02-05 12:43:19 +00:00
GuiMathMatrix.h
GuiNomencl.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiNomencl.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiNote.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiNote.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiPainter.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiPainter.h
GuiParagraph.cpp cosmetics 2008-04-18 20:45:21 +00:00
GuiParagraph.h cosmetics 2008-04-18 20:45:21 +00:00
GuiPrefs.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiPrefs.h * src/frontends/qt4/GuiPrefs.{cpp,h}: 2008-03-19 13:11:14 +00:00
GuiPrint.cpp less string conversions as long as we stay in the frontend 2008-03-08 07:59:47 +00:00
GuiPrint.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
GuiRef.cpp Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiRef.h
GuiSearch.cpp Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=4194 . 2008-03-12 16:17:25 +00:00
GuiSearch.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSelection.cpp header cleanup 2008-02-18 07:14:42 +00:00
GuiSelection.h
GuiSelectionManager.cpp
GuiSelectionManager.h
GuiSendto.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiSendto.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
GuiSetBorder.cpp
GuiSetBorder.h
GuiShowFile.cpp a few more docstring<->QString conversions 2008-03-05 23:10:53 +00:00
GuiShowFile.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSpellchecker.cpp * getSpeller create a new speller, so call it create* 2008-03-16 17:06:26 +00:00
GuiSpellchecker.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiSymbols.cpp cosmetics 2008-03-23 13:59:51 +00:00
GuiSymbols.h improved position caching 2008-03-21 20:47:29 +00:00
GuiTabular.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiTabular.h Free line setting in tabulars. FILE FORMAT CHANGE. 2008-03-18 18:08:32 +00:00
GuiTabularCreate.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiTabularCreate.h s/kb_action/FuncCode/g 2008-03-15 01:20:36 +00:00
GuiTexinfo.cpp ...and clean up headers 2008-03-08 21:55:03 +00:00
GuiTexinfo.h less string conversions as long as we stay in the frontend 2008-03-08 07:59:47 +00:00
GuiThesaurus.cpp header cleanup 2008-02-17 20:47:04 +00:00
GuiThesaurus.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiToc.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiToc.h frontend cosmetics 2008-03-06 19:39:52 +00:00
GuiToolbar.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiToolbar.h * copy icon size to new GuiView from the last GuiView 2008-03-14 16:39:34 +00:00
GuiToolbars.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiToolbars.h Remove TextClassPtr without losing the type safety it provided. 2008-02-28 01:42:02 +00:00
GuiView.cpp fix leak in the undo stack 2008-04-16 22:02:26 +00:00
GuiView.h * on Mac close GuiView when the last tab was closed 2008-03-14 23:24:59 +00:00
GuiViewSource.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
GuiViewSource.h
GuiVSpace.cpp remove InsetVSpaceMailer class 2008-03-27 00:21:35 +00:00
GuiVSpace.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
GuiWorkArea.cpp Fix recursive repaint. QSlider::setRange() didn't used to trigger valueChanged() signal before to Qt4.4. 2008-04-18 11:38:02 +00:00
GuiWorkArea.h A hack to prevents an additional redraw when the scrollbar pops up 2008-04-06 11:52:11 +00:00
GuiWrap.cpp remove InsetWrapMailer class 2008-03-27 00:07:54 +00:00
GuiWrap.h Factorize closeEvent() for GuiDialog based dialogs. 2008-02-17 20:16:14 +00:00
IconPalette.cpp
IconPalette.h
InsertTableWidget.cpp
InsertTableWidget.h
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LengthCombo.cpp
LengthCombo.h
LyXFileDialog.cpp a few more docstring<->QString conversions 2008-03-05 23:10:53 +00:00
LyXFileDialog.h a few more docstring<->QString conversions 2008-03-05 23:10:53 +00:00
Makefile.am Next make dist shot. 2008-03-21 17:31:14 +00:00
Menus.cpp InsetInfo: tidy up error messages, fix an obvious bug in menus.cpp that breaks "info-insert menu name" 2008-04-18 16:26:24 +00:00
Menus.h fix some memory leaks 2008-04-16 19:43:06 +00:00
PanelStack.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
PanelStack.h * src/frontends/qt4/PanelStack.{cpp, h}: 2008-03-19 18:15:16 +00:00
pch.h
qt_helpers.cpp more fixes (correct filename, and repair view file) 2008-03-08 09:54:48 +00:00
qt_helpers.h less string conversions as long as we stay in the frontend 2008-03-08 07:59:47 +00:00
README
TocModel.cpp infrastructure for 'graceful asserts' 2008-04-10 21:49:34 +00:00
TocModel.h cosmetics 2008-03-26 22:25:43 +00:00
TocWidget.cpp frontend cosmetics 2008-03-06 19:39:52 +00:00
TocWidget.h Comments from Andre'. 2008-03-04 21:45:54 +00:00
Validator.cpp
Validator.h

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.