Commit Graph

8873 Commits

Author SHA1 Message Date
Günter Milde
8e825de4b2 Fix preamble-code removal in lyx2lyx. Do some optimizations.
Fix failure of revert_dashes() found by lyx2lyx ctests
using an efficient function to find a given sequence of lines
in a list of lines.

Some optimizations using Python idioms instead of C-like code.
2018-01-21 19:55:27 +01:00
Uwe Stöhr
1450b99ed1 UserGuide.lyx: correct an equation
thanks Yuriy for spotting
2018-01-19 01:02:25 +01:00
Uwe Stöhr
98cfc25277 ru.po: updates from Yuriy
- also some updates for Tutorial.lyx
2018-01-19 00:31:47 +01:00
Günter Milde
9ce5d8578b Prevent rows of hyphens becoming dashes when back-porting to 2.1.
Insert ligature breaks between hyphens where
they are separate in 2.2 but ligated by TeX in 2.1.

This fixes output with LyX 2.1 and prevents -- and --- becoming
en and em dash in the LyX source after a round-trip to 2.1
and back.

Solves lyx2lyx ctest failures with a warning about
possible line-break changes.
2018-01-17 21:39:03 +01:00
Uwe Stöhr
1d81e098a3 French example files: port recent changes to master 2018-01-17 15:58:07 +01:00
Kornel Benko
d794a6d60d Add testfiles-references to automake build: vcs_info_export moved to new directory, part 4 2018-01-17 15:31:57 +01:00
Kornel Benko
26eeaa1af2 vcs_info_export moved to new directory, part 2 2018-01-17 12:25:22 +01:00
Günter Milde
6fe2e45f97 Remove trailing whitespace in lyx2lyx. 2018-01-17 09:48:08 +01:00
Uwe Stöhr
58121e887a example files: distribute some changes
- French:
 - fix compilation of beamer.lyx
 - update a screenshot
2018-01-16 14:50:25 +01:00
Uwe Stöhr
5f93099b88 EmbeddedObjects.lyx: fix a typo spotted by Paul Rubin
fixes #10965
2018-01-16 04:45:44 +01:00
Uwe Stöhr
53188a5f47 doc files: correct preamble commands
thanks toe Jean-Pierre
2018-01-16 04:08:52 +01:00
Scott Kostyshak
baefa82a81 Restore 3c6fa867 and b83252b1
This restores the https URLs.
2018-01-15 16:51:35 -05:00
Scott Kostyshak
a816ef9c33 Restore math options to "load automatically" 2018-01-15 16:51:35 -05:00
Scott Kostyshak
caa6602a15 Restore \origin 2018-01-15 16:51:35 -05:00
Scott Kostyshak
ef9a05dede Big changes to ja/sweave/lyx and ja/knitr.lyx
- Use bxjsarticle + XeLaTeX instead of article + pLaTeX.
- Use LyX's "chunk" inset instead of ERT.
- Translate a couple of English strings.

Patch from Koji Yokota.
2018-01-15 16:51:35 -05:00
Pavel Sanda
3a57f9766c * layouttranslations.review
wa never used, da forgotten, en not needed.
2018-01-14 14:33:38 +01:00
Pavel Sanda
f50e980a40 * layouttranslation.review: pt reviewed by Jose.
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg203376.html
2018-01-14 14:03:55 +01:00
Kornel Benko
aed458f007 Cmake tests: New test for the outliner with beamer
Test idea from Pavel Šanda
Move insets down and up, then compare with expected latex output.
2018-01-14 13:47:27 +01:00
Uwe Stöhr
058ee9ab00 UserGuide.lyx: distribute recent changes 2018-01-12 04:54:03 +01:00
Uwe Stöhr
92955116b0 Additional.lyx: re-sync with master
please use use LyX 2.3.x and keep the docs in sync unless you describe a new feature of LyX 2.4
2018-01-12 02:42:36 +01:00
Günter Milde
0fb2edacdc Use Flex Code inset instead of typewriter custom font style.
Change markup to use semantic markup instead of hard-coded
typewriter for code examples containing --.
Works around false positive warning on changed dashes
leading to lyx2lyx export ctest failures.
2018-01-12 00:35:00 +01:00
Juergen Spitzmueller
3daa447c3c Take AgainFrame to the TOC. 2018-01-11 13:14:16 +01:00
Günter Milde
73b6f42362 Do not convert dashes/hyphens in LyX-Code.
See previous commit and #10961
2018-01-10 12:07:36 +01:00
Günter Milde
cb1fda9988 Do not convert dashes/hyphens in Code insets (logical markup).
Code is by default rendered as typewriter and should be treated
similar:
In text marked up as code, -- or --- is typically part of a
command (e.g. "lyx --help" or "x--") and not a transliteration
for en dash, see #10961.
This is already handled so for text in typewriter font
(see Text.cpp:500).
2018-01-10 12:07:36 +01:00
Uwe Stöhr
bb650bf8c2 Changelog-Customization-LyX_23x.txt: dummy commit as text 2018-01-10 02:12:40 +01:00
Uwe Stöhr
4abe7d0181 Customization.lyx: distribute and accept recent changes 2018-01-09 01:28:26 +01:00
Uwe Stöhr
20df4da55f EmbeddedObjects.lyx: port updates and fixes from Jean-Pierre to master 2018-01-08 15:54:08 +01:00
Juergen Spitzmueller
7da8473c4f Start inset at new line 2018-01-06 10:43:44 +01:00
Juergen Spitzmueller
44670d4778 Customization: some color name fixes. 2018-01-06 09:31:24 +01:00
Juergen Spitzmueller
016393a0dd Minor re-ordering of the Insert menu 2018-01-05 11:09:11 +01:00
Günter Milde
0674abf4a0 Update UserGuide and de/UserGuide.
Remove warnings for issues fixed in lyx2lyx.
Update the GUI name of the ligature-dash Option.
Fix example for preventing unwanted line break in French.
2018-01-02 12:56:49 +01:00
Juergen Spitzmueller
8d8ee12e64 Update layout format 2018-01-02 11:53:01 +01:00
Günter Milde
5dc48f7ef9 Documentation fixes: revert conversion of -- to en dash in code.
lyx2lyx erroneousely merged -- to en dash in text with logical
markup "code".
Revealed by recent (but now silenced) ctest fails.

Also add space around en dash in examples.
2018-01-02 11:20:35 +01:00
Uwe Stöhr
69ef4bc146 Russian doc files: new and updated translations by Yuri 2018-01-01 16:56:31 +01:00
Uwe Stöhr
fd3b9cf6c6 French UserGuide.lyx: port Jean-Pierre's recent changes to master 2018-01-01 14:39:59 +01:00
Juergen Spitzmueller
8f86feb260 Prepend "Insert " in the context menu for environment separators. 2018-01-01 13:40:49 +01:00
Juergen Spitzmueller
ebc3fee728 mention new option 2018-01-01 12:41:00 +01:00
Juergen Spitzmueller
91008d8b21 LFUNS.lyx: update 2017-12-31 18:58:32 +01:00
Juergen Spitzmueller
fe698caeec Distribute UG changes following menu move of environment-split 2017-12-31 10:14:59 +01:00
Juergen Spitzmueller
b0801b43f4 Distribute auto-nest documentation. 2017-12-31 10:00:38 +01:00
Juergen Spitzmueller
cc8ce481f5 Distribute beamer manual changes in the wake of the environment-split mods. 2017-12-30 19:29:51 +01:00
Juergen Spitzmueller
c8abe0cf7b Move environment-split from Edit to Insert, as requested. 2017-12-30 17:54:09 +01:00
Juergen Spitzmueller
3a4b233dbd Properly implement IsTocCaption for Arguments in standard TOC
Fixes: #10631

Candidate for 2.3.x.
2017-12-29 11:51:24 +01:00
Juergen Spitzmueller
f3b89e4c72 Add IsAutoNestedBy
This is complementary to AutoNests: Styles can determine which other
style should auto-nest them. This is particularly useful for modules
that add new styles which should be auto-nested in a given context.
2017-12-29 10:36:03 +01:00
Juergen Spitzmueller
d6fb2abbea Some AutoNest polishment.
* Rename Nests to AutoNests
* Do it when changing from any style
2017-12-29 10:03:00 +01:00
Juergen Spitzmueller
99ecc6e2c9 Implement auto-nesting.
Now layouts can specify other layouts that should be nested in and
after the current one (if the layout is switched from the current one
and if it follows a paragraph in the current one).

This is particularly useful for things such as the beamer frames, where
particular layouts are practically always nested.
2017-12-28 17:44:54 +01:00
Juergen Spitzmueller
2907160fff Introduce environment-split previous
This one checks for an environment in the previous paragraph (outside
the nesting scope).
2017-12-28 12:28:01 +01:00
Juergen Spitzmueller
dfaa4e9466 Fix footnotes in table with RevTeX4
These classes come with their own working implementation of table
footnotes, so we are not supposed to use the tablefootnote or
footnote package.

Also add missing outliner name.
2017-12-27 15:43:40 +01:00
Juergen Spitzmueller
994176e55b Tufte title is fragile
Candidate for 2.3.x.
2017-12-26 12:35:55 +01:00
Scott Kostyshak
713fd70e8f Fix Python escaping of unicode string
When removing "r" from "ur", it is needed to add extra backslashes.
See:

  https://www.mail-archive.com/search?l=mid&q=2024193.iXIh6cq6L3%40myth

Thanks to José.

This commit amends b7983478 (and thus 586d16a4).
2017-12-26 02:10:49 -05:00
Juergen Spitzmueller
931f87f508 Introduce "inherit" encoding for latex_language
This gets rid of the hardcoded latin1 encoding for verbatim. Instead,
verbatim now inherits the encoding from the context, which is what is
actually wanted here.

Fixes: #9012, #9258
2017-12-24 17:10:42 +01:00
Pavel Sanda
61e899ac24 layouttranslation: review cs 2017-12-24 04:56:15 +01:00
Pavel Sanda
10b5f1ac50 layouttranslation: sk is clearly reviewed 2017-12-24 04:34:59 +01:00
Scott Kostyshak
b7983478e1 Fix Python unicode string in lyx2lyx
This commit amends 586d16a4.
2017-12-23 21:47:08 -05:00
Pavel Sanda
3f7e00b661 Russian layouttranslations reviewed by Yuriy, Dec 13 2017. 2017-12-24 03:08:34 +01:00
Juergen Spitzmueller
7b4d227929 Title commands are fragile in memoir 2017-12-23 13:27:10 +01:00
Richard Heck
1c7b9676b0 Release notes for LFUN_EXPORT_CANCEL. 2017-12-21 18:59:46 -05:00
Richard Heck
76214e6012 LFUN and basic code to enable cancellation of background
processes.
2017-12-21 18:55:39 -05:00
Uwe Stöhr
634f69ee23 revtex4-1.lyx: LyXify the document
- avoid unnecessary TeX code etc.
2017-12-19 15:08:10 +01:00
Günter Milde
586d16a49c Fix lyx2lyx conversion of dashes. 2017-12-19 14:10:57 +01:00
Uwe Stöhr
f746a57515 xyfigure.png: update the screenshot 2017-12-19 01:50:42 +01:00
Uwe Stöhr
80140877f6 new Arabic splash.lyx from Hatim 2017-12-18 15:26:17 +01:00
Uwe Stöhr
405bf7a366 Russian Tutorial.lyx: translations from Yuriy 2017-12-18 01:39:16 +01:00
Uwe Stöhr
72bb33422c UserGuide.lyx: distribute dash changes 2017-12-18 01:32:10 +01:00
Juergen Spitzmueller
5dca4abb09 Adapt documentation. 2017-12-17 09:20:34 +01:00
Uwe Stöhr
79bdb88d35 Russian splash.lyx: update from Yuriy 2017-12-17 03:51:22 +01:00
Uwe Stöhr
df2cddb859 Russian doc files: finished review from Yuriy 2017-12-17 03:40:02 +01:00
Uwe Stöhr
6c6cf5e071 use https:// in the first line of .lyx files
- also support to detect https via tex2lyx
2017-12-17 02:24:26 +01:00
Juergen Spitzmueller
ad093160d8 Further modifications of the "Dashes and Linebreaks" section 2017-12-16 17:35:40 +01:00
Uwe Stöhr
1f23d65f8f splash.lyx: link https://www.lyx.org/Walkthrough
It is a good idea from Yuriy to link it, especially for the languages where we don't have other docs than the splash file.
2017-12-16 14:24:17 +01:00
Uwe Stöhr
d509490f5a generate_contributions.py: review links
- use https if possible
- update links
- remove one nonexistent link
- use link to KDE's oxygen icons because these are licensed under the LGPL
2017-12-16 04:06:09 +01:00
Uwe Stöhr
28029074b2 doc, templates and example files: use https for links to lyx.org 2017-12-15 02:53:06 +01:00
Uwe Stöhr
bc4eff1e83 doc files: review of links
- correct dead links
- use https if possible
2017-12-15 02:31:36 +01:00
Uwe Stöhr
18829e8c2f chkconfig.ltx: correct sorting 2017-12-14 20:18:40 +01:00
Uwe Stöhr
a6c6e31745 UserGuide.lyx: review links
- update broken links
- use https if possible
- removed outdated section
- save LyXDocs.bib with JabRef 4
2017-12-14 18:50:56 +01:00
Uwe Stöhr
b9574fd45d example files: use https links 2017-12-14 16:39:14 +01:00
Uwe Stöhr
639d63607a Russian splash.lyx: updates from Yuriy 2017-12-14 14:50:03 +01:00
Uwe Stöhr
0c9ca34ff1 French UserGuide.lyx: port today's changes to master 2017-12-14 03:02:12 +01:00
Uwe Stöhr
ba8a80bc03 Russian Tutorial.lyx: first step to update by Yuriy 2017-12-13 21:15:27 +01:00
Juergen Spitzmueller
323549c10c generate_contributions.py: Fix for python3 2017-12-13 12:55:17 +01:00
Kornel Benko
52e5e940e2 Amend 3dcb317 2017-12-12 20:54:56 +01:00
Kornel Benko
3dcb317c39 Add menus.bind for Slovak UI. 2017-12-12 20:44:05 +01:00
Uwe Stöhr
0630546917 de.po: translate one of 3 new strings
- also update German UserGuide.lyx for consistency
2017-12-12 16:51:32 +01:00
Uwe Stöhr
a26da3268c generate_contributions.py: adding Yuriy to the CREDITS
- btw. generate_contributions.py is not yet ready for Python 3, see bug #10845
2017-12-12 15:30:28 +01:00
Uwe Stöhr
7b105a61b2 UserGuide.lyx: distribute today's changes 2017-12-12 02:25:17 +01:00
Juergen Spitzmueller
637e4d6dfa Add D. Gloger to the credits 2017-12-11 10:18:26 +01:00
Juergen Spitzmueller
480c8a52f2 Some corrections wrt dashes and line breaks 2017-12-10 12:01:17 +01:00
Uwe Stöhr
a97b792eac EmbeddedObjects.lyx: better description for rotated table cells with line breaks 2017-12-07 00:27:45 +01:00
Uwe Stöhr
824133f542 UserGuide.lyx: describe how to use hyperlinks for nomenclature
- also note that toolbar icon size can be changed
2017-12-06 19:16:17 +01:00
Kornel Benko
3d85d6da7b Missing "icon" in description of "info-insert"-function 2017-12-06 15:36:31 +01:00
Kornel Benko
7aa45eb025 Icon modified because of incompatibility to older rsvg-convert
rsvg-convert version 2.40.2 was unable to convert the previous svg-data.
2017-12-05 15:25:58 +01:00
Uwe Stöhr
9a0b3247b0 UserGuide.lyx: update description for nomenclature according to recent changes 2017-12-05 03:02:24 +01:00
Juergen Spitzmueller
0926bb6d40 Use literal formatting in nomencl entry with math 2017-12-03 11:20:11 +01:00
Juergen Spitzmueller
dee4c46b8d Remove obsoleted nomencl workarounds 2017-12-01 12:03:51 +01:00
Kornel Benko
a5e83ded24 Update sk.po 2017-12-01 11:10:38 +01:00
Juergen Spitzmueller
718a353b49 Implement l7n for nomenclature. 2017-12-01 10:10:06 +01:00
Uwe Stöhr
417b854eea UserGuide.lyx: fix 2 nomenclature entries
- also assure correct language for the nomenclature list
2017-11-30 13:20:55 +01:00
Uwe Stöhr
45e44894ce UserGuide.lyx: workaround for a bug in nomencl
see https://tex.stackexchange.com/questions/65913/why-nomenclature-text-is-not-english-when-loading-additional-languages-in-docume for an explanation why the name of the nomenclature can be incorrect.

nomencl is no longer under development since 12 years therefore we should switch to the glossaries package (#10015).
2017-11-30 00:52:17 +01:00
jpc
3e4743051e Update French Math manual for 2.3 2017-11-28 09:06:33 +01:00
Uwe Stöhr
36fba4a508 Customization.lyx: fix bug#10809
also some layout fixes to avoid writing in the page margin
2017-11-28 00:54:49 +01:00
Uwe Stöhr
71e9d3a385 EmbeddedObjects.lyx: update table with available units 2017-11-27 23:12:13 +01:00
Juergen Spitzmueller
65b44311f3 Split inkscape_cl (command line) from inkscape_gui (GUI program)
On Windows, these are two different binaries, and one fails to do the
tasks of the other. On all other OSes, the two are the same.

Fixes: #10805
2017-11-27 18:59:51 +01:00
jpc
6771b0044f A couple of editions in the French Intro manual 2017-11-27 18:12:50 +01:00
Richard Heck
0f0c5bb4b1 Fix bug #10809. 2017-11-26 22:07:28 -05:00
Uwe Stöhr
88085f380c Math: add a note about \tag with RTL languages
- also update a weblink
2017-11-27 02:43:14 +01:00
Uwe Stöhr
c77531a667 UserGuide.lyx: describe \baselineskip
-also add a Spanish translation
2017-11-27 00:26:35 +01:00
Uwe Stöhr
2585745643 UserGuide.lyx: document the Literal option
- also remove some now unnecessary bibliography entries
2017-11-26 19:22:20 +01:00
Uwe Stöhr
601ce9f21c Changelog-UserGuide-LyX_23x.txt: document recent change for the translators 2017-11-26 03:40:34 +01:00
Uwe Stöhr
1f0de77f15 UserGuide.lyx: describe the new font settings options 2017-11-26 03:36:57 +01:00
Juergen Spitzmueller
eb2dbb8b09 Assure print function compatibility in python 2.x 2017-11-24 11:56:41 +01:00
Juergen Spitzmueller
4f10c0a14b Use python3 print syntax 2017-11-23 08:16:10 +01:00
Richard Heck
32c112a07e Update makefile after change of filename. 2017-11-22 19:14:21 -05:00
Richard Heck
6137ff13d8 Revert "Uwe updated this on Windows, and it became lowercase."
This reverts commit 04bf467549.
2017-11-22 19:13:40 -05:00
Richard Heck
04bf467549 Uwe updated this on Windows, and it became lowercase. 2017-11-22 18:48:19 -05:00
Uwe Stöhr
913619c80a svg2pdftex.py: make print work with Python 2 and 3 2017-11-22 23:26:58 +01:00
Juergen Spitzmueller
14df9b74c4 Remove more lower-level dependencies 2017-11-22 16:45:13 +01:00
Juergen Spitzmueller
13d684fd3c Add a note about dependency declarations in layouts/modules 2017-11-22 16:42:33 +01:00
Kornel Benko
403a4981ee Restore uk/Intro.lyx and renaming due to windows ignoring capitalization instead 2017-11-22 11:17:55 +01:00
Juergen Spitzmueller
1400144a8a Remove grandchild-level dependencies.
We agreed to only check for top-level dependencies, see
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg195679.html

This reverts 30475b4b0.
2017-11-22 08:33:09 +01:00
Uwe Stöhr
5313fd1f3d Ukrainian Footnote.png: update image 2017-11-21 23:20:31 +01:00
Kornel Benko
b7a1848775 Use existing graphic paths only, uk/Intro.lyx 2017-11-21 22:09:53 +01:00
Uwe Stöhr
bfcb9cc85a acmart.layout: fix a dependency
for the discussion about the dependencies see bug #10806
2017-11-21 22:02:00 +01:00
Uwe Stöhr
76a3842271 doc files: port today's changes to master 2017-11-20 23:48:44 +01:00
Kornel Benko
37d0b3f066 Use existing graphic paths only 2017-11-20 12:57:02 +01:00
Uwe Stöhr
9135eab226 template files: save them all with LyX 2.3RC1 2017-11-20 02:33:28 +01:00
Uwe Stöhr
b7a6b0a596 varwidth-floats-side-by-side.lyx: use PDF images 2017-11-20 02:31:00 +01:00
Uwe Stöhr
a9254fdf03 apa6.layout: add dependencies
should go in for LyX 2.3.1
2017-11-20 02:29:45 +01:00
Uwe Stöhr
30475b4b0b acmart.layout: add dependencies
should go in for LyX 2.3.1
2017-11-20 02:29:19 +01:00
Uwe Stöhr
0bf202f1ab chkconfig.ltx: add 3 required packages
- the l3 packages are required by more and more packages. Here with a fresh MiKTeX installation I cannot even compile the UserGuide without the l3 packages.

should also go in for LyX 2.3.1
2017-11-19 16:07:08 +01:00
Uwe Stöhr
f6bee7ec8b beamer.layout: add 3 dependencies
both are required according to the beamer.cls

candidate for LyX 2.3.1
2017-11-19 15:48:02 +01:00
Juergen Spitzmueller
5017a0a1c6 Allow footnotes in floating tables via tablefootnote package
See #808.
2017-11-19 12:56:40 +01:00
Juergen Spitzmueller
3affde3957 Fix footnote output in tables outside floats and longtable header/footer
Fixes: #808 (sic!), #5869
2017-11-19 10:41:17 +01:00
Uwe Stöhr
c21c07e027 doc files: save them with LyX 2.3 - part 2 2017-11-19 02:21:30 +01:00
Uwe Stöhr
879611b915 doc files: save them with LyX 2.3 - part 1 2017-11-19 01:55:05 +01:00
Uwe Stöhr
f59c2ea140 Math.lyx: correct a term 2017-11-19 01:37:22 +01:00
Uwe Stöhr
8339e6a09d Catalan mathed.lyx: move outdated file to attic/ca/mathed.lyx
(Besides that it is outdated, we already have all its info in the Spanish math manual and all Catalans understand Spanish.)
2017-11-19 01:30:09 +01:00
Uwe Stöhr
e5dc5f9680 Math.lyx: update the section about subequations.lyx
- an extra example file is not necessary since we already describe subequations in the math manual
2017-11-19 00:53:10 +01:00
Uwe Stöhr
e26a6c8b34 R-S-statements.lyx: move to attic/R-S-statements.lyx
RS statements are deprecated since 2015. Their replacement are the HP statements for which LyX has an example file since LyX 2.2.
2017-11-18 18:16:08 +01:00
Uwe Stöhr
d52bb81671 example files: save them with LyX 2.3 - part 3/
also some minor adjustment to some files like date and version
2017-11-18 18:04:57 +01:00
Uwe Stöhr
a32e45ca37 Slovakian splash.lyx: Revert
this file version was no in the 2.3.x tree. Please use the 2.3.x tree for the up to date docs unless you are describing new features only available in master

This partly reverts commit 828286d313.
2017-11-18 17:58:28 +01:00
Uwe Stöhr
828286d313 example files: save them with LyX 2.3 - part 2
also some minor adjustment to some files like date and version
2017-11-18 17:50:23 +01:00
Uwe Stöhr
618a1cbfc8 example files: save them with LyX 2.3 - part 1
also some minor adjustment to some files like date and version
2017-11-18 17:34:35 +01:00
Uwe Stöhr
2ed7cc3489 example files: suppress date on title page for cases where this is misleading 2017-11-18 17:21:46 +01:00
Uwe Stöhr
4335c76885 lilypond.lyx: remove version info
The LyX version is not necessary
2017-11-18 17:21:13 +01:00
Uwe Stöhr
6dc2763841 Literate.lyx: remove unnecessary TeX code 2017-11-18 17:20:12 +01:00
Uwe Stöhr
b036fcbe8e xypic.lyx: don't output the date in the first page 2017-11-18 17:04:06 +01:00
Uwe Stöhr
146e826081 beamer.lyx: use a PDF image and update version 2017-11-18 17:03:10 +01:00
Uwe Stöhr
39a81fd864 Math.lyx: update version number 2017-11-13 23:16:46 +01:00
Uwe Stöhr
b1b87d0aa6 EmbeddedObjects.lyx: update version number 2017-11-07 21:52:50 +01:00
Juergen Spitzmueller
731c9fb401 configure.py: read layout and module files in binary mode
This prevents encoding issues with Python3 that manifested for a user
on the Mac.

Fixes: #10671
2017-11-04 10:41:22 +01:00