Commit Graph

39616 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
5c1d65afee Fix drawing of labels in insets
In many cases, the origin xo_ of insets was forgotten.

Fixes bug #11425.
2019-01-04 17:06:49 +01:00
Juergen Spitzmueller
c65b146d86 Revert "ctests: invert JSS-article lyx2lyx tests"
This reverts commit 5ad0395dca.
2019-01-04 16:37:57 +01:00
Juergen Spitzmueller
348b3e5e49 rewrite revert_jss reversion routine
Fixes: #11448
2019-01-04 16:36:11 +01:00
Jean-Marc Lasgouttes
a69e01d0b4 Avoid crash when using inset-select-all in tabular
When changing cell idx, it is important to set the pit to a reasonable
value.
2019-01-04 13:57:13 +01:00
Jean-Marc Lasgouttes
f97c11f4e9 Remove unused mathod (CursorSlice::at_cell_end is the same) 2019-01-04 13:55:57 +01:00
Juergen Spitzmueller
35534231d4 Always update bibfiles cache with bibliography environment before opening citation dialog
We need to do this unconditionally, since there is no (trivial and non-
awkward) way to update it when the bibliography paragraphs are modified.

Fixes: #4899
2019-01-04 13:01:03 +01:00
Kornel Benko
21254cd962 lyx2lyx tests: Add conversions to lyx23 2019-01-04 05:58:56 +01:00
Scott Kostyshak
5ad0395dca ctests: invert JSS-article lyx2lyx tests
The regression has been reported at #11448.
2019-01-03 23:32:41 -05:00
Kornel Benko
7568571a24 lyx2lyx tests: Use the temp-dir also for converted lyx files
Important if including data previously copied there.
Fixes test "export/doc/Additional_lyx22"
2019-01-04 05:21:07 +01:00
Scott Kostyshak
3ac2dd8e6c Bibliography.lyx: add a reference so it compiles 2019-01-03 22:27:22 -05:00
Scott Kostyshak
67f5a5173a Fix compilation of chess-article.lyx with TL 2018
Consistent with 32b77f1a.
2019-01-03 21:10:43 -05:00
Richard Kimberly Heck
ba8cf1a50b Also pay attention to OutputParams::free_spacing. 2019-01-03 19:16:48 -05:00
Richard Kimberly Heck
6135824f40 Fix bug #11432.
Take account of Layout::free_spacing.
2019-01-03 19:13:43 -05:00
Jean-Marc Lasgouttes
d8498d4785 Fix vertical offset of fonts like MinionPro
For some reason, adding a LTR/RTL Override unicode character before a
MinionPro string increases the ascent of the line.

This creates vertical offset issues when painting if the ascent used
as reference is the one of the font. Use the QTextLine ascent instead
for better results.

This is a followup to 1bed76e2a.

Fixes (reopened) ticket #11284.
2019-01-03 12:19:47 +01:00
Juergen Spitzmueller
62f8b8beb9 Update tex2lyx tests 2019-01-03 12:00:23 +01:00
Juergen Spitzmueller
4ebb91194a Fixed remaining glitches in tcolorbox reversion routines
The indexes were off at several places, which made the routines leak.
2019-01-03 10:12:14 +01:00
Kornel Benko
eec3d1eb20 lyx2lyx tests: Copy also original lyx files to temp dir
Necessary only if the lyx-file includes some data from
a relative path, nonetheless it happens in some of our tests.
2019-01-03 08:46:26 +01:00
Scott Kostyshak
051eaeec8a maa-monthly.layout: declare dep maa-monthly.sty 2019-01-02 19:56:18 -05:00
Scott Kostyshak
8c266ee28d ctests: restore thesis.lyx lyx2lyx tests
These tests failed because of (multiple instances of) the following
warning:

  Warning: a buffer should not have two parents!

This warning is expected, because, for example, chapter-1 includes
Bibliography.lyx and chapter-2 includes Bibliography.lyx. thesis.lyx
includes both chapter-1 and chapter-2, so both are loaded (but
hidden), and Bibliography.lyx is loaded (but hidden), and LyX then
sees that more than one buffer includes Bibliography.lyx

The consequence of ignoring this warning is that we will not catch
any future regression that triggers this warning when it should not.
2019-01-02 14:12:17 -05:00
Scott Kostyshak
32b77f1ad2 Fix compilation of chessgame.lyx with only TL 2018
chess-workshop-symbols.sty is no longer (on an updated TL 2018)
included in the TL package "skak". This commit replaces the loading
of chess-workshop-symbols in the custom preamble with the loading of
the package chessfss.

chessfss is in TL 2016 and TL 2018, and the example file now
compiles with both TL installations.

Before this commit, compilation of chessgame.lyx was possible if
chess-workshop-symbols.sty were installed manually (i.e., outside of
TL), but it is preferred to keep dependencies to only TL if
possible.
2019-01-02 14:02:03 -05:00
Jean-Marc Lasgouttes
c8f4b68423 Add override statements to please clang
Eventually, all overridden virtual methods should be marked properly.
Currently, clang only warns about those in classes that already use
override in at least one place (which was the case dor GuiApplication).
2019-01-02 18:49:23 +01:00
Jean-Marc Lasgouttes
fba9f5b9e8 Remove premature (and bad) optimization
When blinking the caret, it looks like a cool idea to only update the
small rectangle containing the caret. Actually it is an awful idea, since
the paint event will paint some rows, and these rows will not be
properly painted outside of the small rectangle. Unfortunately, the
painter will skip those "painted" rows on next paint events.

This leads to painting errors that depend on the ordering of "real"
and "caret" paint events. This is the reason why they only appeared
with split screens.

Quote of the day: ``The real problem is that programmers have spent far
too much time worrying about efficiency in the wrong places and at the
wrong times; premature optimization is the root of all evil (or at
least most of it) in programming.''
-- Donald Knuth, The Art of Computer Programming.

Fixes bug #11354.
2019-01-02 18:36:02 +01:00
Kornel Benko
8d927de5ee Amend 12aaeb25, add Bibliography.lyx to the set of not tested subdocuments 2019-01-02 16:32:24 +01:00
Juergen Spitzmueller
25451bc252 fix tcolorbox reversion routines 2019-01-02 15:37:48 +01:00
Enrico Forestieri
9755371729 Fix conversion of math braces to html 2019-01-02 09:49:59 +01:00
Juergen Spitzmueller
8f332f4429 Fix Include dialog UI
#11443
2019-01-02 09:19:45 +01:00
Enrico Forestieri
b3cba2a09c Amend [2dcb7300/lyxgit]
Avoid a crash by checking that a cell is not empty before
accessing its content.
2019-01-02 09:08:39 +01:00
Juergen Spitzmueller
71dfcb18b9 Fis some old box reversion routines. 2019-01-01 16:34:15 +01:00
Juergen Spitzmueller
1db5abbfbd Mark labels in non-outputting insets as inactive.
Fixes: #11437
2018-12-31 18:32:38 +01:00
Juergen Spitzmueller
e61c60fae8 Add inactive labels to the toc
It makes sense to navigate to them.

They are marked as inactive with the cross.
2018-12-31 18:30:20 +01:00
Juergen Spitzmueller
54366c38ef Fix gotoLabel with inactive labels
This now frist looks for the active label. Only if none is found, it
jumps to the (first) inactive label.
2018-12-31 18:28:44 +01:00
Juergen Spitzmueller
5afacb144d Separate LabelCache from RefCache
We only assign references to label _string_. Which inset this corresponds
to will be decided in context.
2018-12-31 18:27:34 +01:00
Juergen Spitzmueller
48c6d5de21 typo 2018-12-31 14:19:06 +01:00
Juergen Spitzmueller
5cfd256974 When checking inset activity status, also check containing insets
which could be deteled
2018-12-30 18:27:28 +01:00
Juergen Spitzmueller
e8c1cb5074 Expand comment 2018-12-30 13:24:51 +01:00
José Matos
8663a371f3 Merge branch 'master' of git.lyx.org:lyx 2018-12-29 19:24:59 +00:00
José Matos
3f03f0a447 Move all python shebangs from /usr/bin/env to python3.
The change is only relevant to development as all the call to python scripts is done
calling C++ os::python that invoques the appropriate python version.

The change is two fold, on one hand remove all the uses of /usr/bin/env for python.

On the other hand rename all the calls to python from python to python3 making it explicit
and being compliant with PEP 394 -- The "python" Command on Unix-Like Systems:
https://www.python.org/dev/peps/pep-0394/

Remove the sheebang from src/graphics/GraphicsConverter.cpp because it is not necessary.

Some small whitespace changes.
2018-12-29 19:14:41 +00:00
Enrico Forestieri
69726b832b Fix bug #4269
Call gunzip with quoted filenames as they may contain spaces or
other special characters.
2018-12-29 20:11:56 +01:00
Juergen Spitzmueller
6e2c86a15c de.po 2018-12-29 18:18:48 +01:00
Juergen Spitzmueller
c457ea90e7 micro amendments 2018-12-29 17:53:21 +01:00
Richard Kimberly Heck
fc14f23b89 New layout file for American Mathematical Monthly.
From John Perry. See bug #10803.
2018-12-29 11:48:38 -05:00
Juergen Spitzmueller
96f880e452 de.po 2018-12-29 16:26:29 +01:00
Juergen Spitzmueller
12aaeb259f Handle bibliography irritations in thesis template
Outsource the bibliography to an own child, which is then also included
in the children's "Standalone" branch

Add some clarifying notes.

Fixes: #10748
2018-12-29 15:08:15 +01:00
Pavel Sanda
33284ee5c8 Completion popup menu did not respond to Esc.
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg207346.html
2018-12-29 14:36:38 +01:00
Juergen Spitzmueller
da273a944f Fix some parsing glitches in Autonest and IsAutonestedBy
Layouts can have spaces, underlines (that must be read as spaces, and
be enquoted)

Candidate for stable
2018-12-29 13:36:39 +01:00
Juergen Spitzmueller
012d9b088e Beamer: autonest column in columns
Candidate for stable
2018-12-29 13:36:13 +01:00
Juergen Spitzmueller
59d73f52b8 Do not auto-insert separator for keepempty layouts
Candidate for stable
2018-12-29 13:35:39 +01:00
Juergen Spitzmueller
a67c541d6b Fixup LocalLayout ui after [3847e0ef/lyxgit] 2018-12-29 11:47:37 +01:00
Juergen Spitzmueller
a550a613e8 Some minor amendments to [3ae6bff538/lyxgit] 2018-12-29 10:26:28 +01:00
Juergen Spitzmueller
3ae6bff538 Do not consider deleted labels in ambiguity check
This adds a new (boolean) parameter "active" to the label cache, where
we track whether a label is deleted in ct mode (the same could be done,
if wanted, for labels in notes and inactive branches).

Deleted (inactive) labels are neither considered in the uniqueness check
nor added to the outliner. This also means that undeleted references to
deleted labels are now (correctly) marked as BROKEN.

Fixes: #6563
2018-12-29 10:08:02 +01:00