Note that there is also a vector parameter that is passed by value.
However it is modified as a local copy and I do not want to change
this now.
Spotted by coverity.
The problem is caused by removing temporary aux, etc, files while
we are in the process of exporting. As Jürgen suggested, we really
do not need to remove these files until we are preparing to export:
They are not used internally. So now we just schedule the removal
and do it then.
Fix 12966. A few notes:
* we need to consider both regular insets and argument insets.
* in passthru layouts (such as verbatim) parentheses still need
to be reversed.
* all arguments of type 'listpreamble' are passthru (this isn't a rule,
this is just what happen in practice).
* custom layout and insets from the local layout, or a custom module
are not considered.
Signed-off-by: Udi-Fogiel <udifoglle@gmail.com>
colswitch was checking for oldstyle instead of normalcolor
to see if we need \normalcolor, which lead to appearence
of \color{none} in some cases, but "none" is not a known
color.
Instead of displaying the complete path, display the file name
first and then the path enclosed in parenthesis.
In this way files with same name but different path can still be
distinguished and, at the same time, files with different names
but same path are more easily spotted in case the complete path
is truncated by file managers.
This fixes, for example, the following ctests:
export/doc/ja/Customization_pdf4_systemF
export/doc/ja/Customization_pdf5_systemF
Consistent with ffe5d61b.
While it is not necessary to run validate() on insets that do not
produce output (yellow notes and disabled branches), it has to be done
for previewing, since a construct inside the inset may require some
support.
This is done in two steps:
1. in PreviewLoader::dumpPreamble, indicate that a preview is being
prepared. It is not clear why the `for_preview' boolean was not set
before.
2. in Inset(Branch|Note)::validate, always call the parent's validate
method when previewing.
It should have been possible to move the code from 2. to
InsetText::validate, but the weird code in handling
InsetNoteParams::Comment in html makes it difficult.
