Commit Graph

39138 Commits

Author SHA1 Message Date
Richard Kimberly Heck
88034d3d89 Fix bug #11422.
We need to load the master document before applying the params, since
otherwise the TOC reset (and other things) happen before the master
has been loaded (and set as parent).

(cherry picked from commit ac3693c04f)
2018-12-29 00:25:58 -05:00
Scott Kostyshak
4ea6d81437 Fix assertion when checking if change in selection
The check for the iterator being in the same paragraph as the end of
selection was incorrect, because paragraphs in different cells could
have the same pit. We now additionally condition on having the same
idx.

This commit amends d1279875 (and thus 23de5e5e).

For discussion, see:

  https://www.mail-archive.com/search?l=mid&q=a5afd0c01a0eb9a84fd4d050d15eb23016d6f38a.camel%40lyx.org

Thanks to Jürgen.

(cherry picked from commit c5301a6495)
2018-12-28 23:56:53 -05:00
Richard Kimberly Heck
b286511b75 Typo
(cherry picked from commit 75c8e5c000)
2018-12-28 23:35:07 -05:00
Richard Kimberly Heck
9cd9712cf0 Fix bug #11378.
(cherry picked from commit f11a51be35)
2018-12-28 23:04:46 -05:00
Enrico Forestieri
f648b2e936 Update it.po 2018-12-26 19:07:05 +01:00
Juergen Spitzmueller
a68e5b7774 When cancelling saving of a children, cancel the whole process.
Fixes remainder of #11405

(cherry picked from commit 4d51206585)
2018-12-25 12:15:43 +01:00
Kornel Benko
ad177dcf29 Update sk.po 2018-12-24 12:15:40 +01:00
Juergen Spitzmueller
08c7cbc621 de.po 2018-12-24 11:55:19 +01:00
Juergen Spitzmueller
6145cb798d Allow to restore default UI colors in prefs
Patch by Daniel Ramöller (racoon), with slight modifications of mine.

Fixes: #10062

(cherry picked from commit 81e4f8dfb6
with minor adaptations)
2018-12-24 11:51:38 +01:00
Scott Kostyshak
c249d942d6 status.23x: add entry for fix to changes in sel
This status entry is for #10338, which was backported in the
previous two commits.
2018-12-23 15:19:40 -05:00
Scott Kostyshak
0af6a43b6a Fix crash when selecting text with changes
When selecting text, in some cases a DocIterator could be forwarded
to a (non-existant) paragraph after the end. The critical part of
this fix is to break the loop at the correct place. The following
are additional improvements:

- increase readability by defining a bool named "in_last_par"
- use cur.selectionEnd().pit() instead of cur.selectionEnd().paragraph().id()
- use it.lastpos() instead of it.paragraph().size()

This commit fixes a regression introduced by 23de5e5e, and reported
at #11204.

Thanks to Jürgen and JMarc.

(cherry picked from commit d12798759a)
2018-12-22 14:57:40 -05:00
Scott Kostyshak
890fb133b1 Only show Accept/Reject Change options if relevant
In the context menu for a selection, we now only show the options
"Accept Change" and "Reject Change" if there is actually a change in
the selection. Similarly, in the toolbar, the buttons are only
enabled when there is a change in the selection.

This fixes #10338.

(cherry picked from commit 23de5e5e19)
2018-12-22 14:57:40 -05:00
Kornel Benko
f2772678b0 Update sk.po 2018-12-22 10:27:28 +01:00
Juergen Spitzmueller
9e5350b8fd de.po 2018-12-22 08:57:19 +01:00
Juergen Spitzmueller
4480b72a9d GuiCharacter: Add menu to Restore button
and allow for resetting all widgets to "No Change" besides "Default"

(cherry picked from commit ac8aac5b36)
2018-12-22 08:52:55 +01:00
Jean-Marc Lasgouttes
714b731e39 Make DEPM respect current cursor position.
Spaces are now conserved when they surround current cursor. Examples:
  abc   |   def
becomes
  abc | def
after DEPM and
  abc |
is kept as it is.

Fixes ticket #11412.

(cherry picked from commit dff0c5729e)
2018-12-21 22:18:40 +01:00
Enrico Forestieri
324b828717 Fix bug 11346
Enclose in braces an optional argument of a math macro when it
starts with an incomplete script inset or ends with a delimiter
size-modifier macro.

(cherry picked from commit 2dcb730026)
2018-12-20 11:57:54 +01:00
Juergen Spitzmueller
d41337179a Also check for dirty children on QUIT
Fixes rest of #11405

(cherry picked from commit 33344c6015)
2018-12-20 11:39:37 +01:00
Pavel Sanda
7b431ff0ba Backport 99bfe20120. 2018-12-19 21:47:06 +01:00
Pavel Sanda
cb848bbcd0 * status.23x 2018-12-18 23:17:54 +01:00
Kornel Benko
6d0cc5be2e Update sk.po 2018-12-18 08:59:58 +01:00
Juergen Spitzmueller
7ce499f534 de.po 2018-12-18 08:44:32 +01:00
Juergen Spitzmueller
1dc6154708 GuiCharacter: Add "Reset" and "Restore Defaults" buttons
Addresses #11415
2018-12-18 08:32:48 +01:00
Juergen Spitzmueller
aea162cc8d Check for hidden dirty child on close
Fixes: #11405
(cherry picked from commit f87218bbb5)
2018-12-17 18:46:13 +01:00
Jean-Marc Lasgouttes
833adc5c6b Fix embarrassing typo
Not clear whether this caused any bug.

(cherry picked from commit 058c6750ac)
2018-12-17 17:22:42 +01:00
Juergen Spitzmueller
262b0dcca4 GuiCharacter: INHERIT is OFF for the tristate buttons.
(cherry picked from commit 1b6ce0e827)
2018-12-17 10:44:10 +01:00
Juergen Spitzmueller
0dcf78a4ad GuiCharacter: Consider default settings for underline, strikeout and language
(cherry picked from commit bf2bf2eaed)
2018-12-17 10:42:00 +01:00
Juergen Spitzmueller
1a43a14ef5 Amend 9705b88251
(cherry picked from commit ab5c08b3f0)
2018-12-17 10:41:31 +01:00
Juergen Spitzmueller
a6e3c59b94 Use current_font, not real_current_font, in character dialog
The latter has the workarea font settings, which are not of interest
here.

Fixes: #11385
(cherry picked from commit 9705b88251)
2018-12-17 10:41:03 +01:00
Jean-Marc Lasgouttes
47adf27ac3 Fix undo after breaking a nested paragraph
We have to take into account that Buffer::updateBuffer can modify the document.

Fix bug #11292.

(cherry picked from commit 57feb0fed0)
2018-12-16 22:00:36 +01:00
Jean-Marc Lasgouttes
09d742cc7f Update boost to 1.68.
This avoid lots of warnings from gcc 8.
2018-12-16 21:45:02 +01:00
Juergen Spitzmueller
10fdb8a312 de.po 2018-12-16 11:42:55 +01:00
Kornel Benko
2888d9e1ed Update sk.po 2018-12-16 02:15:34 +01:00
Richard Kimberly Heck
91078439df Fix spacing. 2018-12-15 12:45:47 -05:00
Jean-Marc Lasgouttes
ebe6612e26 Make sure inset buffer is correctly set in math grid
Make MathData::setBuffer set the buffer of insets that it contains.
Remove corresponding code from InsetMathNest.

update the buffer() property in the following tabular-feature
actions : copy-row, add-row, copy-col, add-col.

(cherry picked from commit 837bcbb043)
2018-12-14 19:39:54 +01:00
Jean-Marc Lasgouttes
0e6cb4e599 Set buffer correctly when changing math space type.
Fixes bug #7747.

(cherry picked from commit 2ec25c8eef)
2018-12-14 19:39:54 +01:00
Pavel Sanda
05282ceeec Backport 641ae5c7ad.
The main reason is to prepare #5348 for landing.
2018-12-14 19:20:36 +01:00
Enrico Forestieri
3e9a1c2da7 Fix bug #9622
The backslash is the escape character used in our parser. Hence,
when used as a path separator on Windows, it has to be itself
escaped or the path enclosed in either double or single quotes.
Windows users are maybe trained to quote paths containing spaces
but not paths with backslashes. So, we automatically escape the
backslashes when they are not already enclosed in quotes.

(cherry picked from commit 4c9df62c6c)
2018-12-14 18:57:48 +01:00
Pavel Sanda
759769131a Keep permissions of the saved files intact. (Backporting 04fe818b22).
Apparently this code helps for qt5 only.
qt4 accepts setPermission, but does not seem to actually implement it.
2018-12-14 18:50:36 +01:00
Richard Kimberly Heck
7bf1392c4d Comment 2018-12-14 11:11:50 -05:00
Richard Kimberly Heck
2126d5a3aa The updateBibfilesCache routine is not in master.
I think it must be a leftover from all the back and forth of trying
to get this right. But there's only one way to find out...
2018-12-14 11:10:05 -05:00
Richard Kimberly Heck
af71ebff8e There is no reason we should need to reload the bibinfo cache for
internal buffers.
2018-12-14 10:43:30 -05:00
Richard Kimberly Heck
e9614a36eb Fix slowness problem reported on the mailing list on Windows.
https://marc.info/?l=lyx-devel&m=154458979925296&w=2

This is related to the fix for #9158 and the caching of bibfile
information. On Windows, it is incredibly slow to run kpsewhich,
which we do to check where files actually are, so as to get info
about them (e.g., timestamps). So we have started to cache that
as a map. The map is supposed to be invalidated when various
things happen, but an oversight was causing it to be invalidated
on every cut operation. This is because cutting uses a temporary
Buffer, and the operations on it were affecting the *global* cache
of biblio file info. (It makes sense to have a global cache, since
these files are not document-specific.) Basically, we have to update
the list of bibfiles in that temporary Buffer---but that is one of
the things that invalidated the cache. The solution is only to
invalidate the cache if the list of bibfiles has actually changed
(a sensible idea anyway). The only time that will happen in the
temporary Buffer is when the copied information contains a BibTeX
inset. That should be fairly rare.
2018-12-14 10:43:30 -05:00
Enrico Forestieri
eba2f14fa7 Fix display of single-char macro names
Essentially, all characters are allowed in single-char macro names.

Part of #11158.

(cherry picked from commit 95bc273a59)
2018-12-14 12:05:40 +01:00
Guillaume MM
a8ad4002a0 Fix segfault after deleting monitor
The boost signal was sent synchronously, and so made the Qt signal to be posted
in FileMonitor::changed after the boost signal returned, so after the sender was
possibly destroyed.

The solution is to make the boost signal asynchronous using the Qt event loop.

Thanks to Scott Kostyshak for the report and MWE.

(cherry picked from commit 131f4b92ba)
2018-12-13 23:31:15 -05:00
Jean-Marc Lasgouttes
7950ace3d9 Fix selection of unmarked RtL text
With Qt 5.11 at least, RtL text will be drawn RtL even when the
(undocumented) flag Qt::TextForceLeftToRight is applied to the
QTextLayout object. This creates selection issues for Hebrew text
marked as English.

The solution is to do the same as in breakAt_helper, that is prepend
the string with a direction override unicode character.

Doing this requires to introduce a TEXTLAYOUT_OFFSET constant that has
to be used wisely to account for this extra character.

Fixes bug #11284.

(cherry picked from commit 1bed76e2a1)
2018-12-13 10:51:59 +01:00
Jean-Marc Lasgouttes
3a123b90af Remove old workaround that is not needed anymore
This causes a compilation error with boost 1.69.

Fixes bug #11349.

(cherry picked from commit 76e99e9a20)
2018-12-13 10:39:58 +01:00
Juergen Spitzmueller
ac351f40f1 Fix encoding problems in \input@path
As of LaTeX2e 2018, characters are made active earlier, which results
in new expansion problems.

Following a suggestion of Markus Kohm (pc) and the TL mailing list [1],
we embrace non-ASCII input paths in \detokenize. This relies on e-tex,
but I think we can assume this is nowadays available everywhere.

[1] http://tug.org/pipermail/tex-live/2018-May/041691.html

Fixes: #11146
(cherry picked from commit 8bd65041f2)
2018-12-12 08:39:20 +01:00
Richard Kimberly Heck
c26c7602e4 Copy modules into the Advanced F&R pane as well.
(cherry picked from commit 5064c09e9f)

Update the Advanced F&R document class when switching buffers.

(cherry picked from commit 944b0ae55d)
2018-12-11 18:05:53 -05:00
Richard Kimberly Heck
7bc7b8f422 Speed up convert_literalparam. Part of #11200.
(cherry picked from commit 4549f46a43)
2018-12-11 18:03:44 -05:00