Commit Graph

44822 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
23cd38bc1c Use TextLayoutHelper in x2pos and pos2x
This leads to substantial code simplification.

No intended behavior change.

Related to ticket #10117.
2022-11-10 16:13:29 +01:00
Jean-Marc Lasgouttes
7fdc604606 Refactor GuiFontMetrics::getLayout
This allows to create a new version that takes an already built
TextLayoutHelper struct as parameter.

No intended change.

See discussion in bug #10117.
2022-11-10 16:13:28 +01:00
Jean-Marc Lasgouttes
201c95a76e Handle multiple spaces at row break
In order to work around the Qt row breaking algorithm, which considers
multiple spaces as one at QTextLine break, we insert word_joiner unicode
characters beteween each pair of spaces.

The TextLayoutHelper class makes it easy to handle that.

Update Row::Element::rtrim() to only remove one space at row end.

Update support::countExpanders() to count all spaces, without special
handling for consecutive ones.

Fixes bug #10117.
2022-11-10 15:21:02 +01:00
Jean-Marc Lasgouttes
a48efa03b1 Introduce a struct to handle docstring <-> QString index translation
This new code allows to get rid of some hardcoded stuff and will be a
foundation for handling of consecutive spaces.

This code can be used in the future for getTextLayout, x2pos, and
pos2x in order to streamline code. Actually some features as the naked
parameter are here to prepare for this second set of changes.

No change intended. The modified code is much clearer, though.

Related to bug #10117.
2022-11-10 12:06:15 +01:00
Jean-Marc Lasgouttes
a99f76477d Revert "Fixup 572b06d6: reduce cache size for breakString"
10MB cache is not so large after all, and it can be helpful with
Scott's perverse examples.

This reverts commit 2abe771407.

Fixes part of bug #12598.
2022-11-08 00:12:40 +01:00
Jean-Marc Lasgouttes
ec151de2cc Fix expensive thinko: operator++ returns a reference, not a copy
This accounts for 45% of the row breaking time on the (huge) paragraph
of the MWE in bug #12598.

Fixes part of bug #12598.
2022-11-08 00:12:40 +01:00
Kornel Benko
5691863043 Update sk.po 2022-11-07 11:28:15 +01:00
Juergen Spitzmueller
069122feba Revert "Try to be more pedantic wrt blank lines in lyx2lyx output"
This reverts commit 9ce0ff50c1.
2022-11-06 17:17:33 +01:00
Juergen Spitzmueller
9ce0ff50c1 Try to be more pedantic wrt blank lines in lyx2lyx output
Hopefully to the tests' please
2022-11-06 16:40:12 +01:00
Scott Kostyshak
cbc3804a2f Correct typos of "occurred" in warnings/errors
Change "occured" and "ocurred" to "occurred".
2022-11-06 10:06:50 -05:00
Jean-Marc Lasgouttes
90ea508111 Fix pasting as LaTeX in documents with no modules
When there is no module, the old code would invoke tex2lyx with option
 -m
instead of
 -m ""
and an error would ensue.

This is because the QProcess command line parser used in Systemcall is
broken and does not recognize empty parameters as such. The solution
is to rewrite our parsecmd() parser to generate a list of parameters.
This is post-2.4.0 work.

The workaround used here is:

- set the list of modules to "," when it should be empty. In effect,
  this is a list of two empty modules.

- change tex2lyx to accept empty module names and ignore them; this is
  good in terms of robustness anyway.

Additionally, when there is no receiving buffer, set the defaults as
the BufferParams defaults instead of empty (this is cleaner, but
should not make a difference in practice).

In the long term, we should switch to use the QStringList-based API of
QProcess in Systemcall (see QTBUG-80640).
2022-11-06 13:20:02 +01:00
jpc
157d67d55d Update fr.po 2022-11-06 11:15:08 +01:00
Juergen Spitzmueller
2604274a88 de/UserGuide: document index-tag-all 2022-11-06 09:11:18 +01:00
Juergen Spitzmueller
8eff70089f de.po 2022-11-06 09:09:12 +01:00
Scott Kostyshak
c94bb34c50 ctests: ignore a couple more roundtrip tests
Export fails after compilation with the following error:

  ERROR: CHAR: index 0 should be less than the length of the string
2022-11-05 14:50:34 -04:00
Scott Kostyshak
378c19bfc2 Guard some debug code
Amend f352a375 and 3bf1b97a.
2022-11-05 14:35:27 -04:00
Juergen Spitzmueller
3bbce7f24a Introduce index-tag-all lfun
This is a convenience function for indexing. It adds a copy of the
index inset under cursor after any word in the buffer that is equal
(case-insensitively) to the word preceding the index inset.

The function can be easily used to generate bad indexes (and I warn
about that in the UserGuide), but if used with care, it can also be
extremely convenient.
2022-11-05 18:39:33 +01:00
Scott Kostyshak
c52808ce1a ctests: log a waste 2022-11-05 10:37:48 -04:00
Scott Kostyshak
0fe28df08f ctests: ignore a couple fragile lyx2lyx tests
From Kornel [1]:

  Exporting to 2.3 format and exporting from the exported differ in extra lines and
  in changed sequence of 2 lines at begin.

  $ diff doc/fr/UserGuide.23.lyx fr/UserGuide.23.23.lyx

[1] https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg218252.html
2022-11-05 10:37:48 -04:00
Juergen Spitzmueller
e2105bed61 Update RELEASE_NOTES 2022-11-05 08:34:36 +01:00
Daniel Ramoeller
89394bcd0f Show suggestions containing the input in the command buffer
Previously, only the suggestions starting with the current input were
shown.

Contains the following minor improvements:
- Add space to indicate when only one suggestion is found

- Select first item in suggestion-list in order to make selecting with
  arrow keys more intuitive

- Fix selection with Shift+Up/Down in text-field

Fix for bug #12572.
2022-11-04 22:27:31 +01:00
Jean-Marc Lasgouttes
fad170be1a New lfun to copy index insets from ToC
The new function inset-insert-copy can only be invoked from the ToC.
It is currently only implemented for Index inset.

It is a special lfun because Inset::dispatch is called directly from
the ToC widget with cursor pointing to the inset, whereas the patch
happens in the workarea at caret position. This function cannot be
called directly.

Add an entry for this function in the toc context menu.

Fixes bug #4582.
2022-11-04 21:52:46 +01:00
Jean-Marc Lasgouttes
d2f05b9e6f When Inset::dispatch is called from TOC, process screen flags
This is needed because we are not using the complete dispatch
machinery here.

Part of bug #4582.
2022-11-04 21:46:32 +01:00
Jean-Marc Lasgouttes
0b27eb7deb Introduce new function copyInsetToTemp
This is a version of copyInset that does touch the cut stack and the X
selection.

Part of bug #4582.
2022-11-04 21:44:24 +01:00
Jean-Marc Lasgouttes
2c53f0315e Fix another use of unqualified std::move 2022-11-04 21:36:43 +01:00
jpc
9dc6f09c65 Update fr.po 2022-11-04 18:05:43 +01:00
Kornel Benko
2333af615d Amend 9be6a425, Workaround for advanced search in 'uncover'-inset.
Use getInset(i)->toString() instead of getInset(i)->plaintext()
if searching, so that we get the option of 'uncover' visible to the search engine.
2022-11-04 15:34:49 +01:00
Kornel Benko
3b3f43cf35 Update sk.po 2022-11-04 12:47:35 +01:00
Juergen Spitzmueller
1b910e3fd9 de.po 2022-11-04 11:37:38 +01:00
Juergen Spitzmueller
68e268e117 Add some options to index context menu 2022-11-04 11:29:56 +01:00
Juergen Spitzmueller
4299d842e8 Adapt French docs to new index features 2022-11-04 09:03:55 +01:00
Juergen Spitzmueller
55870df5c7 Do not \protect stuff in index when we postpone the index
\protect us not needed here and affects sorting
2022-11-04 08:32:34 +01:00
Juergen Spitzmueller
d41e0c9231 Fix page range without page format 2022-11-04 07:57:56 +01:00
Scott Kostyshak
4bb576e940 ctests: log a waste and a success
A couple of the lyx2lyx tests were helpful, and a couple did not
lead to a fix. In particular, testing compilation was not helpful in
this case.
2022-11-03 16:05:10 -04:00
Scott Kostyshak
a1d127efeb ctests: ignore some lyx2lyx tests that fail
From Jürgen [1]:

  These are old problems. One is related to a questionable nomencl change
  which we addressed in master but not in stable, see
  https://www.lyx.org/trac/ticket/10634#comment:2

  The other is due to CJK quotation marks which are not supported in 2.3.

We ignore, rather than invert, since no plans to fix these.

[1] https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg218237.html
2022-11-03 16:00:22 -04:00
Juergen Spitzmueller
e316e21aa1 Amend b8502a3ea2 2022-11-03 07:14:14 +01:00
Juergen Spitzmueller
b8502a3ea2 Fix glitch in index reversion routine 2022-11-03 05:54:50 +01:00
Juergen Spitzmueller
975f304185 Indicate see[also] refs in label and outliner 2022-11-02 15:56:59 +01:00
Juergen Spitzmueller
0e710626b8 Adapt all German and English manuals to new index features 2022-11-02 15:24:13 +01:00
Juergen Spitzmueller
293b8dbe67 Do not unnecessarily reset the outliner to TOC on internal model changes
The activated() signal is only issued on user changes, what we want here,
not internal model changes (as with currentIndexChanged())
2022-11-02 12:33:20 +01:00
Juergen Spitzmueller
b51f1f7800 Remove wrong count comment 2022-11-02 10:46:52 +01:00
Kornel Benko
9be6a425df Workaround for advanced search in 'uncover'-inset.
Allows for matches inside style Uncover if used
	Settings->Adhere to search string formatting
This does not cover all of #12594 though.
2022-11-02 10:33:29 +01:00
Kornel Benko
75d10993c9 Update sk.po 2022-11-02 10:33:06 +01:00
Juergen Spitzmueller
886d881ba3 lyx2lyx: fix index reversion
This was only a warning, but it made the tests fail
2022-11-02 09:33:09 +01:00
jpc
ef10697391 Update fr.po 2022-11-01 16:51:01 +01:00
Juergen Spitzmueller
f41546d73c German documentation of new index features 2022-11-01 14:45:37 +01:00
Juergen Spitzmueller
657ab04d8e de.po 2022-11-01 12:13:45 +01:00
Juergen Spitzmueller
5a53a5f608 Fix output of subentry with sortkey 2022-11-01 11:55:57 +01:00
Juergen Spitzmueller
262f0b528a UserGuide: use new features for all index entries 2022-11-01 11:06:50 +01:00
Juergen Spitzmueller
fd5adacef2 Handle empty index subentries (#7820) 2022-11-01 10:20:50 +01:00