lyx_mirror/src/frontends/qt4
Enrico Forestieri 72a488d7e6 Fix output of en- and em-dashes with TeX fonts
This commit fixes the regression introduced in 2.2 about the
output of en- and em-dashes. In 2.2 en- and em-dashes are output as
the \textendash and \textemdash macros when using TeX fonts, causing
changed output in old documents and also bugs (for example, #10490).

Now documents produced with older versions work again as intended,
while documents produced with 2.2 can be made to produce the exact
same output by simply checking "Don't use ligatures for en-and
em-dashes" in Document->Settings->Fonts.

When exporting documents using TeX fonts to earlier versions, in order
to avoid changed output, a zero-width space character is inserted after
each en/em-dash if dash ligatures are allowed. These characters are
removed when reloading  documents with 2.3, so that they don't accumulate.
2017-03-19 20:50:34 +01:00
..
ui Fix output of en- and em-dashes with TeX fonts 2017-03-19 20:50:34 +01:00
.gitignore
Action.cpp Action.cpp: replace a reference with a shared_ptr 2016-08-28 22:49:21 +01:00
Action.h Action.cpp: replace a reference with a shared_ptr 2016-08-28 22:49:21 +01:00
BulletsModule.cpp
BulletsModule.h
ButtonController.cpp Replace foreach with for 2016-06-12 19:17:33 +01:00
ButtonController.h
ButtonPolicy.cpp
ButtonPolicy.h
CategorizedCombo.cpp Small cleanup to LayoutBox and CategorizedCombo 2017-03-10 15:57:31 +01:00
CategorizedCombo.h
CMakeLists.txt
ColorCache.cpp Use proper QPalette::NoRole enum value instead of our own 2016-08-17 12:10:25 +02:00
ColorCache.h
CustomizedWidgets.cpp ShortcutWidget: override shortcuts in the way they are meant to be (#10075) 2016-05-20 19:14:35 +01:00
CustomizedWidgets.h ShortcutWidget: override shortcuts in the way they are meant to be (#10075) 2016-05-20 19:14:35 +01:00
Dialog.cpp Clarify that the Dialog::lyxview_ pointer is in fact a reference 2016-09-29 12:37:19 +02:00
Dialog.h Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
DialogView.cpp Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
DialogView.h Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
DockView.cpp Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
DockView.h Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
EmptyTable.cpp
EmptyTable.h
FancyLineEdit.cpp Whitespace and remove obsolete #ifdef. 2017-02-26 22:16:10 +01:00
FancyLineEdit.h Whitespace and remove obsolete #ifdef. 2017-02-26 22:16:10 +01:00
FileDialog.cpp
FileDialog.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
FindAndReplace.cpp Rationalise includes 2016-07-04 02:42:17 +02:00
FindAndReplace.h
FloatPlacement.cpp Initialize a bunch of uninitialized members. It does not seem to 2016-06-11 23:39:43 -04:00
FloatPlacement.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiAbout.cpp Always present Qt version info in LyX About dialog - not for developer version only 2016-06-19 11:53:20 +02:00
GuiAbout.h
GuiAlert.cpp GuiAlert: Convert html to plain text on console output 2016-12-04 18:28:03 +01:00
GuiApplication.cpp Handle the case where doc_bv is null 2017-03-09 14:41:27 +01:00
GuiApplication.h Prioritize the shortcuts from the work areas 2016-07-14 20:50:10 +01:00
GuiBibitem.cpp Extend LATEXIFY command param handling and add literal param. 2017-01-30 07:44:55 +01:00
GuiBibitem.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiBibtex.cpp Support for multiple bibliographies 2017-02-04 12:02:00 +01:00
GuiBibtex.h Biblatex support 2017-01-08 09:39:46 +01:00
GuiBox.cpp Replace foreach with for 2016-06-12 19:17:33 +01:00
GuiBox.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiBranch.cpp Introduce "inverted" branch insets: These are branches whose content 2016-07-11 23:56:32 -04:00
GuiBranch.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiBranches.cpp Fix cppcheck variable scope warnings 2015-09-20 10:42:35 +02:00
GuiBranches.h
GuiChanges.cpp GuiChanges: provide feedback when there are no more changes 2016-05-29 17:55:42 -04:00
GuiChanges.h GuiChanges: provide feedback when there are no more changes 2016-05-29 17:55:42 -04:00
GuiCharacter.cpp Factor out multiply used ColorSorter. 2015-11-16 08:19:16 +01:00
GuiCharacter.h
GuiCitation.cpp Remove LyXToolBox 2017-02-26 22:16:10 +01:00
GuiCitation.h Fix 18 memory leaks 2017-02-26 22:16:10 +01:00
GuiClipboard.cpp amend 660a43ec 2016-05-07 01:53:04 +01:00
GuiClipboard.h Remove using directives from headers 2016-06-26 18:22:59 +02:00
GuiCommandBuffer.cpp Make command buffer icons same size as QLineEdit height 2016-06-26 16:58:18 +02:00
GuiCommandBuffer.h Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCommandEdit.cpp Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCommandEdit.h Auto feature for minibuffer toolbar 2015-07-15 17:41:09 +02:00
GuiCompare.cpp Ammend 20addbbf 2016-01-24 13:05:51 -05:00
GuiCompare.h
GuiCompareHistory.cpp
GuiCompareHistory.h
GuiCompleter.cpp Consistency of ellipses across the UI 2015-10-05 21:16:16 +01:00
GuiCompleter.h
GuiDelimiter.cpp Fixup c49cd699: QString::toStdString is not always available 2016-12-28 22:44:40 +01:00
GuiDelimiter.h From c7899a30a0b5975bf599a69ecd11ab25e1cdf1a4 Mon Sep 17 00:00:00 2001 2016-12-28 16:34:44 +01:00
GuiDialog.cpp Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
GuiDialog.h Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
GuiDocument.cpp Fix output of en- and em-dashes with TeX fonts 2017-03-19 20:50:34 +01:00
GuiDocument.h Initialize class members to please coverity 2017-03-01 16:28:30 +01:00
GuiErrorList.cpp Fix missing initialization 2017-03-08 16:41:42 +01:00
GuiErrorList.h
GuiERT.cpp
GuiERT.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiExternal.cpp Add 'needauth' option to converters that need explicit user authorization. 2016-11-22 23:54:58 +01:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp Correct computation of math font size 2016-11-21 00:02:35 +01:00
GuiFontLoader.h
GuiFontMetrics.cpp Move comment 2017-02-21 06:52:34 +01:00
GuiFontMetrics.h Introduce support/Cache.h 2017-02-21 00:06:07 +01:00
GuiGraphics.cpp Fix a number of other uninitialized members. 2016-06-11 23:59:55 -04:00
GuiGraphics.h
GuiGraphicsUi.h
GuiHSpace.cpp HSpace/VSpace: use a _signed_ length validator in the dialogs. 2015-06-26 13:19:12 +02:00
GuiHSpace.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiHyperlink.cpp Extend LATEXIFY command param handling and add literal param. 2017-01-30 07:44:55 +01:00
GuiHyperlink.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiIdListModel.cpp
GuiIdListModel.h
GuiImage.cpp Use bilinear filtering when resizing graphics 2016-05-20 21:19:31 +01:00
GuiImage.h
GuiInclude.cpp Replace static with thread_local when used for caching 2016-08-01 23:44:16 +01:00
GuiInclude.h
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp Fix cppcheck variable scope warnings 2015-09-20 10:42:35 +02:00
GuiIndices.h GuiIndices: Improve widget disabling and account for read only status 2015-06-03 16:54:54 +02:00
GuiInfo.cpp
GuiInfo.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiKeySymbol.cpp Prioritize the shortcuts from the work areas 2016-07-14 20:50:10 +01:00
GuiKeySymbol.h Prioritize the shortcuts from the work areas 2016-07-14 20:50:10 +01:00
GuiLabel.cpp
GuiLabel.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiLine.cpp
GuiLine.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiListings.cpp Replace static with thread_local when used for caching 2016-08-01 23:44:16 +01:00
GuiListings.h
GuiLog.cpp GuiLog: Detect Biber for the GUI. 2017-01-02 12:00:10 +01:00
GuiLog.h Amend fd4d23b4 2016-01-12 21:25:34 +00:00
GuiMathMatrix.cpp
GuiMathMatrix.h
GuiNomenclature.cpp Extend LATEXIFY command param handling and add literal param. 2017-01-30 07:44:55 +01:00
GuiNomenclature.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp Introduce support/Cache.h 2017-02-21 00:06:07 +01:00
GuiPainter.h Allow automatic text direction in Painter::text() 2016-05-31 11:52:30 +02:00
GuiParagraph.cpp GuiParagraph: Fix remaining glitch when entering custom line spread 2015-06-13 12:31:03 +02:00
GuiParagraph.h
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Move the global formats and system_formats variables into the 2017-03-13 23:40:29 -04:00
GuiPrefs.h Make Japanese Biblatex-aware 2017-01-14 12:13:33 +01:00
GuiPrintindex.cpp Extend LATEXIFY command param handling and add literal param. 2017-01-30 07:44:55 +01:00
GuiPrintindex.h
GuiPrintNomencl.cpp
GuiPrintNomencl.h
GuiProgress.cpp Cosmetic changes to the needauth dialogs 2016-12-04 18:28:03 +01:00
GuiProgress.h
GuiProgressView.cpp Fix compiler warning from clang 3.9 2016-10-20 09:31:01 +02:00
GuiProgressView.h
GuiRef.cpp Give focus to the filter in GuiRef 2017-02-26 22:16:10 +01:00
GuiRef.h Add ability to use refstyle's plural and capitalization features. 2017-01-02 22:32:36 -05:00
GuiSearch.cpp Move wrap check for simple search/replace to lyxfind 2016-09-14 10:23:39 +02:00
GuiSearch.h Move wrap check for simple search/replace to lyxfind 2016-09-14 10:23:39 +02:00
GuiSelection.cpp
GuiSelection.h
GuiSelectionManager.cpp Allow Ctrl+Enter in GuiCitation even if the citation is already there 2017-03-05 08:45:52 +01:00
GuiSelectionManager.h Fix 18 memory leaks 2017-02-26 22:16:10 +01:00
GuiSendto.cpp Use a typedef for vector<Format const *>, which is what gets used 2016-10-20 23:07:13 -04:00
GuiSendto.h There is no need now to cache format information in the SendTo 2016-10-20 23:07:13 -04:00
GuiSetBorder.cpp Disable setting vertical lines when using a formal table 2015-11-02 15:58:40 +01:00
GuiSetBorder.h
GuiShowFile.cpp
GuiShowFile.h
GuiSpellchecker.cpp Move wrap check for simple search/replace to lyxfind 2016-09-14 10:23:39 +02:00
GuiSpellchecker.h
GuiSymbols.cpp Add missing initialization 2017-03-01 17:25:03 +01:00
GuiSymbols.h
GuiTabular.cpp Initialize some GuiTabular members in constructor 2016-06-09 16:38:32 +02:00
GuiTabular.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp Show Biblatex files in the TeXInfo dialog 2017-01-01 11:34:35 +01:00
GuiTexinfo.h Show Biblatex files in the TeXInfo dialog 2017-01-01 11:34:35 +01:00
GuiThesaurus.cpp
GuiThesaurus.h
GuiToc.cpp Remove a redundant deletion of a QObject 2016-12-31 15:16:15 +01:00
GuiToc.h Remove a redundant deletion of a QObject 2016-12-31 15:16:15 +01:00
GuiToolbar.cpp Action.cpp: replace a reference with a shared_ptr 2016-08-28 22:49:21 +01:00
GuiToolbar.h Simplify the code for "auto" toolbars handling 2015-06-18 15:51:53 +02:00
GuiView.cpp Clean up 2017-03-18 15:09:07 +01:00
GuiView.h Add the icon-size to the toolbar menu 2016-11-22 10:00:52 +01:00
GuiViewSource.cpp Move the global formats and system_formats variables into the 2017-03-13 23:40:29 -04:00
GuiViewSource.h Fix warning during runtime with qt4 2016-11-09 23:37:35 +01:00
GuiVSpace.cpp HSpace/VSpace: use a _signed_ length validator in the dialogs. 2015-06-26 13:19:12 +02:00
GuiVSpace.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
GuiWorkArea_Private.h Display externally modified status 2017-03-11 00:50:57 +01:00
GuiWorkArea.cpp Clean up 2017-03-18 15:09:07 +01:00
GuiWorkArea.h Clean up 2017-03-18 15:09:07 +01:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp
IconPalette.h
InGuiThread.cpp
InGuiThread.h Add a check to please coverity. 2016-06-12 00:12:03 -04:00
InsertTableWidget.cpp Compilation fix for windows 2015-07-16 09:48:57 +02:00
InsertTableWidget.h
InsetParamsDialog.cpp Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
InsetParamsDialog.h
InsetParamsWidget.cpp
InsetParamsWidget.h Implement proper dialog titles in InsetParamsDialogs 2016-08-26 11:35:12 +02:00
LaTeXHighlighter.cpp Trivial clean-up 2016-08-28 02:34:54 +01:00
LaTeXHighlighter.h Trivial clean-up 2016-08-28 02:34:54 +01:00
LayoutBox.cpp Small cleanup to LayoutBox and CategorizedCombo 2017-03-10 15:57:31 +01:00
LayoutBox.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
LengthCombo.cpp Remove relative units from bounding box 2015-07-18 16:41:52 +02:00
LengthCombo.h Remove relative units from bounding box 2015-07-18 16:41:52 +02:00
LyXFileDialog.cpp Remove context help button hint from file dialogs 2016-10-10 01:25:07 +02:00
LyXFileDialog.h
Makefile.am Notification of external modification inspired by gedit 2017-03-11 00:50:57 +01:00
Menus.cpp Move the global formats and system_formats variables into the 2017-03-13 23:40:29 -04:00
Menus.h Forbid wrong compiler generated copy constructors 2015-09-20 19:43:06 +02:00
PanelStack.cpp Whitespace and remove obsolete #ifdef. 2017-02-26 22:16:10 +01:00
PanelStack.h
qt_helpers.cpp Implement down key press in FancyLineEdit 2017-02-26 22:16:10 +01:00
qt_helpers.h Implement down key press in FancyLineEdit 2017-02-26 22:16:10 +01:00
qt_i18n.h
README
TocModel.cpp Make the generation of children's tocs more robust 2017-01-14 23:13:14 +01:00
TocModel.h TocWidget: Remove possibly dangling BufferView pointer 2016-12-31 15:16:15 +01:00
TocWidget.cpp TocWidget: Remove possibly dangling BufferView pointer 2016-12-31 15:16:15 +01:00
TocWidget.h TocWidget: fix an erroneous collapse and optimise updates based on profiling 2016-05-31 00:14:13 +01:00
Toolbars.cpp Use a typedef for vector<Format const *>, which is what gets used 2016-10-20 23:07:13 -04:00
Toolbars.h Action.cpp: replace a reference with a shared_ptr 2016-08-28 22:49:21 +01:00
ToolTipFormatter.cpp Check the validity of an item before querying its tooltip 2016-12-03 23:35:15 +01:00
ToolTipFormatter.h Line breaks in tooltips 2016-07-03 17:28:45 +02:00
Validator.cpp
Validator.h

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.