Commit Graph

39170 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
ca8f6c09b6 forgot this 2019-01-05 15:04:51 +01:00
Jean-Marc Lasgouttes
3a4c4605e9 Fix drawing of labels in insets
In many cases, the origin xo_ of insets was forgotten.

Also fix spacing between text and label in rtl

Fixes bug #11425.

(cherry picked from commit 5c1d65afee)
(cherry picked from commit 5fc035f99c)
2019-01-05 15:01:58 +01:00
Jean-Marc Lasgouttes
7f3407b89a Avoid crash when using inset-select-all in tabular
When changing cell idx, it is important to set the pit to a reasonable
value.

(cherry picked from commit a69e01d0b4)
2019-01-05 14:56:41 +01:00
Jean-Marc Lasgouttes
e73c0d6387 Fix vertical offset of fonts like MinionPro
For some reason, adding a LTR/RTL Override unicode character before a
MinionPro string increases the ascent of the line.

This creates vertical offset issues when painting if the ascent used
as reference is the one of the font. Use the QTextLine ascent instead
for better results.

This is a followup to 1bed76e2a.

Fixes (reopened) ticket #11284.
Fixes ticket #10532.
Fixes ticket #10767.

(cherry picked from commit d8498d4785)
2019-01-05 14:40:56 +01:00
Juergen Spitzmueller
08100f8b02 Always update bibfiles cache with bibliography environment before opening citation dialog
We need to do this unconditionally, since there is no (trivial and non-
awkward) way to update it when the bibliography paragraphs are modified.

Fixes: #4899
(cherry picked from commit 35534231d4)
2019-01-05 10:31:08 +01:00
Kornel Benko
db5fb78cfd Cmake lyx2lyx tests: Correct use of value for \use_non_tex_fonts
Amend eec3d1eb,7568571a
We are trying to check if the resulting file after lyx2lyx
is compilable, we have to ensure that copying the original file
to the test directory does not mangle use_non_tex_fonts-entry.

(cherry picked from commit c9e62dec53)
2019-01-05 09:03:23 +01:00
Kornel Benko
410054ba5e lyx2lyx tests: Use the temp-dir also for converted lyx files
Important if including data previously copied there.
Fixes test "export/doc/Additional_lyx22"

(cherry picked from commit 7568571a24)
2019-01-04 05:26:48 +01:00
Richard Kimberly Heck
3c4c5aa994 Fix bug #11432.
Take account of Layout::free_spacing.

(cherry picked from commit 6135824f40)
2019-01-03 19:18:22 -05:00
Jean-Marc Lasgouttes
1e2b503ac9 Remove premature (and bad) optimization
When blinking the caret, it looks like a cool idea to only update the
small rectangle containing the caret. Actually it is an awful idea, since
the paint event will paint some rows, and these rows will not be
properly painted outside of the small rectangle. Unfortunately, the
painter will skip those "painted" rows on next paint events.

This leads to painting errors that depend on the ordering of "real"
and "caret" paint events. This is the reason why they only appeared
with split screens.

Quote of the day: ``The real problem is that programmers have spent far
too much time worrying about efficiency in the wrong places and at the
wrong times; premature optimization is the root of all evil (or at
least most of it) in programming.''
-- Donald Knuth, The Art of Computer Programming.

Fixes bug #11354.

(cherry picked from commit fba9f5b9e8)
2019-01-03 13:52:40 +01:00
Jean-Marc Lasgouttes
b9116e8b81 Add override statements to please clang
Eventually, all overridden virtual methods should be marked properly.
Currently, clang only warns about those in classes that already use
override in at least one place (which was the case dor GuiApplication).

(cherry picked from commit c8f4b68423)
2019-01-03 10:22:11 +01:00
Kornel Benko
36aa0526e0 lyx2lyx tests: Copy also original lyx files to temp dir
Necessary only if the lyx-file includes some data from
a relative path, nonetheless it happens in some of our tests.
2019-01-03 08:56:29 +01:00
Kornel Benko
af7dba023b Amend 7e1ecb65, add Bibliography.lyx to the set of not tested subdocuments 2019-01-02 16:35:18 +01:00
Enrico Forestieri
e65e84878f Amend [324b8287/lyxgit]
Avoid a crash by checking that a cell is not empty before
accessing its content.

No status line is needed as this amends a previous commit.
2019-01-02 09:22:56 +01:00
Juergen Spitzmueller
19b12518fe Remove *.bbl and friends when invalidating the bib info cache
This avoids errors when switching engines.

The fix is already in master. We forgot to backport.
2018-12-31 09:46:08 +01:00
Juergen Spitzmueller
279e656d6a Unbreak citing from bibliography environment
We need to bail out here early since otherwise the cache is prematurely
set to valid even if it is invalid with the bibliography environment.
The following checks (for timestamps of bib files) are only targeted
at bib(la)tex.

The fix is already in master.
2018-12-31 09:43:39 +01:00
Kornel Benko
00cd6f101c Amend 031d1c86: Add support for aastex62 2018-12-30 09:22:55 +01:00
Juergen Spitzmueller
acfc897683 de.po 2018-12-30 09:01:47 +01:00
Kornel Benko
a6e45c4c75 Update sk.po 2018-12-29 19:58:45 +01:00
Kornel Benko
031d1c86a1 Added aastex62 example an template files
This is 2.3.x- adapted copy of the versions in master tree.
2018-12-29 19:52:45 +01:00
Pavel Sanda
a6ed1c8f57 * cs.po 2018-12-29 19:23:23 +01:00
Juergen Spitzmueller
51db94b350 Fix some parsing glitches in Autonest and IsAutonestedBy
Layouts can have spaces, underlines (that must be read as spaces, and
be enquoted)

Candidate for stable

(cherry picked from commit da273a944f)
2018-12-29 18:36:20 +01:00
Juergen Spitzmueller
d62775553a Beamer: autonest column in columns
Candidate for stable

(cherry picked from commit 012d9b088e)
2018-12-29 18:34:10 +01:00
Juergen Spitzmueller
a9890828bd Do not auto-insert separator for keepempty layouts
Candidate for stable

(cherry picked from commit 59d73f52b8)
2018-12-29 18:32:47 +01:00
Juergen Spitzmueller
783f94afc2 de.po 2018-12-29 18:22:58 +01:00
Juergen Spitzmueller
7e1ecb653b Handle bibliography irritations in thesis template
Outsource the bibliography to an own child, which is then also included
in the children's "Standalone" branch

Add some clarifying notes.

Fixes: #10748
(cherry picked from commit 12aaeb259f)
2018-12-29 18:07:17 +01:00
Juergen Spitzmueller
07ba1d04fb Fixup LocalLayout ui after [3847e0ef/lyxgit]
(cherry picked from commit a67c541d6b)
2018-12-29 18:02:39 +01:00
Pavel Sanda
78e256163a Backport 33284ee5c. 2018-12-29 17:55:55 +01:00
Richard Kimberly Heck
36bc179efd New layout file for American Mathematical Monthly.
From John Perry. See bug #10803.
2018-12-29 11:48:02 -05:00
Richard Kimberly Heck
d06c3d7d9f Fix bug #6096.
We used to need a hack to set the size of the layout combo, but
the code was changed in Qt 4.5 or so. Hence the appearance of this
bug in 2009. We can now just remove this hack, and all seems to
work correctly.

(cherry picked from commit d7f4346a19)
2018-12-29 11:30:47 -05:00
Richard Kimberly Heck
6806ad98df Fix bug #9004.
I'm not entirely happy with this way of doing it. It seems messy.
But there is not another clear option right now.

(cherry picked from commit 4f0ccae399)
2018-12-29 11:28:51 -05:00
Juergen Spitzmueller
35f0117b5f LFUN_TEXTSTYLE_UPDATE: Do not force any unspecified settings.
Fixes: #11111 (yay!)
(cherry picked from commit 2f9876a410)
2018-12-29 09:38:39 +01:00
Juergen Spitzmueller
4eab21b2bc Slightly lighter icons
All that's changed here is just the file size due to some file optimization.

Fixes: #10626
(cherry picked from commit 186597b546)
2018-12-29 09:11:15 +01:00
Richard Kimberly Heck
88034d3d89 Fix bug #11422.
We need to load the master document before applying the params, since
otherwise the TOC reset (and other things) happen before the master
has been loaded (and set as parent).

(cherry picked from commit ac3693c04f)
2018-12-29 00:25:58 -05:00
Scott Kostyshak
4ea6d81437 Fix assertion when checking if change in selection
The check for the iterator being in the same paragraph as the end of
selection was incorrect, because paragraphs in different cells could
have the same pit. We now additionally condition on having the same
idx.

This commit amends d1279875 (and thus 23de5e5e).

For discussion, see:

  https://www.mail-archive.com/search?l=mid&q=a5afd0c01a0eb9a84fd4d050d15eb23016d6f38a.camel%40lyx.org

Thanks to Jürgen.

(cherry picked from commit c5301a6495)
2018-12-28 23:56:53 -05:00
Richard Kimberly Heck
b286511b75 Typo
(cherry picked from commit 75c8e5c000)
2018-12-28 23:35:07 -05:00
Richard Kimberly Heck
9cd9712cf0 Fix bug #11378.
(cherry picked from commit f11a51be35)
2018-12-28 23:04:46 -05:00
Enrico Forestieri
f648b2e936 Update it.po 2018-12-26 19:07:05 +01:00
Juergen Spitzmueller
a68e5b7774 When cancelling saving of a children, cancel the whole process.
Fixes remainder of #11405

(cherry picked from commit 4d51206585)
2018-12-25 12:15:43 +01:00
Kornel Benko
ad177dcf29 Update sk.po 2018-12-24 12:15:40 +01:00
Juergen Spitzmueller
08c7cbc621 de.po 2018-12-24 11:55:19 +01:00
Juergen Spitzmueller
6145cb798d Allow to restore default UI colors in prefs
Patch by Daniel Ramöller (racoon), with slight modifications of mine.

Fixes: #10062

(cherry picked from commit 81e4f8dfb6
with minor adaptations)
2018-12-24 11:51:38 +01:00
Scott Kostyshak
c249d942d6 status.23x: add entry for fix to changes in sel
This status entry is for #10338, which was backported in the
previous two commits.
2018-12-23 15:19:40 -05:00
Scott Kostyshak
0af6a43b6a Fix crash when selecting text with changes
When selecting text, in some cases a DocIterator could be forwarded
to a (non-existant) paragraph after the end. The critical part of
this fix is to break the loop at the correct place. The following
are additional improvements:

- increase readability by defining a bool named "in_last_par"
- use cur.selectionEnd().pit() instead of cur.selectionEnd().paragraph().id()
- use it.lastpos() instead of it.paragraph().size()

This commit fixes a regression introduced by 23de5e5e, and reported
at #11204.

Thanks to Jürgen and JMarc.

(cherry picked from commit d12798759a)
2018-12-22 14:57:40 -05:00
Scott Kostyshak
890fb133b1 Only show Accept/Reject Change options if relevant
In the context menu for a selection, we now only show the options
"Accept Change" and "Reject Change" if there is actually a change in
the selection. Similarly, in the toolbar, the buttons are only
enabled when there is a change in the selection.

This fixes #10338.

(cherry picked from commit 23de5e5e19)
2018-12-22 14:57:40 -05:00
Kornel Benko
f2772678b0 Update sk.po 2018-12-22 10:27:28 +01:00
Juergen Spitzmueller
9e5350b8fd de.po 2018-12-22 08:57:19 +01:00
Juergen Spitzmueller
4480b72a9d GuiCharacter: Add menu to Restore button
and allow for resetting all widgets to "No Change" besides "Default"

(cherry picked from commit ac8aac5b36)
2018-12-22 08:52:55 +01:00
Jean-Marc Lasgouttes
714b731e39 Make DEPM respect current cursor position.
Spaces are now conserved when they surround current cursor. Examples:
  abc   |   def
becomes
  abc | def
after DEPM and
  abc |
is kept as it is.

Fixes ticket #11412.

(cherry picked from commit dff0c5729e)
2018-12-21 22:18:40 +01:00
Enrico Forestieri
324b828717 Fix bug 11346
Enclose in braces an optional argument of a math macro when it
starts with an incomplete script inset or ends with a delimiter
size-modifier macro.

(cherry picked from commit 2dcb730026)
2018-12-20 11:57:54 +01:00
Juergen Spitzmueller
d41337179a Also check for dirty children on QUIT
Fixes rest of #11405

(cherry picked from commit 33344c6015)
2018-12-20 11:39:37 +01:00