Initializing clientName at declaration time is not a good idea.
Spotted by Coverity scan.
(cherry picked from commit 3d323412ad5b4d47774de43f985202f20cabd156)
It is not necessarily, and infers with some usages, to generally escape
spaces in labels and references
(cherry picked from commit 0beb790a6a19458f3dcf1b17e7796533410c363d)
The position of the cursor should not be decreased if it is already at
the start of the paragraph. This can lead to a crash when trying to
display the caret.
(cherry picked from commit 16be88ca18719a98a555ced268431ca1040658b7)
Since the platform is selected at run time (e.g. xcb vs. Wayland), it
is not a good idea to decide at compile time what code is run. Another
example is on macOS, where having xcb libraries available will lead to
lauching the Xquartz whenever LyX is running.
With this patch, things are separated:
- the code is run when run-time platform is "xcb".
- the support code is compiled in when xcb header and libraries are
available.
The cmake code is courtesy of Kornel Benko.
Fixes ticket #13086.
(cherry picked from commit 18c310a8cf60ebc8cab27aeea6fc0a6e1fcc7fcc)
(cherry picked from commit f1fddd86efa22ac9342de723f5ca724f252f8cbe)
(cherry picked from commit 3bc4554e5762c3484477e1c590632756e3f310ad)
(cherry picked from commit 8c14748e782d93870a7328df383403fb37da936f)
Instead of baking our own support for -geometry command line option on
Windows (Qt only does that for Xcb), use the fact that Qt 5 provides
the equivalent -qwindowgeometry flag.
All we need to do is to replace the -geometry option with -qwindowgeometry.
This is part of the effort in ticket #13086 to get rid of the
compile-time QPA_XCB define.
(cherry picked from commit ce9de28f06eb770ae440992fb8ca8b98a07c1cfd)
The current buffer is part of allRelatives(), contrary to what I
thought. Therefore updateId() increased the buffer id by two.
(cherry picked from commit 2eb4e3d3ca063d12371695282ae0bc3d9609ab06)
Each buffer now has an id which is increased when it is marked dirty
(or when one of its relatives is marked dirty).
This can be a big win since updateMacros is very expensive.
(cherry picked from commit 999fb37ebb1aecfda9889fa6a2b2fbb15133f2aa)
(cherry picked from commit fe1a3b57df2cd6adf1bd4752d05b1aae40a4e5b7)
It makes reload more robust and is in any case good enough to avoid
crash in #139091.
Fixes bug #13091.
(cherry picked from commit 52ec69a1af7f8c860d6f1d6ed6337db58d5ce163)
That module was a wrapper over the popen module and it was scheduled to
be removed in Python 3.11.
This code is also compatible with Python 2.
(cherry picked from commit d06a034578da4b20fb26e53ff983a77ca90bd07c)
* The image scale param is shared by XHTML and DocBook
* It does not only apply to math
* Get rid of redundant group headers (#12902)
(cherry picked from commit 1429552063dfe9909dd5789b9fb1715ddee7d77d)
This is needed to provide ePub and other DocBook-based exports with
the right (renamed) images (fixes#12372)
(cherry picked from commit 03c58420060fef520d74d835bb39e1b1c9fd7c1e)
