Commit Graph

436 Commits

Author SHA1 Message Date
Juergen Spitzmueller
8831d50936 Load rotfloat and rotating after graphicx.
Fixes: #11502
(cherry picked from commit f937b5eb7a)
2019-08-16 17:25:41 +02:00
Juergen Spitzmueller
c1c94010e4 Fix coloured boxes in RTL with [pdf]latex (#8642)
(cherry picked from commit 7ca267e1fe)
2019-08-16 08:10:17 +02:00
Juergen Spitzmueller
7f58601c00 Fix greyedout note in RTL (#8647)
More complicated than I wished for, but color handling in RTL is
particularly tricky.

The three versions are needed due to the differences between [pdf]latex,
xetex, luatex/luabidi and luatex/babel.

(cherry picked from commit 4e74dd0d42)
2019-08-16 07:51:26 +02:00
Juergen Spitzmueller
e097bade85 hebarticle: fix compilation with XeTeX (bug #10525)
(cherry picked from commit 1f2eb92b33)
2019-08-16 07:35:43 +02:00
Juergen Spitzmueller
1c2700eb11 Re-fix #2005
Loading keyval does not work any longer. Fix it properly by de-activating
the equal character locally if graphics options use it.

We do this statically for Turkish and Latin in stable, as opposed to
master (where we have the ActiveChars languages tag)
2019-08-15 09:20:40 +02:00
Juergen Spitzmueller
9e9d51187d Update stats 2019-08-14 18:59:43 +02:00
Juergen Spitzmueller
1ee62a3358 Fix interplay of memoir and geometry
Fixes: #10970
(cherry picked from commit 65c1ae8133)
2019-08-06 10:10:53 +02:00
Juergen Spitzmueller
7c0d9eb4d9 Fix text direction of references with XeTeX/bidi
Fixes: #11626
(cherry picked from commit 231b36d950)
2019-08-06 10:07:41 +02:00
Pavel Sanda
f4e700be2a Backport eceed02a90. 2019-07-26 21:42:19 +02:00
Uwe Stöhr
0baa24df71 colored-boxes.lyx: add section about references
is a user request
2019-07-21 01:31:46 +02:00
Juergen Spitzmueller
6bfad588ab he.po: Fix string direction
Patch by Guy Rutenberg

Fixes: #11607
2019-07-17 06:43:06 +02:00
Richard Kimberly Heck
c839747055 Fix bug #11612.
Register verbatim includes with the outliner.

(cherry picked from commit 6960bab65c)
2019-07-11 16:25:46 -04:00
Juergen Spitzmueller
5679dc5c6f Proper number ordering with luabidi
As opposed to bidi (XeTeX), luabidi (LuaTeX) does no automatic reordering,
so we need to use \\LR{}

(cherry picked from commit 1d0929b5d9)
2019-07-11 17:46:55 +02:00
Juergen Spitzmueller
f0f4b98c6e Brackets reversion differs in luabidi (LuaTeX) from bidi (XeTeX)
This amends [195f62ac93/lyxgit]

(cherry picked from commit d3aa102260)
2019-07-11 17:44:34 +02:00
Juergen Spitzmueller
f60f82e7b7 LuaTeX (luabidi) does not correct directions
This amends [9d20bc4e98/lyxgit].

(cherry picked from commit a95339c6e1)
2019-07-11 08:37:52 +02:00
Juergen Spitzmueller
6e01ceca24 LuaTeX (luabidi) does not swap table columns
This amends [21b347a2f8485/lyxgit].

(cherry picked from commit 6f8db58778)
2019-07-11 08:33:58 +02:00
Juergen Spitzmueller
2208f4f519 Fix right and left layout alignment (in workarea) with RTL
Fixes: #11606
(cherry picked from commit b6f0c1de3d)
2019-07-11 08:31:50 +02:00
Juergen Spitzmueller
6afe258453 Preserve star on citation style change via menu
Fixes: #11439
(cherry picked from commit 52fffee7f2)
2019-07-10 09:37:24 +02:00
Juergen Spitzmueller
4fb4035e7f Update Russian Tutorial
Patch by Yuriy
2019-07-09 16:10:23 +02:00
Richard Kimberly Heck
1e98580988 Fix bug #11588.
Check for the local file before calling kpsewhich.

(cherry picked from commit 2e433654c7)
2019-07-07 13:31:27 -04:00
Jean-Marc Lasgouttes
c047dc64bf Fixup 17571104: really avoid empty numbers in toc
For some reason, I missed this one when trying to fix the bug.

Fixes bug #11423.

(cherry picked from commit 5a22b2e391)
2019-07-07 13:23:45 -04:00
Richard Kimberly Heck
ad4215e462 Fix bug #10091.
See the discussion. The decision was just to keep re-trying for a
bit, since the lock preventing us from removing the old file seems
to clear after a bit.

(cherry picked from commit d96a9aa37f)
2019-07-07 13:15:27 -04:00
Juergen Spitzmueller
53597584e6 Fix nomencl generation with LuaTeX
Fixes: #11571
(cherry picked from commit bf6a7dc38f)
2019-07-07 10:45:41 +02:00
Juergen Spitzmueller
7c673acbb1 \detokenize paths containing ~
(cherry picked from commit d876319e85)
2019-07-07 10:35:55 +02:00
Juergen Spitzmueller
5afb71cb9b Fix import of custom float definitions
Candidate for stable

(cherry picked from commit bda3b6d07e)
2019-07-05 18:47:07 +02:00
Jean-Marc Lasgouttes
b89749ae1d Let TeXFiles.py handle symbolic links.
Nix (https://nixos.org) is a Unix package manager, which can be used to
install LaTeX on macOS. A peculiarity of Nix is that all packages are
installed into separate directories and the actual directory tree is
then constructed via symlinks.

This interacts badly with the way LyX currently detects files in the
TeX setup, because TeXFiles.py does not follow symlinks. Therefore,
almost nothing is found when using LyX together with Nix’ LaTeX.

Patch from Michael Roitzsch.

(cherry picked from commit 642b4acca1)
2019-06-27 23:53:03 +02:00
Enrico Forestieri
a2d181905a Fix bug #11586
Do not replace a latex command with the corresponding symbol
in the unicodesymbols file unless it can be encoded in the
document encoding.

The mhchem \ce inset is a text mode environment but allows entering
spaces and mathmode commands. However, even if it doesn't allow unicode
symbols, LyX allows entering them (by copy/paste, for example), causing
latex errors. As a unicode symbol may have a proper latex representation
from the unicodesymbols file, use it instead of the bare symbol. Here, we
don't care about the mode because both text and math mode should be allowed.
For example, the ⟶ symbol is not recognized but its latex representation
(\longrightarrow) is fine. Of course, there may be symbols that are
not recognized anyway, but this is better because they cause explicit
errors from mhchem instead of cryptic iconv errors in case they cannot
be represented in the document encoding.
2019-06-25 22:23:51 +02:00
Enrico Forestieri
f5510a8a8d Fix bug #11552
Do not write supefluous braces in optionals of a macro when saving.
2019-06-25 22:09:12 +02:00
Enrico Forestieri
911e6412b8 Refined fix for #9633
A branch inset modifies the layout of the internal structures in
which the text is organized. When a branch is active, it is as if it
was not there, but its only presence makes a paragraph which would not
be the last one to actually be the last one, or the check for the
language of the previous paragraph to fail because there is no
previous paragraph before the first one in a branch inset.
Oney way I found to tackle it, is tracking whether the typesetted
paragraphs are actually part of an active branch inset and acting
accordingly.
2019-06-25 21:57:00 +02:00
Enrico Forestieri
7998616edb Properly fix #9616
Now all symbols in the unicodesymbols file having a mathcommand
are not wrapped in a \text inset anymore.

(cherry picked from commit 506324ef9d)
2019-06-25 21:41:21 +02:00
Enrico Forestieri
112616a97b Fix bug #10499
The array environment has to be explicitly parsed in math mode.

(cherry picked from commit 1a286c7910)
2019-06-25 21:33:29 +02:00
Enrico Forestieri
ad8f574277 Fix bug #10498
Use the selection as the argument of a macro also when the
macro has only optional arguments.
2019-06-25 21:27:33 +02:00
Enrico Forestieri
eb66e68ed5 Add submenu to math context menu
The "Rows & Columns" optional submenu is more easily accessible in
the math context menu rather having to navigate to the "Edit" menu.
All possible accelerators are already taken, so use the space bar.

(cherry picked from commit ff7eb0eb38)
2019-06-25 21:21:47 +02:00
Enrico Forestieri
11fd6fe43d Fix bug #11595
Avoid an endless loop when in the definition of a macro the macro
itself is used in the LyX representation part.

(cherry picked from commit 1cb2a443b5)
2019-06-22 21:48:16 +02:00
Juergen Spitzmueller
053876e7d7 Dutch l7n is back with a big splash
Patch by Niko Strijbol
2019-06-21 12:02:21 +02:00
Juergen Spitzmueller
4cf56383ca tex2lyx: improve module support
The current heuristics only considered modules with styles that defined
a searched command in their preamble, and only for commands/environments
that were defined in the document's preamble. This limited the module
support drastically.

The new heuristics also checks for commands coming from packages. If the
command is not (re-)defined in the document preamble, it checks modules
that provide a style with a matching LaTeXName, checks for their
requirements and matches those with the packages loaded by the document.

If no module provides a searched style, but we found modules that load
packages that are loaded in the imported tex file, and if those packages
are not auto-loaded by LyX anyway, we also load this module.

fixes: #11259, part of #8229
(cherry picked from commit 0b54650f0e)
2019-06-19 17:23:26 +02:00
Juergen Spitzmueller
019a4fa124 Prevent multiplication of preamble code
Fixes rest of #8229

(cherry picked from commit f51fa38123)
2019-06-19 17:13:16 +02:00
Juergen Spitzmueller
f8eb3b9742 Fix toprule with booktabs/longtable and captions
(cherry picked from commit fe589d5622)
2019-06-19 09:45:20 +02:00
Juergen Spitzmueller
8941ec4b42 update buffer after fixBiblio
fixes: #2743
(cherry picked from commit 0a4686d8d3)
2019-06-19 09:23:52 +02:00
Juergen Spitzmueller
86f999097e reset bibitem counter in the second updateBuffer() routine as well
Fixes: #8499
(cherry picked from commit 9370135c3e)
2019-06-19 09:20:25 +02:00
Richard Kimberly Heck
4e28ebea31 Open for 2.3.4. 2019-06-18 18:14:22 -04:00
Jean-Marc Lasgouttes
bc54a55491 Cell in delimiter inset should not be tight
Fixes bug #11337.

(cherry picked from commit 4da19ef833)
2019-05-25 14:15:38 +02:00
Jean-Marc Lasgouttes
49255788ea Always paint text decoration when painting inset.
Fixes bug #11402.

(cherry picked from commit 621c908f85)
2019-05-24 10:36:13 +02:00
Jean-Marc Lasgouttes
bbe7b84f3b Reset change bar information when breaking row
This is a much less invasive version of da2696cc+da2696cc, which
reduces the risk to a minimum. There may be other Row members that
need resetting, we'll see that later.

Fixes bug #11396.
2019-05-24 10:21:43 +02:00
Enrico Forestieri
a5f5985d28 Fix bug #11528
The code was not doing what said in the description.

(cherry picked from commit 45e0ce2372)
2019-05-20 22:07:59 +02:00
Juergen Spitzmueller
b90638ccc3 Update Swedish localisation 2019-05-19 14:05:26 +02:00
Richard Kimberly Heck
91cfd0b535 Update Brazilian Portuguese translation. 2019-05-15 22:43:27 -04:00
Jean-Marc Lasgouttes
7686af1ba8 Some Asian langagues allow to wrap text at any position
This is hardcoded for now for simplicity and to allow backporting to
2.3.

The behavior is unchanged for all languages but Chinese, Japanese or
Korean.

Fixes part of bug #10299.

(cherry picked from commit 26c2811cc4)
2019-05-15 18:26:08 +02:00
Jean-Marc Lasgouttes
23505a8a91 Newly created inline math is not numbered
The bad initialisation created phantom entries in equation ToC

Fixes bug #11423.

(cherry picked from commit 175711046d)
2019-05-13 10:05:33 +02:00
Juergen Spitzmueller
f6c0c1ee35 Enable optional \cite* arguments in biblatex-natbib
(cherry picked from commit 6a4199ed23)
2019-05-13 09:25:31 +02:00
Richard Kimberly Heck
679f136eb6 Update Russian translation. 2019-05-11 16:30:37 -04:00
Juergen Spitzmueller
b50949b472 Only write btUnits if we have a bibliography
Fixes: #11562
(cherry picked from commit b77094a497)
2019-04-24 07:32:07 +02:00
Juergen Spitzmueller
43c31f4e0e Revive Bulgarian localization 2019-04-23 13:33:04 +02:00
Juergen Spitzmueller
4104cd13a5 Fix renaming of citation refs after changing bibitem key
Fixes: #6494
(cherry picked from commit faefee3dc6)
2019-04-22 09:18:29 +02:00
Juergen Spitzmueller
6f8673bcee Pass proper text to TeXOnePar in Paragrapgh::Private::validate
This fixes InPreamble layouts in insets (#11557)

(cherry picked from commit 4f884fc92d)
2019-04-21 08:03:22 +02:00
Juergen Spitzmueller
ccf93fc0d6 Use proper listings font styles with polyglossia and RTL
Fixes: #11554

Also load color with minted and polyglossia/RTL, as minted loads it
too late.

(cherry picked from commit 3e516a6219)
2019-04-20 08:37:45 +02:00
Juergen Spitzmueller
ac1ee5947f Status update 2019-04-16 09:10:38 +02:00
Enrico Forestieri
f929e2aae5 Update status.23x
Add reference to a bug reported after it was fixed.
2019-04-14 10:46:05 +02:00
Jean-Marc Lasgouttes
f03c4a2db4 Fixup ad79ac40: reintroduce markers around delimiters
The reasoning behind this change was not correct.

Fixes bug #11516.

(cherry picked from commit 3b58e38dc6)
2019-04-10 14:39:09 +02:00
Jean-Marc Lasgouttes
595c6d0a05 Fix bold-like characters when selecting bidi text
In painter, restrting paining regions does not really work when region is empty.

Fixes bug #11198.

(cherry picked from commit f9da28428a)
2019-04-10 14:19:18 +02:00
Daniel Ramoeller
e8dc6fad05 Fix for #11476: Icons have spurious squares
(cherry picked from commit 209944796a)
2019-04-06 07:30:46 +02:00
Daniel Ramoeller
5f444ee86f Fix for Mac Command-0 zoom-buffer binding
Amends fix to #10455

(cherry picked from commit 990f1eca4a)
2019-04-06 07:28:47 +02:00
Juergen Spitzmueller
7986ac2f32 Fix left/right border UI when toggling formal
Fixes: #9835
(cherry picked from commit 00de6c4be7)
2019-04-01 18:48:07 +02:00
Juergen Spitzmueller
15dae1244b Fix booktabs bottom line with multirows
Fixes: #11445
(cherry picked from commit 819c9c1645)
2019-04-01 18:45:57 +02:00
Enrico Forestieri
f836783908 Fix bug #11526
Correctly categorize a textmode symbol in mathed.

(cherry picked from commit c2af2cfd94)
2019-03-24 22:19:05 +01:00
Jean-Marc Lasgouttes
e0879b1460 Cache the value of GuiFontMetrics::lbearing().
This seems to be necessary on windows, where math editing can get very
slow. Note that other methods like rbearing already use a cache.

In the future all these caches for single characters shall be unified.

(cherry picked from commit d3979e798c)
2019-03-21 18:43:37 +01:00
Jean-Marc Lasgouttes
f94cdf6e1c Place the depth bar correctly in full screen mode
In full screen mode, it is possible to restrict the text width. In
this case, the paint bar should not be painted outside of this
restricted area.

Fixes bug #11286.

(cherry picked from commit 7485225cc6)
2019-03-21 11:57:59 +01:00
Juergen Spitzmueller
5518ca028e Add tabular-features set-inner-lines and fix set-all-lines behavior
Patch by Daniel Ramöller (racoon)

Fixes: #11382
(cherry picked from commit cb84f752f2)
2019-03-20 12:49:23 +01:00
Enrico Forestieri
98a792c9fd Fix bug #11490
Correctly add the branch name suffix when the stem
of the filename contains a dot.

(cherry picked from commit c3b9504835)
2019-03-19 21:41:04 +01:00
Enrico Forestieri
33023e6811 Fix bug #4269 and avoid crash with gzipped file
Call gunzip with quoted filenames as they may contain spaces or
other special characters.

In computing the length of the extension, the code does not account
for the prefix "unzipped_", which is added when the zipped filename
does not have one of the extensions "gz", "z", "Z", or "svgz", and
thus the used index is out of bounds. See also this thread:
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg207360.html

(cherry picked from commit 69726b832b)
(cherry picked from commit 7296e0e6ba)
2019-03-19 21:27:35 +01:00
Juergen Spitzmueller
4456dede9c Do not force LTR with nameref and non-TeX fonts
Fixes: #11518
(cherry picked from commit f0282ddff4)
2019-03-17 17:29:14 +01:00
Richard Kimberly Heck
3ce4338e75 Fix regression concerning collapsing insets after search.
To reproduce: Do a search for text in a footnote (say) that is
currently closed. Click inside the now open footnote. It will close
by itself.

We need to know whether we can go into the inset, not whether we can
edit once we're there.

(cherry picked from commit 4484cc7751)
2019-03-14 21:34:50 -04:00
Juergen Spitzmueller
d3c47dcb13 More exceptions to percent encoding
See #11511

(cherry picked from commit 3c83f01f1b)
2019-03-10 18:04:03 +01:00
Jean-Marc Lasgouttes
ee8a336cbc Update screen as needed when preferences are changed
This commit removes the adhoc code in GuiPrefs and moves it to LyXRC,
so that it triggers in every preference change.

The code has also been updated to trigger on more variables, e.g.
font_*_foundry.

Note that the actual function that are called have not been changed
(addPreviews and LFUN_SCREEN_FONT_UPDATE), although there are doubts
that they behave as needed (see FIXMEs).

Fixes bug #11498.

(cherry picked from commit 954531f247)
2019-02-27 12:04:09 +01:00
Richard Kimberly Heck
9374d0edd9 Fix bad error message (bug 11486).
(cherry picked from commit 5b959033d2)
2019-02-25 22:04:19 -05:00
Juergen Spitzmueller
43edb36032 Amend 5f45b3ed9c
(cherry picked from commit 806f742263)
2019-02-23 17:23:40 +01:00
Juergen Spitzmueller
130a555796 Fix IPA icons
Convert text to path and fix the most salient drawing issues.
2019-02-11 16:47:36 +01:00
Jean-Marc Lasgouttes
4c18a49c87 Fix algorithm for finding localized files
Now we search in priority with the GUI language, and then the
language(s) specified in the LANGUAGES environment variable.
Preoviously, the GUI language would only be considered when
LANGUAGES was not set (which was a bug).

Take this opportunity to remove old compatibility code from 2007.

(cherry picked from commit e203bf519b)
2019-02-07 10:19:28 +01:00
Enrico Forestieri
841f0fd3dd Fix bug #11484
When splitting parameters at commas, take into account that
commas inside curly braces are not parameter separators.

(cherry picked from commit 6316b9b7ae)
2019-02-05 14:57:18 +01:00
Juergen Spitzmueller
f785d63a0a ? and = must not be percent-encoded in hrefs
Fixes: #11482
(cherry picked from commit c2db448ff5)
2019-01-30 08:17:20 +01:00
Daniel Ramoeller
b8e6527c79 Fix for #11294: Wrong description for Change bars module
(cherry picked from commit f71723c8f3)
2019-01-19 19:04:47 -05:00
Richard Kimberly Heck
8cbf1c7cec Rename emergency file when it is kept.
Otherwise, we will ask about it again next time, when the file
may have changed. Also, if we crash again, we'll over-write that
file, which we may not want to do.

See bug #11464.

(cherry picked from commit b804e8851c)
2019-01-17 23:01:54 -05:00
Enrico Forestieri
a54147d087 Remove PYTHONPATH from the environment on Windows
This make sure to use the the modules distributed with LyX,
avoiding reconfigure failures.

(cherry picked from commit ad0c9a548b)
2019-01-12 18:52:01 +01:00
Enrico Forestieri
3131873a6d Replace environment variables in PATH prefix
The PATH prefix modified through the GUI was set without
replacing embedded environment variables. This might have
caused problems on Windows with external python installations.

(cherry picked from commit 472bdf5910)
2019-01-11 23:01:18 +01:00
Juergen Spitzmueller
bfd86a947a Do not consider deleted labels in ambiguity check
This adds a new (boolean) parameter "active" to the label cache, where
we track whether a label is deleted in ct mode (the same could be done,
if wanted, for labels in notes and inactive branches).

Deleted (inactive) labels are neither considered in the uniqueness check
nor added to the outliner. This also means that undeleted references to
deleted labels are now (correctly) marked as BROKEN.

Cherry-picked from:

    [3ae6bff538/lyxgit]
    [a550a613e8/lyxgit]
    [c457ea90e/lyxgit]
    [5cfd25697/lyxgit]
    [5afacb144/lyxgit]
    [54366c38e/lyxgit]

Fixes: #6563
2019-01-09 09:06:53 +01:00
Juergen Spitzmueller
5f3c0d5aca When using polyglossia (bidi), paragraph directions don't need to be swapped
Bidi does that.

Fixes: #11399
(cherry picked from commit 9d20bc4e98)
2019-01-08 08:30:42 +01:00
Scott Kostyshak
45931f7a60 status.23x: correct typo from 822e0133
Thanks to José.
2019-01-07 12:15:16 -05:00
Scott Kostyshak
822e0133aa ko splash.lyx: specify "mj" as CJK font
Now (thanks to d193cd05), the Korean splash.lyx compiles
out-of-the-box with pdflatex.

Thanks to Jürgen.

(cherry picked from commit 0cfaf406c5)
2019-01-07 11:56:23 -05:00
Juergen Spitzmueller
8918075ed0 Properly implement CJKutf8
If we use that, the document actually needs to be in utf8 encoding, and
the CJK environment needs to account for it.

Candidate for stable.

(cherry picked from commit d193cd05a8)
2019-01-07 17:23:22 +01:00
Jean-Marc Lasgouttes
e8d96cb9b1 Fix display of gather in lefteqn mode
The column is flushed when the display of equations is flushed.

Not sure what to do with RtL languages.

Fixes bug 11324.

(cherry picked from commit 7cb0284a3f)
2019-01-07 11:41:35 +01:00
Stephan Witt
7dd5d6371f Add license info for inkscape start script
(cherry picked from commit a4d409b194)

Add status log for 2.3.x
2019-01-07 00:18:52 +01:00
Richard Kimberly Heck
6ac69a78f8 Fix problem caused by re-ordering of menu at 5f6332bf4.
This broke the activation and de-activation of plural, capitalize,
etc. I guess that tells us how much those get used....

(cherry picked from commit 9b3f9cc687)
2019-01-06 12:57:09 -05:00
Jean-Marc Lasgouttes
85e693806e Allow toggling (no)limits only after mathop symbol
In particular, introduce the new InsetMathScript::allowLimits method
that checks for that and honor it in getStatus/ddoDispatch.

Do the same for (over|under)brace

(cherry picked from commit 7b7ed64a0e)
(cherry picked from commit 6cfd733dea)
2019-01-05 15:18:09 +01:00
Jean-Marc Lasgouttes
ca8f6c09b6 forgot this 2019-01-05 15:04:51 +01:00
Jean-Marc Lasgouttes
7f3407b89a Avoid crash when using inset-select-all in tabular
When changing cell idx, it is important to set the pit to a reasonable
value.

(cherry picked from commit a69e01d0b4)
2019-01-05 14:56:41 +01:00
Jean-Marc Lasgouttes
e73c0d6387 Fix vertical offset of fonts like MinionPro
For some reason, adding a LTR/RTL Override unicode character before a
MinionPro string increases the ascent of the line.

This creates vertical offset issues when painting if the ascent used
as reference is the one of the font. Use the QTextLine ascent instead
for better results.

This is a followup to 1bed76e2a.

Fixes (reopened) ticket #11284.
Fixes ticket #10532.
Fixes ticket #10767.

(cherry picked from commit d8498d4785)
2019-01-05 14:40:56 +01:00
Juergen Spitzmueller
08100f8b02 Always update bibfiles cache with bibliography environment before opening citation dialog
We need to do this unconditionally, since there is no (trivial and non-
awkward) way to update it when the bibliography paragraphs are modified.

Fixes: #4899
(cherry picked from commit 35534231d4)
2019-01-05 10:31:08 +01:00
Richard Kimberly Heck
3c4c5aa994 Fix bug #11432.
Take account of Layout::free_spacing.

(cherry picked from commit 6135824f40)
2019-01-03 19:18:22 -05:00
Jean-Marc Lasgouttes
1e2b503ac9 Remove premature (and bad) optimization
When blinking the caret, it looks like a cool idea to only update the
small rectangle containing the caret. Actually it is an awful idea, since
the paint event will paint some rows, and these rows will not be
properly painted outside of the small rectangle. Unfortunately, the
painter will skip those "painted" rows on next paint events.

This leads to painting errors that depend on the ordering of "real"
and "caret" paint events. This is the reason why they only appeared
with split screens.

Quote of the day: ``The real problem is that programmers have spent far
too much time worrying about efficiency in the wrong places and at the
wrong times; premature optimization is the root of all evil (or at
least most of it) in programming.''
-- Donald Knuth, The Art of Computer Programming.

Fixes bug #11354.

(cherry picked from commit fba9f5b9e8)
2019-01-03 13:52:40 +01:00
Jean-Marc Lasgouttes
b9116e8b81 Add override statements to please clang
Eventually, all overridden virtual methods should be marked properly.
Currently, clang only warns about those in classes that already use
override in at least one place (which was the case dor GuiApplication).

(cherry picked from commit c8f4b68423)
2019-01-03 10:22:11 +01:00
Kornel Benko
00cd6f101c Amend 031d1c86: Add support for aastex62 2018-12-30 09:22:55 +01:00
Juergen Spitzmueller
51db94b350 Fix some parsing glitches in Autonest and IsAutonestedBy
Layouts can have spaces, underlines (that must be read as spaces, and
be enquoted)

Candidate for stable

(cherry picked from commit da273a944f)
2018-12-29 18:36:20 +01:00
Juergen Spitzmueller
d62775553a Beamer: autonest column in columns
Candidate for stable

(cherry picked from commit 012d9b088e)
2018-12-29 18:34:10 +01:00
Juergen Spitzmueller
a9890828bd Do not auto-insert separator for keepempty layouts
Candidate for stable

(cherry picked from commit 59d73f52b8)
2018-12-29 18:32:47 +01:00
Juergen Spitzmueller
7e1ecb653b Handle bibliography irritations in thesis template
Outsource the bibliography to an own child, which is then also included
in the children's "Standalone" branch

Add some clarifying notes.

Fixes: #10748
(cherry picked from commit 12aaeb259f)
2018-12-29 18:07:17 +01:00
Pavel Sanda
78e256163a Backport 33284ee5c. 2018-12-29 17:55:55 +01:00
Richard Kimberly Heck
d06c3d7d9f Fix bug #6096.
We used to need a hack to set the size of the layout combo, but
the code was changed in Qt 4.5 or so. Hence the appearance of this
bug in 2009. We can now just remove this hack, and all seems to
work correctly.

(cherry picked from commit d7f4346a19)
2018-12-29 11:30:47 -05:00
Richard Kimberly Heck
6806ad98df Fix bug #9004.
I'm not entirely happy with this way of doing it. It seems messy.
But there is not another clear option right now.

(cherry picked from commit 4f0ccae399)
2018-12-29 11:28:51 -05:00
Juergen Spitzmueller
35f0117b5f LFUN_TEXTSTYLE_UPDATE: Do not force any unspecified settings.
Fixes: #11111 (yay!)
(cherry picked from commit 2f9876a410)
2018-12-29 09:38:39 +01:00
Richard Kimberly Heck
88034d3d89 Fix bug #11422.
We need to load the master document before applying the params, since
otherwise the TOC reset (and other things) happen before the master
has been loaded (and set as parent).

(cherry picked from commit ac3693c04f)
2018-12-29 00:25:58 -05:00
Richard Kimberly Heck
9cd9712cf0 Fix bug #11378.
(cherry picked from commit f11a51be35)
2018-12-28 23:04:46 -05:00
Juergen Spitzmueller
6145cb798d Allow to restore default UI colors in prefs
Patch by Daniel Ramöller (racoon), with slight modifications of mine.

Fixes: #10062

(cherry picked from commit 81e4f8dfb6
with minor adaptations)
2018-12-24 11:51:38 +01:00
Scott Kostyshak
c249d942d6 status.23x: add entry for fix to changes in sel
This status entry is for #10338, which was backported in the
previous two commits.
2018-12-23 15:19:40 -05:00
Juergen Spitzmueller
4480b72a9d GuiCharacter: Add menu to Restore button
and allow for resetting all widgets to "No Change" besides "Default"

(cherry picked from commit ac8aac5b36)
2018-12-22 08:52:55 +01:00
Jean-Marc Lasgouttes
714b731e39 Make DEPM respect current cursor position.
Spaces are now conserved when they surround current cursor. Examples:
  abc   |   def
becomes
  abc | def
after DEPM and
  abc |
is kept as it is.

Fixes ticket #11412.

(cherry picked from commit dff0c5729e)
2018-12-21 22:18:40 +01:00
Enrico Forestieri
324b828717 Fix bug 11346
Enclose in braces an optional argument of a math macro when it
starts with an incomplete script inset or ends with a delimiter
size-modifier macro.

(cherry picked from commit 2dcb730026)
2018-12-20 11:57:54 +01:00
Pavel Sanda
7b431ff0ba Backport 99bfe20120. 2018-12-19 21:47:06 +01:00
Pavel Sanda
cb848bbcd0 * status.23x 2018-12-18 23:17:54 +01:00
Juergen Spitzmueller
1dc6154708 GuiCharacter: Add "Reset" and "Restore Defaults" buttons
Addresses #11415
2018-12-18 08:32:48 +01:00
Juergen Spitzmueller
aea162cc8d Check for hidden dirty child on close
Fixes: #11405
(cherry picked from commit f87218bbb5)
2018-12-17 18:46:13 +01:00
Juergen Spitzmueller
262b0dcca4 GuiCharacter: INHERIT is OFF for the tristate buttons.
(cherry picked from commit 1b6ce0e827)
2018-12-17 10:44:10 +01:00
Jean-Marc Lasgouttes
47adf27ac3 Fix undo after breaking a nested paragraph
We have to take into account that Buffer::updateBuffer can modify the document.

Fix bug #11292.

(cherry picked from commit 57feb0fed0)
2018-12-16 22:00:36 +01:00
Jean-Marc Lasgouttes
09d742cc7f Update boost to 1.68.
This avoid lots of warnings from gcc 8.
2018-12-16 21:45:02 +01:00
Jean-Marc Lasgouttes
0e6cb4e599 Set buffer correctly when changing math space type.
Fixes bug #7747.

(cherry picked from commit 2ec25c8eef)
2018-12-14 19:39:54 +01:00
Enrico Forestieri
3e9a1c2da7 Fix bug #9622
The backslash is the escape character used in our parser. Hence,
when used as a path separator on Windows, it has to be itself
escaped or the path enclosed in either double or single quotes.
Windows users are maybe trained to quote paths containing spaces
but not paths with backslashes. So, we automatically escape the
backslashes when they are not already enclosed in quotes.

(cherry picked from commit 4c9df62c6c)
2018-12-14 18:57:48 +01:00
Enrico Forestieri
eba2f14fa7 Fix display of single-char macro names
Essentially, all characters are allowed in single-char macro names.

Part of #11158.

(cherry picked from commit 95bc273a59)
2018-12-14 12:05:40 +01:00
Jean-Marc Lasgouttes
7950ace3d9 Fix selection of unmarked RtL text
With Qt 5.11 at least, RtL text will be drawn RtL even when the
(undocumented) flag Qt::TextForceLeftToRight is applied to the
QTextLayout object. This creates selection issues for Hebrew text
marked as English.

The solution is to do the same as in breakAt_helper, that is prepend
the string with a direction override unicode character.

Doing this requires to introduce a TEXTLAYOUT_OFFSET constant that has
to be used wisely to account for this extra character.

Fixes bug #11284.

(cherry picked from commit 1bed76e2a1)
2018-12-13 10:51:59 +01:00
Jean-Marc Lasgouttes
3a123b90af Remove old workaround that is not needed anymore
This causes a compilation error with boost 1.69.

Fixes bug #11349.

(cherry picked from commit 76e99e9a20)
2018-12-13 10:39:58 +01:00
Juergen Spitzmueller
ac351f40f1 Fix encoding problems in \input@path
As of LaTeX2e 2018, characters are made active earlier, which results
in new expansion problems.

Following a suggestion of Markus Kohm (pc) and the TL mailing list [1],
we embrace non-ASCII input paths in \detokenize. This relies on e-tex,
but I think we can assume this is nowadays available everywhere.

[1] http://tug.org/pipermail/tex-live/2018-May/041691.html

Fixes: #11146
(cherry picked from commit 8bd65041f2)
2018-12-12 08:39:20 +01:00
Richard Kimberly Heck
c26c7602e4 Copy modules into the Advanced F&R pane as well.
(cherry picked from commit 5064c09e9f)

Update the Advanced F&R document class when switching buffers.

(cherry picked from commit 944b0ae55d)
2018-12-11 18:05:53 -05:00
Richard Kimberly Heck
7bc7b8f422 Speed up convert_literalparam. Part of #11200.
(cherry picked from commit 4549f46a43)
2018-12-11 18:03:44 -05:00
Guillaume Munch
c1945d27df Make tab movement visible (#10733)
The nice hand-made solution for moving tabs has made its time. Use Qt's feature
instead from now on.

(cherry picked from commit 1979496399)
2018-12-11 17:59:27 -05:00
Richard Heck
e694199837 Fix bug 9798.
Nameref support for math references.

(cherry picked from commit 5f6332bf46)
2018-12-11 17:58:07 -05:00
Enrico Forestieri
535309929b Fix reloading of local layout file (bug #11120)
(cherry picked from commit 7822d11361)
2018-12-11 19:26:17 +01:00
Richard Kimberly Heck
ec464a8b9f Prepare for 2.3.2. 2018-12-08 11:24:40 -05:00
Juergen Spitzmueller
a7ecbba7bc sv.po: update by Jim. 2018-11-25 11:51:11 +01:00
Jean-Marc Lasgouttes
f7ebe1f70f Show cursor correctly when loading file
This is a fixup to 4ecbff00. When a file is loaded and the cursor is
set, it is required to first compute metrics to be able to scroll the
screen correctly.

Fixes bug #11377.

(cherry picked from commit 2dc84b69d5)
2018-11-23 17:05:46 +01:00
Jean-Marc Lasgouttes
c1df5fb6ef Avoid extra space in tooltips
When using QTextDocument to check the natutal size of a text, one has
to remove the text margin, which is not useful here.

Fixes bug #11353.

(cherry picked from commit 7db99672e6)
2018-11-21 14:47:04 +01:00
Juergen Spitzmueller
caa4ee6412 pt_BR.po: update by Georger 2018-11-18 18:22:08 +01:00
Juergen Spitzmueller
37599f29a4 uk.po: update by Yuri 2018-11-14 16:21:35 +01:00
Enrico Forestieri
704eede69b Fix bug #11367
The overset, underset, and stackrel insets behave like the script
rather than the fraction inset.
2018-11-12 21:17:03 +01:00
Juergen Spitzmueller
639aa35444 Dispay pre- and posttext widgets if non-empty also if unapplied
Fixes: #11352
(cherry picked from commit b8932afed5)
2018-10-30 22:18:52 +01:00
Juergen Spitzmueller
e00b11355d Merge paragraphs when pasted into an inset that forbids multipars
Fixes: #8281
(cherry picked from commit 5dde4b1b3e)
2018-10-14 09:06:38 +02:00
Juergen Spitzmueller
53a108e814 Load covington later
This solves a loading order conflict with beamer-article.

(cherry picked from commit 00ee54e694)
2018-10-13 09:49:10 +02:00
Enrico Forestieri
e323f74b78 Fix bug #11332
Add the "hyperref-driver=dvips" option to the extra flags of the
latex->dvi converter so that the breakurl package is automatically
loaded when needed.

(cherry picked from commit f5e6db7171)
2018-10-12 08:27:23 +02:00
Richard Kimberly Heck
7697bf7888 Revert "Fix bug #9348"
The fix changes behavior too much for stable. My bad.

This reverts commit e94ea46be7.
2018-10-08 16:27:47 -04:00
Juergen Spitzmueller
7a0416b374 Rework OK/Apply/Cancel UI of prefs dialog
Instead of "Save" (permanently) and "Apply" (temporarily), OK and Apply
now always save permanently, unless the new checkbox "Apply to current
session only" is checked.

Addresses: #10016
(cherry picked from commit c7bdb3b342)
2018-10-08 11:46:42 +02:00
Juergen Spitzmueller
4a8b508d40 If a master is being created at loading the child, un-hide it.
Fixes: #11162
(cherry picked from commit a368439bcc)
2018-10-08 11:43:20 +02:00
Juergen Spitzmueller
5133026b01 Fix suprious comma in book and thesis bib preview.
Fixes: #11272
(cherry picked from commit 399a4d7e71)
2018-10-08 11:40:24 +02:00
Juergen Spitzmueller
ea43f293c2 GuiCitation: don't reset filter on show
Addresses #11291

(cherry picked from commit 33d6499bbc)
2018-10-08 11:36:47 +02:00