anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-17 02:05:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
42,941 Commits 31 Branches 172 Tags 630 MiB
f500a287d4
Commit Graph

27264 Commits

Author SHA1 Message Date
Yuriy Skalko
b56a64a8ef Typo 2020-11-20 15:57:34 +02:00
Yuriy Skalko
f953d88c88 Simplify constructors 2020-11-20 15:57:26 +02:00
Jean-Marc Lasgouttes
a877cdb196 Do not set language from keyboard in passthru setting 2020-11-20 13:49:26 +01:00
Jean-Marc Lasgouttes
875b1def4f Take right margin into account for text inset width 
This is particularly important for contents in RtL languages, where
the right margin may contain the paragraph indentation, or
itemize/enumeration symbols.

Fixes bug #12030.
 2020-11-17 17:51:43 +01:00
Thibaut Cuvelier
c6fe1fbe5f DocBook: implement svglobal. 2020-11-16 20:15:34 +01:00
Yuriy Skalko
888ff9c114 Amend 9b1dc338b2. Fix compilation in GCC 4.9 2020-11-15 22:41:38 +02:00
Thibaut Cuvelier
dc94abf039 DocBook: specific fix for Localization_Test.lyx. 
In one paragraph, there was both a float and a list of floats in a paragraph: the list of floats has no DocBook output, so that there should be no surrounding <para>.
 2020-11-15 19:04:21 +01:00
Thibaut Cuvelier
0ed820fa0b DocBook: fix for nomenclature xml:id and glossary paragraphs. 
Previously, the xml:id's were not consistent among <glossterm> in the text and <glossentry> in the glossary.
 2020-11-15 18:43:58 +01:00
Sam Crawley
f457a32a13 Fix issue in running compare from the command line 
Because Compare uses threads, we need to make sure it is finished when a
compare is executed from the command line. This was a problem for command
sequences, because the next command would start running before the compare
was done, and the buffer with differences was available.

So this commit adds the "run-blocking" parameter when using
LFUN_DIALOG_SHOW to run a Compare. When calling Compare with run-sync, the
LFUN will wait for the compare worker thread to finish before returning and
possibly running the next command.
 2020-11-15 10:35:28 +01:00
Thibaut Cuvelier
46cbd6d234 DocBook: refactor code about retrieving captions and labels. 
There was already an existing method in InsetCaptionable for captions, but not yet for labels. It was at least already useful at two places, that's why I moved it to InsetCaptionable.
 2020-11-15 04:03:04 +01:00
Thibaut Cuvelier
c4bbff8ecb DocBook: fix handling of listings with titles. 
Also implement a code path for inline listings.
 2020-11-15 04:03:04 +01:00
Thibaut Cuvelier
46daa3865b DocBook: missing support for customisation of layouts in inset arguments. 2020-11-15 04:03:04 +01:00
Thibaut Cuvelier
6bc04367cf DocBook: add support for IGNORE tags. 
These paragraphs will simply have no output (no enclosing DocBook tag, no content). This change is as backward-compatible as possible: without this commit, the paragraphs will be output, but in an <IGNORE> tag (not much more can be achieved without this). It is mostly made for metadata and formatting instructions. (As opposed to NONE, which corresponds to outputting the paragraph without enclosing DocBook tag.)
 2020-11-15 04:03:04 +01:00
Jean-Marc Lasgouttes
222a317dd2 Store correctly the window position with Wayland 
To do this, hard-coded test for xcb had to be replaced with a call to
platformName(). Since this method does not exist in Qt4, we emulate
it.

Note that Qt5 uses xcb bindings for X11 system, while Qt4 relies on
older X11 bindings. We return platorm == "qt4x11" in this case.

Fixes bug #11746.
 2020-11-14 17:55:59 +01:00
Yuriy Skalko
9b1dc338b2 Simplify Changers 2020-11-12 14:22:00 +02:00
Thibaut Cuvelier
14887dda1c DocBook: implement achemso. 2020-11-12 03:18:03 +01:00
Richard Kimberly Heck
fdd0a6f849 Revert "Improve structure of updateMacros" 
The problem here is that the check against TEXT_CODE only
catches InsetText, and not its subclasses. Same for the check
against MATH_HULL_CODE. So there is reason not to check codes
here.

This reverts commit 5a54ccfa87.
 2020-11-11 11:26:11 -05:00
Jean-Marc Lasgouttes
63300c3ba8 Fixup aeb51be9: set current font correctly when editing inset 
When using InsetText::edit(), invoke Cursor::setCurrentFont (note that
editXY does it already). It is a good idea in general, especially
after commit 411333fa95, which sets languagecorrectly in ERT.

This allows to comment out (again!) the trick added to fix ticket #9042.
 2020-11-10 15:43:48 +01:00
Jean-Marc Lasgouttes
411333fa95 Make sure that Cursor::setCurrentFont sets LaTeX language in ERT&friends 
Fix issue when language is set to document language instead of
latex_language in ERT and pass thru layouts.

To trigger the issue
1/ select all in a ERT inset
2/ type "abc"
3/ look at code in code preview pane

==> result: the "a" is in document language, the "bc" in LaTeX language
(as should be)
 2020-11-10 14:09:31 +01:00
Yuriy Skalko
437fef65aa Simplify operator== for ParConstIterator 
Comment out it while it is unused.
 2020-11-08 23:29:20 +02:00
Yuriy Skalko
589e780e15 Whitespace & renaming 2020-11-06 21:34:02 +02:00
Yuriy Skalko
01e673635b MacroData refactoring 2020-11-06 21:33:56 +02:00
Yuriy Skalko
5a54ccfa87 Improve structure of updateMacros 2020-11-06 21:33:41 +02:00
Richard Kimberly Heck
97ecf71016 Remove dead comment 2020-11-06 11:30:07 -05:00
Richard Kimberly Heck
5bd498c56d Move trivial constructors into header. Remove unimplemented one. 2020-11-06 11:30:07 -05:00
Thibaut Cuvelier
1766bff806 DocBook: remove special options from InsetGraphics.cpp 
This was not really a useful attribute for DocBook, or it must be parsed beforehand.
 2020-11-05 05:35:34 +01:00
Thibaut Cuvelier
85a8664ba5 MathML: make InsetMathXArrow generate valid XML entities when required. 
Before this, it only supported HTML entities.
 2020-11-05 02:18:47 +01:00
Thibaut Cuvelier
7f8d0fd7b7 DocBook: ensure that tables do not get wrapped in a paragraph. 2020-11-05 02:03:34 +01:00
Thibaut Cuvelier
307aefef89 DocBook: don't consider bridgeheads for abstracts. 2020-11-05 00:02:59 +01:00
Jean-Marc Lasgouttes
4094afaf2e Indentation 2020-11-03 15:12:20 +01:00
Richard Kimberly Heck
060c3de2f0 StepMasterCounter --> StepParentCounter 2020-11-02 17:36:58 -05:00
Richard Kimberly Heck
fba1c434e5 Revert "Fix a number of signedness warnings" 
This reverts commit e8a28c33c5.

I was not aware that we used negative numbers for author IDs!
 2020-11-02 17:09:59 -05:00
Richard Kimberly Heck
39f997048e Remove 'slave' terminology from Counters.cpp. 
And with it, 'master'. That is less problematic by itself (so I'm not
worried about 'master document'), but here it doesn't make a lot of
sense without 'slave'.
 2020-11-02 17:09:59 -05:00
Yuriy Skalko
8a25741ccd Use default member initialization in OutputParams 2020-11-02 20:30:01 +02:00
Richard Kimberly Heck
e8a28c33c5 Fix a number of signedness warnings 2020-11-02 12:03:37 -05:00
Richard Kimberly Heck
cfd19d86be whitespace and style 2020-11-02 11:45:09 -05:00
Richard Kimberly Heck
2945bc356e whitespace 2020-11-02 11:38:52 -05:00
Yuriy Skalko
c7d0ba0f26 Simplify bformat 2020-11-02 11:54:40 +02:00
Thibaut Cuvelier
ebfdac4fa3 DocBook: implement svmult. 
More generally, ensures that paragraphs in abstracts do not have something else configured.

A major problem in making the layout more useful is that article titles are not supposed to be in TOC.
 2020-11-02 04:30:39 +01:00
Richard Kimberly Heck
679ce23ddc Some constness, following Yuriy 2020-11-01 17:37:28 -05:00
Yuriy Skalko
1fdcd7bf14 Constify LaTeXFont 2020-11-01 22:25:08 +02:00
Yuriy Skalko
81a5e7927b Use default member initialization 2020-11-01 22:25:03 +02:00
Yuriy Skalko
6f514da5fd Use bool literals 2020-11-01 22:24:48 +02:00
Yuriy Skalko
9c47e736f8 Constify InsetQuotesParams 2020-11-01 22:24:31 +02:00
Yuriy Skalko
d38eddb397 Match header/source function argument naming 2020-11-01 22:23:44 +02:00
Yuriy Skalko
5061db891c Use const references 2020-11-01 22:23:26 +02:00
Yuriy Skalko
6e65967e15 Use default member initialization in InsetLayout 2020-11-01 22:22:50 +02:00
Yuriy Skalko
dbe35af542 Simplify with std::map::insert 2020-11-01 22:22:27 +02:00
Richard Kimberly Heck
ca3077b40b Change the logic of the indentation setting. 
The option here is to NOT indent the paragraph, so make that clear.
As it was, we would set "Indent" to false in the case of paragraphs
that do not permit indentation and then write that, uselessly, to the
LyX file if we wrote any other option (and then keep writing it, even
if other options were removed). Now, we will write it only if it's been
explicitly set.
 2020-10-30 13:34:36 -04:00
Richard Kimberly Heck
3b4b047576 Fix warning 2020-10-30 13:26:48 -04:00
Thibaut Cuvelier
df0ea858ed DocBook: use the same normalisation for biblio IDs and their references. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
da6e999fc6 DocBook: more robust list implementation. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
6843bc5a38 DocBook: ensure to have paragraphs in <sidebar>. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
30572880ba DocBook: fix an issue where parts of list in abstract were duplicated. 
Excerpt from export/latex/lyxbugs-resolved/9633-languagenesting_enumerate_and_lyxcode.
 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
661c5d256b DocBook: support for <info> tags in inner sections. 
Previously, this code only worked correctly for the root tag.
 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
4405f0164a DocBook: implement algorithm floats. 
Now that https://github.com/docbook/docbook/pull/185 has been merged into DocBook 5.2.
 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
f2b7f8a089 DocBook: generate chapter metadata in <info>, for Springer mono. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
b816cb0f3c DocBook: don't consider sectioning items that shouldn't be in TOC for anything section-related. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
149e1ccc02 DocBook: add DocBookSection parameter for styles that define new sections and implement argument parameters; improve Springer support. 
For elements that should behave like sections (for now, mostly prefaces).

A second paragraph of PartBacktext can only wreak havok: it should start a section, and nothing else (otherwise, it's a real nightmare to implement).
 2020-10-30 01:59:34 +01:00
Richard Kimberly Heck
cc1d3b78c9 Const 2020-10-29 18:25:33 -04:00
Yuriy Skalko
b8737e898c Simplify DispatchResult ctors 2020-10-29 15:52:38 +02:00
Yuriy Skalko
d8ead7debf Use nullptr 2020-10-29 15:52:33 +02:00
Yuriy Skalko
524073d09f Move HullType functions declared in InsetMath.h into InsetMath.cpp 2020-10-29 15:52:28 +02:00
Yuriy Skalko
f1926251c0 Move Windows-specific stuff into os_win32.h 2020-10-25 19:59:03 +02:00
Yuriy Skalko
10272e4747 Move include of own header to the top. Fix dependencies 2020-10-25 19:58:57 +02:00
Yuriy Skalko
4ece87c324 Fix obsoleted Qt values 
All new values exist in Qt 4.8.7.
 2020-10-25 09:28:46 +02:00
Yuriy Skalko
1b508fff03 Small refactorings 2020-10-25 09:28:41 +02:00
Yuriy Skalko
a7018252b7 Constify 2020-10-25 09:28:34 +02:00
Jean-Marc Lasgouttes
21422dd652 Replace QFontMetrics::width() by horizontalAdvance() in Qt>=5.11 
The method horizontalAdvance() replaces width() starting with Qt 5.11.
To handle this, all direct calls to QFontMetrics::width() are replaced
by calls to GuiFontMetrics::width(), and the code for
GuiFontMetrics::width(QChar) uses horizontalAdvance on newer Qt
versions.
 2020-10-24 19:52:18 +02:00
Yuriy Skalko
69f838bbf3 Fix isSpace for docstring 2020-10-24 18:55:05 +03:00
Pavel Sanda
8af747c9d9 Revert da8b5de97 because of MSVC 2017. 
In GCC `min` is defined via including <vector>.
 2020-10-24 12:06:54 +02:00
Enrico Forestieri
d2d33a6a1f Fix compilation on cygwin 2020-10-23 15:00:23 +02:00
Yuriy Skalko
c928714b0b Unify naming of menu items 2020-10-23 10:23:01 +03:00
Jean-Marc Lasgouttes
2395522aa7 Revert "Do not set language from keyboard in passthru setting" 
This reverts commit d94bd07264.
 2020-10-21 18:50:31 +02:00
Jean-Marc Lasgouttes
526b4b0d79 Revert "Fix compilation mess in d94bd0726" 
This reverts commit abaf2e9bda.
 2020-10-21 18:50:10 +02:00
Jean-Marc Lasgouttes
abaf2e9bda Fix compilation mess in d94bd0726 2020-10-21 18:37:22 +02:00
Jean-Marc Lasgouttes
d94bd07264 Do not set language from keyboard in passthru setting 2020-10-21 18:09:31 +02:00
Pavel Sanda
5d0b1b640b Make master compilable again with older gcc. 2020-10-21 00:01:03 +02:00
Yuriy Skalko
196d9caeb0 Clean includes using the output of iwyu tool 2020-10-20 11:38:55 +03:00
Thibaut Cuvelier
d1b9af3b1d DocBook: fix file inclusion. 
Previously, nothing was output. Special care was needed for when new paragraphs should be open (this work is probably not finished yet).
 2020-10-20 02:34:02 +02:00
Yuriy Skalko
af29f02dd8 Reduce includes in header files (2) 2020-10-19 18:01:17 +03:00
Yuriy Skalko
d25c10ed81 Remove duplicate and unused header includes in .cpp files 2020-10-19 18:01:11 +03:00
Yuriy Skalko
fa6ac23e1c Reduce includes in header files 2020-10-19 17:33:51 +03:00
Yuriy Skalko
65c88f0a0a Remove redundant const & for primitive types 2020-10-19 12:50:07 +03:00
Thibaut Cuvelier
7be7026386 DocBook: generalise detection of "special cases" to check all insets of a paragraph. 
This will catch cases where there are multiple listings in a single paragraph, for instance.

The new code is also less brittle (checks on lyxCode instead of generated LaTeX or names).
 2020-10-18 08:23:37 +02:00
Thibaut Cuvelier
739735ab73 DocBook: output inline equations in their own paragraph if they are the only inset of the paragraph. 
It's invalid to have an <inlineequation> outside a paragraph. Another solution would have been to change InsetMathHull::docbook to generate an <informalequation>, but that function would have required more knowledge about its context than now.

Need more tests to determine if <inlineequation> should only be output for hullSimple or in more cases like:

		const static std::set<HullType> inlineHulls = {
				hullUnknown,
				hullNone,
				hullSimple,
				hullEquation,
				hullMultline,
				hullGather,
				hullRegexp
		};
 2020-10-18 08:23:36 +02:00
Jean-Marc Lasgouttes
c286cad565 Reset caret size when inserting text over a selection 2020-10-17 20:29:16 +02:00
Scott Kostyshak
1e3ef3c6e2 Update tex2lyx tests after the format change 
The diff consists of only the format number, which is expected since
there is no instance of "\nopagebreak" in the .tex files.
 2020-10-16 23:06:15 -04:00
Yuriy Skalko
b5cb23a92a Remove unused headers in output_xhtml.h 2020-10-16 23:05:54 +03:00
Yuriy Skalko
a3eeb8a4b5 Clean math headers 2020-10-16 23:05:46 +03:00
Thibaut Cuvelier
0ba9b7c0c8 DocBook: fix an assertion/crash. 2020-10-16 17:02:24 +02:00
Yuriy Skalko
84365fc946 Move Author.h, Format.h from BufferParams.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
4c8d262996 Const refactor 2020-10-16 08:02:51 +03:00
Yuriy Skalko
ce0e192689 Move Cursor.h from TocWidget.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
fbefdb10a5 Move Cursor.h from Clipboard.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
7f40bb2b2d Clean output_latex 2020-10-16 08:02:51 +03:00
Yuriy Skalko
65db7b31ad Clean Cursor and CursorSlice 2020-10-16 08:02:51 +03:00
Yuriy Skalko
61bc850c27 Remove CutAndPaste.h from Trans.cpp 2020-10-16 08:02:51 +03:00
Yuriy Skalko
bea9d2f3f7 Clean includes in TextMetrics.cpp 2020-10-16 08:02:51 +03:00
Yuriy Skalko
da56091c2a Clean includes in buffer_funcs.cpp 2020-10-16 08:02:51 +03:00
Thibaut Cuvelier
170866986c Amend 82ea3d6 
Test was done on the wrong data structure: the title is almost the only element ending up in shouldBeInInfo, it is never inmustBeInInfo.
 2020-10-16 04:30:41 +02:00
Yuriy Skalko
36c8e06cf1 Move Dimension.h from InsetIPA.h 2020-10-15 19:26:16 +03:00
Yuriy Skalko
5ac65d1532 Move BufferParams.h from Language.h 2020-10-15 19:25:37 +03:00
Yuriy Skalko
87d19e1068 Remove BufferParams.h from BiblioInfo.h 2020-10-15 19:25:19 +03:00
Daniel Ramoeller
d5fe3337c6 Cleanup CutAndPaste.cpp 2020-10-15 10:24:00 +02:00
Richard Kimberly Heck
1f22a2520a Fix linking problem by adding convert from string to unsigned long long. 2020-10-14 22:28:10 -04:00
Pavel Sanda
c0f9309300 Move <fstream> from support/gzstream.h 2020-10-14 15:12:48 +02:00
Pavel Sanda
644c1d3453 Move docstream.h from output_xhtml.h 2020-10-14 15:06:12 +02:00
Pavel Sanda
560ff6d40d Move MetricsInfo.h from InsetMathSize.h 2020-10-14 14:58:18 +02:00
Pavel Sanda
2b02b73f4a Move <QTimer> from TocWidget.h 2020-10-14 14:48:41 +02:00
Pavel Sanda
bd33601512 Move <QTimer> from GuiViewSource.h 2020-10-14 14:37:38 +02:00
Pavel Sanda
85eec10e4b Move <QKeyEvent> from DockView.h 2020-10-14 14:35:29 +02:00
Pavel Sanda
61824e057e Move GuiView.h from DockView.h 2020-10-14 14:28:47 +02:00
Pavel Sanda
57703d51c6 <QCloseEvent> DialogView.h -> DialogView.cpp 2020-10-14 13:57:30 +02:00
Pavel Sanda
f1b147cc97 include "GuiView.h": DialogView.h -> DialogView.cpp 2020-10-14 13:53:40 +02:00
Pavel Sanda
10fafd3bfe <map> ParagraphMetrics.h -> TextMetrics.h 2020-10-14 13:14:58 +02:00
Pavel Sanda
da8b5de973 Move <algorithm> from DocIterator.h 2020-10-14 13:01:30 +02:00
Richard Kimberly Heck
b7f632ca1c Fix bug #12002. 
Patch from Daniel.
 2020-10-13 19:51:27 -04:00
Richard Kimberly Heck
1ff2de387d Whitespace 2020-10-13 18:26:13 -04:00
Richard Kimberly Heck
28ae543a2a Fix signed-ness warnings 2020-10-13 18:24:03 -04:00
Pavel Sanda
0ea9df7467 Add inset for \nopagebreak. 
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg213388.html
 2020-10-13 19:13:59 +02:00
Jean-Marc Lasgouttes
c516c86d19 Make cursor width depend on current font 
This makes the cursor more visible wrt current font.

Moreover make the cursor width scalable by default.
 2020-10-13 17:27:52 +02:00
Jean-Marc Lasgouttes
310c94c48c Fix display of caret completion indicator 
The zooming algorithm based on caret width was deeply flawed. It is
not replaced with a formula based on caret height.

Fixes bug #12000.
 2020-10-13 17:09:33 +02:00
Yuriy Skalko
2a594d3e90 Remove unused forward declarations 2020-10-13 09:57:36 +03:00
Thibaut Cuvelier
769578eac6 Fix typos in filetools.cpp. 2020-10-13 00:33:05 +02:00
Thibaut Cuvelier
82ea3d67ec DocBook: documents must have a title. 2020-10-12 19:26:37 +02:00
Thibaut Cuvelier
92b9c82dea Fix compilation on Visual C++. 
Without this patch, there would be errors like these (warnings turned into errors):

D:\LyX\lyx-unstable\src\frontends\qt\GuiView.cpp(2413): error C4101: 'e': unreferenced local variable
D:\LyX\lyx-unstable\src\frontends\qt\GuiView.cpp(4879): error C4101: 'ex': unreferenced local variable
 2020-10-12 19:21:58 +02:00
Yuriy Skalko
cb52dd2e42 Add override in VCBackend 2020-10-12 15:14:55 +02:00
Yuriy Skalko
238fd9ac50 Right exception rethrowing 2020-10-12 15:14:55 +02:00
Yuriy Skalko
919a06718a Constify 2020-10-12 15:06:16 +02:00
Richard Kimberly Heck
2dc4277452 Const 2020-10-10 17:12:50 -04:00
Richard Kimberly Heck
b28bd27932 Fix warning 2020-10-10 17:12:50 -04:00
Yuriy Skalko
7d38a4d126 Loop refactoring 2020-10-09 09:04:20 +03:00
Richard Kimberly Heck
b511d8d93e Use 'delete' for unimplemented constructors. 
Thanks Yuriy!
 2020-10-07 11:05:54 -04:00
Thibaut Cuvelier
0bd2978ac9 DocBook: add DocBookInnerTag and family. 
This allows old DocBook documents to be valid when output.
 2020-10-07 06:05:22 +02:00
Thibaut Cuvelier
6a0e93f162 Amend 249d899 
Non-ASCII characters make std::isspace crash, but not lyx::isSpace.
 2020-10-07 04:49:20 +02:00
Richard Kimberly Heck
3d46cc302b Use explicit default syntax (C++11). 
Thanks to Jos'e for noticing this option.
 2020-10-06 20:31:11 -04:00
Richard Kimberly Heck
0f417f2a06 Fix some warnings 2020-10-06 12:27:28 -04:00
Richard Kimberly Heck
bff97ba76d Explicit InsetTableCell copy constructor 2020-10-06 12:20:31 -04:00
Pavel Sanda
ffbcac3dde Add few examples for lineno options. 
It's actually pretty hard to get that from the manual.
 2020-10-06 15:05:11 +02:00
Thibaut Cuvelier
249d899298 DocBook: clean output when fonts span over text that ends with a space 2020-10-05 16:22:58 +02:00
Jean-Marc Lasgouttes
c46f3b8f31 remove unused variable 2020-10-05 15:11:51 +02:00
Yuriy Skalko
c5ae08f0b8 Amend efc0877f 
Add the last `override`s.
 2020-10-05 15:03:13 +02:00
Yuriy Skalko
fe85162a29 Refactoring 2020-10-05 14:55:00 +02:00
Yuriy Skalko
d82adc625b Amend efc0877f 
Add more `override` specifiers. Replace `throw()` to `noexcept`.
 2020-10-05 09:37:15 +02:00
Yuriy Skalko
14b0da28c2 Amend efc0877f 2020-10-03 21:17:17 +02:00
Yuriy Skalko
715b8cda54 Refactoring based on cppcheck suggestions 2020-10-03 13:39:51 +02:00
Kornel Benko
a43d8501a2 Do not use runparams.nice == true while exporting to docbook5 
The setting implies that the variable external_in_tmpdir is set to false.
If a lyx-file includes external material for spreadsheet,
the conversion results are in tmpdir.
The routine doSubstitution() (insets/ExternalSupport.cpp:188) therefore
does nothing for the entry $$Contents because it uses wrong path.
 2020-10-03 13:28:26 +02:00
Yuriy Skalko
efc0877f8f Add override specifiers to improve code maintainability 2020-10-03 12:43:48 +02:00
Juergen Spitzmueller
2330b4ce9c Never mark references in inactive insets broken 
This is the sledgehammer (and the only) way to omit broken refs if the
target is in an (or the same) inactive inset as well.
 2020-10-03 08:54:06 +02:00
Richard Kimberly Heck
2afc68ede2 Whitespace 2020-10-02 13:11:28 -04:00
Jean-Marc Lasgouttes
dd65a97b55 Pass parameters as const references when possible 
Fixes some cppcheck warnings.
 2020-10-02 18:56:01 +02:00
Jean-Marc Lasgouttes
4d9a2c2e59 Fixup f96b99dc: do not initialize cache too late 2020-10-02 12:17:57 +02:00
Jean-Marc Lasgouttes
a97b384b07 Fixup f96b99dc: thinko 
Setting the res value and returning from the function at the same time
does not make sense. After reflection, it is the "return" that shall
go.

No idea what effect it had.
 2020-10-02 12:06:32 +02:00
Juergen Spitzmueller
8b155ce957 Refactoring 2020-10-02 08:30:31 +02:00
Juergen Spitzmueller
720179947e tex2lyx: properly set textclass if no class is given 
(snippets without \documentclass and no forced class)
 2020-10-02 08:17:45 +02:00
Jean-Marc Lasgouttes
e16b9e8d22 Remove non-const version of ParagraphMetrics::getRow 
Constify a bit TextMetrics::isRTLBoundary().
 2020-10-01 14:58:18 +02:00
Jean-Marc Lasgouttes
a2b754b10b Fixup 7d965319: reset cursor font at a finer level 2020-10-01 14:19:09 +02:00
Jean-Marc Lasgouttes
7f1b1729b4 Cleanup the caret geometry code 
Intended changes:

* code is shorter and cleaner

* caret scales better with zoom when cursor_width=0: completion
  indicator, l-shaped cursor...

Details:

* Rename BufferView::getPosAndHeight to getPosAndDim because ascent is
  needed too and width could in the future be set depending on font.

* Get rid of rect_ in CaretWidget and record a Dimension (and y value) instead.
  Remove also caret_width_ and slant_, replace rtl_ with dir.

* Make CaretWidget members public and lose the trailing _.

* change CaretWidget::update to read its parameters from current bufferview.
 2020-10-01 13:17:01 +02:00
Jean-Marc Lasgouttes
7d96531909 Fix bug where cursor size is not reset correctly. 
A couple of calls to setCurrentFont fix the issue, but there has to be
more cases to catch. I am not sure why it used to work.
 2020-10-01 12:44:38 +02:00
Jean-Marc Lasgouttes
f9aadae290 Get rid of helper Text::previousWord(), used only once 2020-09-29 10:15:31 +02:00
Richard Kimberly Heck
a41bcb3701 Error message 2020-09-28 22:45:44 -04:00
Richard Kimberly Heck
003a267764 We really do not want id to change 2020-09-28 22:20:22 -04:00
Richard Kimberly Heck
594401912b Fix minor annoyance with previous commit. 
When validating local layout, in particular, we create a dummy text TextClass
and so are not necessarily modifying previously declared material. Hence, we
get a spurious (but harmless) "Incomplete argument definition!" warning. This
suppresses it, but to do that we need to propogate the ReadType.
 2020-09-28 22:07:08 -04:00
Richard Kimberly Heck
6f643e52d4 Allow argument definitions in layout files to modify existing ones. 
This is what layout re-definitions do in all other cases.
 2020-09-28 22:06:11 -04:00
Richard Kimberly Heck
54a72663ae Move defaults into struct definition 2020-09-28 21:30:40 -04:00
Pavel Sanda
ad475adfd3 amend 6d6fc761be 2020-09-28 16:44:12 +02:00
Pavel Sanda
6d6fc761be Qt4 compilable again 2020-09-28 16:34:42 +02:00
Yuriy Skalko
e47092044b Use real italic slope for slanted caret 2020-09-28 14:30:05 +02:00
Juergen Spitzmueller
b38500353c Amend 448e5efab4 
Only set langClosed to true if it really has been closed.
 2020-09-26 12:12:09 +02:00
Enrico Forestieri
f0807a604c Use correct bounding box when exporting from command line 
Without GUI an image is not available even if it is actually cached.
In this case we load the image for obtaining its dimensions in order
to correct the clipping bounding box.

This amends 380f34a1.
 2020-09-25 20:58:40 +02:00
Enrico Forestieri
a8572c1358 Correct comment 2020-09-25 12:11:10 +02:00
Enrico Forestieri
9b1763cd42 Do not correct clipping bounding box for vector formats 
This amends 380f34a1 that only took into account the postscript format.
 2020-09-25 12:01:57 +02:00
Jean-Marc Lasgouttes
967f4d661e Remove default parameter of UndoGroupHelper constructor 
This can lead to mistakes. If no buffer is required at the beginning,
it is better to pass 'nullptr' explicitly.

Fix a case of missing parameter in GuiCompleter (introduced at
f3656600). This avoids some spurious "There is no group open (creating
one)" messages.
 2020-09-23 17:33:17 +02:00
Jean-Marc Lasgouttes
32b688225d Do not use a fake row to compute completion dimension 
The code in TextMetrics::completionPosAndDim is needlessly complicated.

1/ It is easier to rely directly on Text::getWord() rather than on the
   helper previousWord().

2/ Using a fake row to compute completion height is overkill. A
   simpler solution is proposed here.

No intended effect. These changes prepare the fix to ticket #11818.
 2020-09-22 15:11:08 +02:00
Juergen Spitzmueller
b814c4fda7 Fix unnecessary cprotect 2020-09-20 08:45:42 +02:00
Thibaut Cuvelier
da67bde61a Revert "XHTML: remove DOCTYPE, as the document is then understood as HTML4/XHTML1, and not XHTML5." 
This reverts commit c8e2c17a: this makes some browsers unable to understand basic HTML entities.
 2020-09-20 01:35:14 +02:00
Thibaut Cuvelier
44a7d2bc88 DocBook: adapt code for older GCC. 2020-09-19 23:55:07 +02:00
Thibaut Cuvelier
b5adcec28a XHTML: fix for encodings in attributes (patch by Kornel) 2020-09-19 20:43:42 +02:00
Thibaut Cuvelier
c83fd0eb06 XHTML sections: saner code to close the section. 
It only caused troubles in corner cases...
 2020-09-19 20:43:42 +02:00
Thibaut Cuvelier
a85b4b88ed XHTML sections: only filter out things that are not Sectioning, not based on the level. 2020-09-19 20:43:42 +02:00
Thibaut Cuvelier
0dfa240209 XHTML: restore sections. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
15dbc2b9ab Revert "XHTML: remove <section> support." 
This reverts commit 52216b73
 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
c8e2c17a58 XHTML: remove DOCTYPE, as the document is then understood as HTML4/XHTML1, and not XHTML5. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
92ad86dacc XHTML: remove <section> support. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
bfeb3b66b1 DocBook: slight code simplification. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
6c51cabd35 DocBook: fix output in Layout::write. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
50f011e062 DocBook: implement InsetBox titles. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
3711a38b9c DocBook: fix a crash in bibliography paragraphs. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
1b818c448d DocBook: work for more subfigure cases. 
EmbeddedObjects hid quite a few gems :).
 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
8758000641 DocBook: ensure xml:id is not output too many times. 
This is mostly important for subfigures, but debugging this issue showed that InsetCaption could be slightly simplified and InsetLabel should be made a tad more robust.
 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
d0a5ba4859 DocBook: handle other cases of subfigures. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
9a48c8d22b DocBook: fix handling of new lines and fonts. 
Only the font variable was restored to the right state, not fs.
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
5f0720e947 XHTML: fix generation of many useless </section>. 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
faec783822 XML: bad fix for a crash that only happened in XHTML. 
As an error is output, I suppose that this behaviour is OK.
 2020-09-19 20:43:40 +02:00
Scott Kostyshak
a632a9ae3c DocBook: remove useless functions. 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
1a76fb9658 DocBook: avoid using isspace in StartTag::writeTag. 
This is the cause of crashes (on both Windows and Linux).
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
2cd7a94f8b DocBook: introduce Floating::docbookFloatType. 
This ensures that all comparisons for DocBook are made on the same normalised version of the float type. This cased a strange bug where <table> was output within <informaltable> for Linguistics Tableaux.
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
8ed8d36595 Fix two warnings in BufferView. 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
40f4da3c9f DocBook: floats can no more override DocBookTag. 
This lead to a quite subtle bug. The major problem is that float tags
depend on whether the LyX float has a title (formal) or nor (informal).
This information cannot be encoded in the layout format as easily as a
simple DocBookTag.
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
08a58242c1 DocBook: better output with the Linguistics module. 
One issue left: <table> output within an <informaltable>, that does not make sense... I'm debugging it.
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
abed1f3e6e DocBook: fix crash with Linguistics example. 
This was due to Floating::docbookTag not returning anything with the floattype_ tableau. Another issue that happened with that document is that the standard library's isspace crashed for some characters. I therefore implemented a more efficient version of the part that required it, and inlined the definition of isspace (even though that part becomes irrespective of locale, but was that feature ever used?).
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
594a4763b7 Fix a few warnings. 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
e3da8b65f6 DocBook: several missing features for Additional.lyx. 
Includes: semantic markup (sorry about noun: Additional.lyx uses it to mark menus; there is something better in DocBook, but it looks like the LaTeX equivalent is really for person names), boxes, info layouts.
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
19734ea454 DocBook: implement LyX-Code. 
This is quite ugly.
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
bc9d3ec262 DocBook: <person> is not valid per se, rather use <personname>. 
The cleanest solution would still be <person><personname>, but this ought to be enough. Otherwise, that would imply having two tags for some fonts...
 2020-09-19 20:43:40 +02:00
Thibaut Cuvelier
8f3d0fd88f DocBook: new-line behaviour in bibliographies. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
6d246bba69 DocBook: fix margin notes. 
They were nested twice in <sidebar>. Also fixes a new line issue.
 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
91982ee105 DocBook: new lines around formulae. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
e995414917 DocBook: avoid generating fonts for "special cases" like equations. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
654559feb8 DocBook: fix line issues around programlisting. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
9d3a717ef1 DocBook: fix font issues when a paragraph has an InsetNewline. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
7a1b82a16a DocBook: fix issue with fonts. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
c3aa843da8 DocBook: fixes in bibliography (missing new line at the end). 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
6688b076cc DocBook: fixes in lists. 
Actually output something when list item is empty. XMLStream discarded the sequence StartTag/EndTag (nothing in between).

New-line behaviour around term in description lists.
 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
5b01c80635 DocBook: fix titles in KOMA Script. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
976bd91fc2 DocBook: bug fixing with wrapper merging. 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
ec0f4885a7 DocBook: fix bibliographies (end of <bibliography> and sections). 2020-09-19 20:43:39 +02:00
Thibaut Cuvelier
642b18aad0 DocBook: generate <partintro> when required. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
17b06f5336 DocBook: streamline code to handle sections. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
f219fe1cd7 DocBook: streamline code to handle abstracts. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
a8da31e5e0 DocBook: fix handling of index end-of-range. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
78a361778f DocBook: fix float tags (was unduly overridden). 
The output was not valid for floats without title.
 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
39ad6e84f0 DocBook: improve equation formatting (new lines for block equations). 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
fc2c36289b DocBook: rewrite makeListEnvironment. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
8656fbd520 DocBook: start splitting environment handling in two, to have proper things for lists. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
1bd49f9c39 DocBook: make all make* functions have the same argument order. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
fc0999a422 DocBook: partially remove use of bpit/epit in docbookParagraphs and docbookSimpleAllParagraphs. 
This will help with the next refactoring to be much cleaner (only work with iterators, don't maintain twice the same information).
 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
bfc67c59b4 XML: use the new mechanisms for CR detection with errors. 
This helps tracking down line problems even in the presence of errors.
 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
52b2d3f683 DocBook: make Paragraph::simpleDocBookOnePar return a list of paragraphs. 
Before, it directly wrote to the XMLStream, but it made implementation of new lines tricky. Now, it returns the XML for each sub-paragraph (delimited by new lines) as a string, so that the caller can adopt a more precise behaviour (such as in lists).
 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
faaf780bed DocBook: fix compilation issues. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
3d348818e0 DocBook: Coverity potential problem for precooked bibliographies. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
ac46456b28 DocBook: simplify precooked bibliography code. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
6a4d3dbef7 DocBook: remove useless includes. 2020-09-19 20:43:38 +02:00
Thibaut Cuvelier
d8651cc60b More functions in anonymous namespace. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
25f72d392c DocBook: fine tuning of new lines. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
bdea21a87e DocBook: improve comments. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
9393ca74ba DocBook: new logic to handle the new lines, only used in output_docbook for now. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
27a44f8e48 XML: memorise if the last thing that is getting output is a line feed. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
6998e76495 DocBook: define new arguments in layouts to configure new-line behaviour. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
87dae26e4a Simplify code to generate only one paragraph at a time. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
9184ae14f0 A few more constants to avoid copies 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
dab71087cf DocBook: add a layout tag to tell whether an item is the abstract or not. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
7b0f9d9524 DocBook: simplify code to handle abstracts. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
0f145c3ef0 DocBook: use DocBookWrapperMergeWithPrevious in the code. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
c92e0bc5e7 DocBook: fix for ordering. 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
72c304a629 DocBook: make openParTag/closeTag use paragraphs instead of layouts. 
Not useful per se, but will be next with checking whether the wrapper tags should be opened/closed.
 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
c417253d0b DocBook: use DocBookItemTag within paragraphs. 
This is at least helpful for AAS, even though it slightly resembles a repurposition of that parameter.
 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
1a09086ec2 Merge findLastParagraph and findLastBibliographyParagraph to lower code duplication. 
Maybe these functions should move to ParagraphList.h/cpp?
 2020-09-19 20:43:37 +02:00
Thibaut Cuvelier
4d78fe5957 Slight code-consistency improvements. 2020-09-19 20:43:36 +02:00